Hi, Arnd
Sorry to bother you, some questions about this patch will trouble you to give
some advice:
+ ufs: ufs@ff3b {
+ compatible = "hisilicon,hi3660-ufs", "jedec,ufs-1.1";
+ /* 0: HCI standard */
+ /* 1: UFS SYS CTRL */
+ reg = <0
On Thu, 30 Nov 2017, James Bottomley wrote:
> +#define __sdev_for_each_get(sdev, head, list)
> \
> + list_for_each_entry(sdev, head, list) \
> + if (kobject_get_unless_zero(&sdev->sdev_gendev.kobj))
> +
I think that should
On Thu, 2017-11-30 at 16:08 +, Bart Van Assche wrote:
> On Thu, 2017-11-30 at 09:18 +0800, Jason Yan wrote:
> >
> > Hi Bart, I chose the approach in my patch because it has been used
> > in scsi_device_get() for years and been proved safe. I think using
> > kobject_get_unless_zero() is safe he
Hi,
On 11/30/2017 05:35 PM, 김기웅 wrote:
> Dear Jaehoon
>
> Actually, I used to use the way what you mentioned, but
> now a new way has been using with latest products.
>
> Anyway, I would refer to your comment.
If you will send the next version, you need to run "checkpatch".
When i run checkpat
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
---
drivers/scsi/scsi_error.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
index b22a9a23c74c..1622eacbf577 100644
---
If scsi_eh_scmd_add() is called concurrently with
scsi_host_queue_ready() while shost->host_blocked > 0 then it can
happen that neither function wakes up the SCSI error handler. Fix
this by making every function that decreases the host_busy counter
wake up the error handler if necessary and by prot
Hello Martin,
As reported by Pavel Tikhomirov it can happen that the SCSI error handler does
not get woken up. This is very annoying because it results in a queue
stall. The two patches in this series address this issue without acquiring the
SCSI host lock in the hot path. Please consider these pa
Hi,
On 11/29/2017 10:41 PM, Fengguang Wu wrote:
> Hello,
>
> FYI this happens in mainline kernel 4.15.0-rc1.
> It looks a new regression and bisect is on the way.
>
> It occurs in 3 out of 3 boots.
>
> [ 35.704690] init: Failed to create pty - disabling logging for job
> [ 35.706676] init:
> On Nov 30, 2017, at 7:53 AM, Hannes Reinecke wrote:
>
> Two spelling errors in one line ...
Embarrassing.. Will fix them in v3
Thanks,
- Himanshu
Hi Hannes,
> On Nov 30, 2017, at 7:51 AM, Hannes Reinecke wrote:
>
> Does this really belong to the above patch?
> It looks to me as if it fixes a completely different issue...
This flag indicates firmware to purge all IO’s of a session instead of
assuming FW will purge them.
if you prefer t
On Thu, Nov 30, 2017 at 04:08:38PM +, Bart Van Assche wrote:
> On Thu, 2017-11-30 at 09:18 +0800, Jason Yan wrote:
> > Hi Bart, I chose the approach in my patch because it has been used in
> > scsi_device_get() for years and been proved safe. I think using
> > kobject_get_unless_zero() is safe
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> Signed-off-by: Himanshu Madhani
> ---
> drivers/scsi/qla2xxx/qla_version.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_version.h
> b/drivers/scsi/qla2xxx/qla_version.h
> index b6ec02b96d3d..9
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> When driver is loaded in Target/Dual mode, it creates QPair
> to support MQ and allocates resources for each QPair. This Qpair
> initialization is delayed until the FW personality is changed to
> Dual/Target mode by issuing chip reset. At the time o
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Fix system crash due to NULL pointer access.
>
> qlt_plogi_ack_t and fc_port structures were not properly
> bound before calling qlt_plogi_ack_unref().
>
> RIP: 0010:qlt_plogi_ack_unref+0xa1/0x150 [qla2xxx]
> Call Trace:
> q
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Giridhar Malavali
>
> This fix the spinlock recursion issue seen while unloading the driver.
>
> 14 [9f2e21e03db8] native_queued_spin_lock_slowpath at ad0d8802
> 15 [9f2e21e03dc0] do_raw_spin_lock at ad0d99e4
> 16 [f
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Giridhar Malavali
>
> This patch defers processing of GS IOCB calls from interrupt
> context to avoid hardware spinlock recursion.
>
> Following stack trace is seen
>
> ? mod_timer+0x193/0x330
> ? ql_dbg+0xa7/0xf0 [qla2xxx]
> _raw_spin_loc
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> clear loop id after delete to prevent session invalidation
> of stale session.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by: Himans
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Add correct value of scan_state field indicating state
> of the FC port
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by: Himanshu Madh
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Current code manually allocate an fcport structure that
> is not properly initialize. Replace kzalloc with
> qla2x00_alloc_fcport, so that all fields are initialized.
> Also set set scan flag to port found
>
> Cc:
> Signed-o
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Original code acquires hardware_lock to add Abort IOCB
> onto driver's request queue for processing. However,
> abort_command() will also acquire hardware lock to look up
> sp pointer before issuing abort IOCB command resultin
On Thu, 2017-11-30 at 09:18 +0800, Jason Yan wrote:
> Hi Bart, I chose the approach in my patch because it has been used in
> scsi_device_get() for years and been proved safe. I think using
> kobject_get_unless_zero() is safe here and can fix this issue too. And
> this approach is beneficial to all
https://bugzilla.kernel.org/show_bug.cgi?id=197875
--- Comment #8 from Chuck Burt (chuck.burt+kernel@gmail.com) ---
Created attachment 260953
--> https://bugzilla.kernel.org/attachment.cgi?id=260953&action=edit
Output of lspci on 4.10.x kernel
I won't be able to boot into the newer kernel f
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Get Port Database MBX cmd is to validate current Login state upon
> PRLI completion. Current code looks at the last login state for
> re-validation which was incorrect. This patch removed incorrect
> state check.
>
> Fixes: 1
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> This patch fixes clearing out els_send_logo flag at the
> time of session deletion.
>
> Fixes: 3515832cc614 ("scsi: qla2xxx: Reset the logo flag, after target
> re-login.")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signe
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Current driver design schedules relogin process via DPC thread
> every 1 second. In a large fabric, this DPC thread tries to
> schedule too many jobs and might get overloaded. As a result of
> this processing of DPC thread, it
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> If user swaps one target port for another target port for same
> switch port, the new target port is not being recognized by the
> driver. Current code assumes that old Target port has recovered
> from link down. The fix will
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Sawan Chandak
>
> Add check to make sure we are cleaning up global target host
> list only for NPIV hosts
>
> Fixes: bdbe24de281e2 ("scsi: qla2xxx: Cleanup NPIV host in target mode during
> config teardown")
> Cc: # 4.10+
> Signed-off-by:
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> This patch returns discovery state machine back to
> Login Complete.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by: Himanshu Madhani
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> GPNID is triggered by RSCN. For multiple RSCNs of the same
> affected NPORT ID, serialize the GPNID to prevent confusion.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Retry GID_PN & GPN_ID switch commands for time out case.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by: Himanshu Madhani
> ---
> d
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> When NPort Handle is in use, driver needs to mark the handle
> as used and pick another. Instead, the code clears the handle
> and re-pick the same handle.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric di
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Move session delete from system work queue to driver's
> work queue for in time processing.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-o
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Fix co-existence between Block MQ and Target Mode. Block MQ
> and initiator mode requires midlayer queue mapping to check
> for IRQ to be affinitize. For target mode, it's not the case.
>
> Fixes: 09620eeb62c41 ("scsi: qla2xx
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Stop GPNID command from advancing if command has failed.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by: Himanshu Madhani
> ---
> d
On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran
>
> Fix NULL pointer crash due to missing timeout handling callback
> for Notify Ack IOCB.
>
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: # 4.10+
> Signed-off-by: Quinn Tran
> Signed-off-by
Dear Jaehoon
Actually, I used to use the way what you mentioned, but
now a new way has been using with latest products.
Anyway, I would refer to your comment.
Thank you.
> -Original Message-
> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
> ow...@vger.kernel.org] On Behalf
36 matches
Mail list logo
