On 11/30/2017 04:40 AM, Himanshu Madhani wrote:
> From: Quinn Tran <quinn.t...@cavium.com>
> 
> Fix NULL pointer crash due to missing timeout handling callback
> for Notify Ack IOCB.
> 
> Fixes: 726b85487067d ("qla2xxx: Add framework for async fabric discovery")
> Cc: <sta...@vger.kernel.org> # 4.10+
> Signed-off-by: Quinn Tran <quinn.t...@cavium.com>
> Signed-off-by: Himanshu Madhani <himanshu.madh...@cavium.com>
> ---
>  drivers/scsi/qla2xxx/qla_target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_target.c 
> b/drivers/scsi/qla2xxx/qla_target.c
> index 18069edd4773..1259ec85ec0a 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -665,7 +665,7 @@ int qla24xx_async_notify_ack(scsi_qla_host_t *vha, 
> fc_port_t *fcport,
>       qla2x00_init_timer(sp, qla2x00_get_async_timeout(vha)+2);
>  
>       sp->u.iocb_cmd.u.nack.ntfy = ntfy;
> -
> +     sp->u.iocb_cmd.timeout = qla2x00_async_iocb_timeout;
>       sp->done = qla2x00_async_nack_sp_done;
>  
>       rval = qla2x00_start_sp(sp);
> 
Reviewed-by: Hannes Reinecke <h...@suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Teamlead Storage & Networking
h...@suse.de                                   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)

Reply via email to