Re: [PATCH] scsi: fix race condition when removing target

[Finn Thain]

On Thu, 30 Nov 2017, James Bottomley wrote:

> +#define __sdev_for_each_get(sdev, head, list)                                
> \
> +     list_for_each_entry(sdev, head, list)                           \
> +             if (kobject_get_unless_zero(&sdev->sdev_gendev.kobj))
> +

I think that should have an 'else' clause, like this macro from 
include/drm/drmP.h:

#define for_each_if(condition) if (!(condition)) {} else

--