On 02/08/2017 08:13 PM, James Smart wrote:
>
> On 2/8/2017 4:47 AM, Christoph Hellwig wrote:
>> On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote:
>>> I realize I cut these in a silly way. In the v1 patches, I had a big
>>> patch
>>> that I then cut into 6 parts, by file. In the v2 pat
On Wed, Dec 28, 2016 at 4:35 PM, ojab wrote:
> MPI2 controllers sometimes got lost (i. e. disappears from
> /sys/bus/pci/devices) if ASMP is enabled.
>
> Signed-off-by: Slava Kardakov
> Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=60644
>From some of our system engineers team, I came to kn
When a device is deleted through sysfs handle "delete", the code
locks shost->scan_mutex. If multiple devices are deleted at the
same time, these deletes will be handled in series.
On the other hand, sd_shutdown() sometimes issues long latency
commands: sync cache and start_stop. It is not necessa
On Mon, 2017-02-06 at 21:42 -0800, Dan Williams wrote:
> On Mon, Feb 6, 2017 at 8:09 PM, Jens Axboe wrote:
> > On 02/06/2017 05:14 PM, James Bottomley wrote:
> > > On Sun, 2017-02-05 at 21:13 -0800, Dan Williams wrote:
> > > > On Sun, Feb 5, 2017 at 1:13 AM, Christoph Hellwig
> > > > wrote:
> > >
- Original Message -
> From: "Laurence Oberman"
> To: "Linux SCSI List"
> Sent: Wednesday, February 8, 2017 3:07:12 PM
> Subject: Patch: lpfc: Modify Emulex lpfc LPFC_DEFAULT_SG_SEG_CNT to 128 for
> default larger sg_io capability
>
> We have been seeing issues with qemu_kvm virtual g
> On Feb 8, 2017, at 2:58 PM, Bart Van Assche
> wrote:
>
> On Wed, 2017-02-08 at 14:53 -0800, Song Liu wrote:
>> +try_lock_scan_mutex = mutex_trylock(&shost->scan_mutex);
>
> This is at least as bad as the approach of your previous patch because
> whether or not this mutex_trylock() call s
On Wed, 2017-02-08 at 14:53 -0800, Song Liu wrote:
> + try_lock_scan_mutex = mutex_trylock(&shost->scan_mutex);
This is at least as bad as the approach of your previous patch because
whether or not this mutex_trylock() call succeeds not only depends on
whether or not the caller holds the scan_
> On Feb 8, 2017, at 2:53 PM, Song Liu wrote:
>
> When a device is deleted through sysfs handle "delete", the code
> locks shost->scan_mutex. If multiple devices are deleted at the
> same time, these deletes will be handled in series.
>
> On the other hand, sd_shutdown() sometimes issues long la
On Wed, Feb 08, 2017 at 05:34:48PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/lpfc/lpfc.h | 10 +++
> drivers/scsi/lp
When a device is deleted through sysfs handle "delete", the code
locks shost->scan_mutex. If multiple devices are deleted at the
same time, these deletes will be handled in series.
On the other hand, sd_shutdown() sometimes issues long latency
commands: sync cache and start_stop. It is not necessa
Sie benötigen eine Finanzierung?
Wir vergeben Darlehen. Bewerben Sie sich jetzt. Senden Sie
uns u.a. Details zurück und Sie erhalten in Kürze Antwort
Vorname:
Familienname:
Geschlecht:
Land:
Telefonnummer:
benötigter Darlehensbetrag:
Gewünschte Laufzeit:
Mit freund
On Wed, Feb 08, 2017 at 12:42:40PM -0800, Song Liu wrote:
> When a device is deleted through sysfs handle "delete", the code
> locks shost->scan_mutex. If multiple devices are deleted at the
> same time, these deletes will be handled in series.
>
> On the other hand, sd_shutdown() sometimes issues
> On Feb 8, 2017, at 1:02 PM, Christoph Hellwig wrote:
>
> On Wed, Feb 08, 2017 at 12:42:40PM -0800, Song Liu wrote:
>> When a device is deleted through sysfs handle "delete", the code
>> locks shost->scan_mutex. If multiple devices are deleted at the
>> same time, these deletes will be handled
When a device is deleted through sysfs handle "delete", the code
locks shost->scan_mutex. If multiple devices are deleted at the
same time, these deletes will be handled in series.
On the other hand, sd_shutdown() sometimes issues long latency
commands: sync cache and start_stop. It is not necessa
We have been seeing issues with qemu_kvm virtual guests where if they issue
I/O to direct attached SCSI passthrough LUNS with large I/O sizes such as 512K
the sg_io will fail with -EINVAL.
Simple reproducer is here.
strace -e ioctl sg_dd if=/dev/zero of=/dev/sdae bpt=0x400 count=0x400 blk_sgio=1
On Wed, 2017-02-08 at 19:55 +0100, Peter Senna Tschudin wrote:
> On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
> > pci_pool_*() functions should be replaced by the corresponding functions
> > in the DMA pool API. This adds support to check for use of these pci
> > functions and dis
On 02/08/2017 08:11 AM, Kalle Valo wrote:
> David Miller writes:
>
>> From: Florian Fainelli
>> Date: Tue, 7 Feb 2017 15:02:53 -0800
>>
>>> I'm hoping this doesn't conflict with what's already in net-next...
>>>
>>> David, this should probably go via your tree considering the diffstat.
>>
>> I
On 2/8/2017 4:47 AM, Christoph Hellwig wrote:
On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote:
I realize I cut these in a silly way. In the v1 patches, I had a big patch
that I then cut into 6 parts, by file. In the v2 patches, I tried to keep
the patches as is, and address the co
On Wed, Feb 08, 2017 at 05:34:41PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
>
> Signe
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> From: Quinn Tran
>
> When FW notify driver or driver detects low FW resource,
> driver tries to send out Busy SCSI Status to tell Initiator
> side to back off. During the send process, the lock was not held.
>
> Signed-off-by: Quinn Tr
On 2/8/17, 10:48 AM, "Bart Van Assche" wrote:
>On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
>> index db6bd92..4225256 100644
>> --- a/drivers/scsi/qla2xxx/qla_mbx.c
>> +++ b/drivers/scsi/qla2xxx/qla_mbx
> > +static inline void
> > +megasas_complete_r1_command(struct megasas_instance *instance,
> > + struct megasas_cmd_fusion *cmd) {
> > + u8 *sense, status, ex_status;
> > + u32 data_length;
> > + u16 peer_smid;
> > + struct fusion_context *fusion;
> > + struct megas
On 2/8/17, 10:42 AM, "Bart Van Assche" wrote:
>The above code occurs two times in this patch. We try to avoid duplicating
>code in the Linux kernel, especially code that contains hardcoded constants.
>Have you considered to change the name of plogi_nack_done_jiff into e.g.
>plogi_done_deadline
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index db6bd92..4225256 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -10,6 +10,29 @@
> #include
> #include
>
On Wed, Feb 08, 2017 at 05:34:49PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/megaraid/megaraid_mbox.c | 30 ++--
Hi Nic,
On 2/7/17, 8:13 PM, "Nicholas A. Bellinger" wrote:
>On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
>> From: Quinn Tran
>>
>> Add routines to support T10 DIF tag.
>>
>> Signed-off-by: Quinn Tran
>> Signed-off-by: Anil Gurumurthy
>> Signed-off-by: Himanshu Madhani
>> --
On Wed, Feb 08, 2017 at 05:34:52PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed
Hi Bart,
On 2/8/17, 10:57 AM, "Bart Van Assche" wrote:
>On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
>> +/* Response code and sense key */
>> +((uint32_t *)ctio->u.status1.sense_data)[0] =
>> +cpu_to_le32((0x70 << 24) | (sense_key << 8));
>> +/* Additional se
On Wed, Feb 08, 2017 at 05:34:57PM +0100, Romain Perier wrote:
> pci_pool_*() functions should be replaced by the corresponding functions
> in the DMA pool API. This adds support to check for use of these pci
> functions and display a warning when it is the case.
Don't know if relevant, but did no
On 2/8/17, 5:03 AM, "Christoph Hellwig" wrote:
>On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote:
>> -spin_lock_irqsave(&ha->vport_slock, flags);
>> -while (atomic_read(&vha->vref_count)) {
>> -spin_unlock_irqrestore(&ha->vport_slock, flags);
>> -
>> +whil
On Wed, Feb 08, 2017 at 05:34:38PM +0100, Romain Perier wrote:
Hi Romain,
Nice set of patches! Thank you.
I sent a few comments, but basically you missed to run checkpatch.pl on
your patches. Also you can take the chance to fix some white space
issues that are on the lines you are changing like s
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> + /* Response code and sense key */
> + ((uint32_t *)ctio->u.status1.sense_data)[0] =
> + cpu_to_le32((0x70 << 24) | (sense_key << 8));
> + /* Additional sense length */
> + ((uint32_t *)ctio->u.status1.sense_data)
On Wed, Feb 08, 2017 at 05:34:43PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed-o
On Wed, Feb 08, 2017 at 05:34:42PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed-o
On Wed, Feb 08, 2017 at 05:34:53PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed
On Wed, Feb 08, 2017 at 05:34:55PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/usb/gadget/udc/pch_udc.c | 28 ++-
On Wed, Feb 08, 2017 at 05:34:40PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signe
On Wed, Feb 08, 2017 at 05:34:56PM +0100, Romain Perier wrote:
> Now that all the drivers use dma pool API, we can remove the macro
> functions for PCI pool.
Good news: make allyesconfig;make succeed after the changes until this
point, but:
$ grep -R pci_pool
...
drivers/usb/gadget/udc/pch_udc.c:
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> + if (fcport->fw_login_state == DSC_LS_PLOGI_COMP) {
> + unsigned long t = fcport->plogi_nack_done_jiff + HZ;
> +
> + if (time_before_eq(jiffies, t))
> + return;
> + }
The above code oc
On Wed, Feb 08, 2017 at 05:34:54PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed
On Wed, Feb 08, 2017 at 05:34:51PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/mvsas/mv_init.c | 4 ++--
> drivers/scsi/mvsas/m
On Wed, Feb 08, 2017 at 05:34:50PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/mpt3sas/mpt3sas_base.c | 64
> +
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> +static void qla2x00_iocb_work_fn(struct work_struct *work)
> +{
> + struct scsi_qla_host *vha = container_of(work,
> + struct scsi_qla_host, iocb_work);
> + unsigned long flags;
> + int cnt = 0;
> +
> + while
On Wed, Feb 08, 2017 at 05:34:47PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/scsi/csiostor/csio_hw.h | 2 +-
> drivers/scsi/csio
On Wed, Feb 08, 2017 at 05:34:39PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
Tested by compilation only. Some whitespace errors, but the patch do
On Wed, Feb 08, 2017 at 05:34:44PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 10 +--
On Wed, Feb 08, 2017 at 05:34:46PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
Tested by compilation only.
Acked-by: Peter Senna Tschudin
Tested-by: Peter Senna Tschudin
> Signed
On Wed, Feb 08, 2017 at 05:34:45PM +0100, Romain Perier wrote:
> The PCI pool API is deprecated. This commits replaces the PCI pool old
> API by the appropriated function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> ---
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 12 ++--
Hi Bart,
On 2/8/17, 7:02 AM, "Bart Van Assche" wrote:
>On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
>> Please consider this series for inclusion in target-pending.
>
>Hello Himanshu,
>
>I gave this patch series a try on a system equipped with two QLogic FC HBAs
>where an FC cabl
On Tue, 2017-02-07 at 14:44 -0800, Christoph Hellwig wrote:
> On Tue, Feb 07, 2017 at 01:17:46PM +, Nicholas A. Bellinger wrote:
> > + if (orig->se_lun_acl != NULL) {
> > + pr_warn_ratelimited("Detected existing explicit"
> > + " se_lun_acl-
David Miller writes:
> From: Florian Fainelli
> Date: Tue, 7 Feb 2017 15:02:53 -0800
>
>> I'm hoping this doesn't conflict with what's already in net-next...
>>
>> David, this should probably go via your tree considering the diffstat.
>
> I think you need one more respin. Are you doing an all
From: Wei Yongjun
Fixes the following sparse warning:
drivers/scsi/sd.c:3087:6: warning:
symbol 'sd_devt_release' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sd.c b/dr
On Tue, 2017-02-07 at 19:46 -0800, Nicholas A. Bellinger wrote:
> On Tue, 2017-02-07 at 15:12 -0800, Christoph Hellwig wrote:
> > And the real patch after compile fixing it is here of course:
> >
>
> Getting rid of the extra se_node_acl->acl_free_comp seems to make sense
> here..
>
> The only po
From: Florian Fainelli
Date: Tue, 7 Feb 2017 15:02:53 -0800
> I'm hoping this doesn't conflict with what's already in net-next...
>
> David, this should probably go via your tree considering the diffstat.
I think you need one more respin. Are you doing an allmodconfig build?
If not, for somet
On 8.2.2017 10:29, Shivasharan S wrote:
> fix in v2 - split patches into two.
> discussed below
> http://marc.info/?l=linux-scsi&m=148638999110404&w=2
>
> No functional change. Code clean up. Removing error code which is not
> valid scenario.
> In megasas_get_request_descriptor we can remove the
On 8.2.2017 10:29, Shivasharan S wrote:
> New functionality
> Adding detection logic for NVME device attached behind Ventura controller.
> Driver set HostPageSize in IOC_INIT frame to inform about page size for NVME
> devices.
> Firmware reports NVME page size to the driver.
> PD INFO DCMD provide
On Fri, 2017-02-03 at 14:40 -0800, Himanshu Madhani wrote:
> Please consider this series for inclusion in target-pending.
Hello Himanshu,
I gave this patch series a try on a system equipped with two QLogic FC HBAs
where an FC cable connects both HBAs to each other. qlini_mode has been set
to "dua
On 8.2.2017 10:29, Shivasharan S wrote:
> fix in v2 :
> 1. split patches into two as discussed below
> http://marc.info/?l=linux-scsi&m=148638999110404&w=2
> 2. issue_dcmd return type changed from int to void.
>
>
> With the changes to remove checks for a valid request descriptor,
> issue_dcmd wi
On 8.2.2017 10:29, Shivasharan S wrote:
> Signed-off-by: Shivasharan S
> Signed-off-by: Kashyap Desai
Reviewed-by: Tomas Henzl
Tomas
Dan Carpenter kindly reported:
The patch d27a7cb91960: "zfcp: trace on request for open and close of
WKA port" from Aug 10, 2016, leads to the following static checker
warning:
drivers/s390/scsi/zfcp_fsf.c:1615 zfcp_fsf_open_wka_port()
warn: 'req' was already freed.
drivers/s390/
On 8.2.2017 10:28, Shivasharan S wrote:
> fix in v2 - ex_status and status was wrongly re-used in
> megasas_complete_r1_command.
> discussed below -
> http://marc.info/?l=linux-scsi&m=148638763409385&w=2
>
>
> No functional change. Code refactor.
> Remove function megasas_fpio_to_ldio as we never
On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote:
> I realize I cut these in a silly way. In the v1 patches, I had a big patch
> that I then cut into 6 parts, by file. In the v2 patches, I tried to keep
> the patches as is, and address the comments in the respective patch the
> comment
On Fri, Feb 03, 2017 at 02:40:44PM -0800, Himanshu Madhani wrote:
> - spin_lock_irqsave(&ha->vport_slock, flags);
> - while (atomic_read(&vha->vref_count)) {
> - spin_unlock_irqrestore(&ha->vport_slock, flags);
> -
> + while (count-- && atomic_read(&vha->vref_count))
>
On Mon, Feb 06, 2017 at 03:08:51PM -0800, James Smart wrote:
>
> I replaced the v1 patch with Christoph's original
>
> james
>
> From: Christoph Hellwig
Everything above this from line should not go into the mail sent
to the list. Note that git-send-email will automatically do the right
thi
Looks fine,
Reviewed-by: Christoph Hellwig
On Mon, Feb 06, 2017 at 03:08:50PM -0800, James Smart wrote:
>
> Correct WQ creation for pagesize
Except that the (partial) subject should not be repeated in the body.
On 02/08/2017 10:29 AM, Shivasharan S wrote:
> Signed-off-by: Shivasharan S
> Signed-off-by: Kashyap Desai
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 25 ++---
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
Reviewed-by: Hannes Reinecke
Cheers,
Hannes
--
D
On 02/08/2017 10:29 AM, Shivasharan S wrote:
> New functionality
> Adding detection logic for NVME device attached behind Ventura controller.
> Driver set HostPageSize in IOC_INIT frame to inform about page size for NVME
> devices.
> Firmware reports NVME page size to the driver.
> PD INFO DCMD pr
On 02/08/2017 10:29 AM, Shivasharan S wrote:
> fix in v2 - split patches into two.
> discussed below
> http://marc.info/?l=linux-scsi&m=148638999110404&w=2
>
> No functional change. Code clean up. Removing error code which is not
> valid scenario.
> In megasas_get_request_descriptor we can remov
On 02/08/2017 10:28 AM, Shivasharan S wrote:
> No functional change. Code refactor.
> megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura.
> No need to pass extra flag.
> Only IOC INIT required 64 bit Descriptor write.
>
> Signed-off-by: Shivasharan S
> Signed-off-by: Kash
On 02/08/2017 10:29 AM, Shivasharan S wrote:
> fix in v2 :
> 1. split patches into two as discussed below
> http://marc.info/?l=linux-scsi&m=148638999110404&w=2
> 2. issue_dcmd return type changed from int to void.
>
>
> With the changes to remove checks for a valid request descriptor,
> issue_
fix in v2 - split patches into two.
discussed below
http://marc.info/?l=linux-scsi&m=148638999110404&w=2
No functional change. Code clean up. Removing error code which is not
valid scenario.
In megasas_get_request_descriptor we can remove the error handling
which is not required.
With fusion con
No functional change. Code refactor.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 175
1 file changed, 100 insertions(+), 75 deletions(-)
diff --g
Moving to use DID_REQUEUE return type for reliable unconditional retries.
Driver wants unconditional re-queue, so replace DID_RESET with DID_REQUEUE
Discussed below -
https://www.spinics.net/lists/linux-scsi/msg102848.html
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Ha
No functional change. Code refactor.
megasas_fire_cmd_fusion can always use 32 bit descriptor write for ventura. No
need to pass extra flag.
Only IOC INIT required 64 bit Descriptor write.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Tomas Henzl
---
drivers/scsi/mega
For RAID1 FastPath writes, driver needs to allocate extra commands
internally to accommodate for the extra peer command being sent.
Currently driver is allocating 2 extra commands for each but only
one extra command is necessary.
Set RAID_1_10_RMW_CMDS to 2 and also change macro name to
RAID_1_PEER
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
---
drivers/scsi/megaraid/megaraid_sas_base.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
index 6ca
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megarai
Changes in v2:
Patch 3: Fix to update status and ex_status from failed r1_cmd
Patch 8: Split into two separate patches,
1. megasas_get_request_descriptor will always return valid
request descriptor
2. With above changes, issue_dcmd always return DCMD_SUCCESS.
Change return type to void an
This reverts
commit "3e5eadb1a881" ("scsi: megaraid_sas: Enable or Disable Fast path based
on the PCI Threshold Bandwidth")
This patch was aimed to increase performance of R1 Write operation for large IO
size.
Since this method used timer approach, it turn on/off fast path did not work as
expec
Fix - increase internal command pool to 8.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas.h| 2 +-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
2 files changed, 2 insertions(
Code refactoring to build_mpt_mfi_pass_thru to return void.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --
Fixing issue of not setting residual bytes correctly.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/scsi/me
Fix endiannes fixes for Ventura specific.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fp.c | 15 ++--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 70 ++---
drivers/sc
Minor Optimization: No need to update HBA can_queue value
if the current max FW commands is equal to earlier value.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file ch
Fix indentation issues and smatch warning reported by Dan Carpenter
for previous series as discussed below.
http://www.spinics.net/lists/linux-scsi/msg103635.html
http://www.spinics.net/lists/linux-scsi/msg103603.html
Reported-by: Dan Carpenter
Signed-off-by: Kashyap Desai
Signed-off-by: Sasikum
Since maximum supported FW commands are all defined as u16, change
all local variables referring to max_cmd from u32 to u16.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_base.c | 10 +++
FIX - Do not use random delay to synchronize with IRQ. Use kernel API.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 20 ++--
1 file changed, 18 insertions(+), 2
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas.h| 2 -
drivers/scsi/megaraid/megaraid_sas_base.c | 15 --
drivers/scsi/megaraid/megaraid_sas_fp.c | 266 +
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas.h| 4 ++--
drivers/scsi/megaraid/megaraid_sas_base.c | 20 ++--
drivers/scsi/megaraid/megaraid_sas_fusion.c | 12 +++
On a host, if an ld is deleted there is a hole in the ld array returned
by the FW. But in MR_ValidateMapInfo we are not accounting for holes in
the ld array and traverse only upto index num_lds.
This patch takes care of converting the capability field of all the
valid lds in the ld raid map.
Signe
Fetch the latest controller OCR capability from FW before
sending MR_DCMD_CTRL_SHUTDOWN
When application sends a shutdown DCMD (MR_DCMD_CTRL_SHUTDOWN),
driver will fetch latest controller information from firmware.
This is to ensure that driver always has latest OCR capability
of controller before
Fix kernel warning for accessing unaligned memory access in driver.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_base.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --gi
Error handling: If controller reset is not able to
recover, kill HBA and quit immediately.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
1 file changed, 1 insertion(+)
dif
Add additional logging from driver in OCR context.
Add debug logs for partial completion of IOs is iodone context.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas.h| 3 +++
drivers/
FIX - firmware wants non-RW SYS PD IOs to avoid FastPath for
better tracking and other functionalities if the device
is task management capable.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_s
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/mega
Currently fusion context has fixed array load_balance_info. Use dynamic
allocation.
In few places, driver do not want physically contigious memory.
Attempt to use vmalloc if physical contiguous memory is not available.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hanne
Fix if RDPQ mode enabled MR FW is deployed on big endian host machine,
driver does not setup reply address correctly.
Signed-off-by: Shivasharan S
Signed-off-by: Kashyap Desai
Reviewed-by: Hannes Reinecke
Reviewed-by: Tomas Henzl
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file
fix in v2 - updated description content.
Change MR_TargetIdToLdGet return type from u8 to u16.
ld id range check is added at two places in this patch -
@megasas_build_ldio_fusion and @megasas_build_ld_nonrw_fusion.
Previous driver code used different data type for lds TargetId returned from
MR_T
Avoid Host side PCI bandwidth bottleneck and hint FW to do Write buffering using
RaidFlag MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT.
Once IO is landed in FW with MR_RAID_FLAGS_IO_SUB_TYPE_LDIO_BW_LIMIT,
it will do single DMA from host and buffer the Write operation. On back end,
FW will DMA same buff
1 - 100 of 110 matches
Mail list logo
