> On Feb 8, 2017, at 2:58 PM, Bart Van Assche <bart.vanass...@sandisk.com> > wrote: > > On Wed, 2017-02-08 at 14:53 -0800, Song Liu wrote: >> + try_lock_scan_mutex = mutex_trylock(&shost->scan_mutex); > > This is at least as bad as the approach of your previous patch because > whether or not this mutex_trylock() call succeeds not only depends on > whether or not the caller holds the scan_mutex but also on whether any > other thread accidentally holds that mutex. Please stop hacking and do > what Christoph proposed, namely address the caller of this method. > > Bart. > Western Digital Corporation (and its subsidiaries) E-mail Confidentiality > Notice & Disclaimer: > > This e-mail and any files transmitted with it may contain confidential or > legally privileged information of WDC and/or its affiliates, and are intended > solely for the use of the individual or entity to which they are addressed. > If you are not the intended recipient, any disclosure, copying, distribution > or any action taken or omitted to be taken in reliance on it, is prohibited. > If you have received this e-mail in error, please notify the sender > immediately and delete the e-mail in its entirety from your system. >
Thanks for the feedback. I will dig more in the caller side. Song
