Re: [PATCH v4 6/6] scsi: ufs: add dme control primitives

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:13 PM, Seungwon Jeon wrote: > Implements to support the following operations. > Currently, this patch doesn't introduce DME_ENABLE and DME_RESET > because host controller's HCE enable contains these roles. > > DME_POWERON{OFF}, DME_HIBERNATE_ENTER{EXIT}, DME_ENDPOINTRESET.

Re: [PATCH v4 5/6] scsi: ufs: add dme configuration primitives

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:12 PM, Seungwon Jeon wrote: > Implements to support Get and Set operation of the DME. > These operations are used to configure the behavior of > the UNIPRO. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > Change in v4: > - Removed unipro.h header file. It

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon wrote: > On Thursday, May 09, 2013 Santosh wrote: >> > There are two patches remained. These are applied with your final comments. >> > Do you have any idea? >> > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives >> > [PATCH v4 6/6] scsi: ufs

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
On Thursday, May 09, 2013 Santosh wrote: > > There are two patches remained. These are applied with your final comments. > > Do you have any idea? > > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives > > [PATCH v4 6/6] scsi: ufs: add dme control primitives > > > > Since there is no use c

Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Dolev Raviv
>> + */ >> +int ufshcd_query_request(struct ufs_hba *hba, >> + struct ufs_query_req *query, >> + u8 *descriptor, >> + struct ufs_query_res *response, >> + int timeout, >> + int retries) >>

[ANNOUNCE] lsscsi version 0.27 released

2013-05-08 Thread Douglas Gilbert
lsscsi is a command line utility that probes sysfs in Linux 2.6 and 3 series kernels in order to list information about SCSI devices and SCSI hosts. Both a compact format which is one line per device and a "classic" format (like the output of 'cat /proc/scsi/scsi') are supported. Version 0.27 is

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
> There are two patches remained. These are applied with your final comments. > Do you have any idea? > [PATCH v4 5/6] scsi: ufs: add dme configuration primitives > [PATCH v4 6/6] scsi: ufs: add dme control primitives > Since there is no use case for these implementations yet, except for ufshcd_ge

[PATCH] [SCSI] fnic: fix error return code in fnic_probe()

2013-05-08 Thread Wei Yongjun
From: Wei Yongjun Fix to return -ENOMEM in the mempool_create_slab_pool() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/scsi/fnic/fnic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/fnic/fnic_main.c b/drive

[PATCH] [SCSI] sd: fix error return code in sd_probe()

2013-05-08 Thread Wei Yongjun
From: Wei Yongjun Fix to return a negative error code in the device add error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/

RE: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
On Thursday, May 09, 2013, Santosh Y wrote: > On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > > Simplify operations with hiding mmio_base. > > > > Signed-off-by: Seungwon Jeon > > Tested-by: Maya Erez > > --- > > drivers/scsi/ufs/ufshcd.c | 105 > > +++--

[patch] [SCSI] pm80xx: missing break statement in mpi_sata_completion()

2013-05-08 Thread Dan Carpenter
Smatch discovered a missing break statement here. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_hwi.c index 670998a..6c0470e 100644 --- a/drivers/scsi/pm8001/pm80xx_hwi.c +++ b/drivers/scsi/pm8001/pm80xx_hwi.c @@ -2021,6 +2021,7 @@ mpi_sa

re: [SCSI] pm80xx: NCQ error handling changes

2013-05-08 Thread Dan Carpenter
Hello Sakthivel K, This is a semi-automatic email about new static checker warnings. The patch 1cde970c1025: "[SCSI] pm80xx: NCQ error handling changes" from Mar 19, 2013, leads to the following Smatch complaint: drivers/scsi/pm8001/pm8001_hwi.c:4393 pm8001_chip_sata_req() warn: variabl

Re: [PATCH V4 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 3:20 PM, Sujit Reddy Thumma wrote: > As part of device initialization sequence, sending NOP OUT UPIU and > waiting for NOP IN UPIU response is mandatory. This confirms that the > device UFS Transport (UTP) layer is functional and the host can configure > the device with furt

Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Santosh Y
> + */ > +int ufshcd_query_request(struct ufs_hba *hba, > + struct ufs_query_req *query, > + u8 *descriptor, > + struct ufs_query_res *response, > + int timeout, > + int retries) > +{ > +

Re: [PATCH v4 4/6] scsi: ufs: rework link start-up process

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:12 PM, Seungwon Jeon wrote: > Link start-up requires long time with multiphase handshakes > between UFS host and device. This affects driver's probe time. > This patch let link start-up run asynchronously. Link start-up > will be executed at the end of prove separately. >

Re: [PATCH v4 3/6] scsi: ufs: fix interrupt status clears

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > There is no need to check the version to clear > the interrupt status. And the order is changed > prior to actual handling. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c |5 + > 1 files ch

Re: [PATCH v4 2/6] scsi: ufs: amend interrupt configuration

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > It makes interrupt setting more flexible especially > for disabling. And wrong bit mask is fixed for ver 1.0. > [17:16] is added for mask. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c | 84

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
On Wed, May 8, 2013 at 2:11 PM, Seungwon Jeon wrote: > Simplify operations with hiding mmio_base. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c | 105 > +++-- > drivers/scsi/ufs/ufshcd.h |7 +++- > 2 files

[PATCH RESEND] qla2xxx: Update firmware link in Kconfig file.

2013-05-08 Thread Chad Dupuis
Hi James, Can you apply this for inclusion in 3.10-rc? Thanks, Chad Signed-off-by: Giridhar Malavali Signed-off-by: Chad Dupuis --- drivers/scsi/qla2xxx/Kconfig |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kcon

[PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Dolev Raviv
Send fDeviceInit flag during device initialization. Than poll until the device clears the flag. This step is required during the device initialization process. The flag set is used to communicate to the UFS device that it can complete its initialization. The UFS device will then move from Boot W-LU

Re: [PATCH v10 0/9] More device removal fixes

2013-05-08 Thread Joe Lawrence
On Sun, 07 Apr 2013 16:55:33 +0200 Bart Van Assche wrote: > Fix a few issues that can be triggered by removing a device: > - Fix a race between starved list processing and device removal. > - Avoid that a SCSI LLD callback can get invoked after >scsi_remove_host() finished. > - Speed up devic

Re: [PATCH trivial] mvsas: fix build warning about enum comparisons

2013-05-08 Thread Kyle McMartin
On Tue, May 07, 2013 at 02:20:37PM -0700, James Bottomley wrote: > On Tue, 2013-05-07 at 12:57 -0400, Kyle McMartin wrote: > > device_type is a sas_device_type, not a sas_dev_type. > > Heh, months ago, someone who submitted the same trivial but insufficient > fix was asked to go and see if they co

Re: [PATCH] scsi: add put_device() after device_find_child()

2013-05-08 Thread Vikas Chaudhary
-Original Message- From: Mike Christie Date: Monday 6 May 2013 10:36 PM To: Zhao Hongjiang Cc: "jbottom...@parallels.com" , Ravi Anand , Vikas , scsi Subject: Re: [PATCH] scsi: add put_device() after device_find_child() >On 05/06/2013 06:55 AM, Zhao Hongjiang wrote: >> The qla4xxx_sysf

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread merez
Hi, I tested the new set of patches (v4 1-6) and it works. Thanks, Maya > Simplify operations with hiding mmio_base. > > Signed-off-by: Seungwon Jeon > Tested-by: Maya Erez > --- > drivers/scsi/ufs/ufshcd.c | 105 > +++-- > drivers/scsi/ufs/ufshcd.h |

[PATCH V4 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-08 Thread Sujit Reddy Thumma
As part of device initialization sequence, sending NOP OUT UPIU and waiting for NOP IN UPIU response is mandatory. This confirms that the device UFS Transport (UTP) layer is functional and the host can configure the device with further commands. Add support for sending NOP OUT UPIU to check the dev

[PATCH v4 6/6] scsi: ufs: add dme control primitives

2013-05-08 Thread Seungwon Jeon
Implements to support the following operations. Currently, this patch doesn't introduce DME_ENABLE and DME_RESET because host controller's HCE enable contains these roles. DME_POWERON{OFF}, DME_HIBERNATE_ENTER{EXIT}, DME_ENDPOINTRESET. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- Chang

[PATCH v4 4/6] scsi: ufs: rework link start-up process

2013-05-08 Thread Seungwon Jeon
Link start-up requires long time with multiphase handshakes between UFS host and device. This affects driver's probe time. This patch let link start-up run asynchronously. Link start-up will be executed at the end of prove separately. Along with this change, the following is worked. Defined comple

[PATCH v4 5/6] scsi: ufs: add dme configuration primitives

2013-05-08 Thread Seungwon Jeon
Implements to support Get and Set operation of the DME. These operations are used to configure the behavior of the UNIPRO. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- Change in v4: - Removed unipro.h header file. It will be introduced in next. - Changed function names and error message

[PATCH v4 3/6] scsi: ufs: fix interrupt status clears

2013-05-08 Thread Seungwon Jeon
There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- drivers/scsi/ufs/ufshcd.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/ufs/u

[PATCH v4 2/6] scsi: ufs: amend interrupt configuration

2013-05-08 Thread Seungwon Jeon
It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- drivers/scsi/ufs/ufshcd.c | 84 +++- drivers/scsi/ufs/ufshcd.h |

[PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Seungwon Jeon
Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon Tested-by: Maya Erez --- drivers/scsi/ufs/ufshcd.c | 105 +++-- drivers/scsi/ufs/ufshcd.h |7 +++- 2 files changed, 50 insertions(+), 62 deletions(-) diff --git a/drivers/scsi/u

[SCSI] mvsas: Fix the kernel panic due to unaligned data access

2013-05-08 Thread Paul Guo
It's easy to find the address and symbol that causes the unalignd data access according to the stack dump information. The following small patch will fix it. This change is harmless for platforms (like x86/x64) which support unaligned data access but is critical for platforms those do not support