From: Wei Yongjun <yongjun_...@trendmicro.com.cn>

Fix to return a negative error code in the device add error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
---
 drivers/scsi/sd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 82910cc..99f07e92 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2944,7 +2944,8 @@ static int sd_probe(struct device *dev)
        sdkp->dev.class = &sd_disk_class;
        dev_set_name(&sdkp->dev, dev_name(dev));
 
-       if (device_add(&sdkp->dev))
+       error = device_add(&sdkp->dev);
+       if (error)
                goto out_free_index;
 
        get_device(dev);

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to