Re: [PATCH] MT9T031: write xskip and yskip at each set_params call

2010-02-08 Thread Guennadi Liakhovetski
Hi Val On Mon, 8 Feb 2010, Valentin Longchamp wrote: > > /* > > * Power Management: > > * This function does nothing for now but must be present for pm to work > > */ > > static int mt9t031_runtime_suspend(struct device *dev) > > { > > return 0; > > } > > First, can you confirm me that th

Re: [PATCH] MT9T031: write xskip and yskip at each set_params call

2010-02-08 Thread Valentin Longchamp
Hello Guennadi, Guennadi Liakhovetski wrote: First more details about what I do with the camera: I open the device, issue the S_CROP / S_FMT calls and read images, the behaviour is fine, then close the device. Then if I reopen the device, reissue the S_CROP / S_FMT calls with the same params, b

Re: [PATCH] MT9T031: write xskip and yskip at each set_params call

2010-02-04 Thread Guennadi Liakhovetski
(added two more persons to CC, because I think, this discussion can be interesting for them too) On Thu, 21 Jan 2010, Valentin Longchamp wrote: > Guennadi Liakhovetski wrote: > > On Wed, 20 Jan 2010, Valentin Longchamp wrote: > > > > > This prevents the registers to be different to the computed

Re: [PATCH] MT9T031: write xskip and yskip at each set_params call

2010-01-21 Thread Valentin Longchamp
Guennadi Liakhovetski wrote: On Wed, 20 Jan 2010, Valentin Longchamp wrote: This prevents the registers to be different to the computed values the second time you open the same camera with the sames parameters. The images were different between the first device open and the second one with the

Re: [PATCH] MT9T031: write xskip and yskip at each set_params call

2010-01-20 Thread Guennadi Liakhovetski
On Wed, 20 Jan 2010, Valentin Longchamp wrote: > This prevents the registers to be different to the computed values > the second time you open the same camera with the sames parameters. > > The images were different between the first device open and the > second one with the same parameters. But

[PATCH] MT9T031: write xskip and yskip at each set_params call

2010-01-20 Thread Valentin Longchamp
This prevents the registers to be different to the computed values the second time you open the same camera with the sames parameters. The images were different between the first device open and the second one with the same parameters. Signed-off-by: Valentin Longchamp --- drivers/media/video/m