Re: [RFC v2] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-11-22 Thread Shuah
On 11/18/24 14:23, Jakub Kicinski wrote: On Mon, 18 Nov 2024 14:02:29 -0700 Shuah Khan wrote: Sorry for the delay, the responses to v1 weren't super positive but I keep thinking this would be very useful :) Or at the very least I find workflows@ very useful and informative as a maint

Re: [RFC v2] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-11-18 Thread Shuah Khan
sting as an RFC because we need to create the new ML. I have to repeat the same thing I said when you sent RFC v1 It is going to add the confusion - people don't cc the one mailing list we have now. I am going to have to say no. Sorry. thanks, -- Shuah

Re: [PATCH] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests

2024-11-07 Thread Shuah Khan
On 11/7/24 11:00, Catalin Marinas wrote: On Thu, Nov 07, 2024 at 09:50:20AM -0700, Shuah Khan wrote: On 11/7/24 06:16, Kevin Brodsky wrote: Commit 6e182dc9f268 ("selftests/mm: Use generic pkey register manipulation") makes use of PKEY_UNRESTRICTED in pkey_sighandler_tests. The macr

Re: [PATCH] selftests/mm: Define PKEY_UNRESTRICTED for pkey_sighandler_tests

2024-11-07 Thread Shuah Khan
ic inline u64 set_pkey_bits(u64 reg, int pkey, u64 flags) { thanks, -- Shuah

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
On 10/31/24 18:39, Andrew Morton wrote: On Thu, 31 Oct 2024 11:50:16 -0600 Shuah Khan wrote: On 10/30/24 07:43, Luis Felipe Hernandez wrote: Adds test suite for integer based square root function. The test suite is designed to verify the correctness of the int_sqrt() math library function

Re: [PATCH v3] lib/math: Add int_sqrt test suite

2024-10-31 Thread Shuah Khan
nit_test_suites(&int_sqrt_test_suite); + +MODULE_DESCRIPTION("math.int_sqrt KUnit test suite"); +MODULE_LICENSE("GPL"); Acked-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests: Add kselftest framework to the testfile

2024-10-24 Thread Shuah Khan
On 10/24/24 10:55, Shivam Chaudhary wrote: This patch updates the existing test that checks for `open(O_TMPFILE)` and `linkat()` behaviors in mount namespaces to use the kselftest framework. This includes the following changes: - Replaced direct error handling with `ksft_test_result_*` macros

Re: [PATCH] Add Selftest to test fork() syscall

2024-10-23 Thread Shuah Khan
On 10/23/24 15:11, Shivam Chaudhary wrote: On 24/10/24 2:15 AM, Shuah Khan wrote: On 10/22/24 14:42, Shivam Chaudhary wrote: This test verifies the correct behavior of the fork() system call, which creates a child process by duplicating the parent process. The test checks the following

Re: [PATCH net-next 4/8] selftests: net: lib: Move logging from forwarding/lib.sh here

2024-10-23 Thread Shuah Khan
ommon and to namespace conflicts in the future. Signed-off-by: Petr Machata Reviewed-by: Amit Cohen --- CC: Shuah Khan Acked-by: Shuah Khan for all patches 4/8 through 8/8 I have been cc'ed on. thanks, -- Shuah

Re: [PATCH] Add Selftest to test fork() syscall

2024-10-23 Thread Shuah Khan
call. thanks, -- Shuah

Re: [PATCH kselftest v3 1/3] selftests: vDSO: unconditionally build chacha test

2024-10-08 Thread Shuah Khan
code. Signed-off-by: Jason A. Donenfeld --- Thank you. Applied all three patches to linux-kselftest fixes and will include them in my next pull request for rc3. thanks, -- Shuah

Re: [PATCH kselftest v2 4/4] selftests: vDSO: unconditionally build chacha test

2024-10-07 Thread Shuah Khan
der.S:1: +// SPDX-License-Identifier: GPL-2.0 thanks, -- Shuah

Re: [PATCH v4] Kunit to check the longest symbol length

2024-10-07 Thread Shuah Khan
atic struct kunit_suite longest_symbol_test_suite = { + .name = "longest-symbol", + .test_cases = longest_symbol_test_cases, +}; +kunit_test_suite(longest_symbol_test_suite); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Test the longest symbol length"); +MODULE_AUTHOR("Sergio González Collado"); base-commit: abf2050f51fdca0fd146388f83cddd95a57a008d thanks, -- Shuah

Re: [PATCH kselftest 0/3] getrandom & chacha cleanups

2024-10-03 Thread Shuah Khan
On 10/2/24 21:13, Jason A. Donenfeld wrote: Hi Shuah, I've now read your email several times trying to figure out what you meant and what your objections are. This series is my best attempt at trying to satisfy that. But my understanding still has a lot of question marks, so I may have m

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-10-03 Thread Shuah Khan
On 9/23/24 20:57, Yu Liao wrote: Hi, On 2024/9/23 23:30, Shuah Khan wrote: On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. CLONE_NEWTIME was introduced in glibc-2.36, which was released in August

Re: [RFC] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-10-03 Thread Shuah
iff --git a/MAINTAINERS b/MAINTAINERS index c27f3190737f..9a03dc1c8974 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12401,6 +12401,18 @@ S: Maintained Q:https://patchwork.kernel.org/project/linux-kselftest/list/ T:git git://git.kernel.org/pub/scm/linux/kernel/git/shua

Re: [PATCH v5 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-10-02 Thread Shuah Khan
Signed-off-by: Yifei Liu --- v4->v5: Remove the above quotes in the first part. remove the incorrect format which could confuse the git. Applied to linux-kselftest fixes branch for next rc. thanks, -- Shuah

Re: [PATCH] selftests: vDSO: align getrandom states to cache line

2024-10-01 Thread Shuah Khan
or next rc. thanks, -- Shuah

Re: [PATCH v4 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
s/power/state) 2> /dev/null"); + + timerfd_gettime(timerfd, &spec); + if (spec.it_value.tv_sec != 0 || spec.it_value.tv_nsec != 0) ksft_exit_fail_msg("Failed to enter Suspend state\n"); close(timerfd); thanks, -- Shuah

Re: [PATCH v4 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
On 9/30/24 16:13, Shuah Khan wrote: On 9/30/24 14:36, Yifei Liu wrote: "step_after_suspend_test fails with device busy error while You don't need quotes writing to /sys/power/state to start suspend." Same here. The test believes it failed to enter suspend sta

Re: [PATCH] selftests/proc/proc-empty-vm.c: Test for unmapped process

2024-09-30 Thread Shuah Khan
sleep(1); + if (rv == EXIT_SUCCESS) { + rv = test_proc_pid_mem(pid); + } if (rv == EXIT_SUCCESS) { rv = test_proc_pid_maps(pid); } Also add everybody get_maintianer.pl suggests when you send v2. You are missing key reviewers and maintainers. thanks, -- Shuah

Re: [PATCH v3 v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-30 Thread Shuah Khan
at ',' (ctx:VxO) #168: FILE: tools/testing/selftests/breakpoints/step_after_suspend_test.c:157: + timerfd_gettime(timerfd,&spec); ^ ERROR: space required before that '&' (ctx:OxV) #168: FILE: tools/testing/selftests/breakpoints/step_after_suspend_test.c:157: + timerfd_gettime(timerfd,&spec); ^ thanks, -- Shuah

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-23 Thread Shuah Khan
On 9/23/24 15:18, Yifei Liu wrote: On Sep 23, 2024, at 1:56 PM, Shuah Khan wrote: On 9/23/24 14:47, Yifei Liu wrote: We recently notice that the step_after_suspend_test would noticed How about change this to find? Either is fine - it would found instead of find - or you could write it

Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use remaining time to check if suspend succeed

2024-09-23 Thread Shuah Khan
timerfd,&spec); + if (spec.it_value.tv_sec != 0 || spec.it_value.tv_nsec != 0) ksft_exit_fail_msg("Failed to enter Suspend state\n"); close(timerfd); thanks, -- Shuah

Re: [PATCH 2/2] unicode: kunit: change tests filename and path

2024-09-23 Thread Shuah Khan
s good to me. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH 1/2] unicode: kunit: refactor selftest to kunit tests

2024-09-23 Thread Shuah Khan
nst char *s) Keep "const char *s" on the second line. { return utf8nlen(um, n, s, (size_t)-1); } Rest looks good to me. thanks, -- Shuah

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-23 Thread Shuah Khan
On 9/20/24 11:52, Yifei Liu wrote: Hi Shuah, On Sep 20, 2024, at 8:07 AM, Shuah Khan wrote: On 9/19/24 17:09, Yifei Liu wrote: Hi Shuah, On Sep 19, 2024, at 11:36 AM, Shuah Khan wrote: On 9/17/24 16:48, Yifei Liu wrote: We recently notice that the step_after_suspend_test would fail on

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-23 Thread Shuah Khan
On 9/20/24 09:31, Jason A. Donenfeld wrote: Indeed probably is what's wanted here. Yu Liao, Please send v2 as per the review comments. Shuah - I was taking patches for this code during the 6.12 development cycle, because it all interacted with the dev work I was doing. But I think t

Re: [External] : Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-20 Thread Shuah Khan
On 9/19/24 17:09, Yifei Liu wrote: Hi Shuah, On Sep 19, 2024, at 11:36 AM, Shuah Khan wrote: On 9/17/24 16:48, Yifei Liu wrote: We recently notice that the step_after_suspend_test would fail on our plenty devices. The test believesit failed to What are "plenty devices" recent

Re: [PATCH v6.11 v5.15 v5.4 v4.19 1/1] selftests: breakpoints: use time passed to check if suspend succeed

2024-09-19 Thread Shuah Khan
d to enter Suspend state\n"); + t = clock(); + write(power_state_fd, "mem", strlen("mem")); + t = clock()-t; + if ((int)(t) < 4) + ksft_exit_fail_msg("Failed to enter Suspend state %d\n",errno); close(timerfd); close(power_state_fd); thanks, -- Shuah

Re: [PATCH] selftests: timers: Fix clock_adjtime for newer 32-bit arches

2024-09-19 Thread Shuah Khan
o I wonder if a better fix would be just to drop the local clock_adjtime implementation here, as I'm sure the libc has similar logic to what's being added here? The proposed solution works better than adding local clock_adjtime implementation here. thanks, -- Shuah

Re: [PATCH] selftests: vDSO: fix compile error for vdso_test_getrandom

2024-09-19 Thread Shuah Khan
+++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include Do you see this error after installing headers? Installing headers is a dependency to be able to compile selftests. thanks, -- Shuah

Re: [PATCH v5] lib/math: Add int_pow test suite

2024-09-12 Thread Shuah Khan
t case with non-power of two exponent - Fix module license --- Looks good to me, thanks! Reviewed-by: David Gow Cheers, -- David thanks, -- Shuah

[GIT PULL] KUnit fixes update for Linux 6.11-rc7

2024-09-04 Thread Shuah Khan
. thanks, -- Shuah The following changes since commit 8400291e289ee6b2bf9779ff1c83a291501f017b: Linux 6.11-rc1 (2024-07-28 14:19:55 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/shuah

Re: [PATCH 1/5] selftests: vdso: Fix vDSO name for powerpc

2024-08-30 Thread Shuah Khan
On 8/30/24 06:41, Jason A. Donenfeld wrote: Hi Shuah, No 0/5 patch, so replying to the first one. These are fixes to the vDSO selftests that Christophe is ostensibly providing as a preamble to his work porting vgetrandom to PPC. Do you mind if I take these via my random tree so his PPC

Re: [PATCH] kselftest/arm64: Fix build warnings for ptrace

2024-08-30 Thread Shuah Khan
t_exit_fail_msg("raise(SIGSTOP)", strerror(errno)); + ksft_exit_fail_perror("raise(SIGSTOP)"); return EXIT_SUCCESS; } Thanks for doing this. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests: splice: Add splice_read.sh and hint

2024-08-30 Thread Shuah Khan
esting/selftests/splice/splice_read.sh @@ -0,0 +1,9 @@ +#!/bin/sh +# SPDX-License-Identifier: GPL-2.0 +set -e +nl=$(./splice_read /etc/os-release | wc -l) + +test "$nl" != 0 && exit 0 + +echo "splice_read broken" +exit 1 thanks, -- Shuah

Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

2024-08-27 Thread Shuah Khan
ARM64 has already lost test coverage after commit 48f6430505c0. I am seeing several checkpatch errors - please fix them and send me v2. thanks, -- Shuah

Re: [PATCH v3] Documentation: KUnit: Update filename best practices

2024-08-27 Thread Shuah Khan
push it through along with the naming changes, that's fine by me. Reviewed-by: David Gow Hi! Just a quick check: I haven't seen this land in -next yet. Are you still planning to take this? I applied it yesterday to kunit next. thanks, -- Shuah

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-08-27 Thread Shuah Khan
On 8/22/24 06:14, Dev Jain wrote: Rename sigaltstack to generic signal directory, to allow adding more signal tests in the future. Sorry - I think I mentioned I don't like this test renamed. Why are you sending this rename still included in the patch series? thanks, -- Shuah

Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal

2024-08-27 Thread Shuah Khan
On 8/22/24 05:10, Dev Jain wrote: On 8/22/24 08:33, Shuah Khan wrote: On 8/21/24 00:15, Dev Jain wrote: Rename sigaltstack to signal, and rename the existing test to sigaltstack.c. Can you elaborate on the benefits if renaming the test? Also you have such a good information in the cover

Re: [PATCH] ftrace/selftest: Test combination of function_graph tracer and function profiler

2024-08-26 Thread Shuah Khan
On 8/22/24 07:19, Steven Rostedt wrote: On Wed, 21 Aug 2024 21:54:42 -0600 Shuah Khan wrote: On 8/21/24 13:09, Steven Rostedt wrote: From: Steven Rostedt Masami reported a bug when running function graph tracing then the function profiler. The following commands would cause a kernel crash

Re: [PATCH] test coverage for dup_fd() failure handling in unshare_fd()

2024-08-21 Thread Shuah Khan
hanks, -- Shuah

Re: [PATCH v1] selftests:tdx:Use min macro

2024-08-21 Thread Shuah Khan
line_len = min((len - j), rowsize); | ^~~ thanks, -- Shuah

Re: [PATCH] ftrace/selftest: Test combination of function_graph tracer and function profiler

2024-08-21 Thread Shuah Khan
nabled with +# function graph tracer. If the below fails, mark it as unsupported +echo 1 > function_profile_enabled || exit_unsupported + +sleep 1 Any specific reason for this sleep 1 - can you add a comment on top? + +exit 0 Reviewed-by: Shuah Khan Let me know if you would like v2 for

Re: [PATCH v5 1/2] selftests: Rename sigaltstack to generic signal

2024-08-21 Thread Shuah Khan
/current_stack_pointer.h diff --git a/tools/testing/selftests/sigaltstack/sas.c b/tools/testing/selftests/signal/sigaltstack.c similarity index 100% rename from tools/testing/selftests/sigaltstack/sas.c rename to tools/testing/selftests/signal/sigaltstack.c thanks, -- Shuah

Re: [PATCH v1] tools:mm:Check mmap based on return values

2024-08-21 Thread Shuah Khan
WRITE, MAP_ANONYMOUS|MAP_PRIVATE, -1, 0); - if (!map) + if (map == MAP_FAILED) ksft_exit_fail_msg("anon mmap failed\n"); } else { test_fd = open(fname, O_RDWR | O_CREAT, 0664); With the above fixed: Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/ftrace: Fix test to handle both old and new kernels

2024-08-20 Thread Shuah Khan
On 8/19/24 13:20, Steven Rostedt wrote: On Fri, 14 Jun 2024 12:43:22 -0400 Steven Rostedt wrote: Shuah, Can you take this through your tree? Ping. -- Steve Thanks, -- Steve On Wed, 15 May 2024 01:36:20 -0400 Steven Rostedt wrote: From: "Steven Rostedt (Google)" Th

Re: [PATCH 0/3] selftests: Fix cpuid / vendor checking build issues

2024-08-20 Thread Shuah Khan
es. Usama, does this fix the problem you are seeing? Hi Reinette - do these look okay to you? Can you give me an ack if they do? thanks, -- Shuah

Re: [PATCH v2] selftests: kvm: fix mkdir error when building for unsupported arch

2024-08-19 Thread Shuah Khan
Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-19 Thread Shuah Khan
On 8/14/24 06:25, Eugene Syromiatnikov wrote: On Wed, Aug 14, 2024 at 05:14:08AM -0600, Shuah Khan wrote: On 8/13/24 10:33, Eugene Syromiatnikov wrote: On Mon, Aug 12, 2024 at 05:03:45PM -0600, Shuah Khan wrote: On 8/12/24 10:56, Eugene Syromiatnikov wrote: The relative RPATH ("./"

Re: [PATCH v4 3/3] selftests/tracing: Add hist poll() support test

2024-08-16 Thread Shuah Khan
== BUFSIZE); + + ret = poll(&pfd, 1, timeout); + if (ret < 0 && errno != EINTR) { + perror("poll"); + return -1; + } + close(pfd.fd); + + /* If timeout happned, return code is 0 */ Looks like you missed this one :) Otherwise looks good to me. With this fixed Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests: filesystems: fix warn_unused_result build warnings

2024-08-16 Thread Shuah Khan
e change looks good to me. thanks, -- Shuah

Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests

2024-08-14 Thread Shuah Khan
On 8/13/24 18:53, Masami Hiramatsu (Google) wrote: Hi Shuah, Can you pick this? I confirmed this can be applied on v6.11-rc3. On Thu, 13 Jun 2024 07:12:10 +0900 "Masami Hiramatsu (Google)" wrote: From: Masami Hiramatsu (Google) kprobe_args_{char,string}.tc

Re: [PATCH v3 3/3] selftests/tracing: Add hist poll() support test

2024-08-14 Thread Shuah Khan
GPID} ]; then + echo "poll exits too soon" + kill -KILL ${BGPID} ||: + exit_fail +fi + +if ! grep -qw "sleep" trace; then + echo "poll exits before event happens" + exit_fail +fi + +exit_pass thanks, -- Shuah

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-14 Thread Shuah Khan
On 8/13/24 10:33, Eugene Syromiatnikov wrote: On Mon, Aug 12, 2024 at 05:03:45PM -0600, Shuah Khan wrote: On 8/12/24 10:56, Eugene Syromiatnikov wrote: The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-13 Thread Shuah Khan
On 8/13/24 01:39, Ilpo Järvinen wrote: On Mon, 12 Aug 2024, Reinette Chatre wrote: On 8/12/24 3:49 PM, Shuah Khan wrote: On 8/9/24 02:45, Ilpo Järvinen wrote: Adding Maciej. On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: On 8/9/24 12:23 PM, Ilpo Järvinen wrote: On Fri, 9 Aug 2024

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-13 Thread Shuah Khan
On 8/12/24 18:05, Reinette Chatre wrote: Hi Shuah, On 8/12/24 3:49 PM, Shuah Khan wrote: On 8/9/24 02:45, Ilpo Järvinen wrote: Adding Maciej. On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: On 8/9/24 12:23 PM, Ilpo Järvinen wrote: On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: This test

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-12 Thread Shuah Khan
ard.redhat.com/ --- tools/testing/selftests/alsa/Makefile | 1 - tools/testing/selftests/bpf/Makefile | 5 ++--- tools/testing/selftests/lib.mk | 3 +++ tools/testing/selftests/rseq/Makefile | 2 +- tools/testing/selftests/sched/Makefile | 3 +-- 5 files changed, 7 insertions(+), 7 deletions(-) thanks, -- Shuah

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-12 Thread Shuah Khan
pecific to lack of CPUID. This seems a kselftest common level problem to me, since __cpuid_count() is provided in kselftest.h. Shuah (or others), what is the intended mechanism for selftests to know if it can be used or not since as is, it's always defined? _cpuid_count() gets defined

Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c

2024-08-12 Thread Shuah Khan
) { - ksft_print_msg("zswpwb_after is %ld while wb is %s", + ksft_print_msg("zswpwb_after is %ld while wb is %s\n", zswpwb_after, wb ? "enabled" : "disabled"); goto out; } The change looks good

Re: [PATCH 1/2] selftests: rust: config: add trailing newline

2024-08-11 Thread Shuah Khan
be improved too? Shuah, if you plan to pick this: Acked-by: Miguel Ojeda Thanks! Cheers, Miguel Applied to linux-kselftest next for Linux 6.12-rc1. thanks, -- Shuah

Re: [PATCH 2/2] selftests: rust: config: disable GCC_PLUGINS

2024-08-11 Thread Shuah Khan
https://lore.kernel.org/rust-for-linux/20240731125615.3368813-1-n...@gompa.dev/ goes in, this could also be relaxed. Thanks! Cheers, Miguel Applied to linux-kselftest next for Linux 6.12-rc1. thanks, -- Shuah

Re: [PATCH] selftests/mm: compaction_test: Fix off by one in check_compaction()

2024-08-09 Thread Shuah Khan
efine? - sprintf(init_nr_hugepages, "%lu", initial_nr_hugepages); + snprintf(init_nr_hugepages, sizeof(init_nr_hugepages), +"%lu", initial_nr_hugepages); /* We want to test with 80% of available memory. Else, OOM killer comes in to play */ Wi

Re: [PATCH 2/2] selftests/mm: Do not fail test for a single migration failure

2024-08-09 Thread Shuah Khan
ures = 0; tmp = n2; n2 = n1; n1 = tmp; thanks, -- Shuah

Re: [PATCH] selftests/alsa/Makefile: fix relative rpath usage

2024-08-09 Thread Shuah Khan
On 8/8/24 19:00, Eugene Syromiatnikov wrote: On Thu, Aug 08, 2024 at 02:20:21PM -0600, Shuah Khan wrote: Wouldn't make sense to fix fix this in selftests main Makefile instead of changing the all the test makefiles As of now, the usage of rpath is localised, so it is relatively ea

Re: [PATCH] selftests: memfd_secret: don't build memfd_secret test on unsupported arches

2024-08-09 Thread Shuah Khan
M_MERGE_TIME_HUGE_PAGES test with size of 100 CATEGORY="ksm" run_test ./ksm_tests -H -s 100 Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] selftests/alsa/Makefile: fix relative rpath usage

2024-08-08 Thread Shuah Khan
$(OUTPUT) -Wl,-rpath=\$$ORIGIN/ LDLIBS+=-lpthread Wouldn't make sense to fix fix this in selftests main Makefile instead of changing the all the test makefiles Same comment on all other files. It would be easier to send these as series - please mentioned the tests run as well after this change. thanks, -- Shuah

Re: [PATCH] selftests/sched/Makefile: remove relative rpath usage

2024-08-08 Thread Shuah Khan
ll the test makefiles Same comment on all other files. It would be easier to send these as series - please mentioned the tests run as well after this change. thanks, -- Shuah

Re: [PATCH] selftests/rseq/Makefile: fix relative rpath usage

2024-08-08 Thread Shuah Khan
other files. It would be easier to send these as series - please mentioned the tests run as well after this change. thanks, -- Shuah

Re: [PATCH v2 00/15] tools/nolibc: improve LLVM/clang support

2024-08-07 Thread Shuah Khan
s changed, 83 insertions(+), 48 deletions(-) --- base-commit: ae1f550efc11eaf1496c431d9c6e784cb49124c5 change-id: 20240727-nolibc-llvm-3fad68590d4c Best regards, Looks good to me. For selftests patches: Reviewed-by: Shuah Khan thanks, -- Shuah

Re: [PATCH] tracing/selftests: Run the ownership test twice

2024-08-07 Thread Shuah Khan
On 8/7/24 14:29, Steven Rostedt wrote: On Fri, 14 Jun 2024 12:41:51 -0400 Steven Rostedt wrote: Shuah, Can you take this through your tree? Ping! -- Steve Sorry for the delay. Applied it o linux-kselftest next for Linux 6.12-rc1. thanks, -- Shuah

Re: [PATCH] selftests/uprobes: Add a basic uprobe testcase

2024-08-07 Thread Shuah Khan
Reviewed-by: Steven Rostedt (Google) Shuah, can you take this too. Yes. -- Steve Applied to linux-kselftest next for Linux 6.12-rc1. thanks, -- Shuah

Re: [PATCH v2 0/2] selftests: harness: refactor __constructor_order

2024-08-06 Thread Shuah Khan
n commit description. Masahiro Yamada (2): selftests: harness: remove unneeded __constructor_order_last() selftests: harness: rename __constructor_order for clarification Thanks for resending this! Reviewed-by: Kees Cook Shuah, do you want to take this via kselftest? If not, I can carry it... -K

Re: [PATCH] selftests: kvm: fix mkdir error when building for non-supported arch

2024-08-06 Thread Shuah Khan
-$(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS +$(shell mkdir -p $(sort $(dir $(TEST_GEN_PROGS))) > /dev/null 2>&1) $(SPLIT_TEST_GEN_OBJ): $(GEN_HDRS) $(TEST_GEN_PROGS): $(LIBKVM_OBJS) $(TEST_GEN_PROGS_EXTENDED): $(LIBKVM_OBJS) thanks, -- Shuah

Re: [PATCH v2] kselftest/devices/probe: Fix SyntaxWarning in regex strings for Python 3

2024-08-05 Thread Shuah Khan
PRODUCT=.*/(\d)/.*") with open(os.path.join(sysfs_dev_dir, "uevent")) as f: return int(re_usb_version.search(f.read()).group(1)) thanks, -- Shuah

Re: [PATCH RFT v7 0/9] fork: Support shadow stacks in clone3()

2024-08-05 Thread Shuah Khan
91501f017b change-id: 20231019-clone3-shadow-stack-15d40d2bf536 Best regards, For selftests: Acked-by: Shuah Khan thanks, -- Shuah

[GIT PULL] Kselftest fixes update for Linux 6.11-rc3

2024-08-05 Thread Shuah Khan
account and report the test as passed. diff is attached. thanks, -- Shuah The following changes since commit 8400291e289ee6b2bf9779ff1c83a291501f017b: Linux 6.11-rc1 (2024-07-28 14:19:55 -0700) are available in the Git repository at

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-02 Thread Shuah Khan
On 8/1/24 23:38, Muhammad Usama Anjum wrote: On 8/1/24 9:27 PM, Shuah Khan wrote: On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. Th

Re: [PATCH 1/2] tools/nolibc: add support for [v]sscanf()

2024-08-02 Thread Shuah Khan
On 8/2/24 09:48, Thomas Weißschuh wrote: On 2024-07-31 17:01:09+, Shuah Khan wrote: On 7/31/24 12:32, Thomas Weißschuh wrote: The implementation is limited and only supports numeric arguments. I would like to see more information in here. Why is this needed etc. etc. Ack. Signed-off

Re: [PATCH 0/2] selftests/nolibc: run-user improvements

2024-08-02 Thread Shuah Khan
e was messed up. I blame systemd-timesyncd. Well, at least we know b4 is Y38K compliant. ;) And my nolibc email folder will show this thread as the latest forever :) thanks, -- Shuah

Re: [PATCH] selftests: tpm2: redirect python unittest logs to stdout

2024-08-01 Thread Shuah Khan
On 8/1/24 16:24, Jarkko Sakkinen wrote: On Wed Jul 31, 2024 at 8:45 PM EEST, Shuah Khan wrote: On 7/31/24 07:42, Muhammad Usama Anjum wrote: Reminder top post??? On 7/10/24 1:15 PM, Muhammad Usama Anjum wrote: The python unittest module writes all its output to stderr, even when the run

Re: [PATCH RFC] kselftest: devices: Add test to detect missing devices

2024-08-01 Thread Shuah Khan
On 8/1/24 15:03, Nícolas F. R. A. Prado wrote: On Thu, Aug 01, 2024 at 02:13:05PM -0600, Shuah Khan wrote: On 8/1/24 13:15, Nícolas F. R. A. Prado wrote: On Wed, Jul 31, 2024 at 05:19:45PM -0600, Shuah Khan wrote: On 7/24/24 15:40, Nícolas F. R. A. Prado wrote: Introduce a new test to

Re: [PATCH RFC] kselftest: devices: Add test to detect missing devices

2024-08-01 Thread Shuah Khan
On 8/1/24 13:15, Nícolas F. R. A. Prado wrote: On Wed, Jul 31, 2024 at 05:19:45PM -0600, Shuah Khan wrote: On 7/24/24 15:40, Nícolas F. R. A. Prado wrote: Introduce a new test to identify regressions causing devices to go missing on the system. For each bus and class on the system the test

Re: [PATCH] MAINTAINERS: Add selftests/x86 entry

2024-08-01 Thread Shuah Khan
On 8/1/24 13:27, Shuah Khan wrote: On 7/31/24 15:23, Peter Zijlstra wrote: On Wed, Jul 31, 2024 at 12:14:16PM -0600, Shuah Khan wrote: On 7/31/24 07:42, Muhammad Usama Anjum wrote: Kind reminder On 7/2/24 3:17 PM, Muhammad Usama Anjum wrote: Kind reminder Top post ??? On 6/10/24 10:28

Re: [PATCH] MAINTAINERS: Add selftests/x86 entry

2024-08-01 Thread Shuah Khan
On 7/31/24 15:23, Peter Zijlstra wrote: On Wed, Jul 31, 2024 at 12:14:16PM -0600, Shuah Khan wrote: On 7/31/24 07:42, Muhammad Usama Anjum wrote: Kind reminder On 7/2/24 3:17 PM, Muhammad Usama Anjum wrote: Kind reminder Top post ??? On 6/10/24 10:28 AM, Muhammad Usama Anjum wrote

Re: [PATCH v4] selftest: acct: Add selftest for the acct() syscall

2024-08-01 Thread Shuah Khan
, -- Shuah

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Shuah Khan
On 8/1/24 10:27, Shuah Khan wrote: On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead chec

Re: [PATCH v2] selftests: openat2: don't print total number of tests and then skip

2024-08-01 Thread Shuah Khan
On 8/1/24 02:42, Muhammad Usama Anjum wrote: On 7/31/24 9:57 PM, Shuah Khan wrote: On 7/31/24 07:39, Muhammad Usama Anjum wrote: Don't print that 88 sub-tests are going to be executed, but then skip. This is against TAP compliance. Instead check pre-requisites first before printing

Re: [PATCH v3] selftest: acct: Add selftest for the acct() syscall

2024-07-31 Thread Shuah Khan
rest looks good to me. Please send v4 adding the SPDX to acct/Makefile thanks, -- Shuah

Re: [PATCH RFC] kselftest: devices: Add test to detect missing devices

2024-07-31 Thread Shuah Khan
es/exist: exist.py # TAP version 13 # # No matching reference file found (tried './LENOVO,20XH005JUS.yaml') # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 not ok 1 selftests: devices/exist: exist.py # exit=1 make: Leaving directory '/linux/linux_6.11/tools/testing/selftests/devices/exist' thanks, -- Shuah

Re: [PATCH] selftests: ksft: Track skipped tests when finishing the test suite

2024-07-31 Thread Shuah Khan
On 7/30/24 04:35, Laura Nao wrote: On 7/29/24 22:06, Shuah Khan wrote: On 7/29/24 08:52, Laura Nao wrote: Hi Shuah, On 7/23/24 18:17, Shuah Khan wrote: On 7/22/24 09:43, Laura Nao wrote: Consider skipped tests in addition to passed tests when evaluating the overall result of the test suite

Re: [PATCH 1/2] tools/nolibc: add support for [v]sscanf()

2024-07-31 Thread Shuah Khan
CASE_TEST(char); EXPECT_VFPRINTF(1, "c", "%c", 'c'); break; CASE_TEST(hex); EXPECT_VFPRINTF(1, "f", "%x", 0xf); break; CASE_TEST(pointer); EXPECT_VFPRINTF(3, "0x1", "%p", (void *) 0x1); break; + CASE_TEST(scanf);EXPECT_ZR(1, test_scanf()); break; case __LINE__: return ret; /* must be last */ /* note: do not set any defaults so as to permit holes above */ thanks, -- Shuah

Re: [PATCH 0/2] tools/nolibc: add support for [v]sscanf()

2024-07-31 Thread Shuah Khan
On 7/31/24 12:32, Thomas Weißschuh wrote: The implementation is limited and only supports numeric arguments. It would help to add more details on why this is needed especially in the commit log. Signed-off-by: Thomas Weißschuh --- Thomas Weißschuh (2): tools/nolibc: add support for [

Re: kselftest/next kselftest-lib: 1 runs, 1 regressions (v6.11-rc1-6-g38cde27f74d8)

2024-07-31 Thread Shuah Khan
/ Above link give me 404 - page not found - bad link? Test: kselftest-lib Tree: kselftest Branch: next Describe: v6.11-rc1-6-g38cde27f74d8 URL: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git SHA: 38cde27f74d8bbe2f705fb1f80384acab9762e9e

Re: [PATCH] MAINTAINERS: Add selftests/x86 entry

2024-07-31 Thread Shuah Khan
On 7/31/24 07:42, Muhammad Usama Anjum wrote: Kind reminder On 7/2/24 3:17 PM, Muhammad Usama Anjum wrote: Kind reminder Top post ??? On 6/10/24 10:28 AM, Muhammad Usama Anjum wrote: There are no maintainers specified for tools/testing/selftests/x86. Shuah has mentioned [1] that the

Re: [PATCH v2] selftests: lib: remove strscpy test

2024-07-31 Thread Shuah Khan
On 7/31/24 02:32, Muhammad Usama Anjum wrote: On 7/31/24 3:37 AM, Shuah Khan wrote: On 7/25/24 06:11, Muhammad Usama Anjum wrote: The strscpy test loads test_strscpy module for testing. But test_strscpy was converted to Kunit (see fixes). Hence remove strscpy. Fixes: 41eefc46a3a4 ("s

Re: [PATCH] selftests: user: remove user suite

2024-07-31 Thread Shuah Khan
On 7/30/24 23:13, Muhammad Usama Anjum wrote: On 7/31/24 7:33 AM, Kees Cook wrote: On July 30, 2024 3:36:11 PM PDT, Shuah Khan wrote: On 7/25/24 08:44, Shuah Khan wrote: On 7/25/24 05:08, Muhammad Usama Anjum wrote: The user test suite has only one test, test_user_copy which loads

Re: [PATCH v2] selftests: ksft: Fix finished() helper exit code on skipped tests

2024-07-31 Thread Shuah Khan
d to linux-kselftest fixes for Linux 6.11-rc2 thanks, -- Shuah

Re: [PATCH] selftests: tpm2: redirect python unittest logs to stdout

2024-07-31 Thread Shuah Khan
Anjum --- tools/testing/selftests/tpm2/test_async.sh | 2 +- tools/testing/selftests/tpm2/test_smoke.sh | 2 +- tools/testing/selftests/tpm2/test_space.sh | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Applied to linux-kselftest next for Linux 6.12-rc1 thanks, -- Shuah

  1   2   3   4   5   >