On 9/10/24 22:33, David Gow wrote:
On Tue, 10 Sept 2024 at 09:10, Luis Felipe Hernandez
<luis.hernandez...@gmail.com> wrote:

Adds test suite for integer based power function.

It would be nice to see more details on what this test does>
What's the output look like?

I fixed it up with the details from the Kconfig. Please do make sure
to add test details in the commit long in the future.

There was a trailing whitespace I had to fix. Run checkpatch to verify
that there are no issues with the patch in future.


Signed-off-by: Luis Felipe Hernandez <luis.hernandez...@gmail.com>
---
Changes in v5:
   - Fix kernel test bot warning
   - Rebase with latest
Changes in v4:
   - Address checkpatch warning and make kconfig description longer
   - Use GPL-2.0-only for consistency
   - Spelling fix fith -> fifth
Changes in v3:
   - Fix compiler warning: explicitly define constant as unsigned int
   - Add changes in patch revisions
Changes in v2:
   - Address review feedback
   - Add kconfig entry
   - Use correct dir and file convention for KUnit
   - Fix typo
   - Remove unused static_stub header
   - Refactor test suite to use paramerterized test cases
   - Add close to max allowable value to in large_result test case
   - Add test case with non-power of two exponent
   - Fix module license
---

Looks good to me, thanks!

Reviewed-by: David Gow <david...@google.com>

Cheers,
-- David

thanks,
-- Shuah

Reply via email to