Re: [PATCH v1] selftests:tdx:Use min macro

[Shuah Khan]

On 8/21/24 22:46, Yan Zhen wrote:

Using the min macro is usually more intuitive and readable.

How did you find this problem?

Signed-off-by: Yan Zhen <yanz...@vivo.com>
---
  tools/testing/selftests/tdx/tdx_guest_test.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/tdx/tdx_guest_test.c 
b/tools/testing/selftests/tdx/tdx_guest_test.c
index 81d8cb88e..d7ddf5307 100644
--- a/tools/testing/selftests/tdx/tdx_guest_test.c
+++ b/tools/testing/selftests/tdx/tdx_guest_test.c
@@ -118,7 +118,7 @@ static void print_array_hex(const char *title, const char 
*prefix_str,
        printf("\t\t%s", title);

for (j = 0; j < len; j += rowsize) {

-               line_len = rowsize < (len - j) ? rowsize : (len - j);
+               line_len = min((len - j), rowsize);
                printf("%s%.8x:", prefix_str, j);
                for (i = 0; i < line_len; i++)
                        printf(" %.2x", ptr[j + i]);

Did you compile this patch and test it? I am seeing warnings during
build.

tdx_guest_test.c:121:28: warning: implicit declaration of function ‘min’ 
[-Wimplicit-function-declaration]
  121 |                 line_len = min((len - j), rowsize);
      |                            ^~~

thanks,
-- Shuah