Re: [RFC PATCH v5 18/29] KVM: selftests: TDX: Add TDX MMIO writes test

2024-03-01 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies MMIO writes of various sizes from the guest to the host. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji Patch 17 and 18 test the part that guest has received the #VE caused by MMIO access, so

Re: [PATCH v4 06/15] RISC-V: KVM: No need to update the counter value during reset

2024-03-01 Thread Andrew Jones
On Wed, Feb 28, 2024 at 05:01:21PM -0800, Atish Patra wrote: > The virtual counter value is updated during pmu_ctr_read. There is no need > to update it in reset case. Otherwise, it will be counted twice which is > incorrect. > > Fixes: 0cb74b65d2e5 ("RISC-V: KVM: Implement perf support without sa

Re: [RFC PATCH v5 16/29] KVM: selftests: TDX: Add TDX HLT exit test

2024-03-01 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies that the guest runs TDVMCALL and the guest vCPU enters to the halted state. Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/

RE: [PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-01 Thread Song, Yoong Siang
On Saturday, March 2, 2024 1:55 AM, John Fastabend wrote: >Song Yoong Siang wrote: >> This patch adds support to per-packet Tx hardware timestamp request to >> AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that >> user needs to enable Tx HW timestamp capability via igc_ioctl(

Re: [PATCH v4 13/15] KVM: riscv: selftests: Add SBI PMU selftest

2024-03-01 Thread Atish Kumar Patra
On Thu, Feb 29, 2024 at 8:47 PM Anup Patel wrote: > > On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > > > This test implements basic sanity test and cycle/instret event > > counting tests. > > > > Signed-off-by: Atish Patra > > I feel the test should have been called sbi_pmu_test but no n

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Guillaume Tucker
On 29/02/2024 17:28, Nicolas Dufresne wrote: > Hi, > > Le jeudi 29 février 2024 à 16:16 +0200, Nikolai Kondrashov a écrit : >> On 2/29/24 2:20 PM, Guillaume Tucker wrote: >>> Hello, >>> >>> On 28/02/2024 23:55, Helen Koike wrote: Dear Kernel Community, This patch introduces a `.gitl

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 15:02, Zi Yan wrote: > On 1 Mar 2024, at 14:37, Zi Yan wrote: > >> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cases

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Linus Torvalds
On Fri, 1 Mar 2024 at 02:27, Nikolai Kondrashov wrote: > > I agree, it's hard to imagine even a simple majority agreeing on how GitLab CI > should be done. Still, we would like to help people, who are interested in > this kind of thing, to set it up. How about we reframe this contribution as a > s

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 14:37, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via both >>>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:27, Mark Brown wrote: > On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > >> Although I agree it might be a tall order create and mount an XFS fs in >> run_vmtests.sh. Perhaps it might be good enough to add an optional param to >> the >> test to pass a path when

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH v4 04/15] RISC-V: Add SBI PMU snapshot definitions

2024-03-01 Thread Atish Kumar Patra
On Fri, Mar 1, 2024 at 3:14 AM Andrew Jones wrote: > > On Wed, Feb 28, 2024 at 05:01:19PM -0800, Atish Patra wrote: > > SBI PMU Snapshot function optimizes the number of traps to > > higher privilege mode by leveraging a shared memory between the S/VS-mode > > and the M/HS mode. Add the definition

Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path

2024-03-01 Thread Jakub Kicinski
environments. Indeed, it looks like it can be caused by that > > modification. I will send a fix ASAP! > > The following patch fixes the issue on my side (when using 'renice 20' > and stress-ng in parallel :) ): > > https://lore.kernel.org/netdev/20240301-upstream-n

Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path

2024-03-01 Thread Matthieu Baerts
idn't have this error on my side, even without '-d SLUB_DEBUG_ON' we > do on top of the debug kconfig, but I see I can reproduce it on slower > environments. Indeed, it looks like it can be caused by that > modification. I will send a fix ASAP! The following patch fixes the i

[PATCH net-next 15/15] selftests: mptcp: userspace pm get addr tests

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds a new helper userspace_pm_get_addr() in mptcp_join.sh. In it, parse the token value from the output of 'pm_nl_ctl events', then pass it to pm_nl_ctl get_addr command. Use this helper in userspace pm dump tests. Signed-off-by: Geliang Tang Reviewed-by: Matthieu

[PATCH net-next 14/15] selftests: mptcp: add token for get_addr

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang The command get_addr() of pm_nl_ctl can be used like this in in-kernel PM: pm_nl_ctl get $id This patch adds token argument for it to support userspace PM: pm_nl_ctl get $id token $token If 'token $token' is passed to get_addr(), copy it into the kernel netl

[PATCH net-next 13/15] mptcp: get addr in userspace pm list

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch renames mptcp_pm_nl_get_addr_doit() as a dedicated in-kernel netlink PM get addr function mptcp_pm_nl_get_addr(). and invoke a new wrapper mptcp_pm_get_addr() in mptcp_pm_nl_get_addr_doit. If a token is gotten in the wrapper, that means a userspace PM is used. So in

[PATCH net-next 12/15] mptcp: implement mptcp_userspace_pm_get_addr

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch implements mptcp_userspace_pm_get_addr() to get an address from userspace pm address list according the given 'token' and 'id'. Use nla_get_u32() to get the u32 value of 'token', then pass it to mptcp_token_get_sock() to get the msk. Pass 'msk' and 'id' to the helper

[PATCH net-next 11/15] mptcp: add userspace_pm_lookup_addr_by_id helper

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang Corresponding __lookup_addr_by_id() helper in the in-kernel netlink PM, this patch adds a new helper mptcp_userspace_pm_lookup_addr_by_id() to lookup the address entry with the given id on the userspace pm local address list. Signed-off-by: Geliang Tang Reviewed-by: Matthieu

[PATCH net-next 10/15] selftests: mptcp: dump userspace addrs list

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds a new helper userspace_pm_dump() to dump addresses for the userspace PM. Use this helper to check whether an ID 0 subflow is listed in the output of dump command after creating an ID 0 subflow in "userspace pm create id 0 subflow" test. Dump userspace PM address

[PATCH net-next 09/15] selftests: mptcp: add mptcp_lib_check_output helper

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang Extract the main part of check() in pm_netlink.sh into a new helper named mptcp_lib_check_output in mptcp_lib.sh. This helper will be used for userspace dump addresses tests. Co-developed-by: Matthieu Baerts (NGI0) Signed-off-by: Matthieu Baerts (NGI0) Signed-off-by: Gelian

[PATCH net-next 08/15] selftests: mptcp: add token for dump_addr

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang The command dump_addr() of pm_nl_ctl can be used like this in in-kernel PM: pm_nl_ctl dump This patch adds token argument for it to support userspace PM: pm_nl_ctl dump token $token If 'token $token' is passed to dump_addr(), copy it into the kernel netlink.

[PATCH net-next 02/15] mptcp: export mptcp_genl_family & mptcp_nl_fill_addr

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch exports struct mptcp_genl_family and mptcp_nl_fill_addr() helper to allow them can be used in pm_userspace.c. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- net/mptcp/pm_netli

[PATCH net-next 07/15] selftests: mptcp: add userspace pm subflow flag

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds the address flag MPTCP_PM_ADDR_FLAG_SUBFLOW in csf() in pm_nl_ctl.c when subflow is created by a userspace PM. Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts (NGI0) Reviewed-by: Mat Martineau Signed-off-by: Matthieu Baerts (NGI0) --- tools/testin

[PATCH net-next 06/15] mptcp: check userspace pm flags

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang Just like MPTCP_PM_ADDR_FLAG_SIGNAL flag is checked in userspace PM announce mptcp_pm_nl_announce_doit(), PM flags should be checked in mptcp_pm_nl_subflow_create_doit() too. If MPTCP_PM_ADDR_FLAG_SUBFLOW flag is not set, there's no flags field in the output of dump_addr. This

[PATCH net-next 05/15] mptcp: dump addrs in userspace pm list

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch renames mptcp_pm_nl_get_addr_dumpit() as a dedicated in-kernel netlink PM dump addrs function mptcp_pm_nl_dump_addr(), and invoke a newly added wrapper mptcp_pm_dump_addr() in mptcp_pm_nl_get_addr_dumpit(). Invoke in-kernel PM dump addrs function mptcp_pm_nl_dump_ad

[PATCH net-next 04/15] mptcp: add token for get-addr in yaml

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch adds token parameter together with addr in get-addr section in mptcp_pm.yaml, then use the following commands to update mptcp_pm_gen.c and mptcp_pm_gen.h: ./tools/net/ynl/ynl-gen-c.py --mode kernel \ --spec Documentation/netlink/specs/mptcp_pm.yaml --source

[PATCH net-next 03/15] mptcp: implement mptcp_userspace_pm_dump_addr

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang This patch implements mptcp_userspace_pm_dump_addr() to dump addresses from userspace pm address list. Use mptcp_token_get_sock() to get the msk from the given token, if userspace PM is enabled in it, traverse each address entry in address list, put every entry to userspace usi

[PATCH net-next 01/15] mptcp: make pm_remove_addrs_and_subflows static

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang mptcp_pm_remove_addrs_and_subflows() is only used in pm_netlink.c, it's no longer used in pm_userspace.c any more since the commit 8b1c94da1e48 ("mptcp: only send RM_ADDR in nl_cmd_remove"). So this patch changes it to a static function. Signed-off-by: Geliang Tang Reviewed-b

[PATCH net-next 00/15] mptcp: userspace pm: 'dump addrs' and 'get addr'

2024-03-01 Thread Matthieu Baerts (NGI0)
nged, 374 insertions(+), 50 deletions(-) --- base-commit: e960825709330cb199d209740326cec37e8c419d change-id: 20240301-upstream-net-next-20240301-mptcp-userspace-pm-dump-addr-221f169ac144 Best regards, -- Matthieu Baerts (NGI0)

Re: [PATCH iwl-next,v2 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval

2024-03-01 Thread Stanislav Fomichev
On 03/02, Song Yoong Siang wrote: > In current ping-pong design, xdp_hw_metadata will wait until the packet > transmition completely done, then only start to receive the next packet. > > The current sleep interval is 10ms, which is unnecessary large. Typically, > a NIC does not need such a long ti

RE: [PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-01 Thread John Fastabend
Song Yoong Siang wrote: > This patch adds support to per-packet Tx hardware timestamp request to > AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that > user needs to enable Tx HW timestamp capability via igc_ioctl() with > SIOCSHWTSTAMP cmd before sending xsk Tx hardware timest

RE: [PATCH iwl-next,v2 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval

2024-03-01 Thread John Fastabend
Song Yoong Siang wrote: > In current ping-pong design, xdp_hw_metadata will wait until the packet > transmition completely done, then only start to receive the next packet. > > The current sleep interval is 10ms, which is unnecessary large. Typically, > a NIC does not need such a long time to tran

[PATCH net 1/2] selftests: mptcp: diag: return KSFT_FAIL not test_cnt

2024-03-01 Thread Matthieu Baerts (NGI0)
From: Geliang Tang The test counter 'test_cnt' should not be returned in diag.sh, e.g. what if only the 4th test fail? Will do 'exit 4' which is 'exit ${KSFT_SKIP}', the whole test will be marked as skipped instead of 'failed'! So we should do ret=${KSFT_FAIL} instead. Fixes: df62f2ec3df6 ("sel

[PATCH net 2/2] selftests: mptcp: diag: avoid extra waiting

2024-03-01 Thread Matthieu Baerts (NGI0)
When creating a lot of listener sockets, it is enough to wait only for the last one, like we are doing before in diag.sh for other subtests. If we do a check for each listener sockets, each time listing all available sockets, it can take a very long time in very slow environments, at the point we

[PATCH net 0/2] selftests: mptcp: fixes for diag.sh

2024-03-01 Thread Matthieu Baerts (NGI0)
extra waiting tools/testing/selftests/net/mptcp/diag.sh | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) --- base-commit: 1c61728be22c1cb49c1be88693e72d8c06b1c81e change-id: 20240301-upstream-net-20240301-selftests-mptcp-diag-exit-timeout-207d7925b7c0 Best regards, -- Matthieu Baerts (NGI0)

Re: [PATCH 0/5] KVM RISC-V report few more ISA extensions through ONE_REG

2024-03-01 Thread Anup Patel
On Wed, Feb 14, 2024 at 6:08 PM Anup Patel wrote: > > This series extends the KVM RISC-V ONE_REG interface to report few more > ISA extensions namely: Ztso and Zacas. These extensions are already > supported by the HWPROBE interface in Linux-6.8 kernel. > > To test these patches, use KVMTOOL from

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

2024-03-01 Thread Miguel Ojeda
On Fri, Mar 1, 2024 at 4:22 PM Laura Nao wrote: > > Adding --first-time (you meant --first-time, right?) definitely makes > sense, thanks for the pointer. I think having the modules being built-in > should be treated as a skip, same as when they are not there at all. Yeah, I meant `--first-time`,

[PATCH iwl-next,v2 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-01 Thread Song Yoong Siang
This patch adds support to per-packet Tx hardware timestamp request to AF_XDP zero-copy packet via XDP Tx metadata framework. Please note that user needs to enable Tx HW timestamp capability via igc_ioctl() with SIOCSHWTSTAMP cmd before sending xsk Tx hardware timestamp request. Same as implementa

[PATCH iwl-next,v2 1/2] selftests/bpf: xdp_hw_metadata reduce sleep interval

2024-03-01 Thread Song Yoong Siang
In current ping-pong design, xdp_hw_metadata will wait until the packet transmition completely done, then only start to receive the next packet. The current sleep interval is 10ms, which is unnecessary large. Typically, a NIC does not need such a long time to transmit a packet. Furthermore, during

[PATCH iwl-next,v2 0/2] XDP Tx Hardware Timestamp for igc driver

2024-03-01 Thread Song Yoong Siang
Implemented XDP transmit hardware timestamp metadata for igc driver. This patchset is tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel ADL-S platform. Below are the test steps and results. Test Step 1: Run xdp_hw_metadata app sudo ./xdp_hw_metadata > /dev/shm/result.log Test St

Re: [PATCH v4 05/15] drivers/perf: riscv: Implement SBI PMU snapshot function

2024-03-01 Thread Alexandre Ghiti
On Fri, Mar 1, 2024 at 3:40 PM Andrew Jones wrote: > > On Wed, Feb 28, 2024 at 05:01:20PM -0800, Atish Patra wrote: > > SBI v2.0 SBI introduced PMU snapshot feature which adds the following > > features. > > > > 1. Read counter values directly from the shared memory instead of > > csr read. > > 2.

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

2024-03-01 Thread Laura Nao
Hi Miguel, On 2/29/24 17:44, Miguel Ojeda wrote: > On Thu, Feb 29, 2024 at 4:53 PM Laura Nao wrote: >> >> Add new basic kselftest that checks if the available rust sample modules >> can be added and removed correctly. >> >> Signed-off-by: Laura Nao >> Reviewed-by: Sergio Gonzalez Collado >> Rev

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:27, Mark Brown wrote: > On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > >> Although I agree it might be a tall order create and mount an XFS fs in >> run_vmtests.sh. Perhaps it might be good enough to add an optional param to >> the >> test to pass a path when

Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path

2024-03-01 Thread Matthieu Baerts
Hi Jakub, On 01/03/2024 15:37, Jakub Kicinski wrote: > On Fri, 23 Feb 2024 17:14:20 +0100 Matthieu Baerts (NGI0) wrote: >> From: Paolo Abeni >> >> The mptcp diag interface already experienced a few locking bugs >> that lockdep and appropriate coverage have detected in advance. >> >> Let's add a t

Re: [PATCH net-next 1/3] net: gro: set {inner_,}network_header in receive phase

2024-03-01 Thread Richard Gobert
Eric Dumazet wrote: > On Thu, Feb 29, 2024 at 2:22 PM Richard Gobert > wrote: >> >> >> >> Eric Dumazet wrote: >>> >>> My intuition is that this patch has a high cost for normal GRO processing. >>> SW-GRO is already a bottleneck on ARM cores in smart NICS. >>> >>> I would suggest instead using

Re: [PATCH v4 05/15] drivers/perf: riscv: Implement SBI PMU snapshot function

2024-03-01 Thread Andrew Jones
On Wed, Feb 28, 2024 at 05:01:20PM -0800, Atish Patra wrote: > SBI v2.0 SBI introduced PMU snapshot feature which adds the following > features. > > 1. Read counter values directly from the shared memory instead of > csr read. > 2. Start multiple counters with initial values with one SBI call. >

Re: [PATCH net 10/10] selftests: mptcp: explicitly trigger the listener diag code-path

2024-03-01 Thread Jakub Kicinski
On Fri, 23 Feb 2024 17:14:20 +0100 Matthieu Baerts (NGI0) wrote: > From: Paolo Abeni > > The mptcp diag interface already experienced a few locking bugs > that lockdep and appropriate coverage have detected in advance. > > Let's add a test-case triggering the relevant code path, to prevent > sim

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 9:23, Ryan Roberts wrote: > On 01/03/2024 14:00, Zi Yan wrote: >> On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: >> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cases f

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 02:18:16PM +, Ryan Roberts wrote: > Although I agree it might be a tall order create and mount an XFS fs in > run_vmtests.sh. Perhaps it might be good enough to add an optional param to > the > test to pass a path when running the test manually, and if that's not > pr

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 01:09:04PM +, Ryan Roberts wrote: > On 01/03/2024 12:52, Zi Yan wrote: > > I can do that. But is this a new requirement that self tests have to be > > finish > > in CI/CD environment? Can you provide a guideline for it? > I'm not sure what's written down, but certain

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 14:00, Zi Yan wrote: > On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via both >>> debu

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Nikolai Kondrashov
On 3/1/24 4:07 PM, Mark Brown wrote: On Fri, Mar 01, 2024 at 12:27:13PM +0200, Nikolai Kondrashov wrote: On 2/29/24 10:21 PM, Linus Torvalds wrote: I would suggest the CI project be separate from the kernel. It is possible to have a GitLab CI setup with the YAML files in a separate repositor

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 13:53, Zi Yan wrote: > On 1 Mar 2024, at 8:09, Ryan Roberts wrote: > >> On 01/03/2024 12:52, Zi Yan wrote: >>> On 1 Mar 2024, at 5:33, Ryan Roberts wrote: >>> On 01/03/2024 09:51, Aishwarya TCV wrote: > > > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 07:56:41AM -0500, Zi Yan wrote: > On 1 Mar 2024, at 7:11, Mark Brown wrote: > > Mounting on /mnt would also be a bit of an issue, that's something > > people are relatively likely to have used for something so could be > > disruptive. If the test is going to do a new mount

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 12:27:13PM +0200, Nikolai Kondrashov wrote: > On 2/29/24 10:21 PM, Linus Torvalds wrote: > > We already have the situation that the drm people have their own ci > > model. II'm ok with that, partly because then at least the maintainers > > of that subsystem can agree on the

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 4:51, Aishwarya TCV wrote: > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 8:09, Ryan Roberts wrote: > On 01/03/2024 12:52, Zi Yan wrote: >> On 1 Mar 2024, at 5:33, Ryan Roberts wrote: >> >>> On 01/03/2024 09:51, Aishwarya TCV wrote: On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_l

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 12:52, Zi Yan wrote: > On 1 Mar 2024, at 5:33, Ryan Roberts wrote: > >> On 01/03/2024 09:51, Aishwarya TCV wrote: >>> >>> >>> On 26/02/2024 20:55, Zi Yan wrote: From: Zi Yan It is used to test split_huge_page_to_list_to_order for pagecache THPs. Also add test cas

Re: [PATCH v2 0/3] RISC-V: mm: do not treat hint addr on mmap as the upper bound to search

2024-03-01 Thread Conor Dooley
On Fri, Mar 01, 2024 at 04:54:05AM +0800, Yangyu Chen wrote: > Another concern is that if we can't make this decision in time to catch up > with v6.9 we don't want some bad things to happen as a large number of sv48 > machines might appear this year and they may run on the next v6.9 LTS > kernel,

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 7:11, Mark Brown wrote: > On Fri, Mar 01, 2024 at 10:33:15AM +, Ryan Roberts wrote: > >> - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT >> ...); >> where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist, >> then the open wil

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Zi Yan
On 1 Mar 2024, at 5:33, Ryan Roberts wrote: > On 01/03/2024 09:51, Aishwarya TCV wrote: >> >> >> On 26/02/2024 20:55, Zi Yan wrote: >>> From: Zi Yan >>> >>> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >>> Also add test cases for split_huge_page_to_list_to_order via bot

Re: [RFC PATCH v5 09/29] KVM: selftests: TDX: Add report_fatal_error test

2024-03-01 Thread Yan Zhao
... > diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > b/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > index b570b6d978ff..6d69921136bd 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/tdx/test_util.h > +++ b/tools/testing/selftests/kvm/include/x86_

Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

2024-03-01 Thread Pedro Tammela
On 01/03/2024 09:24, Naresh Kamboju wrote: Hi Pedro, On Thu, 29 Feb 2024 at 20:08, Pedro Tammela wrote: Add the dependsOn test check for all the mirred blockcast tests. It will prevent the issue reported by LKFT which happens when an older iproute2 is used to run the current tdc. Thank you

Re: [RFC PATCH v5 23/29] KVM: selftests: TDX: Add shared memory test

2024-03-01 Thread Yan Zhao
> +void guest_shared_mem(void) > +{ > + uint32_t *test_mem_shared_gva = > + (uint32_t *)TDX_SHARED_MEM_TEST_SHARED_GVA; > + > + uint64_t placeholder; > + uint64_t ret; > + > + /* Map gpa as shared */ > + ret = tdg_vp_vmcall_map_gpa(test_mem_shared_gpa, PAGE_SIZE, > +

Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

2024-03-01 Thread Naresh Kamboju
Hi Pedro, On Thu, 29 Feb 2024 at 20:08, Pedro Tammela wrote: > > Add the dependsOn test check for all the mirred blockcast tests. > It will prevent the issue reported by LKFT which happens when an older > iproute2 is used to run the current tdc. Thank you for the fix patch. LKFT tests run on Deb

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Mark Brown
On Fri, Mar 01, 2024 at 10:33:15AM +, Ryan Roberts wrote: > - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...); > where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist, > then the open will fail I think? I'm pretty sure that's what's happeni

Re: [RFC PATCH v5 15/29] KVM: selftests: TDX: Add TDX MSR read/write tests

2024-03-01 Thread Binbin Wu
On 3/1/2024 8:00 PM, Binbin Wu wrote: On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies reads and writes for MSR registers with different access level. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji ---   .../selftests/kvm/include/x86_64/td

Re: kselftest/next kselftest-livepatch: 1 runs, 1 regressions (v6.8-rc1-56-g539cd3f4da3f)

2024-03-01 Thread Marcos Paulo de Souza
On Wed, 28 Feb 2024 15:28:14 -0700 Shuah Khan wrote: > On 2/28/24 00:21, kernelci.org bot wrote: > > kselftest/next kselftest-livepatch: 1 runs, 1 regressions > > (v6.8-rc1-56-g539cd3f4da3f) > > > > Regressions Summary > > --- > > > > platform| arch | lab | co

Re: [RFC PATCH v5 15/29] KVM: selftests: TDX: Add TDX MSR read/write tests

2024-03-01 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies reads and writes for MSR registers with different access level. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h| 5 + .../selftests/kvm/lib

Re: [PATCH v4 04/15] RISC-V: Add SBI PMU snapshot definitions

2024-03-01 Thread Andrew Jones
On Wed, Feb 28, 2024 at 05:01:19PM -0800, Atish Patra wrote: > SBI PMU Snapshot function optimizes the number of traps to > higher privilege mode by leveraging a shared memory between the S/VS-mode > and the M/HS mode. Add the definitions for that extension and new error > codes. > > Reviewed-by:

Re: [PATCH v4 12/12] selftests: ip_local_port_range: use XFAIL instead of SKIP

2024-03-01 Thread Jakub Sitnicki
On Thu, Feb 29, 2024 at 06:25 PM -05, Xin Long wrote: > On Thu, Feb 29, 2024 at 3:27 PM Jakub Sitnicki wrote: >> >> On Wed, Feb 28, 2024 at 04:59 PM -08, Jakub Kicinski wrote: >> > SCTP does not support IP_LOCAL_PORT_RANGE and we know it, >> > so use XFAIL instead of SKIP. >> > >> > Reviewed-by: K

Re: [PATCH v4 00/12] selftests: kselftest_harness: support using xfail

2024-03-01 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Wed, 28 Feb 2024 16:59:07 -0800 you wrote: > Hi! > > When running selftests for our subsystem in our CI we'd like all > tests to pass. Currently some tests use SKIP for cases they > expect to fail, because the k

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Ryan Roberts
On 01/03/2024 09:51, Aishwarya TCV wrote: > > > On 26/02/2024 20:55, Zi Yan wrote: >> From: Zi Yan >> >> It is used to test split_huge_page_to_list_to_order for pagecache THPs. >> Also add test cases for split_huge_page_to_list_to_order via both >> debugfs. >> >> Signed-off-by: Zi Yan >> --- >>

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-01 Thread Nikolai Kondrashov
Thanks for stopping by, Linus! On 2/29/24 10:21 PM, Linus Torvalds wrote: > On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: >> >> However, I think a better approach would be *not* to add the .gitlab-ci.yaml >> file in the root of the source tree, but instead change the very same repo >>

Re: [PATCH v4 03/15] drivers/perf: riscv: Read upper bits of a firmware counter

2024-03-01 Thread Andrew Jones
On Wed, Feb 28, 2024 at 05:01:18PM -0800, Atish Patra wrote: > SBI v2.0 introduced a explicit function to read the upper 32 bits > for any firmwar counter width that is longer than 32bits. firmware > This is only applicable for RV32 where firmware counter can be > 64 bit. > > Acked-by: Palmer Da

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-01 Thread Aishwarya TCV
On 26/02/2024 20:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_order for pagecache THPs. > Also add test cases for split_huge_page_to_list_to_order via both > debugfs. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 34

Re: [PATCH] selftests/mm: Dont fail testsuite due to a lack of hugepages

2024-03-01 Thread Muhammad Usama Anjum
On 3/1/24 12:33 PM, Nico Pache wrote: > On systems that have large core counts and large page sizes, but limited > memory, the userfaultfd test hugepage requirement is too large. > > Exiting early due to missing one test's requirements is a rather aggressive > strategy, and prevents a lot of other

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-03-01 Thread Muhammad Usama Anjum
On 2/29/24 10:36 PM, T.J. Mercier wrote: > On Thu, Feb 29, 2024 at 1:14 AM Muhammad Usama Anjum > wrote: >> >> On 2/28/24 11:47 PM, T.J. Mercier wrote: >>> On Wed, Feb 28, 2024 at 3:46 AM Muhammad Usama Anjum >>> wrote: On 2/27/24 10:18 PM, T.J. Mercier wrote: > On Tue, Feb 27, 2024

[PATCH v4 2/2] selftests: dmabuf-heap: add config file for the test

2024-03-01 Thread Muhammad Usama Anjum
The config fragment enlists all the config options needed for the test. This config is merged into the kernel's config on which this test is run. Reviewed-by: T.J. Mercier Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Add reviewed-by tag --- tools/testing/selftests/dmabuf-heaps/co

[PATCH v4 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-03-01 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- Chanages since v3: - abort test-case instead of exiting if heap/mem allocation fails - Correct test_alloc_zeroed() test

Re: [PATCH v3 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-03-01 Thread Muhammad Usama Anjum
On 2/29/24 10:37 PM, T.J. Mercier wrote: > On Thu, Feb 29, 2024 at 1:21 AM Muhammad Usama Anjum > wrote: >> >> Conform the layout, informational and status messages to TAP. No >> functional change is intended other than the layout of output messages. >> >> Signed-off-by: Muhammad Usama Anjum >> -

Re: [PATCH v4 02/15] RISC-V: Add FIRMWARE_READ_HI definition

2024-03-01 Thread Clément Léger
On 29/02/2024 02:01, Atish Patra wrote: > SBI v2.0 added another function to SBI PMU extension to read > the upper bits of a counter with width larger than XLEN. > > Add the definition for that function. > > Acked-by: Conor Dooley > Reviewed-by: Anup Patel > Signed-off-by: Atish Patra > ---

Re: [PATCH v4 01/15] RISC-V: Fix the typo in Scountovf CSR name

2024-03-01 Thread Clément Léger
On 29/02/2024 02:01, Atish Patra wrote: > The counter overflow CSR name is "scountovf" not "sscountovf". > > Fix the csr name. > > Fixes: 4905ec2fb7e6 ("RISC-V: Add sscofpmf extension support") > Reviewed-by: Conor Dooley > Reviewed-by: Anup Patel > Signed-off-by: Atish Patra > --- > arch/

Re: [RFC PATCH v5 14/29] KVM: selftests: TDX: Add TDX IO reads test

2024-03-01 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies IO reads of various sizes from the host to the guest. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/x86_64/tdx_vm_tests.c | 87 +++ 1 file changed

Re: [RFC PATCH v5 08/29] KVM: selftests: TDX: Add TDX lifecycle test

2024-03-01 Thread Yan Zhao
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c > b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c > index 063ff486fb86..b302060049d5 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx_util.c > @@