'sleeping function called from invalid context' bug when mounting an IDE device

2005-07-08 Thread Vitaly Wool
Hi Ingo, I've come across the following problem during the debugging of IDE driver for Philips PNX0105 ARM9 platform in RT mode (CONFIG_PREEMPT_RT). When I mount/unmount a device, the following error is printed out to a terminal: > # mount /dev/discs/disc0/part1 /mnt/ > BUG: sleeping function ca

Re: 8250 serial driver and PM

2005-08-31 Thread Vitaly Wool
Hi Grigory, it's unclear from your letter where you take pnx4008_uart_pm from. Can you please elaborate? What I would think of if I were you is adding a field 'pm' to struct plat_serial8250_port which is filled in in the architecture-specific part and setting up->pm accrodingly. I'll send a

[PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
tions(+), 7 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6.10/drivers/serial/8250.c === --- linux-2.6.10.orig/drivers/serial/8250.c +++ linux-2.6.10/drivers/serial/8250.c @@ -236

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
Sorry for format. Attached is the better one :) Vitaly Wool wrote: Greetings, please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 serial driver. Please note that the interface to the outer world (i. e. exported functions

Re: [PATCH] custom PM support for 8250

2005-08-31 Thread Vitaly Wool
th the changes you suggest and work it out to the new patch. ;) Best regards, Vitaly Russell King wrote: On Wed, Aug 31, 2005 at 03:10:09PM +0400, Vitaly Wool wrote: please find the patch that allows passing the pointer to custom power management routine (via platform_device) to 8250 ser

[PATCH] custom PM support for 8250 serial (updated)

2005-08-31 Thread Vitaly Wool
iver to provide such facility. drivers/serial/8250.c | 77 include/linux/serial_8250.h |6 +++ 2 files changed, 69 insertions(+), 14 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6.13/

Re: [PATCH] custom PM support for 8250

2005-09-05 Thread Vitaly Wool
e the first patch I've sent for 8250 in place first? I'll continue to work on 8250 PM/platform_serial_data changes then. Vitaly Grigory Tolstolytkin wrote: Hi Russel, I tried the patch provided by Vitaly Wool. And it works correctly. And now I'm successful with the PM support f

[PATCH -mm] pnx8xxx-uart: irq and ktermios fixes

2006-12-21 Thread Vitaly Wool
Hello Andrew, this patch adds irq 2.6.19 changes and 2.6.20 ktermios changes to pnx8xxx-uart.c (which was added to -mm tree with pnx8550-uart-driver.patch). drivers/serial/pnx8xxx_uart.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Signed-off-by: Vitaly Wool <[EM

[PATCH] 8250: make probing for TXEN bug a config option

2006-12-26 Thread Vitaly Wool
files changed, 14 insertions(+), 1 deletion(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 51f3c73..cf3eb31 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -1645,6 +1645,7 @@ static int serial8250_st

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-02-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Wed, 14 Feb 2007 11:37:52 +0300 "Vitaly Wool" <[EMAIL PROTECTED]> wrote: > Hmm, why? I can't think of a platform where one 8250-compatible UART is > problematic and another isn't :) > Is it not pos

[PATCH][resend] fix PNX8550 serial breakage

2006-12-07 Thread Vitaly Wool
+ 3 files changed, 82 insertions(+), 82 deletions(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> Index: linux-2.6/include/linux/serial_ip3106.h === --- linux-2.6.orig/include/linux/serial_ip

[PATCH][resend] PNX8550 UART driver

2006-12-08 Thread Vitaly Wool
x27;t been accepted yet due to merge window miss at that moment. drivers/serial/Kconfig| 16 drivers/serial/Makefile |1 drivers/serial/pnx8xxx_uart.c | 853 ++ 3 files changed, 870 insertions(+) Signed-off-by: Vitaly Wool &l

[PATCH] smc911x: fix netpoll compilation faliure

2006-12-15 Thread Vitaly Wool
Hello folks, the trivial patch below fixes the compilation failure for smc911x.c when NET_POLL_CONTROLLER is set. drivers/net/smc911x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Signed-off-by: Vitaly Wool <[EMAIL PROTECTED]> diff --git a/drivers/net/smc911x.c b/drive

Re: [PATCH] fix "prev->state: 2 != TASK_RUNNING??" problem on SD/MMC card removal

2006-11-27 Thread Vitaly Wool
On 11/26/06, Pierre Ossman <[EMAIL PROTECTED]> wrote: Hmm... I can't find any such requirement in HEAD, or 2.6.18. What kernel are you running? 2.6.18 + -rt patches by Ingo. Vitaly - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROT

Re: [PATCH] 8250: make probing for TXEN bug a config option

2007-03-14 Thread Vitaly Wool
On 2/14/07, Andrew Morton <[EMAIL PROTECTED]> wrote: I think this should be a module option/boot parameter, not a config-time option. NM, the recent changes in 8250 driver eliminated the need for this patch :) Vitaly - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH/RFC] mm: do not regard CMA pages as free on watermark check

2015-09-09 Thread Vitaly Wool
patch also adds some primitive testing for the method implemented which has proven that it works as it should. Signed-off-by: Vitaly Wool --- include/linux/mmzone.h | 1 + mm/page_alloc.c| 56 +- mm/page_isolation.c| 2 +- 3 files ch

[PATCH] binder: use lockless list for deferred_work

2018-01-08 Thread Vitaly Wool
Binder uses hlist for deferred list, which isn't a good match. It's slow and requires mutual exclusion mechanism to protect its operations. Moreover, having schedule_work() called under a mutex may cause significant delays and creates noticeable adverse effect on Binder performance. Deferred list

Re: Crashes/hung tasks with z3pool under memory pressure

2018-04-12 Thread Vitaly Wool
Hi Guenter, Den fre 13 apr. 2018 kl 00:01 skrev Guenter Roeck : > Hi all, > we are observing crashes with z3pool under memory pressure. The kernel version > used to reproduce the problem is v4.16-11827-g5d1365940a68, but the problem was > also seen with v4.14 based kernels. just before I dig

Re: [PATCH] z3fold: fix wrong handling of headless pages

2018-11-05 Thread Vitaly Wool
Hi Jongseok, Den fre 6 juli 2018 kl 07:11 skrev Jongseok Kim : > > During the processing of headless pages in z3fold_reclaim_page(), > there was a problem that the zhdr pointed to another page > or a page was already released in z3fold_free(). So, the wrong page > is encoded in headless, or test_b

Re: [PATCH] z3fold: fix wrong handling of headless pages

2018-11-08 Thread Vitaly Wool
r patch) the right way? I could apply the new patch on top of yours but that would effectively revert most of your changes. Would it be ok for you if I add you to Signed-off-by for the new patch instead? ~Vitaly > I'm sorry I sent reply twice. > > Best regards, > Jongseok > &

[PATCH] z3fold: fix possible reclaim races

2018-11-05 Thread Vitaly Wool
unction. This patch supersedes "[PATCH] z3fold: fix reclaim lock-ups". Signed-off-by: Vitaly Wool Reviewed-by: Snild Dolkow --- mm/z3fold.c | 101 1 file changed, 62 insertions(+), 39 deletions(-) diff --git a/mm/z3fold.c b/

[PATCH] z3fold: encode object length in the handle

2018-10-25 Thread Vitaly Wool
object we couldn't correctly map before. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 48 +++- 1 file changed, 35 insertions(+), 13 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 4b366d181f35..86359b565d45 100644 --- a/mm/z3fold.c ++

Re: [RFC PATCH] z3fold: prevent reclaim/free race for headless pages

2021-02-16 Thread Vitaly Wool
Hi Thomas, On Tue, Feb 16, 2021 at 9:44 AM Thomas Hebb wrote: > > commit ca0246bb97c2 ("z3fold: fix possible reclaim races") introduced > the PAGE_CLAIMED flag "to avoid racing on a z3fold 'headless' page > release." By atomically testing and setting the bit in each of > z3fold_free() and z3fold_

[PATCH] z3fold: fix reclaim lock-ups

2018-04-30 Thread Vitaly Wool
Do not try to optimize in-page object layout while the page is under reclaim. This fixes lock-ups on reclaim and improves reclaim performance at the same time. Reported-by: Guenter Roeck Signed-off-by: Vitaly Wool --- mm/z3fold.c | 42 ++ 1 file changed

Re: [PATCH 0/4] z3fold: support page migration

2019-04-17 Thread Vitaly Wool
Den ons 17 apr. 2019 kl 01:18 skrev Andrew Morton : > > On Thu, 11 Apr 2019 17:32:12 +0200 Vitaly Wool wrote: > > > This patchset implements page migration support and slightly better > > buddy search. To implement page migration support, z3fold has to move > > away

[PATCHv2 0/4] z3fold: support page migration

2019-04-17 Thread Vitaly Wool
emory consumption) is included in this patchset. Vitaly Wool (4): z3fold: introduce helper functions z3fold: improve compression by extending search z3fold: add structure for buddy handles z3fold: support page migration mm/z3fold.c |

[PATCHV2 1/4] z3fold: introduce helper functions

2019-04-17 Thread Vitaly Wool
This patch introduces a separate helper function for object allocation, as well as 2 smaller helpers to add a buddy to the list and to get a pointer to the pool from the z3fold header. No functional changes here. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 184

[PATCHv2 3/4] z3fold: add structure for buddy handles

2019-04-17 Thread Vitaly Wool
page is moved. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 185 1 file changed, 145 insertions(+), 40 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 29a4f1249bef..bebc10083f1c 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -34,6 +34,29

[PATCHv2 2/4] z3fold: improve compression by extending search

2019-04-17 Thread Vitaly Wool
bject. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 36 1 file changed, 36 insertions(+) diff --git a/mm/z3fold.c b/mm/z3fold.c index 7a59875d880c..29a4f1249bef 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -522,6 +522,42 @@ static inline struct z3fold_h

[PATCHv2 4/4] z3fold: support page migration

2019-04-17 Thread Vitaly Wool
back the page if z3fold_page_migrate() for it failed permanently (i. e. not with -EAGAIN code). Signed-off-by: Vitaly Wool --- mm/z3fold.c | 241 +--- 1 file changed, 231 insertions(+), 10 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c

[PATCH 0/4] z3fold: support page migration

2019-04-11 Thread Vitaly Wool
eases memory consumption) is included in this patchset. Vitaly Wool (4):   z3fold: introduce helper functions   z3fold: improve compression by extending search   z3fold: add structure for buddy handles   z3fold: support page migration  mm/z3fold.c |

[PATCH 1/4] z3fold: introduce helper functions

2019-04-11 Thread Vitaly Wool
This patch introduces a separate helper function for object allocation, as well as 2 smaller helpers to add a buddy to the list and to get a pointer to the pool from the z3fold header. No functional changes here. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 184

[PATCH 2/4] z3fold: improve compression by extending search

2019-04-11 Thread Vitaly Wool
that object. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 36 1 file changed, 36 insertions(+) diff --git a/mm/z3fold.c b/mm/z3fold.c index 7a59875d880c..29a4f1249bef 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -522,6 +522,42 @@ static inline struct z3fold_h

[PATCH 3/4] z3fold: add structure for buddy handles

2019-04-11 Thread Vitaly Wool
page is moved. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 185 1 file changed, 145 insertions(+), 40 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 29a4f1249bef..bebc10083f1c 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -34,6

[PATCH 4/4] z3fold: support page migration

2019-04-11 Thread Vitaly Wool
back the page if z3fold_page_migrate() for it failed permanently (i. e. not with -EAGAIN code). Signed-off-by: Vitaly Wool --- mm/z3fold.c | 241 +--- 1 file changed, 231 insertions(+), 10 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c

Re: zswap z3fold + memory offline = infinite loop

2020-05-20 Thread Vitaly Wool
On Tue, May 19, 2020 at 5:50 AM Qian Cai wrote: > > > > > Removing that check in ->isolate() is not a big deal, but ->migratepage() > > shall not allow actual migration anyway if there are mapped objects. > > Is that worse than an endless loop here? Well, let's figure if there really has to be

[PATCH] RISC-V: simplify BUILTIN_DTB processing

2021-01-11 Thread Vitaly Wool
Provide __dtb_start as a parameter to setup_vm() in case CONFIG_BUILTIN_DTB is true, so we don't have to duplicate BUILTIN_DTB specific processing in MMU-enabled and MMU-disabled versions of setup_vm(). Signed-off-by: Vitaly Wool --- arch/riscv/kernel/head.S | 4 arch/riscv/mm/i

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-21 Thread Vitaly Wool
On Mon, Dec 21, 2020 at 6:24 PM Minchan Kim wrote: > > On Sun, Dec 20, 2020 at 02:22:28AM +0200, Vitaly Wool wrote: > > zsmalloc takes bit spinlock in its _map() callback and releases it > > only in unmap() which is unsafe and leads to zswap complaining > > about sche

[PATCH v3] RISC-V: enable XIP

2020-12-21 Thread Vitaly Wool
-xip.lds.S - changed long -> uintptr_t typecast in __XIP_FIXUP macro. Changed in v3: - rebased against latest for-next - XIP address fixup macro now takes an argument - SMP related fixes Signed-off-by: Vitaly Wool --- arch/riscv/Kconfig | 46 - arch/riscv/Makef

[PATCH] arch/Kconfig: JUMP_LABEL should depend on !XIP

2020-12-21 Thread Vitaly Wool
option is set. Signed-off-by: Vitaly Wool --- arch/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/Kconfig b/arch/Kconfig index 56b6ccc0e32d..88632c9588ae 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -81,6 +81,7 @@ config JUMP_LABEL bool "Optimize very unlikely/

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-21 Thread Vitaly Wool
On Mon, Dec 21, 2020 at 10:30 PM Song Bao Hua (Barry Song) wrote: > > > > > -Original Message- > > From: Shakeel Butt [mailto:shake...@google.com] > > Sent: Tuesday, December 22, 2020 10:03 AM > > To: Song Bao Hua (Barry Song) > > Cc: Vitaly Wool

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-21 Thread Vitaly Wool
On Tue, Dec 22, 2020 at 12:37 AM Song Bao Hua (Barry Song) wrote: > > > > > -Original Message- > > From: Song Bao Hua (Barry Song) > > Sent: Tuesday, December 22, 2020 11:38 AM > > To: 'Vitaly Wool' > > Cc: Shakeel Butt ; Mincha

Re: [PATCH v3] RISC-V: enable XIP

2020-12-21 Thread Vitaly Wool
On Tue, Dec 22, 2020 at 2:44 AM Bin Meng wrote: > > Hi Vitaly, > > On Tue, Dec 22, 2020 at 4:39 AM Vitaly Wool wrote: > > > > Introduce XIP (eXecute In Place) support for RISC-V platforms. > > It allows code to be executed directly from non-volatile storage >

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-22 Thread Vitaly Wool
On Tue, 22 Dec 2020, 03:11 Song Bao Hua (Barry Song), wrote: > > > > > -Original Message- > > From: Song Bao Hua (Barry Song) > > Sent: Tuesday, December 22, 2020 3:03 PM > > To: 'Vitaly Wool' > > Cc: Shakeel Butt ; Minchan Kim ; > &g

Re: [PATCH v3] RISC-V: enable XIP

2020-12-22 Thread Vitaly Wool
Hi Anup, On Tue, Dec 22, 2020 at 6:16 AM Anup Patel wrote: > > On Tue, Dec 22, 2020 at 2:08 AM Vitaly Wool wrote: > > > > Introduce XIP (eXecute In Place) support for RISC-V platforms. > > It allows code to be executed directly from non-volatile storage > > directl

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-22 Thread Vitaly Wool
On Tue, 22 Dec 2020, 22:06 Song Bao Hua (Barry Song), wrote: > > > > > -Original Message- > > From: Vitaly Wool [mailto:vitaly.w...@konsulko.com] > > Sent: Tuesday, December 22, 2020 10:44 PM > > To: Song Bao Hua (Barry Song) > > Cc: Shakeel Butt

Re: scheduling while atomic in z3fold

2020-12-07 Thread Vitaly Wool
On Mon, Dec 7, 2020 at 3:18 AM Mike Galbraith wrote: > > On Mon, 2020-12-07 at 02:05 +0100, Vitaly Wool wrote: > > > > Could you please try the following patch in your setup: > > crash> gdb list *z3fold_zpool_free+0x527 > 0xc0e14487 is in z3fold_zpool

Re: scheduling while atomic in z3fold

2020-12-07 Thread Vitaly Wool
On Mon, Dec 7, 2020 at 1:34 PM Mike Galbraith wrote: > > On Mon, 2020-12-07 at 12:52 +0100, Vitaly Wool wrote: > > > > Thanks. This trace beats me because I don't quite get how this could > > have happened. > > I swear there's a mythical creature loose i

Re: scheduling while atomic in z3fold

2020-12-08 Thread Vitaly Wool
Hi Mike, On 2020-12-07 16:41, Mike Galbraith wrote: On Mon, 2020-12-07 at 16:21 +0100, Vitaly Wool wrote: On Mon, Dec 7, 2020 at 1:34 PM Mike Galbraith wrote: Unfortunately, that made zero difference. Okay, I suggest that you submit the patch that changes read_lock() to write_lock() in

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2021-01-14 Thread Vitaly Wool
On Thu, 14 Jan 2021, 17:18 Sebastian Andrzej Siewior, wrote: > > On 2020-12-23 19:25:02 [+0100], Vitaly Wool wrote: > > > write the following patch according to your idea, what do you think ? > > > > Yep, that is basically what I was thinking of. Some nitpicks below

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2021-01-14 Thread Vitaly Wool
On Thu, Jan 14, 2021 at 5:56 PM Sebastian Andrzej Siewior wrote: > > On 2021-01-14 17:29:37 [+0100], Vitaly Wool wrote: > > On Thu, 14 Jan 2021, 17:18 Sebastian Andrzej Siewior, > > wrote: > > > > > > On 2020-12-23 19:25:02 [+0100], Vitaly Wool wrote:

Re: [PATCH] riscv: add BUILTIN_DTB support for MMU-enabled targets

2020-12-28 Thread Vitaly Wool
On Mon, Dec 28, 2020 at 12:59 PM Anup Patel wrote: > > On Sat, Dec 26, 2020 at 10:03 PM Vitaly Wool wrote: > > > > Sometimes, especially in a production system we may not want to > > use a "smart bootloader" like u-boot to load kernel, ramdisk and > > de

Re: [PATCH] riscv: add BUILTIN_DTB support for MMU-enabled targets

2020-12-28 Thread Vitaly Wool
On Mon, Dec 28, 2020 at 3:10 PM Anup Patel wrote: > > On Mon, Dec 28, 2020 at 7:05 PM Vitaly Wool wrote: > > > > On Mon, Dec 28, 2020 at 12:59 PM Anup Patel wrote: > > > > > > On Sat, Dec 26, 2020 at 10:03 PM Vitaly Wool > > > wrote: > >

Re: [PATCH] riscv: add BUILTIN_DTB support for MMU-enabled targets

2020-12-31 Thread Vitaly Wool
On Tue, Dec 29, 2020 at 6:05 AM Anup Patel wrote: > > On Mon, Dec 28, 2020 at 10:08 PM Vitaly Wool wrote: > > > > On Mon, Dec 28, 2020 at 3:10 PM Anup Patel wrote: > > > > > > On Mon, Dec 28, 2020 at 7:05 PM Vitaly Wool > > > wrote: > > >

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-23 Thread Vitaly Wool
On Wed, Dec 23, 2020 at 1:44 PM tiantao (H) wrote: > > > 在 2020/12/23 8:11, Vitaly Wool 写道: > > On Tue, 22 Dec 2020, 22:06 Song Bao Hua (Barry Song), > > wrote: > >> > >> > >>> -Original Message- > >>> From: Vitaly Wool [ma

[PATCH] riscv: add BUILTIN_DTB support for MMU-enabled targets

2020-12-26 Thread Vitaly Wool
nt to have device tree compiled into the kernel binary. Since this case is not limited to MMU-less systems, let's support it for these which have MMU enabled too. Signed-off-by: Vitaly Wool --- arch/riscv/Kconfig | 1 - arch/riscv/mm/init.c | 12 ++-- 2 files changed, 10 insertions(

Re: [PATCH v6] RISC-V: enable XIP

2021-03-31 Thread Vitaly Wool
erence to > `__init_text_begin' > riscv64-linux-ld: init.c:(.text+0x2a0): undefined reference to > `__init_data_begin' all the RO sections should fit in 8 MB for xipImage. Could you please remove the unnecessary parts from your kernel and retry? Thanks, Vitaly > On 2021/3/

Re: [PATCH v5] RISC-V: enable XIP

2021-03-21 Thread Vitaly Wool
Hey Alex, On Sun, Mar 21, 2021 at 4:11 PM Alex Ghiti wrote: > > Hi Vitaly, > > Le 3/10/21 à 4:22 AM, Vitaly Wool a écrit : > > Introduce XIP (eXecute In Place) support for RISC-V platforms. > > It allows code to be executed directly from non-volatile storage > > d

[PATCH v6] RISC-V: enable XIP

2021-03-21 Thread Vitaly Wool
for the time being only work on MMU-enabled kernels. Signed-off-by: Vitaly Wool --- Changes in v2: - dedicated macro for XIP address fixup when MMU is not enabled yet o both for 32-bit and 64-bit RISC-V - SP is explicitly set to a safe place in RAM before __copy_data call - removed redundant

Re: [PATCH v5] RISC-V: enable XIP

2021-03-22 Thread Vitaly Wool
On Mon, Mar 22, 2021 at 7:55 AM Alex Ghiti wrote: > > Le 3/21/21 à 2:06 PM, Vitaly Wool a écrit : > > Hey Alex, > > > > On Sun, Mar 21, 2021 at 4:11 PM Alex Ghiti wrote: > >> > >> Hi Vitaly, > >> > >> Le 3/10/21 à 4:22 AM, Vitaly Wool

Re: [PATCH v6] RISC-V: enable XIP

2021-03-29 Thread Vitaly Wool
space on the non-volatile storage. The physical flash address used > > to link the kernel object files and for storing it has to be known > > at compile time and is represented by a Kconfig option. > > > > XIP on RISC-V will for the time being only work on MMU-enabled > &g

[PATCH] riscv: XIP: fix build for rv32

2021-03-27 Thread Vitaly Wool
32-bit RISC-V uses folded page tables by default, so we should follow that in the XIP-specific part of init too. Signed-off-by: Vitaly Wool Reported-by: kernel test robot --- arch/riscv/mm/init.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/riscv/mm

Re: [PATCH v4 3/5] RISC-V: Initial DTS for Microchip ICICLE board

2021-03-28 Thread Vitaly Wool
On Sat, Mar 27, 2021 at 6:24 PM Alex Ghiti wrote: > > Hi Atish, > > Le 3/3/21 à 3:02 PM, Atish Patra a écrit : > > Add initial DTS for Microchip ICICLE board having only > > essential devices (clocks, sdhci, ethernet, serial, etc). > > The device tree is based on the U-Boot patch. > > > > https://

Re: [PATCH v7] RISC-V: enable XIP

2021-04-12 Thread Vitaly Wool
On Mon, Apr 12, 2021 at 7:12 AM Alex Ghiti wrote: > > Le 4/9/21 à 10:42 AM, Vitaly Wool a écrit : > > On Fri, Apr 9, 2021 at 3:59 PM Mike Rapoport wrote: > >> > >> On Fri, Apr 09, 2021 at 02:46:17PM +0200, David Hildenbrand wrote: > >>>>>>

Re: [PATCH v6] RISC-V: enable XIP

2021-04-06 Thread Vitaly Wool
On Tue, Apr 6, 2021 at 8:47 AM Alex Ghiti wrote: > > Hi Vitaly, > > Le 4/5/21 à 4:34 AM, Vitaly Wool a écrit : > > On Sun, Apr 4, 2021 at 10:39 AM Vitaly Wool > > wrote: > >> > >> On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: > >>>

Re: [PATCH v6] RISC-V: enable XIP

2021-04-07 Thread Vitaly Wool
Hi Alex, > > All in all, I am quite sure now that your take on XIP is working fine. > > The issue with single-core boot under QEmu seems to be less > > reproducible on slower machines running QEmu and more reproducible on > > higher performance ones. It's not clear to me if that is a QEmu > > pr

Re: [PATCH v6] RISC-V: enable XIP

2021-04-01 Thread Vitaly Wool
Hi Alex, On Thu, Apr 1, 2021 at 10:11 AM Alex Ghiti wrote: > > Hi, > > Le 3/30/21 à 4:04 PM, Alex Ghiti a écrit : > > Le 3/30/21 à 3:33 PM, Palmer Dabbelt a écrit : > >> On Tue, 30 Mar 2021 11:39:10 PDT (-0700), a...@ghiti.fr wrote: > >>> > >>&

Re: [PATCH v4 3/5] RISC-V: Initial DTS for Microchip ICICLE board

2021-04-18 Thread Vitaly Wool
Hi Atish, On Sun, Apr 18, 2021 at 5:37 AM Atish Patra wrote: > > On Mon, Mar 29, 2021 at 10:04 AM Vitaly Wool wrote: > > > > On Sat, Mar 27, 2021 at 6:24 PM Alex Ghiti wrote: > > > > > > Hi Atish, > > > > > > Le 3/3/21 à 3:02 PM, Atish

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread Vitaly Wool
On Fri, Apr 9, 2021 at 3:59 PM Mike Rapoport wrote: > > On Fri, Apr 09, 2021 at 02:46:17PM +0200, David Hildenbrand wrote: > > > > > Also, will that memory properly be exposed in the resource tree as > > > > > System RAM (e.g., /proc/iomem) ? Otherwise some things (/proc/kcore) > > > > > won't wor

Re: [PATCH v6] RISC-V: enable XIP

2021-04-04 Thread Vitaly Wool
On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: > > Hi Vitaly, > > Le 4/1/21 à 7:10 AM, Alex Ghiti a écrit : > > Le 4/1/21 à 4:52 AM, Vitaly Wool a écrit : > >> Hi Alex, > >> > >> On Thu, Apr 1, 2021 at 10:11 AM Alex Ghiti wrote: > >>>

Re: [PATCH v6] RISC-V: enable XIP

2021-04-05 Thread Vitaly Wool
On Sun, Apr 4, 2021 at 10:39 AM Vitaly Wool wrote: > > On Sat, Apr 3, 2021 at 12:00 PM Alex Ghiti wrote: > > > > Hi Vitaly, > > > > Le 4/1/21 à 7:10 AM, Alex Ghiti a écrit : > > > Le 4/1/21 à 4:52 AM, Vitaly Wool a écrit : > > >> Hi Alex, >

[PATCH] riscv: toggle mmu_enabled flag in a precise manner

2020-12-01 Thread vitaly . wool
From: Vitaly Wool Cuurently mmu_enabled flag is set to true way later than the actual MMU enablement takes place. This leads to hard-to-track races in e. g. SBI earlycon initialization taking wrong path configuring fixmap. To fix that, move mmu_enabled toggling to head.S and rename it to

Re: [patch] zswap: fix zswap_frontswap_load() vs zsmalloc::map/unmap() might_sleep() splat

2020-12-19 Thread Vitaly Wool
Hi Mike, On Sat, Dec 19, 2020 at 11:12 AM Mike Galbraith wrote: > > (mailer partially munged formatting? resend) > > mm/zswap: fix zswap_frontswap_load() vs zsmalloc::map/unmap() might_sleep() > splat > > zsmalloc map/unmap methods use preemption disabling bit spinlocks. Take the > mutex outsid

Re: [patch] zswap: fix zswap_frontswap_load() vs zsmalloc::map/unmap() might_sleep() splat

2020-12-19 Thread Vitaly Wool
On Sat, 19 Dec 2020, 11:27 Mike Galbraith, wrote: > > On Sat, 2020-12-19 at 11:20 +0100, Vitaly Wool wrote: > > Hi Mike, > > > > On Sat, Dec 19, 2020 at 11:12 AM Mike Galbraith wrote: > > > > > > (mailer partially munged formatting? resend) > >

[PATCH] zsmalloc: do not use bit_spin_lock

2020-12-19 Thread Vitaly Wool
-by: Vitaly Wool --- mm/zsmalloc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 7289f502ffac..ff26546a7fed 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -876,22 +876,25 @@ static unsigned long obj_to_head(struct page *page

Re: [PATCH] zsmalloc: do not use bit_spin_lock

2020-12-19 Thread Vitaly Wool
On Sun, Dec 20, 2020 at 2:18 AM Matthew Wilcox wrote: > > On Sun, Dec 20, 2020 at 02:22:28AM +0200, Vitaly Wool wrote: > > zsmalloc takes bit spinlock in its _map() callback and releases it > > only in unmap() which is unsafe and leads to zswap complaining > > about sche

Re: [PATCH] riscv: toggle mmu_enabled flag in a precise manner

2020-12-01 Thread Vitaly Wool
On Tue, Dec 1, 2020 at 6:40 PM Atish Patra wrote: > > On Tue, Dec 1, 2020 at 1:01 AM wrote: > > > > From: Vitaly Wool > > > > Cuurently mmu_enabled flag is set to true way later than the actual > > MMU enablement takes place. This leads to hard-to-t

[PATCH] arch/riscv: enable XIP

2020-12-02 Thread Vitaly Wool
will currently only work on MMU-enabled kernels. Signed-off-by: Vitaly Wool --- arch/riscv/Kconfig | 40 +++- arch/riscv/Makefile | 8 +- arch/riscv/boot/Makefile| 14 ++- arch/riscv/include/asm/pgtable.h| 53 +-- arch/riscv/kernel

Re: [PATCH] arch/riscv: enable XIP

2020-12-02 Thread Vitaly Wool
On Wed, Dec 2, 2020 at 7:06 PM Nicolas Pitre wrote: > > On Wed, 2 Dec 2020, Vitaly Wool wrote: > > > Introduce XIP (eXecute In Place) support for RISC-V platforms. > > It allows code to be executed directly from non-volatile storage > > directly addressable by the

[PATCH v2] RISC-V: enable XIP

2020-12-03 Thread Vitaly Wool
-xip.lds.S - changed long -> uintptr_t typecast in __XIP_FIXUP macro. Signed-off-by: Vitaly Wool --- arch/riscv/Kconfig | 40 - arch/riscv/Makefile | 8 +- arch/riscv/boot/Makefile| 14 ++- arch/riscv/include/asm/pgtable.h|

Re: scheduling while atomic in z3fold

2020-12-03 Thread Vitaly Wool
On Thu, Dec 3, 2020 at 2:39 PM Sebastian Andrzej Siewior wrote: > > On 2020-12-03 09:18:21 [+0100], Mike Galbraith wrote: > > On Thu, 2020-12-03 at 03:16 +0100, Mike Galbraith wrote: > > > On Wed, 2020-12-02 at 23:08 +0100, Sebastian Andrzej Siewior wrote: > > > Looks like... > > > > > > d8f117abb

Re: [PATCH] z3fold: prevent reclaim/free race for headless pages

2021-03-12 Thread Vitaly Wool
c drm agpgart > ---[ end trace 126d646fc3dc0ad8 ]--- > > To fix the issue, re-add the earlier test and set in the case where we > have a headless page. > > Fixes: dcf5aedb24f8 ("z3fold: stricter locking and more careful reclaim") > Cc: sta...@vger.kernel

Re: [PATCH v3] riscv: add BUILTIN_DTB support for MMU-enabled targets

2021-01-21 Thread Vitaly Wool
On Sat, Jan 16, 2021 at 12:57 AM Vitaly Wool wrote: > > Sometimes, especially in a production system we may not want to > use a "smart bootloader" like u-boot to load kernel, ramdisk and > device tree from a filesystem on eMMC, but rather load the kernel > from a NAND par

[PATCH v4] RISC-V: enable XIP

2021-03-06 Thread Vitaly Wool
will currently only work on MMU-enabled kernels. Signed-off-by: Vitaly Wool --- Changed in v2: - dedicated macro for XIP address fixup when MMU is not enabled yet = both for 32-bit and 64-bit RISC-V - SP is explicitly set to a safe place in RAM before __copy_data call - removed redundant

[PATCH v5] RISC-V: enable XIP

2021-03-10 Thread Vitaly Wool
will currently only work on MMU-enabled kernels. Signed-off-by: Vitaly Wool --- Changes in v2: - dedicated macro for XIP address fixup when MMU is not enabled yet o both for 32-bit and 64-bit RISC-V - SP is explicitly set to a safe place in RAM before __copy_data call - removed redundant alignment

[PATCH v2] riscv: add BUILTIN_DTB support for MMU-enabled targets

2021-01-04 Thread Vitaly Wool
nt to have device tree compiled into the kernel binary. Since this case is not limited to MMU-less systems, let's support it for these which have MMU enabled too. Signed-off-by: Vitaly Wool --- Changelog from v1: * no direct initial_boot_params assignment * skips the temporary mapping for DT i

Re: [PATCH] RISC-V: simplify BUILTIN_DTB processing

2021-01-15 Thread Vitaly Wool
On Fri, Jan 15, 2021 at 11:43 AM Anup Patel wrote: > > On Fri, Jan 15, 2021 at 3:18 PM Vitaly Wool wrote: > > > > > > > > On Fri, 15 Jan 2021, 10:39 Anup Patel, wrote: > >> > >> On Tue, Jan 12, 2021 at 2:51 AM Vitaly Wool > >> w

[PATCH v3] riscv: add BUILTIN_DTB support for MMU-enabled targets

2021-01-15 Thread Vitaly Wool
ic processing in MMU-enabled and MMU-disabled versions of setup_vm(). Signed-off-by: Vitaly Wool --- Changes from v2: * folded "RISC-V: simplify BUILTIN_DTB processing" patch [http://lists.infradead.org/pipermail/linux-riscv/2021-January/004153.html] Changes from v1: * no direct initial_

[RFC/PATCH] ksm: add vma size threshold parameter

2014-05-27 Thread Vitaly Wool
Hi, I have recently been poking around saving memory on low-RAM Android devices, basically following the Google KSM+ZRAM guidelines for KitKat and measuring the gain/performance. While getting quite some RAM savings indeed (in the range of 10k-20k pages) we noticed that kswapd used a lot of CP

[PATCH] z3fold: the 3-fold allocator for compressed pages

2016-04-14 Thread Vitaly Wool
pages unlike zbud which can store at most 2. Therefore the compression ratio goes to around 2.5x while zbud's one is around 1.7x. The patch is based on the latest linux.git tree. [1] https://openiotelc2016.sched.org/event/6DAC/swapping-and-embedded-compression-relieves-the-pressure-vitaly

Re: [PATCH] z3fold: the 3-fold allocator for compressed pages

2016-04-14 Thread Vitaly Wool
[resending due to mail client issues] On Thu, Apr 14, 2016 at 10:48 AM, Vlastimil Babka wrote: > > On 04/14/2016 10:05 AM, Vitaly Wool wrote: >> >> This patch introduces z3fold, a special purpose allocator for storing >> compressed pages. It is designed to store up to th

Re: [PATCH] z3fold: the 3-fold allocator for compressed pages

2016-04-14 Thread Vitaly Wool
On Thu, Apr 14, 2016 at 5:53 PM, Seth Jennings wrote: > On Thu, Apr 14, 2016 at 4:06 AM, Vitaly Wool wrote: >> >> >> On Thu, Apr 14, 2016 at 10:48 AM, Vlastimil Babka wrote: >>> >>> On 04/14/2016 10:05 AM, Vitaly Wool wrote: >>>> >>>

Re: [PATCH] z3fold: the 3-fold allocator for compressed pages

2016-04-14 Thread Vitaly Wool
>> On Thu, Apr 14, 2016 at 5:53 PM, Seth Jennings wrote: >>> This also means that the unbuddied list is broken in this >>> implementation. num_free_chunks() is calculating the _total_ free >>> space in the page. But that is not that the _usable_ free space by a >>> single object, if the middle

Re: Confusing olddefault prompt for Z3FOLD

2016-04-28 Thread Vitaly Wool
On Thu, Apr 28, 2016 at 1:58 PM, Michal Hocko wrote: > On Thu 28-04-16 13:35:45, Vitaly Wool wrote: >> On Wed, Apr 27, 2016 at 2:31 PM, Michal Hocko wrote: >> > On Tue 26-04-16 12:08:30, Valdis Kletnieks wrote: >> >> Saw this duplicate prompt text in

Re: [PATCH v3] z3fold: the 3-fold allocator for compressed pages

2016-05-09 Thread Vitaly Wool
.sched.org/event/6DAC/swapping-and-embedded-compression-relieves-the-pressure-vitaly-wool-softprise-consulting-ou >> [2] https://lkml.org/lkml/2016/4/21/799 >> >> Signed-off-by: Vitaly Wool >> --- >> Documentation/vm/z3fold.txt | 27 ++ >>

[PATCH v4] z3fold: the 3-fold allocator for compressed pages

2016-05-09 Thread Vitaly Wool
event/6DAC/swapping-and-embedded-compression-relieves-the-pressure-vitaly-wool-softprise-consulting-ou [2] https://lkml.org/lkml/2016/4/21/799 [3] https://lkml.org/lkml/2016/5/4/852 Signed-off-by: Vitaly Wool --- Documentation/vm/z3fold.txt | 27 ++ mm/Kconfig | 12 +- mm/Mak

Re: [PATCH v4] z3fold: the 3-fold allocator for compressed pages

2016-05-27 Thread Vitaly Wool
Hello Dan, On Fri, May 20, 2016 at 2:39 PM, Dan Streetman wrote: >> +static int z3fold_compact_page(struct z3fold_header *zhdr) >> +{ >> + struct page *page = virt_to_page(zhdr); >> + void *beg = zhdr; >> + >> + >> + if (!test_bit(MIDDLE_CHUNK_MAPPED, &page->private) && >> +

[PATCH] z3fold: avoid modifying HEADLESS page and minor cleanup

2016-05-27 Thread Vitaly Wool
This patch fixes erroneous z3fold header access in a HEADLESS page in reclaim function, and changes one remaining direct handle-to-buddy conversion to use the appropriate helper. Signed-off-by: Vitaly Wool --- mm/z3fold.c | 24 ++-- 1 file changed, 14 insertions(+), 10

Re: Confusing olddefault prompt for Z3FOLD

2016-04-28 Thread Vitaly Wool
On Wed, Apr 27, 2016 at 2:31 PM, Michal Hocko wrote: > On Tue 26-04-16 12:08:30, Valdis Kletnieks wrote: >> Saw this duplicate prompt text in today's linux-next in a 'make oldconfig': >> >> Low density storage for compressed pages (ZBUD) [Y/n/m/?] y >> Low density storage for compressed pages (Z3F

[PATCH v2] z3fold: the 3-fold allocator for compressed pages

2016-04-19 Thread Vitaly Wool
P/HMP platforms. [1]https://openiotelc2016.sched.org/event/6DAC/swapping-and-embedded-compression-relieves-the-pressure-vitaly-wool-softprise-consulting-ou Signed-off-by: Vitaly Wool --- mm/Kconfig | 9 + mm/Makefile | 1 + mm/z3fold.c

  1   2   3   >