king. I'm pleased to test your patches in this way if you need to
check probe() function in driver module.
Thanks
Takashi Sakamoto
(May 27 2013 07:57), Greg Kroah-Hartman wrote:
On Sun, May 26, 2013 at 11:35:13PM +0200, Stefan Richter wrote:
I think your approach is sensible. There is
uot;, an driver module is for TC
Applied Technologies' Dice based firewire sound devices. I'll inform
them about your patches and topic branch.
Thanks a lot!
Takashi Sakamoto
o-taka...@sakamocchi.jp
(Jun 03 2013 08:35), Stefan Richter wrote:
On Jun 02 Greg Kroah-Hartman wrote:
On Mon,
by: Valdis Kletnieks
Reviewed-by: Takashi Sakamoto
As a nitpicking, I think it better to change the subject line with a
prefix of 'ALSA: line6:' or 'ALSA: usb-line6:', following to our fashion.
diff --git a/sound/usb/line6/Kconfig b/sound/usb/line6/Kconfig
index 8ffcf
On Sep 21 2016 21:37, Takashi Iwai wrote:
> On Wed, 21 Sep 2016 03:56:05 +0200,
> Takashi Sakamoto wrote:
>>
>> On Sep 21 2016 07:14, Valdis Kletnieks wrote:
>>> ALSA - snd-usb-line6 depends on CONFIG_SND_HWDEP
>>>
>>> ERROR: "snd_hwdep
On Sep 21 2016 22:30, Takashi Iwai wrote:
> On Wed, 21 Sep 2016 15:25:43 +0200,
> Takashi Sakamoto wrote:
>>
>> On Sep 21 2016 21:37, Takashi Iwai wrote:
>>> On Wed, 21 Sep 2016 03:56:05 +0200,
>>> Takashi Sakamoto wrote:
>>>>
>>>> On Sep
structures that have this property can be declared as const
also.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
Reviewed-by: Takashi Sakamoto
I've realized this issue and will fix in this development cycle for
Linux 4.9. Thanks for your continuous effo
On 2016年09月02日 08:28, Takashi Sakamoto wrote:
Hi Julia,
On 2016年09月02日 07:13, Julia Lawall wrote:
Check for snd_pcm_ops structures that are only stored in the ops field of a
snd_soc_platform_driver structure or passed as the third argument to
snd_pcm_set_ops. The corresponding field or
sound interfaces of actual hardwares.)
Please declare the way to enable stuffs on DomU to get the positions
from actual hardware.
Regards
Takashi Sakamoto
mean that any alsa-lib or libpulse applications run on Dom0 as a
backend driver for the frontend driver on DomU?
Regards
Takashi Sakamoto
; unexpected callbacks in the future.
This suggestion is better for safety. Do you have some ways to detect the
pattern on current vanilla kernel? Or we should find it by eye-grep?
Thanks
Takashi Sakamoto
8<
>From 85896b50aa22bf2f2b5e45456daa16d386602edc Mon Sep 17 00:00:0
them. For
instance, you can point links to backend/frontend implementation as
para-virtualization drivers which use the new feature of interface, if
you did work for it. Indicating procedure to use a series of your work
is better for test, if possible.
[1] https://www.ietf.org/rfc/rfc0822.txt
Regards
Takashi Sakamoto
topic/segment-in-pcm
[2] https://github.com/takaswie/sound/tree/topic/trace+refactor
[3] https://github.com/libfuse/osspd
Regards
Takashi Sakamoto
On May 11 2017 19:01, Takashi Sakamoto wrote:
But the set_fs() usage in OSS code is hard to get rid of, due to the
in-kernel ioctl calls, and I really don't want to touch such dusty
codes, either. So I wanted to post the very same question, but you
were faster :)
But looking at the OSS
rgot
itself when developing the driver... I'd like to have a bit time for
further investigation, then post my fix in this development period.
Please let me keep this patch pending.
Thanks
Takashi Sakamoto
81af6b2222c6b4e025a5d01b37b4449b
Regards
Takashi Sakamoto
ff-by: Takashi Iwai
---
sound/core/pcm_native.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
Yeah. I have concerned about it for a long time but kept it as is
because it had no issue. Now, let's obsolete it.
Reviewed-by: Takashi Sakamoto
diff --git a/
front_info->num_evt_pairs = num_streams;
return 0;
Yep. All branches for error path on the nested for loop have goto
statement, thus no need to check error outer the loop.
Reviewed-by: Takashi Sakamoto
Takashi Sakamoto
s the third argument of xen_snd_front_stream_prepare() because it is
'u8'. This patch looks good to me.
Reviewed-by: Takashi Sakamoto
Regards
Takashi Sakamoto
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-May/136620.html
[2] ASoC: fix 0-day warnings with snd_soc_new_compress()
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-4.18&id=0b014d72ebae14c0c6ab3fb36a442fda91e1a1b3
Thanks
Takashi Sakamoto
On 2018年10月09日 04:39, Connor McAdams wrote:
This patch set fixes the microphone inconsistency issue, which means
the microphone now works all the time on all of the cards I've tested
(ZxR, Z, AE-5), along with the input effects.
It also includes changes suggested by Takashi Sakamoto, I be
nd.h' in a
development period for Linux kernel v4.21[1]. Would I need to add you to
C.C list of the future patch to notify the change, or things go well
without such special care for your side?
[1]
https://github.com/takaswie/presentations/blob/master/20181021/contents.md
Regards
Takashi Sakamoto
Hi,
On 2018/11/01 22:04, Arnaldo Carvalho de Melo wrote:
Em Thu, Nov 01, 2018 at 08:54:45PM +0900, Takashi Sakamoto escreveu:
Hi Arnaldo,
On Nov 1 2018 4:29, Arnaldo Carvalho de Melo wrote:
Wouldn't a symlink be simpler?
That would be equivalent to using it directly, see my respon
insertions(+)
Reviewed-by: Takashi Sakamoto
Tested-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
pplied to for-next branch. I'll use spellcheck program when posting this
kind of changes.
Thanks
Takashi Sakamoto
his is
like a story about 'chicken or the egg'. So I cannot achieve this.
Now that I have no reports about disorder in this point (this driver
cannot handle any Fireworks devices), this function has just a meaning
of FYI.
Regards
Takashi Sakamoto
>> ---
>> sound/fire
pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42f945970af9
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=4b671f577474
[3]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b602aa8eb1a0
[4]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fccf53881e9b
Regards
Takashi Sakamoto
or-next&id=5730f9f744cfe20b771adc33f3b476b95d3eebba
[2]
http://mailman.alsa-project.org/pipermail/alsa-devel/2018-March/133268.html
Thanks
Takashi Sakamoto
so_mc_callback_t). This idea leaves
current drivers as is and the change is done inner firewire-core driver,
therefore existent kernel API is not changed.
Later I post two patches for the proposal. I'd like you to review it and
I'm glad to receive your comments.
Regards
Takashi Sakamoto
lly, no in-kernel driver uses the mode
and the additional kernel API is never used at present.
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-iso.c | 17 +
inc
This commit obsoletes cast of function callback to assist attempt of
Control Flow Integrity builds.
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-cdev.c | 44
. Although the
API is exported in the patchset, it's better to discuss about unexporting
the API.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firewire/core-cdev.c#n985
[2] https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Regards
Ta
uffer to process, or for error code. The
error code is checked immediately. The range of value is equal to
or less than 3 when reaching the calculation, thus it should be less than
16777.
Regardless of the type of 'int' or 'unsigned int', this patch can fix
the issued problem. F
the value is equals to or less than
SND_FF_MAXIMIM_MIDI_QUADS (= 9). For latter protocol, the value is
equals to or less than 3. Anyway, the value should not be larger
than 16777 and the calculation can be done without ULL suffix.
Reviewd-by: Takashi Sakamoto
> diff --git a/sound/firewire/firef
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Wei,
Thanks for this patch, while I found the other issues in this file. I
would like to post new patches instead of yours, later.
Thanks
Takashi Sakamoto
o-taka...@sakamocchi.jp
(Jul 20 2014 13:50), weiyj...@163.com wrote:
> From: Wei Yong
()
https://lkml.org/lkml/2014/7/20/12
Signed-off-by: Takashi Sakamoto
---
sound/firewire/bebob/bebob_maudio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/bebob/bebob_maudio.c
b/sound/firewire/bebob/bebob_maudio.c
index 6af50eb..fc470c6 100644
--- a
(May 29 2014 01:42), Dan Carpenter wrote:
> There was a typo here so we return directly instead of freeing "hwinfo".
>
> Signed-off-by: Dan Carpenter
Reviewd-by: Takashi Sakamoto
Tested-by: Takashi Sakamoto
> diff --git a/sound/firewire/fireworks/fireworks.c
> b
On May 03 2016 16:42, Dan Carpenter wrote:
> We intended || here instead of &&. The original code potentially leads
> to a NULL dereference.
>
> Fixes: 2889099eb8cd ('ASoC: hdac_hdmi: Register chmap controls and ops')
> Signed-off-by: Dan Carpenter
Inde
readers.
Reviewed-by: Takashi Sakamoto
Tested-by: Takashi Sakamoto
---
sound/core/pcm_native.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index a8b27cd..fadd3eb 100644
--- a/sound/core
ytterhoeven
Yep. It came from original code[1] and I overlooked.
Reviewed-by: Takashi Sakamoto
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c
> b/sound/fire
evel(format);
> memcpy(verbose_fmt, format, end_of_header - format);
> vaf.fmt = end_of_header;
> - } else if (level)
> + } else if (snd_level)
> memcpy(verbose_fmt, KERN_DEBUG, sizeof(KERN_DEBUG) - 1);
> printk(verbose_fmt, sanity_file_name(path), line, &vaf);
There's no need to rename variable names.
Regards
Takashi Sakamoto
o-taka...@sakamocchi.jp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
return false;
>
> for (i = 0; i < ARRAY_SIZE(models); i++) {
> if (strcmp(models[i], model) == 0)
Reviewd-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
o-taka...@sakamocchi.jp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Hi,
On Nov 02 2015 15:55, Julia Lawall wrote:
Move constant to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Takashi Sakamoto
Signed-off-by: Fengguang Wu
Signed-off-by: Julia Lawall
---
Depends on personal taste, but the modified version
Hi Julia,
On Nov 02 2015 16:20, Julia Lawall wrote:
On Mon, 2 Nov 2015, Takashi Sakamoto wrote:
Hi,
On Nov 02 2015 15:55, Julia Lawall wrote:
Move constant to the right of binary operators.
Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
CC: Takashi Sakamoto
Signed-off-by
a.c|2 +-
> 9 files changed, 11 insertions(+), 11 deletions(-)
Thanks. This patch, itself, is OK to me, while I wonder why this patch
doesn't change the other members like rate and meter.
Regards
Takashi Sakamoto
> diff --git a/sound/firewire/bebob/bebob_yamaha.c
> b/soun
wire/bebob/bebob_stream.c|6 +++---
> sound/firewire/bebob/bebob_terratec.c | 10 +-
> sound/firewire/bebob/bebob_yamaha.c|6 +++---
> 9 files changed, 61 insertions(+), 61 deletions(-)
Tested-by: Takashi Sakamoto
Reviewed-by: Takashi Sakamoto
Thank you to incl
rratec.c | 10 +-
> sound/firewire/bebob/bebob_yamaha.c|6 +++---
> 9 files changed, 61 insertions(+), 61 deletions(-)
Tested-by: Takashi Sakamoto
Reviewed-by: Takashi Sakamoto
Good, thanks ;)
Takashi Sakamoto
> diff --git a/sound/firewire/bebob/bebob.c b/sound/fi
to post their issues, especially for
regression.
Signed-off-by: Takashi Sakamoto
---
MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 24e29b2e53c9..8929a2ec75f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6264,8 +6264,9 @@ S
On Sat, Aug 31, 2019 at 05:27:13PM +0200, Takashi Iwai wrote:
> On Fri, 30 Aug 2019 15:24:46 +0200,
> Takashi Sakamoto wrote:
> >
> > This commit adds myself as one of maintainers for firewire audio
> > drivers and IEC 61883-1/6 packet streaming engine. I call them ALSA
header.
Signed-off-by: Takashi Sakamoto
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4200194e69ea..6bd54ce6dc66 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6271,6 +6271,7 @@ L:alsa-de...@alsa-project.org (moderated for
non
"
ALSA: firewire-lib: refactoring to obsolete IR packet handler").
https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=98e3e43b599d742c104864c6772a251025ffb52b
Thanks
Takashi Sakamoto
sed instead.
>
> Signed-off-by: Ross Zwisler
> ---
> MAINTAINERS | 13 ++---
> 1 file changed, 6 insertions(+), 7 deletions(-)
This is a good catch.
Reviewed-by: Takashi Sakamoto
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e17ebf70b5480..d373d976a9317 1
-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Takashi Sakamoto
And this bug exists till its first commit for v2.6.39.
Fixes: 31ef9134eb52 ("ALSA: add LaCie FireWire Speakers/Griffin FireWave
Surround driver")
Cc: # v2.6.39+
Thanks
Takashi Sakamoto
/sound.git/log/?h=for-4.19
Thanks
Takashi Sakamoto
nt to members in hda_codec, etc.)
->'spec' preparation (assignment to members in ca0132_spec, etc.)
Regards
Takashi Sakamoto
add_mic_boost_enum
- ae5_add_headphone_gain_enum
- ae5_add_sound_filter_enum
- zxr_add_headphone_gain_switch
This is not a strong request and you can work for it after merging this
patchset. We have two weeks more till next merge window.
Regards
Takashi Sakamoto
/ca0132 - Add ZxR exit commands
sound/pci/hda/patch_ca0132.c | 369 ---
1 file changed, 345 insertions(+), 24 deletions(-)
I reviewed the above patches and they looks good to be merged to
upstream.
Reviewed-by: Takashi Sakamoto
I've already point
/firewire/oxfw/oxfw.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto
For my information, use_match_string() helper was firstly introduced to
v4.6 kernel by a commit 56b060814e2d ('lib/string: introduce
match_string() helper').
diff --g
Hi,
On May 21 2018 20:58, Yisheng Xie wrote:
match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.
Cc: Clemens Ladisch
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Cc: Takashi Sakamoto
Cc: alsa-de...@alsa-project.org
Signed-off-by
's better to write enough information in the cover letter.
For its content, please refer to cover letters by the other developers
in alsa-devel archive.
http://mailman.alsa-project.org/pipermail/alsa-devel/
Thanks
Takashi Sakamoto
iewed the above patches.
Reviewed-by: Takashi Sakamoto
There're some points to improve such like read-only memory objects, and
I'll post some patches for them after merging this patchset.
Thanks
Takashi Sakamoto
dspio_alloc_dma_chan()
* dspio_free_dma_chan()
* Changes for SBZ only
* Changes for R3Di only
Could you please prepare for these three patches from this large patch
in your next chance? Especially, you can describe enough information to
the latter two patches as patch comment.
Thanks
Takashi Sakamoto
eqs = { 0x18, 0x01, 0x1F, 0x15,
+ 0x3A, 0x1A, 0x1B, 0x1C },
+ .vals = { 0x, 0x, 0x,
+ 0x, 0x, 0x,
+ 0x, 0x }
+ }
+};
+
It's better to add 'const' qualifier.
Regards
Takashi Sakamoto
_user(ctl, argp, true);
case SNDRV_CTL_IOCTL_ELEM_LOCK:
return snd_ctl_elem_lock(ctl, argp);
case SNDRV_CTL_IOCTL_ELEM_UNLOCK:
Thanks
Takashi Sakamoto
long as in-kernel drivers
know specifications of endpoints, userspace applications can start PCM
substreams correctly.
[1] In detail, please refer to specification of 1394TA I introduced:
http://www.spinics.net/lists/netdev/msg381259.html
[2] I guess that IEC 61883-1/6 packet for Ethernet-AVB is a mutant from
original specifications.
Regards
Takashi Sakamoto
ur side, few
developers can tell you, I think.
Regards
Takashi Sakamoto
ix, just for
readers. But I agree with these patches because the code is a bit
confusing. I'll post a patch soon for this aim with appropriate
information, sorry for Nicolas.
Thanks
Takashi Sakamoto
static int snd_usb_pcm_prepare(struct snd_pcm_substream
> *substream)
> /* for playback, submit the URBs now; otherwise, the first hwptr_done
>* updates for all URBs would happen at the same time when starting */
> if (subs->direction == SNDRV_PCM_STREAM_PLAYB
Hi,
On Dec 20 2016 20:47, Ioan-Adrian Ratiu wrote:
On Tue, 20 Dec 2016, Takashi Sakamoto wrote:
---
Hi,
Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream")
fixes a race-codition but it also introduces another really nasty data race
regression which makes my
On Dec 5 2016 16:32, Jiada Wang wrote:
Hi Sakamoto
On 11/30/2016 02:45 AM, Takashi Sakamoto wrote:
Hi Jiada,
I don't oppose this patch. Nevertheless, your description is not
necessarily correct.
On Nov 30 2016 16:59, Jiada Wang wrote:
From: Daniel Girnus
ALSA usually calls the pr
d-off-by: Kees Cook
---
sound/synth/emux/emux_seq.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Takashi Sakamoto
diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
index a0209204ae48..55579f6b8cb2 100644
--- a/sound/synth/emux/emux_
nit_sample_rate(subs->stream->chip,
+ subs->cur_audiofmt->iface,
+ alts,
+ subs->cur_audiofmt,
+ subs->cur_rate);
+ if (ret < 0)
+ goto unlock;
+
ret = configure_endpoint(subs);
if (ret < 0)
goto unlock;
Regards
Takashi Sakamoto
On Nov 30 2016 19:45, Takashi Sakamoto wrote:
Hi Jiada,
I don't oppose this patch. Nevertheless, your description is not
necessarily correct.
On Nov 30 2016 16:59, Jiada Wang wrote:
From: Daniel Girnus
ALSA usually calls the prepare function twice before starting the
playback:
_kcontrols == 0) {
+ kcontrol_type = 0;
template.num_kcontrols = 0;
goto widget;
}
Reported-by: Dan Carpenter
Reviewed-by: Takashi Sakamoto
This bug was already reported but not fixed yet:
[alsa-devel] [bug report] ASoC: topology: Only free TLV for volume
mixers of a wi
15, 2016 at 12:15:24PM +0900, Takashi Sakamoto wrote:
>>> On Mon, Jun 13, 2016 at 01:47:13PM +0200, Richard Cochran wrote:
>>>> I have seen audio PLL/multiplier chips that will take, for example, a
>>>> 10 kHz input and produce your 48 kHz media clock. With the ri
On Feb 19 2016 19:21, Bhumika Goyal wrote:
Declare snd_emux_operators structure as const as it is only copied into
another structure. So, snd_emux_operators structures having this property
can be made const.
Signed-off-by: Bhumika Goyal
Reviewed-by: Takashi Sakamoto
...The 'ASLA
f (!dev) {
- dev_warn(&pdev->dev, "kzalloc fail\n");
+ if (!dev)
The line for 'dev_warn()' should be kept.
return -ENOMEM;
- }
dw_i2s_dai = devm_kzalloc(&pdev->dev, sizeof(*dw_i2s_dai), GFP_KERNEL);
if (!dw_i2s_dai)
Regards
Takashi Sakamoto
_KERNEL);
- if (!i2s) {
- dev_err(&pdev->dev, "Can't allocate rk_i2s_dev\n");
+ if (!i2s)
The line for dev_warn() should be kept.
return -ENOMEM;
- }
i2s->dev = &pdev->dev;
Regards
Takashi Sakamoto
host), GFP_KERNEL);
- if (!host) {
- dev_warn(&pdev->dev, "kzalloc fail\n");
+ if (!host)
Ditto.
return -ENOMEM;
- }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->io_base = devm_ioremap_resource(&pdev->dev, res);
Takashi Sakamoto
t be static?
Signed-off-by: Wei Yongjun
---
sound/soc/codecs/hdmi-codec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Takashi Sakamoto
Unfortunately, this patch causes conflict to Mark's PR[0], due to a
commit 8480ac567959 ("ASoC: hdmi-codec: remove H
ed elements; e.g. only for elements belong to one control
element set.
On Feb 3 2017 16:24, Takashi Iwai wrote:
On Thu, 02 Feb 2017 04:45:48 +0100,
Takashi Sakamoto wrote:
I'm _strongly_ interested in your two patches, because it has a
potentiality to purge ASoC abuse of TLV feature, which
function calls to NULL and the function definition is omitted. This is a
sample:
https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/tree/sound/pci/hda/patch_sigmatel.c#n4427
Let us apply the same idea to this module?
Thanks
Takashi Sakamoto
and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu
> Signed-off-by: Baole Ni
Reviewed-by: Takashi Sakamoto
> ---
> sound/firewire/fireworks/fireworks.c
and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu
> Signed-off-by: Baole Ni
Reviewed-by: Takashi Sakamoto
> ---
> sound/firewire/bebob/bebob.
fault.
I'm on short summer vacation, so will post patches for them in next week.
Thanks
Takashi Sakamoto
eriod)
f = f >> 1;
- pages = (size + f - 1) / f;
+ pages = DIV_ROUND_UP(size, f);
data->size = size;
data->pages = pages;
snd_printdd
Reviewed-by: Takashi Sakamoto
Regards
Takashi Sakamoto
development for my minor hardwares...
(Actually, Iwai-san posted patches to fix them at incredibly pace. I
can't follow his pace, because I'm working for ALSA in my free time.)
Regards
Takashi Sakamoto
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
iQEcBAEBCAAG
x27;t mind to receive them because it's a good information for
me to get current state of ALSA core functionality. If I had some
spare time, I was also going to fix it. But currently I have little
time for it due to my development for my minor hardwares...
(Actually, Iwai-san posted patches to fix them at incredibly pace. I
can't follow his pace, because I'm working for ALSA in my free time.)
Regards
Takashi Sakamoto
m params for both streams */
> - index = get_formation_index(rate);
> + err = get_formation_index(rate, &index);
> + if (err < 0)
> + goto end;
> pcm_channels = bebob->tx_stream_formations[index].pcm;
> midi_channels = bebob->tx_stream
es code more
> clear and declarative. This way avoid the call to a function with one
> purpose to achieved another one.
>
> Co-developed-by: Takashi Sakamoto
> Signed-off-by: Takashi Sakamoto
> Co-developed-by: Stefan Richter
> Signed-off-by: Stefan Richter
> Signed-off-
efw->supported_sampling_rate,
> + runtime->hw.rates = efw->supported_sampling_rate;
> snd_pcm_limit_hw_rates(runtime);
>
> limit_channels(&runtime->hw, pcm_channels);
Oops. It seems to be my typo added at the commit aa02bb6e6078
("ALSA: fireworks: Add PCM interface")...
Acked-by: Takashi Sakamoto
Thanks
Takashi Sakamoto
Hi Greg,
On Sat, May 23, 2020 at 08:10:33AM +0200, Greg KH wrote:
> On Fri, May 22, 2020 at 07:43:08PM +0200, Oscar Carter wrote:
> > Hi,
> >
> > On Wed, May 20, 2020 at 03:16:24PM +0900, Takashi Sakamoto wrote:
> > > Hi,
> > >
> > > I'm an a
unction
- tested by libhinoko
Reported-by: Oscar Carter
Reference:
https://lore.kernel.org/lkml/20200519173425.4724-1-oscar.car...@gmx.com/
Signed-off-by: Takashi Sakamoto
---
drivers/firewire/core-cdev.c | 40 +++-
include/linux/firewire.h | 16 +++
;
At first place, I wrote the similar patch but judged it's a bit ad-hoc
way that callback functions are assigned after the call of
fw_iso_context_create() in raw code. For explicitness in a point of things
being declarative, I put the inline function into header, and avoid
someone's misfortune for future even if IEEE 1394 is enough legacy.
Anyway, I don't mind Stefan's proposal since it works well. It depends
on developers' fashion to choose policy to write codes.
Thanks
Takashi Sakamoto
+++---
> drivers/firewire/core-iso.c | 2 +-
> include/linux/firewire.h | 17 -
> 3 files changed, 12 insertions(+), 13 deletions(-)
Oscar Carter has posted a patch to fix it.
https://sourceforge.net/p/linux1394/mailman/message/37024966/
I don't know exactly but maintainers seems to overlook it...
Thanks
Takashi Sakamoto
am.h:273:6-19: WARNING: Comparison to bool
> >
> > Reported-by: Tosk Robot
> > Signed-off-by: Kaixu Xia
The message seems not to reach my mailbox. Anyway:
Acked-by: Takashi Sakamoto
> Thanks, applied.
>
>
> Takashi
>
> > ---
> > sound/firewire/amdtp-stream.
snd_set_vender_interface);
I think the symbol name has typo; 'vender' against 'vendor'.
Anyway, this feature is not widely used at present. I suggest to add
kernel configuration for the feature at kernel compilation time, IMO.
Regards
Takashi Sakamoto
und with the help of Coccinelle.
>
> [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> [2] https://github.com/KSPP/linux/issues/21
> [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> sound/firewire/fi
lization to a
helper function")
Signed-off-by: Arnd Bergmann
---
sound/soc/intel/skylake/bxt-sst.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Takashi Sakamoto
diff --git a/sound/soc/intel/skylake/bxt-sst.c
b/sound/soc/intel/skylake/bxt-sst.c
index fde4bc0f35b0..
return ret;
> }
Thanks for posting this patch, however Vinod already posted the same
fix. Please wait for merging it and verify again:
[alsa-devel] [PATCH 1/3] ASoC: Intel: Skylake: Fix uninitialized pointer
usage
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120214.html
Regards
Takashi Sakamoto
ruct snd_kcontrol_new x;
Signed-off-by: Bhumika Goyal
---
sound/usb/line6/pod.c | 2 +-
sound/usb/line6/toneport.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Takashi Sakamoto
I have interests in your way to detect this kind of issue, because below
&#x
1 - 100 of 134 matches
Mail list logo
