Hi,
On Apr 28 2017 00:13, Colin King wrote:
> From: Colin Ian King <colin.k...@canonical.com>
>
> The dev_err message is dereferencing an uininitialized skl pointer
> which should be avoided. Don't use skl, use dev instead.
>
> Detected by CoverityScan, CID#1432042 ("Uninitialized pointer read")
>
> Fixes: 9fe9c71192832 ("ASoC: Intel: Skylake: Move sst common initialization
> to a helper function")
> Signed-off-by: Colin Ian King <colin.k...@canonical.com>
> ---
> sound/soc/intel/skylake/bxt-sst.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/skylake/bxt-sst.c
> b/sound/soc/intel/skylake/bxt-sst.c
> index fde4bc0f35b0..f5e7dbb1ba39 100644
> --- a/sound/soc/intel/skylake/bxt-sst.c
> +++ b/sound/soc/intel/skylake/bxt-sst.c
> @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem
> *mmio_base, int irq,
>
> ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev);
> if (ret < 0) {
> - dev_err(skl->dev, "%s: no device\n", __func__);
> + dev_err(dev, "%s: no device\n", __func__);
> return ret;
> }
Thanks for posting this patch, however Vinod already posted the same
fix. Please wait for merging it and verify again:
[alsa-devel] [PATCH 1/3] ASoC: Intel: Skylake: Fix uninitialized pointer
usage
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120214.html
Regards
Takashi Sakamoto
