Re: [PATCH v2 12/26] MIPS: CPC: Provide a default mips_cpc_default_phys_base

2016-08-31 Thread Sergei Shtylyov
Hello. On 8/30/2016 8:29 PM, Paul Burton wrote: Provide a weak default implementation of mips_cpc_default_phys_base which reads the base address of the CPC from the device tree if possible, and failing that returns the existing physical address of the CPC as read from CPC base address GCR. This

Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: add MDB support

2016-08-31 Thread Sergei Shtylyov
Hello. On 08/31/2016 05:46 PM, Vivien Didelot wrote: diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 93abfff..812cb47 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -2240,6 +2240,15 @@ static int mv88e6xxx_port_db_d

Re: [Patch v3 08/11] net: ethernet: xilinx: Generate random mac if none found

2016-09-01 Thread Sergei Shtylyov
Hello. On 8/31/2016 7:35 PM, Zubair Lutfullah Kakakhel wrote: At the moment, if the emaclite device doesn't find a mac address from any source, it simply uses 0x0 with a warning printed. Instead of using a 0x0 mac address, use a randomly generated one. Signed-off-by: Zubair Lutfullah Kakakhel

Re: [Patch v3 09/11] net: ethernet: xilinx: Enable emaclite for MIPS

2016-09-01 Thread Sergei Shtylyov
On 8/31/2016 7:35 PM, Zubair Lutfullah Kakakhel wrote: The MIPS based xilfpga platform uses this driver. Enable it for MIPS Signed-off-by: Zubair Lutfullah Kakakhel [...] diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig index 4f5c024..ae5c404 100644 -

Re: [RFC V2 PATCH 04/25] net/netpolicy: get CPU information

2016-08-05 Thread Sergei Shtylyov
Hello. On 8/4/2016 10:36 PM, kan.li...@intel.com wrote: From: Kan Liang Net policy also needs to know CPU information. Currently, online CPU number is enough. s/number/count/. Or "the number of online CPUs". Signed-off-by: Kan Liang --- net/core/netpolicy.c | 5 + 1 file changed

Re: [PATCH 08/11] net/fsl: use of_property_read_bool

2016-08-05 Thread Sergei Shtylyov
Hello. On 8/5/2016 11:56 AM, Julia Lawall wrote: Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S2,S1; @@ - if (of_get_property(e1,e2,NULL)) +

Re: [PATCH 08/11] net/fsl: use of_property_read_bool

2016-08-05 Thread Sergei Shtylyov
On 8/5/2016 2:38 PM, Julia Lawall wrote: Use of_property_read_bool to check for the existence of a property. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression e1,e2; statement S2,S1; @@ - if (of_get_property(e1,e2,NULL)) + if (o

Re: [PATCH] phy: request shared IRQ

2016-08-24 Thread Sergei Shtylyov
Hello. On 08/24/2016 08:53 PM, Xander Huff wrote: From: Nathan Sullivan On hardware with multiple PHY devices hooked up to the same IRQ line, allow them to share it. Note that it had been allowed until my (erroneous?) commit 33c133cc7598e60976a069344910d63e56cc4401 ("phy: IRQ cannot be

Re: [PATCH] sata: ahci-da850: Fix some error handling paths in 'ahci_da850_probe()'

2017-08-16 Thread Sergei Shtylyov
Hello! On 8/16/2017 8:31 AM, Christophe JAILLET wrote: 'rc' is known to be 0 at this point. If 'platform_get_resource()' or 'devm_ioremap()' fail, return -ENOMEM instead of 0 which means success. Signed-off-by: Christophe JAILLET --- drivers/ata/ahci_da850.c | 8 ++-- 1 file changed, 6

Re: [PATCH 4/7] ARM: dts: stm32: Enable USB HS on stm32746g-eval

2017-08-17 Thread Sergei Shtylyov
Hello! On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch enables USB HS on stm32746g-eval (Host mode). Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32746g-eval.dts | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/stm32746g-eval.dts

Re: [PATCH 6/7] ARM: dts: stm32: Add USB FS support for STM32F746 MCU

2017-08-17 Thread Sergei Shtylyov
On 8/17/2017 12:33 PM, Amelie Delaunay wrote: This patch adds the USB pins and nodes for USB FS core on STM32F746 SoC. Signed-off-by: Amelie Delaunay --- arch/arm/boot/dts/stm32f746.dtsi | 31 +++ 1 file changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/s

Re: [PATCH V6 21/21] net-next/hinic: Add netpoll

2017-08-17 Thread Sergei Shtylyov
Hello. On 08/17/2017 03:25 PM, Aviad Krawczyk wrote: Add more netdev operation - netpoll. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- MAINTAINERS| 7 +++ drivers/net/ethernet/huawei/hinic/hinic_main.c | 20 2 fi

Re: [PATCH v4 1/4] can: dev: Add support for limiting configured bitrate

2017-08-17 Thread Sergei Shtylyov
Hello! On 08/17/2017 08:54 PM, Franklin S Cooper Jr wrote: Various CAN or CAN-FD IP may be able to run at a faster rate than what the transceiver the CAN node is connected to. This can lead to unexpected errors. However, CAN transceivers typically have fixed limitations and provide no means to

Re: [PATCH] net: stmmac: socfgpa: Ensure emac bit set in sys manager for MII/GMII/SGMII.

2017-08-18 Thread Sergei Shtylyov
Hello! On 8/18/2017 9:55 AM, Stephan Gatzka wrote: When using MII/GMII/SGMII in the Altera SoC, the phy needs to be wired through the FPGA. To ensure correct behavior, the appropriate bit in the System Manager FPGA Interface Group register needs to be set. Signed-off-by: Stephan Gatzka ---

Re: [PATCH V8 5/5] libata: Align DMA buffer to dma_get_cache_alignment()

2017-10-17 Thread Sergei Shtylyov
On 10/17/2017 11:05 AM, Huacai Chen wrote: In non-coherent DMA mode, kernel uses cache flushing operations to maintain I/O coherency, so in ata_do_dev_read_id() the DMA buffer should be aligned to ARCH_DMA_MINALIGN. Otherwise, If a DMA buffer and a kernel structure share a same cache line, and i

Re: linux-next: manual merge of the net-next tree with the net tree

2017-10-17 Thread Sergei Shtylyov
Hello! On 10/16/2017 12:36 PM, Mark Brown wrote: Today's linux-next merge of the net-next tree got a conflict in: drivers/net/dsa/mv88e6060.c between commit: 3efc93c2bc243 ("net: dsa: mv88e6060: fix switch MAC address") from the net tree and commit: 56c3ff9bf23e1 ("net: dsa: mv88e

Re: [PATCH 6/7] [media] soc_camera: rcar_vin: use proper name for the R-Car SoC

2017-05-29 Thread Sergei Shtylyov
Hello! Why "soc_camera:" in the subject? The 'soc_camera" driver has been removed (replaced by a "normal" V4L2 driver). MBR, Sergei

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
Hello! On 10/28/2017 08:19 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any change in the resulting

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/29/2017 02:00 PM, Geert Uytterhoeven wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/30/2017 11:51 PM, Sergei Shtylyov wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any change in the resulting o

Re: [PATCH 8/8] bdc_pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-05 Thread Sergei Shtylyov
Hello. On 10/5/2015 6:16 AM, Greg KH wrote: Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Why? Seemed a good idea to me back in March. :-) I hate PCI_VDEVICE(), it's impossible to grep for things and does Didn't think about grepping... not help with re

Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

2015-10-06 Thread Sergei Shtylyov
Hello. On 10/6/2015 10:25 AM, Neil Armstrong wrote: To prevent memory leakage on unbinding, add missing kfree calls. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index c59fa5d..12ce

[PATCH 0/2] Some phylib simplifications

2015-08-28 Thread Sergei Shtylyov
Hello. Here's 2 patches against DaveM's 'net-next.git' repo. We simplify a bogus string of type casts in the 1st patch and make the code respect some coding standards of the networking code in the 2nd one. I may follow with fixing of checkpatch.pl's complaints. if I have time.. [1/2] phylib: s

[PATCH 1/2] phylib: simplify bogus phy_device_create() result

2015-08-28 Thread Sergei Shtylyov
Get rid of the bogus string of type casts where ERR_PTR() is enough. Signed-off-by: Sergei Shtylyov --- drivers/net/phy/phy_device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next/drivers/net/phy/phy_device.c

[PATCH 2/2] phylib: simplify NULL checks

2015-08-28 Thread Sergei Shtylyov
Fix scripts/checkpatch.pl's messages like: CHECK: Comparison to NULL could be written "!phydrv->read_mmd_indirect" BTW, it doesn't detect the reversed comparisons (which I've fixed as well). Signed-off-by: Sergei Shtylyov --- drivers/net/phy/phy.c

Re: [PATCH 3/4] MIPS: ath79: Add the EHCI controller and USB phy to the AR9132 dtsi

2015-09-01 Thread Sergei Shtylyov
Hello. On 09/01/2015 06:23 PM, Alban Bedel wrote: Signed-off-by: Alban Bedel --- arch/mips/boot/dts/qca/ar9132.dtsi | 24 1 file changed, 24 insertions(+) diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi index fb7734e..665ee84 1

Re: [PATCH] usb: musb: core: add common method of getting vbus status

2015-10-12 Thread Sergei Shtylyov
Hello. On 10/12/2015 05:14 PM, Roman Alyautdin wrote: Fix musb_platform_get_vbus_status return value in case of platform implementation is not defined, bringing expected behaviour of musb_platform_get wrapper. Add musb_vbus_show default method to determine VBUS status in case platform method is

Re: [PATCH] ohci-pci: use USB_DT_*

2015-10-12 Thread Sergei Shtylyov
Hello. On 10/11/2015 12:43 AM, Sergei Shtylyov wrote: Toshiba Portege 4000 quirk entry can be written shorter using the PCI_DEVICE_SUB() macro. Signed-off-by: Sergei Shtylyov Oops, wrong subject. I'll resend. :-< MBR, Sergei -- To unsubscribe from this list: send

[PATCH] ohci-pci: use PCI_DEVICE_SUB()

2015-10-12 Thread Sergei Shtylyov
Toshiba Portege 4000 quirk entry can be written shorter using the PCI_DEVICE_SUB() macro. Signed-off-by: Sergei Shtylyov --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. drivers/usb/host/ohci-pci.c |6 ++ 1 file changed, 2 i

Re: [RFC PATCH 1/2] perf: Add the flag sample_disable not to output data on samples

2015-10-13 Thread Sergei Shtylyov
Hello. On 10/12/2015 12:02 PM, Kaixu Xia wrote: In some scenarios we don't want to output trace data when sampling to reduce overhead. This patch adds the flag sample_disable to implement this function. By setting this flag and integrating with ebpf, we can control the data output process and g

Re: [PATCH v4 3/3] arm64: dts: mt8173: Add nor flash node

2015-10-13 Thread Sergei Shtylyov
Hello. On 10/13/2015 12:39 PM, Bayi Cheng wrote: Add Mediatek nor flash node Signed-off-by: Bayi Cheng --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/

Re: [RFC v2 PATCH 00/14] Implement generic IPI support mechanism

2015-10-13 Thread Sergei Shtylyov
Hello. On 10/13/2015 04:53 PM, Thomas Gleixner wrote: This series is based on Linus tree. I couldn't compile test it because MIPS compilation was broken due to other reasons. I expect some brokeness because of the introduction of struct irq_common_data which is not present on the 4.1 tree I was

Re: [PATCH v4 3/3] arm64: dts: mt8173: Add nor flash node

2015-10-14 Thread Sergei Shtylyov
Hello. On 10/14/2015 4:07 AM, Daniel Kurtz wrote: Add Mediatek nor flash node Signed-off-by: Bayi Cheng --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediate

Re: [PATCH] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
Hello. On 09/07/2015 09:15 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. So adding explicit check for NULL. Cc:

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
IS_ERR_OR_NULL() check. Cc: Giuseppe Cavallaro Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org Cc: David Miller Cc: Sergei Shtylyov Signed-off-by: Alexey Brodkin --- Changes compared to v1: * Use IS_ERR_OR_NULL() instead of discrete checks for null and err drivers/net/ethernet/stmicro

Re: [PATCH v2] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
situations we use combined IS_ERR_OR_NULL() check. Cc: Giuseppe Cavallaro Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org Cc: David Miller Cc: Sergei Shtylyov Signed-off-by: Alexey Brodkin MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH v3] stmmac: fix check for phydev being open

2015-09-08 Thread Sergei Shtylyov
check IS_ERR_OR_NULL() that covers both cases. Cc: Sergei Shtylyov Cc: Giuseppe Cavallaro Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin --- Changes compared to v2: * Updated commit message with mention of of_phy_connect() inste

Re: [PATCH v3] stmmac: fix check for phydev being open

2015-09-08 Thread Sergei Shtylyov
bined check IS_ERR_OR_NULL() that covers both cases. Cc: Sergei Shtylyov Cc: Giuseppe Cavallaro Cc: linux-kernel@vger.kernel.org Cc: sta...@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin --- Changes compared to v2: * Updated commit message with mention of of_phy_connect() inste

[PATCH 1/2] mmc: skip reclaiming host on mmc_add_card() error

2015-10-14 Thread Sergei Shtylyov
There's little sense in releasing the host on mmc_add_card() error immediately after reclaiming it, so reclaim the host only in case of success. Signed-off-by: Sergei Shtylyov --- The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch. driver

[PATCH 2/2] sd: skip reclaiming host on mmc_add_card() error

2015-10-14 Thread Sergei Shtylyov
There's little sense in releasing the host on mmc_add_card() error immediately after reclaiming it, so reclaim the host only in case of success. Signed-off-by: Sergei Shtylyov --- The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch. drive

Re: [PATCH] USB: serial: cp210x: Adding tx_empty() to avoid cp2108 failure

2015-10-16 Thread Sergei Shtylyov
Hello. On 10/16/2015 1:07 AM, Konstantin Shkolnyy wrote: Occasionally, writing data and immediately closing the port makes cp2108 stop responding. The device had to be unplugged to clear the error. The failure is induced by shutting down the device while its Tx queue still has unsent data. Repo

Re: [PATCH] net: hix5hd2_gmac: avoid integer overload warning

2015-10-16 Thread Sergei Shtylyov
On 10/16/2015 09:04 PM, Joe Perches wrote: BITS_RX_EN is an 'unsigned long' constant, so the ones complement of that has bits set that do not fit into a 32-bit variable on 64-bit architectures, which causes a harmless gcc warning: ... static void hix5hd2_port_disable(struct hix5hd2_priv *pri

Re: [PATCH v2] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall

2015-10-17 Thread Sergei Shtylyov
Hello. On 10/17/2015 3:25 AM, Leonid Yegoshin wrote: MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly set to processing aka rt_sigaction() variant only. Fixed. -- v2: Taken in account CONFIG vars interdependencies and conditional expression simplified. As a resul

Re: [PATCH] libata: add support for NCQ commands for SG interface

2015-10-17 Thread Sergei Shtylyov
Hello. On 10/17/2015 2:48 PM, vinayak.k...@gmail.com wrote: From: Vinayak Kale This patch is needed to make NCQ commands with FPDMA protocol value (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. Signed-off-by: Vinayak Kale --- drivers/ata/libata-scsi.c | 10 -- 1 fil

Re: [PATCH] ohci-pci: use PCI_DEVICE_SUB()

2015-10-17 Thread Sergei Shtylyov
On 10/17/2015 9:39 AM, Greg KH wrote: Toshiba Portege 4000 quirk entry can be written shorter using the PCI_DEVICE_SUB() macro. Signed-off-by: Sergei Shtylyov --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. drivers/usb/host/ohci-pci

Re: [PATCH] libata: add support for NCQ commands for SG interface

2015-10-17 Thread Sergei Shtylyov
On 10/17/2015 3:25 PM, Vinayak Kale wrote: From: Vinayak Kale This patch is needed to make NCQ commands with FPDMA protocol value (eg READ/WRITE FPDMA) work over SCSI Generic (SG) interface. Signed-off-by: Vinayak Kale --- drivers/ata/libata-scsi.c | 10 -- 1 file changed, 8 ins

Re: [PATCH 01/15] net: wireless: ath: use | instead of + for summing bitmasks

2015-10-21 Thread Sergei Shtylyov
Hello. On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the ath10k/pci.h file that fixes following warning pci.c, you mean? reported by coccicheck: WARNING: sum of probable bitmasks, consider | I have replaced + with OR operator | for summing bitmasks Signed-off-by: Punit

Re: [PATCH 11/15] net: wireless: iwlegacy: Remove unneeded variable ret

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the 3945-mac.c file that fixes up following warning by coccicheck: drivers/net/wireless/iwlegacy/3945-mac.c:247:5-8: Unneeded variable: "ret". Return "- EOPNOTSUPP" on line 249 Return -EOPNOTSUPP directly instead of return using ret S

Re: [PATCH 15/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 05:55 PM, Punit Vara wrote: This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded variable ret created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/ath/wcn36xx/mai

Re: [PATCH v2 05/15] net: wireless: ti: Return flow can be simplified for wl1271_cmd_interrogate

2015-10-21 Thread Sergei Shtylyov
On 10/21/2015 10:07 PM, Punit Vara wrote: Remove int ret suggested by kbuild test robot This patch is to the wlcore/acx.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified if negative or 0 value Prefer direct return value instead of writing 2-3 more sen

Re: [PATCH v3 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Sergei Shtylyov
Hello. On 10/22/2015 09:26 PM, Punit Vara wrote: This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret". Return "0" on line 1733 Remove unneccesary variable ret created to return zero. Also removed empty line suggested by Sergei Signed-off-

Re: [PATCH v4 14/15] net: wireless: ath: Remove unneeded variable ret returning 0

2015-10-22 Thread Sergei Shtylyov
On 10/22/2015 09:47 PM, Punit Vara wrote: Remove black line suggested by Sergei Such kind of comments should be under the --- tear line. This patch is to the ath5k/eeprom.c that fixes up warning caught by coccicheck: Unneeded variable: "ret". Return "0" on line 980 Remove unneeded vari

Re: of_mdiobus_register_phy() and deferred probe

2015-10-22 Thread Sergei Shtylyov
Hello. On 10/22/2015 04:31 PM, Geert Uytterhoeven wrote: Due to a probe deferral of an interrupt controller[1], the Micrel Ethernet PHY on r8a7791/koelsch started failing to get its IRQ: no irq domain found for /interrupt-controller@e61c ! However, of_mdiobus_register_phy() uses irq_

Re: [PATCH] extcon: add MAX3355 driver

2015-10-22 Thread Sergei Shtylyov
Hello. On 10/21/2015 05:57 AM, Chanwoo Choi wrote: I think this patch is too much delay. I recommend you better to develop this driver based on latest extcon-next branch[1]. [1] https://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/log/?h=extcon-next I would really appreciate if

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-02 Thread Sergei Shtylyov
Hello. On 09/02/2015 05:24 PM, Roger Quadros wrote: We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if we're in host or gadget mode and take the necessary actions dur

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Sergei Shtylyov
Hello. On 09/03/2015 05:01 PM, Roger Quadros wrote: We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if we're in host or gadget mode and take the necessary actions dur

Re: [PATCH v4 9/9] usb: dwc3: core: don't break during suspend/resume while we're dual-role

2015-09-03 Thread Sergei Shtylyov
On 09/03/2015 05:10 PM, Roger Quadros wrote: We can't rely just on dr_mode to decide if we're in host or gadget mode when we're configured as otg/dual-role. So while dr_mode is OTG, we find out from the otg state machine if we're in host or gadget mode and take the necessary actions during susp

[PATCH] fixed_phy: pass 'irq' to fixed_phy_add()

2015-09-03 Thread Sergei Shtylyov
phy_register()") Signed-off-by: Sergei Shtylyov --- The patch is against DaveM's 'net.git' repo. drivers/net/phy/fixed_phy.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net/drivers/net/phy/fixed_phy.c ==

Re: [PATCH] RDS: verify the underlying transport exists before creating a connection

2015-09-04 Thread Sergei Shtylyov
Hello. On 09/04/2015 07:43 PM, Sasha Levin wrote: There was no verification that an underlying transport exists when creating a connection, this would cause dereferencing a NULL ptr. Signed-off-by: Sasha Levin --- net/rds/connection.c |6 ++ 1 file changed, 6 insertions(+) diff --

Re: [PATCH v10 3/3] arm64: dts: mediatek: add xHCI & usb phy for mt8173

2015-10-18 Thread Sergei Shtylyov
Hello. On 10/18/2015 6:51 AM, Chunfeng Yun wrote: add xHCI and phy drivers for MT8173-EVB Signed-off-by: Chunfeng Yun [...] diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi index d18ee42..46f5f50 100644 --- a/arch/arm64/boot/dts/mediatek/mt

Re: [PATCH] net: wireless: rt2x00: statics code style

2015-10-18 Thread Sergei Shtylyov
Hello. On 10/17/2015 11:25 PM, Paul McQuade wrote: Do not initialise statics to 0 or NULL Also use tabs where possible Signed-off-by: Paul McQuade --- drivers/net/wireless/rt2x00/rt61pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/rt2x00/r

Re: [3.19.y-ckt stable] Patch "stmmac: fix check for phydev being open" has been added to staging queue

2015-10-19 Thread Sergei Shtylyov
nnect() IS_ERR() makes perfect sense. So let's use combined check IS_ERR_OR_NULL() that covers both cases. Cc: Sergei Shtylyov Cc: Giuseppe Cavallaro Cc: linux-kernel@vger.kernel.org Cc: David Miller Signed-off-by: Alexey Brodkin Signed-off-by: David S. Miller Signed-off-by: Kam

Re: [PATCH] extcon: add MAX3355 driver

2015-10-20 Thread Sergei Shtylyov
Hello. On 12/18/2014 12:58 AM, Sergei Shtylyov wrote: MAX3355E chip integrates a charge pump and comparators to enable a system with an integrated USB OTG dual-role transceiver to function as a USB OTG dual-role device. In addition to sensing/controlling Vbus, the chip also passes thru the ID

Re: [PATCH 4.1 108/159] stmmac: fix check for phydev being open

2015-10-01 Thread Sergei Shtylyov
On 10/1/2015 6:04 AM, Greg Kroah-Hartman wrote: 4.1-stable review patch. If anyone has any objections, please let me know. NAK on the same grounds as the 3.x patches. of_phy_connect() isn't called yet. If the patch has been committed already, it's OK -- it should do no harm. Yeah, it's

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Sergei Shtylyov
On 10/2/2015 1:48 PM, Neil Armstrong wrote: To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Tested-by: Andrew Lunn Tested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 delet

Re: [PATCH 1/3] net: dsa: Use devm_ prefixed allocations

2015-10-02 Thread Sergei Shtylyov
On 10/2/2015 4:30 PM, Neil Armstrong wrote: To simplify and prevent memory leakage when unbinding, use the devm_ memory allocation calls. Tested-by: Andrew Lunn Tested-by: Florian Fainelli Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Sergei Shtylyov
Hello. On 10/2/2015 3:12 PM, Mans Rullgard wrote: Some SoCs have a UART with a non-standard register layout. This allows the debug console to work with these. Signed-off-by: Mans Rullgard --- I would have preferred a more accurate description of the UART, but I've not managed to figure out

Re: [PATCH] ARM: debug: add support for alternate 8250 register layout

2015-10-02 Thread Sergei Shtylyov
On 10/2/2015 5:26 PM, Måns Rullgård wrote: Some SoCs have a UART with a non-standard register layout. This allows the debug console to work with these. Signed-off-by: Mans Rullgard --- I would have preferred a more accurate description of the UART, but I've not managed to figure out who the

Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

2015-10-03 Thread Sergei Shtylyov
Hello. On 10/3/2015 5:25 PM, Neil Armstrong wrote: To prevent memory leakage on unbinding, add missing kfree calls. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index c59fa5d..12cec40 1

Re: [PATCH v2 1/5] net: dsa: add missing kfree on remove

2015-10-03 Thread Sergei Shtylyov
On 10/3/2015 6:20 PM, Neil Armstrong wrote: On 10/3/2015 5:25 PM, Neil Armstrong wrote: To prevent memory leakage on unbinding, add missing kfree calls. Signed-off-by: Neil Armstrong --- net/dsa/dsa.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/dsa/dsa.c

[PATCH] usb: hcd: use USB_DT_*

2015-10-04 Thread Sergei Shtylyov
Fix using the bare numbers to set the 'bDescriptorType' descriptor fields while the values are #define'd in . Signed-off-by: Sergei Shtylyov --- The patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo. I's been laying around from th

[PATCH 0/8] USB: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Hello. Here's a set of 8 patches against the 'usb-next' branch of Greg KH's 'usb.git' repo. It's to eliminate the use of the PCI_DEVICE() macro where less verbose PCI_VDEVICE() should have been used. [1/8] ehci-pci: use PCI_VDEVICE() instead of PCI_DEVICE() [2/8] ohci-pci:-use-PCI_VDEVICE() i

[PATCH 1/8] ehci-pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ehci-pci.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: usb/drivers/usb/host/ehci-pci.c

[PATCH 2/8] ohci-pci:-use-PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/host/ohci-pci.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) Index: usb/drivers/usb/host/ohci-pci.c

[PATCH 3/8] chipidea: ci_hdrc_pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/chipidea/ci_hdrc_pci.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: usb/drivers/usb/chipidea/ci_hdrc_pci.c

[PATCH 4/8] dwc2: pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/dwc2/pci.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) Index: usb/drivers/usb/dwc2/pci.c

[PATCH 5/8] dwc3-pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/dwc3/dwc3-pci.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) Index: usb/drivers/usb/dwc3/dwc3-pci.c

[PATCH 6/8] amd5536udc: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/gadget/udc/amd5536udc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: usb/drivers/usb/gadget/udc/amd5536udc.c

[PATCH 7/8] pch_udc: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/gadget/udc/pch_udc.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) Index: usb/drivers/usb/gadget/udc/pch_udc.c

[PATCH 8/8] bdc_pci: use PCI_VDEVICE() instead of PCI_DEVICE()

2015-10-04 Thread Sergei Shtylyov
Fix using the PCI_DEVICE() macro instead of less verbose PCI_VDEVICE(). Signed-off-by: Sergei Shtylyov --- drivers/usb/gadget/udc/bdc/bdc_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: usb/drivers/usb/gadget/udc/bdc/bdc_pci.c

Re: [RESEND PATCH] sh: make use of for_each_node_by_type()

2018-06-25 Thread Sergei Shtylyov
Hello! On 6/25/2018 1:42 AM, Dmitry Torokhov wrote: Instead of open-coding the loop, let's use canned macro. Also make sure we are not leaking "cpus" node reference. Signed-off-by: Dmitry Torokhov Sounds/looks like a material for 2 separate patches. --- arch/sh/boards/of-generic.c

Re: [PATCH 01/14] ata: ahci-platform: add reset control support and the flag to specify using reset

2018-08-22 Thread Sergei Shtylyov
Hello! On 8/22/2018 10:36 AM, Kunihiko Hayashi wrote: Add support to get and control a list of resets for the device as optional and shared. These resets must be kept de-asserted until the device is enabled. This is specified as shared because some SoCs like UniPhier series have common reset c

Re: [PATCH 4.14 210/217] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 10:55 AM, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Sergei Shtylyov > > commit a5fb9fb023a1435f2b42bccd7f547560f3a21dc3 upstream. > > When testing the R-Ca

Re: [PATCH 4.9 124/130] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 10:54 AM, Greg Kroah-Hartman wrote: > 4.9-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Sergei Shtylyov > > commit a5fb9fb023a1435f2b42bccd7f547560f3a21dc3 upstream. > > When testing the R-Ca

Re: [PATCH 4.14 210/217] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 02:56 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 23, 2018 at 01:17:28PM +0200, Greg Kroah-Hartman wrote: >> On Thu, Aug 23, 2018 at 01:57:35PM +0300, Sergei Shtylyov wrote: >>> On 08/23/2018 10:55 AM, Greg Kroah-Hartman wrote: >>> >>>> 4.14-

Re: [PATCH 4.14 210/217] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 06:27 PM, Greg Kroah-Hartman wrote: > On Thu, Aug 23, 2018 at 06:20:31PM +0300, Sergei Shtylyov wrote: >> On 08/23/2018 02:56 PM, Greg Kroah-Hartman wrote: >>> On Thu, Aug 23, 2018 at 01:17:28PM +0200, Greg Kroah-Hartman wrote: >>>> On Thu, Aug 23, 20

Re: [PATCH 4.14 210/217] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 06:41 PM, Greg Kroah-Hartman wrote: >>>>>>>> 4.14-stable review patch. If anyone has any objections, please let me >>>>>>>> know. >>>>>>>> >>>>>>>> -- >>&g

[PATCH 4.14.y] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
quot;) Signed-off-by: Sergei Shtylyov [lorenzo.pieral...@arm.com: split commit/updated the commit log] Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Reviewed-by: Linus Walleij --- drivers/pci/host/pci-host-common.c |2 - drivers/pci/host/pcie-rcar.c |2

[PATCH 4.9.y] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
quot;) Signed-off-by: Sergei Shtylyov [lorenzo.pieral...@arm.com: split commit/updated the commit log] Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Reviewed-by: Linus Walleij --- drivers/pci/host/pci-host-common.c |2 - drivers/pci/host/pcie-rcar.c |2

Re: [PATCH 4.9.y] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
On 08/23/2018 11:04 PM, Sergei Shtylyov wrote: > Commit a5fb9fb023a1435f2b42bccd7f547560f3a21dc3 upstream. > > When testing the R-Car PCIe driver on the Condor board, if the PCIe PHY > driver was left disabled, the kernel crashed with this BUG: > > kernel BUG at lib/ioremap.

[PATCH v2 4.9.y] PCI: OF: Fix I/O space page leak

2018-08-23 Thread Sergei Shtylyov
quot;) Signed-off-by: Sergei Shtylyov [lorenzo.pieral...@arm.com: split commit/updated the commit log] Signed-off-by: Lorenzo Pieralisi Signed-off-by: Bjorn Helgaas Reviewed-by: Linus Walleij --- drivers/pci/host/pci-host-common.c |2 - drivers/pci/host/pcie-rcar.c |2

Re: [PATCH v2 17/17] MIPS: JZ4740: DTS: Add DMA nodes

2018-07-19 Thread Sergei Shtylyov
On 7/18/2018 9:20 PM, Paul Cercueil wrote: Add the devicetree nodes for the DMA core of the JZ4740 SoC, disabled by default, as currently there are no clients for the DMA driver (until the MMC driver and/or others get a devicetree node). Signed-off-by: Paul Cercueil Tested-by: Mathieu Malaterr

Re: [PATCH v2 16/17] MIPS: JZ4770: DTS: Add DMA nodes

2018-07-19 Thread Sergei Shtylyov
On 7/18/2018 9:20 PM, Paul Cercueil wrote: Add the two devicetree nodes for the two DMA cores of the JZ4770 SoC, disabled by default, as currently there are no clients for the DMA driver (until the MMC driver and/or others get a devicetree node). Signed-off-by: Paul Cercueil Tested-by: Mathieu

Re: [PATCH] mtd: solutionengine.c: fix printk format warnings

2018-07-22 Thread Sergei Shtylyov
Hello! On 7/21/2018 10:37 PM, Randy Dunlap wrote: From: Randy Dunlap Fix 2 printk format warnings (this driver is currently SUPERH only) by using "%pap" instead of "%lx". (or we could just cast the physical addresses to unsigned int) Fixes these build warnings: ../drivers/mtd/maps/solutione

Re: [PATCH 1/4] docs: bpf: Rename README.rst to index.rst

2018-07-25 Thread Sergei Shtylyov
Hello! On 7/25/2018 5:29 AM, Tobin C. Harding wrote: Recently bpf/ docs were converted to us RST format. 'README.rst' was s/us/use/? created but in order to fit in with the Sphinx build system this file should be named 'index.rst'. Rename file, fixes to integrate into Sphinx build syst

Re: [PATCH 1/3] ata: Allow having a port recovery callback

2018-01-10 Thread Sergei Shtylyov
Hello! On 01/10/2018 02:04 AM, Florian Fainelli wrote: Some AHCI controllers may need to recovery from a failure to identify a drive, Recover. such as the Broadcom AHCI controller, make that possible at both the libata-core.c and AHCI controller level such that we can provide such an err

Re: [PATCH v8 04/11] ARM: dts: r7s72100: Add Capture Engine Unit (CEU)

2018-01-31 Thread Sergei Shtylyov
Hello! On 1/30/2018 12:58 PM, Jacopo Mondi wrote: Add Capture Engine Unit (CEU) node to device tree. Signed-off-by: Jacopo Mondi Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Acked-by: Hans Verkuil --- arch/arm/boot/dts/r7s72100.dtsi | 15 --- 1 file changed,

Re: [PATCH 09/18] p54: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:10 AM, Dan Williams wrote: Static analysis reports that 'queue' may be a user controlled value that is used as a data dependency to read from the 'priv->qos_params' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stre

Re: [PATCH 08/18] carl9170: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
Hello! On 1/6/2018 4:10 AM, Dan Williams wrote: Static analysis reports that 'queue' may be a user controlled value that is used as a data dependency to read from the 'ar9170_qmap' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction s

Re: [PATCH 13/18] ipv6: prevent bounds-check bypass via speculative execution

2018-01-06 Thread Sergei Shtylyov
On 1/6/2018 4:11 AM, Dan Williams wrote: Static analysis reports that 'offset' may be a user controlled value that is used as a data dependency reading from a raw6_frag_vec buffer. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stream th

<    3   4   5   6   7   8   9   10   11   12   >