On Thu, 12 Jul 2007, Andrew Morton wrote:
> On Tue, 10 Jul 2007 06:33:26 -0400 (EDT)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> >
> > Allow individual architectures to override a small set of macros
> > before including asm-generic/ioctl.h, i
On Fri, 13 Jul 2007, Christoph Hellwig wrote:
> On Tue, Jul 10, 2007 at 06:33:26AM -0400, Robert P. J. Day wrote:
> > + * Let any architecture override either of the following before
> > + * including this file.
> > + */
> > +
> > +#ifndef _IOC_SIZEBITS
&
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
given the application of the patch for the enhanced
header file I submitted yesterday, this would be
a patch against the MIPS ioctl.h file to shorter it considerably.
similar trivial patches would be available for alpha, pari
Convert old/obsolete NORET_TYPE and ATTRIB_NORET macros to use the
newer standard of "__noreturn" as defined in compiler-gcc.h.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
since there were a number of these old macros under the MIPS
directory alone, i thought it
On Fri, 25 May 2007, H. Peter Anvin wrote:
> Robert P. J. Day wrote:
> > Convert old/obsolete NORET_TYPE and ATTRIB_NORET macros to use the
> > newer standard of "__noreturn" as defined in compiler-gcc.h.
> >
> > Signed-off-by: Robert P. J. Day <[
On Sat, 26 May 2007, Satyam Sharma wrote:
> Hi Robert,
>
> On 5/25/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > On Fri, 25 May 2007, Satyam Sharma wrote:
> > ...
> > > 1. If this is a function _declaration_ (i.e. a prototype in some
> > > header
On Fri, 25 May 2007, H. Peter Anvin wrote:
> Robert P. J. Day wrote:
> >
> >
> > f() __attribute__((noreturn)) ;
> >
> > you get:
> >
> > warning: data definition has no type or storage class
> >
> > but gcc doesn't complain i
On Fri, 25 May 2007, H. Peter Anvin wrote:
> Robert P. J. Day wrote:
> >
> >
> > f() __attribute__((noreturn)) ;
> >
> > you get:
> >
> > warning: data definition has no type or storage class
> >
> > but gcc doesn't complain i
Remove a clearly useless reference to the obsolete MODULE_PARM macro.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
given that that macro call is enclosed within an obsolete
"__MODULE__" check, i have to assume that snippet of code can be
safely removed.
diff --git
* 13 CONFIG_FORCED_INLINING
* 14 kernel_thread()
which of the above are legitimate candidates for removal? which are
already underway in someone's local tree? anything else that can
be added? etc, etc.
rday
--
========
Robert P. J.
On Mon, 28 May 2007, Oliver Pinter wrote:
> + open sound system
yeah, that one's so obvious, i don't even list it anymore. :-) i'm
assuming adrian's going to deal with that when the time comes.
rday
--
==============
On Mon, 28 May 2007, Jan Engelhardt wrote:
>
> On May 28 2007 16:15, Robert P. J. Day wrote:
> >removing dead content from the tree:
> >
> >http://fsdev.net/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
> >
> >currently, the list contains the it
On Mon, 28 May 2007, Robert P. J. Day wrote:
> On Mon, 28 May 2007, Jan Engelhardt wrote:
>
> >
> > On May 28 2007 16:15, Robert P. J. Day wrote:
> > >removing dead content from the tree:
> > >
> > >http://fsdev.net/wiki/index.php?title=Kernel_Janitor
On Tue, 29 May 2007, Jan Engelhardt wrote:
>
> On May 28 2007 18:25, Robert P. J. Day wrote:
> >On Mon, 28 May 2007, Jan Engelhardt wrote:
>
> >> >currently, the list contains the items:
> >> >
> >> >* 4 Traffic policing
> >>
Delete the apparently unused array "int dummy[5]" from struct
inodes_stat_t.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
no idea what that array is for, but no one seems to care about it.
removal compile-tested on x86 with "make allyesconfig" and nob
On Tue, 29 May 2007, Andrew Morton wrote:
> On Tue, 29 May 2007 13:11:07 -0400 (EDT)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> >
> > Delete the apparently unused array "int dummy[5]" from struct
> > inodes_stat_t.
>
On Tue, 29 May 2007, Randy Dunlap wrote:
> On Tue, 29 May 2007 14:07:01 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Tue, 29 May 2007, Andrew Morton wrote:
> >
> > > kernel/sysctl.c:
> > >
> > > {
> > > .ctl_name = FS_STA
On Tue, 29 May 2007, David Miller wrote:
> From: "Robert P. J. Day" <[EMAIL PROTECTED]>
> Date: Wed, 2 May 2007 17:15:01 -0400 (EDT)
>
> >
> > again, this list contains some CONFIG_ variables that aren't
> > technically dead, but *really* shoul
On Wed, 30 May 2007, Adrian Bunk wrote:
> On Wed, May 30, 2007 at 08:41:56AM +0200, Stefan Richter wrote:
> > From: Stefan Richter <[EMAIL PROTECTED]>
> > Subject: fs: clarify "dummy" member in struct inodes_stat_t
> >
> > Found by Robert P. J. Day: T
ate a writable file. but that's just
me.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
==
"Kernel message".
that doesn't tell anyone what you're actually asking about.
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario,
ot subject to
> different compilers), I think the preferred form is plain
> `attribute'.
compiler-gcc.h also defines the common form of the shortcut:
#define __aligned(x)__attribute__((aligned(x)))
rday
--
==
meone at
least recalibrate their removal dates and update that file?
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main
Replace worthless comments with actual preprocessor errors when
including the wrong versions of the compiler.h files.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
include/linux/compiler-gcc.h |4 +++-
include/linux/compiler-gcc3.h |4 +++-
include/linux/compiler-
and this stuff should be
> simply deleted.
that header file is included only by drivers/serial/dz.c, whose
Kconfig controlling setting is:
config SERIAL_DZ
bool "DECstation DZ serial driver"
...
so, since it's "bool," there's no way "#ifd
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
given that the entire contents of include/linux/tty.h is contained
within an "#ifdef __KERNEL__", it seems pointless to export it to
userspace, unless there's some kind of need for that header file to
exist in us
a while back, i threw together this wiki page:
http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed
feel free to comment.
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo
On Wed, 18 Jul 2007, Clemens Koller wrote:
> Robert P. J. Day schrieb:
> >a while back, i threw together this wiki page:
> >
> > http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed
> >
> > feel free to comment.
>
> Won't miss anything there.
On Wed, 18 Jul 2007, Jesper Juhl wrote:
> On 18/07/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> >
> >a while back, i threw together this wiki page:
> >
> > http://fsdev.net/wiki/index.php?title=Stuff_to_be_removed
> >
> > feel free
ll be
done automatically.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsub
On Wed, 18 Jul 2007, Jiri Slaby wrote:
> Robert P. J. Day napsal(a):
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> >
> > ---
> >
> > given that the entire contents of include/linux/tty.h is contained
> > within an "#ifdef __KERNEL__&
On Wed, 18 Jul 2007, Randy Dunlap wrote:
> On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Wed, 18 Jul 2007, Gabriel C wrote:
> >
> > > Everything 'depends on' EXPERIMENTAL should be marked as such,
> > > visible in the menu
On Wed, 18 Jul 2007, Jeff Garzik wrote:
> Randy Dunlap wrote:
> > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
> > > there's no point adding all that redundant content when it can all be
> > > done automatically.
> >
> > I like i
On Wed, 18 Jul 2007, Adrian Bunk wrote:
> On Wed, Jul 18, 2007 at 04:51:33PM -0400, Robert P. J. Day wrote:
> > On Wed, 18 Jul 2007, Jeff Garzik wrote:
> >
> > > Randy Dunlap wrote:
> > > > On Wed, 18 Jul 2007 16:23:09 -0400 (EDT) Robert P. J. Day wrote:
> &
me
to make a choice.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
at this point, i've really given up caring about it. if
someone wants to do this, have at it. i have better things to do than
to keep suggesting it and getting nowhere with it.
rday
--
================
Robert P. J. Day Linux Consulting, Tr
On Thu, 19 Jul 2007, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> >
> > ...
> >> I would consider it more ugly to special case this and that in the
> >> kconfig code when plain dependencies already of
ude
#include
#include
-#include
struct semaphore {
atomic_t count;
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/
On Thu, 19 Jul 2007, Robert P. J. Day wrote:
blah blah ...
once upon a time, i *did* scan the source tree to verify that any
source file that used a R/W semaphore did, in fact, include the
rwsem.h file, and i found only one file that needed tweaking:
commit
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
steve walks warily down the street with the brim pulled way down low
...
diff --git a/fs/ncpfs/ncplib_kernel.c b/fs/ncpfs/ncplib_kernel.c
index 551e0ba..df6d60b 100644
--- a/fs/ncpfs/ncplib_kernel.c
+++ b/fs/ncpfs/ncplib_ke
On Thu, 19 Jul 2007, Karel Zak wrote:
> On Wed, Jul 18, 2007 at 04:33:12PM -0400, Robert P. J. Day wrote:
> > On Wed, 18 Jul 2007, Jiri Slaby wrote:
> >
> > > Robert P. J. Day napsal(a):
> > > > given that the entire contents of include/linux/tty.h is
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
what subsystem would something like this belong to?
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 691a174..fd67da8 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -5,6 +5,10 @@
* 'tty.h&#x
ere in the tree. so does that mean
this feature can be tossed? or might it still be used every so often?
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://
On Thu, 19 Jul 2007, Christoph Hellwig wrote:
> On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote:
> > so you're saying you'll drop that include from util-linux, is that
> > it? but it's still a good plan to generate a warning whenever
> > u
On Thu, 19 Jul 2007, Arjan van de Ven wrote:
> Stefan Richter wrote:
> > Robert P. J. Day wrote:
> > ...
> > > it's not clear if that means that it was a *one-time* transition
> > > aid which is now unnecessary, or whether it's an *ongoing* aid which
On Thu, 19 Jul 2007, Stefan Richter wrote:
> Robert P. J. Day wrote:
> ...
> > it's not clear if that means that it was a *one-time* transition
> > aid which is now unnecessary, or whether it's an *ongoing* aid which
> > might be used at any time. curr
On Thu, 19 Jul 2007, Jiri Slaby wrote:
> Christoph Hellwig napsal(a):
> > On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote:
> >> so you're saying you'll drop that include from util-linux, is
> >> that it? but it's still a good plan to
On Thu, 19 Jul 2007, Randy Dunlap wrote:
> On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote:
>
> > On Thu, 19 Jul 2007, Stefan Richter wrote:
> >
> > > Robert P. J. Day wrote:
> > > > On Thu, 19 Jul 2007, Adrian Bunk wrote:
> > > >
rday
--
====
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: send the line "unsubscribe l
is included if MODULE *is*
defined. unless i've misread something.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
On Sat, 12 May 2007, Antonino A. Daplas wrote:
> On Sat, 2007-05-12 at 06:32 -0400, Robert P. J. Day wrote:
> > i'm guessing someone's already spotted this but, with "make
> > allyesconfig" on x86:
> >
> > ...
> > LD .tmp_vml
cial about that module? just curious.
rday
--
========
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title
On Sun, 13 May 2007, James Bottomley wrote:
> On Sun, 2007-05-13 at 12:06 -0400, Dave Jones wrote:
> > On Sun, May 13, 2007 at 11:22:55AM -0400, Robert P. J. Day wrote:
> > >
> > > not a big deal, but is there a reason that a "make defconfig" on my
&g
On Sun, 13 May 2007, James Bottomley wrote:
> On Sun, 2007-05-13 at 12:20 -0400, Robert P. J. Day wrote:
> > since this thread looks like it's going to get away from me in a
> > hurry :-), my only point in asking was to point out that that lone
> > module was the only
-- the fact that the raw driver is currently listed as
"obsolete" when it is, in fact, only deprecated.
in short, do *not* remove its "deprecated" status. rather, remove its
"obsolete" status and *make* it deprecated.
rday
--
s, deprecated features are *not*
possible candidates for removal, but obsolete features *are*. that's
why raw drivers are deprecated, not obsolete.
--
r basis, continue to submit patches to remove things that claim
to be "obsolete" but which aren't, and this whole freakin' debate will
start all over again.
happy now?
rday
--
Robert
who's been
following this thread knows *exactly* what those two words are being
proposed to represent. what's happening is that they don't *like*
that proposed usage.
quite simply, there is no confusion here, there is simply annoying
obstinacy. there's a difference.
rday
--
Remove the apparently unreferenced header file
include/linux/mtd/jedec.h.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
this header file *appears* to be unnecessary, but i've been wrong
before.
diff --git a/include/linux/mtd/jedec.h b/include/linux/mtd/jedec.h
delete
Remove the few remaining traces of the interrupt-related "SA_" flags,
which were scheduled for official deletion in September of 2007,
anyway.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
there's little point in leaving this cruft in the tree since there
were
Remove the last two instances of the interrupt-related "SA_" flags
from the tree, but leave the support for out-of-tree modules until the
scheduled removal date of September 2007.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
drivers/misc/tifm_7xx1.c |2
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main
Fix the obvious errors in the explanation of Kconfig files.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
index afc2867..444141e 100644
--- a/Documentation/CodingStyle
+++ b/Documentation/CodingStyle
@@ -
onger definition.
i'll post a patch for that shortly.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.n
Replace the few occurrences of, and the macro definition of,
"__attribute_pure__" with the shorter "__pure", to be more consistent
with the other abbreviations in include/linux/compiler-gcc.h.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
given that the
Given that all of the actual code references to "driverfs" have been
replaced with "sysfs," replace the few remaining comment references
just to be consistent.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Documentation/pnp.txt |4 ++--
ent.
rday
--
========
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: sen
define MACH COBALT
# else
#define MACH PC
# endif
never evaluates to true, therefore making
fairly useless, at least under the circumstances.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kern
On Sun, 3 Jun 2007, Randy Dunlap wrote:
> On Sun, 3 Jun 2007 13:17:48 -0400 (EDT) Robert P. J. Day wrote:
>
> >
> > (no one's listed as the official cobalt maintainer so i thought i'd
> > just throw this out there.)
> >
> > there is no Kc
(CCed) patch "Add Cobalt Networks support to
> > nvram driver". Which added this to drivers/cobalt:
> >
> > +bool 'Support for Cobalt Networks x86 servers' CONFIG_COBALT
> >
> > I guess Tim can clear up what's intended...
ok, that sounds
ortly and you can pass judgment.
rday
--
========
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?ti
Drop all references to the COBALT arch from drivers/char/nvram.c.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/char/nvram.c b/drivers/char/nvram.c
index 204deaa..98dec38 100644
--- a/drivers/char/nvram.c
+++ b/drivers/char/nvram.c
@@ -42,19 +42,12 @@
#
Remove the "#if 0"ed definition of apm_get_battery_status().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
Acked-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
diff --git a/arch/i386/kernel/apm.c b/arch/i386/kernel/apm.c
index 4112afe..5c6da2b 100644
--- a/arch/i386/k
On Mon, 4 Jun 2007, Christoph Lameter wrote:
> On Sun, 3 Jun 2007, Robert P. J. Day wrote:
>
> > first, can a call to __get_free_pages to allocate DMA-able
> > memory omit specifying either of GFP_KERNEL or GFP_ATOMIC?
> > love's book on kernel development
On Mon, 4 Jun 2007, Christoph Lameter wrote:
> On Mon, 4 Jun 2007, Robert P. J. Day wrote:
>
> > all right, then some of those __get_free_pages() calls would translate
> > to calls of the form __get_dma_pages(0, ...) -- is that what you're
> > saying? or would it be
Replace the call to __get_free_pages() with the more specific
__get_dma_pages().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index 8ff2fea..108e7df 100644
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel
Replace a number of calls to __get_free_pages() with the corresponding
calls to __get_dma_pages().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
once the __GFP_DMA argument is removed, it does look weird to see
the first argument of just 0. should that be filled in with
GFP_
Replace a couple calls to __get_free_pages() with the corresponding
calls to __get_dma_pages().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
that's the lot of them.
diff --git a/lib/swiotlb.c b/lib/swiotlb.c
index 10c13ad..8fc38dc 100644
--- a/lib/swiotlb.c
+++ b/li
On Tue, 5 Jun 2007, Andrew Morton wrote:
> On Tue, 5 Jun 2007 16:58:57 -0400 (EDT)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> > Replace a couple calls to __get_free_pages() with the corresponding
> > calls to __get_dma_pages().
> >
> >
On Tue, 5 Jun 2007, Andrew Morton wrote:
> On Tue, 5 Jun 2007 16:58:57 -0400 (EDT)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> > Replace a couple calls to __get_free_pages() with the corresponding
> > calls to __get_dma_pages().
> >
> >
sonable, i'll go with that.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
===
, this was just a mindless grep, but you get the idea. the
actual macro definition can be left in gfp.h for a while to
accommodate out-of-tree builds for now.
rday
--
====
Robert P. J. Day
Linux Consulting, Training and Annoying
sistent usage of all of the above.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To u
torical cruft?
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: send the line "uns
On Thu, 7 Jun 2007, Nick Piggin wrote:
> Robert P. J. Day wrote:
> > probably making a fool of myself here, but what is the purpose of
> > that single argument to the macro "ZERO_PAGE"?
> >
> > $ grep -r "define ZERO_PAGE" include
> &
On Thu, 7 Jun 2007, Satyam Sharma wrote:
> On 6/7/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > On Thu, 7 Jun 2007, Nick Piggin wrote:
> >
> > > Robert P. J. Day wrote:
> > > > probably making a fool of myself here, but what is the purpose of
*alternative* to those other header
files?
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
never send a comment to do a preprocessor directive's job.
(note: no one's actually doing this, so this shouldn't break any
builds.)
include/linux/compiler-gcc.h |4 +++-
include/linux/compiler-gcc3.h
On Thu, 7 Jun 2007, H. Peter Anvin wrote:
> William Lee Irwin III wrote:
> > Robert P. J. Day wrote:
> >>> although it's not clear where in the source tree are the invocations
> >>> that would actually make a difference to a MIPS system, which is why
>
as i learned when i first ran across this on my fedora core system.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
Prevent from being included more than once,
otherwise you get a redefinition error if you happen to include
first.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
any chance of pushing this one through expeditiously?
diff --git a/include/linux/console_struct.h b/include
only \
this definition or declaration, which is probably not what you want
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
i'm *guessing* this is the solution to the above issue.
diff --git a/include/linux/tty_driver.h b/include/linux/tty_driver.h
index 85c95cd..b68
he termbits.h header, i get the
aforementioned error. beyond that, i'm unclear on what you're asking.
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wi
ion/declaration that exists in another
header file, it should include that other header file. any other
approach is wrong.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ont
m
:
struct tty_driver {
...
struct ktermios init_termios; /* Initial termios */
...
doesn't this suggest that you better have a definition of that
ktermios struct before this point?
rday
--
Robert
On Fri, 8 Jun 2007, Alan Cox wrote:
> On Fri, 8 Jun 2007 09:29:12 -0400 (EDT)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
>
> > The header file should include
> > to pick up the definition of "struct ktermios";
> > otherwise, you run the
but suggesting that it's
going to result in "a mass of unresolvable dependancy loops" is sheer
laziness.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario,
inful. The tty headers and
> the scheduler headers are particularly problematic for getting
> tangled.
ok, i'll defer to your experience. but can we at least apply my patch
to protect console_struct.h from multiple inclusion? that one really
*is* annoying.
rday
--
=======
param_get_bool, &nousb, 0444);
one has to wonder about the value of a macro that is invoked only
once throughout the entire tree.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo,
ore,
> then revert all this if not. Or, we can add a name somehow and live
> with it visible in sysfs...
there appears to be no reference to "nousbstorage" anywhere in the
tree. go for it.
rday
--
501 - 600 of 924 matches
Mail list logo
