On Fri, 8 Jun 2007, Alan Cox wrote: > > i don't see how fixing the C file solves this issue. the header > > file <linux/tty_driver.h> clearly refers to "struct ktermios", for > > which it won't have a definition unless it includes > > <asm/termbits.h>. > > Anyone using tty stuff will include <linux/tty.h> to get all the > stuff needed an that includes asm/termios.h which includes > asm/termbits.h
that may well be, but i don't think counting on the choice or order of header file inclusions represents a really robust approach to software design. if a header file needs a definition/declaration that exists in another header file, it should include that other header file. any other approach is wrong. rday -- ======================================================================== Robert P. J. Day Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA http://fsdev.net/wiki/index.php?title=Main_Page ======================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
