Since quota.h declares a R/W semaphore, it should include rwsem.h
explicitly.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
No, this doesn't fix an *existing* problem, but it's necessary for
an upcoming patch which will remove all includes of
from all the s
a
couple patches to start the process, but it never really went
anywhere.
rday
--
====
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=
Remove the final vestiges of the kernel config option DEBUG_RWSEMS,
since it has no value, at least at the moment.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
my apologies for pushing this so high up the food chain, but i want
to submit another patch that sits *right* n
as an aside, rather than have to implement this with two Kconfig
features, it might even be worth creating a whole new feature,
something like "submenuconfig" or whatever, that does all this
automatically.)
thoughts?
rday
--
=========
Remove all inclusions of "linux/rwsem.h" from the standard semaphore
header files, since anyone who needs R/W semaphores should be
including that header file directly.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
it *seems* fairly obvious that the nume
Standardize on "depends on" in Kconfig files, and drop support for
the alternative forms of "depends" or "requires".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
there was a consensus to standardize exclusively on the qualifier
"depends o
ions
*can't* be a good thing.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
-
To unsubscribe from this list: sen
change.
> >
> Yes, but is it meant to state that 'size' is not a power of two?
> Otherwise, imho, it should be left as-is.
i think the above change is fine. as long as the final, overall
semantics of the condition are identical, then there's no problem.
rday
--
=
t is_power_of_2() should be fixed up first
> and then we can see about it.
there's nothing about is_power_of_2() that needs "fixing". it's
correct as it's currently implemented.
> And as I stated before; !is_power_of_2(size) != (size & (size-1))!
> It may be a bug but then we have to be sure it is s
Remove the long-obsolete "raw device" support.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
based on this excerpt from
Documentation/feature-removal-schedule.txt:
What: RAW driver (CONFIG_RAW_DRIVER)
When: December 2005
Why:declared obsolete si
Add two new maturity levels of DEPRECATED and OBSOLETE to the kbuild
structure.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
one more time, i'll see if i can get this into the main tree, since
previous attempts just seem to disappear into the void, even though
sev
On Sun, 18 Feb 2007, Bartlomiej Zolnierkiewicz wrote:
> Hi,
>
> Would it be possible to get this patch merged
> (or at least DEPRECATED part of it)?
>
> I think that the patch is useful and that the distinction between
> DEPRECATED and OBSOLETE options is quite clear:
>
> * DEPRECATED == new bette
bsolete means dead/unsupported/use at own risk. might still work but
no guarantees and could be removed at any time.
rday
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Wa
t now* and you should consider switching to it.
if you can't offer someone a completely functional, better alternative
to what they're using now, then you can't say that what they're using
now is deprecated.
rday
--
==
On Tue, 20 Feb 2007, Sam Ravnborg wrote:
> On Tue, Feb 20, 2007 at 05:47:43PM -0500, Robert P. J. Day wrote:
> > in a nutshell, my idea of deprecated is: perhaps still supported,
> > still being used, but there is a better alternative available right
> > now and you should
tion/feature-removal-schedule.txt for
+ any proposed removal dates.
+
config BROKEN
bool
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Onta
On Wed, 21 Feb 2007, Tilman Schmidt wrote:
> Am 20.02.2007 23:52 schrieb Robert P. J. Day:
> > "deprecated" means that there *is* a complete replacement available
> > *right now* and you should consider switching to it.
> >
> > if you can't off
On Thu, 25 Jan 2007, Andrew Morton wrote:
> On Thu, 25 Jan 2007 04:32:12 -0500 (EST)
> "Robert P. J. Day" <[EMAIL PROTECTED]> wrote:
> > +/*
> > + * round down to nearest power of two
> > + */
> > +static inline __attribute__((const))
> > +
Remove the sole remaining reference to the apparently dead config
variable CONFIG_UNWIND_INFO.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
there doesn't seem to be much point in leaving this in if nothing's
using it.
diff --git a/include/asm-i386/dwarf2.h b/
On Fri, 26 Jan 2007, Alexey Dobriyan wrote:
> On Fri, Jan 26, 2007 at 01:06:39PM -0500, Robert P. J. Day wrote:
> > Remove the sole remaining reference to the apparently dead config
> > variable CONFIG_UNWIND_INFO.
>
> Regardless of unwinder future, patch doesn't up
Replace the apparent typo CONFIG_ACPI_DEBUG_OUTPUT with
the non-Kconfig conditional ACPI_DEBUG_OUTPUT, which is what every
other file uses.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index 698a154..d65142a 100644
Replace the apparent typo CONFIG_LOCKDEP_DEBUG with the correct
CONFIG_DEBUG_LOCKDEP.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/kernel/lockdep_proc.c b/kernel/lockdep_proc.c
index b554b40..78381a6 100644
--- a/kernel/lockdep_proc.c
+++ b/kernel/lockdep_
l-encompassing
CONFIG_OMAP16XX confguration setting.
--
================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/
Rename some of the debugging macros for ISDN AVM so that they don't
resemble kernel config settings, as they're primarily for author
debugging instead.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Replace the "CONFIG_" prefix with an "AVM_" pr
Replace misspelled CONFIG_HISAX_QUADRO with CONFIG_HISAX_SCT_QUADRO.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index 17ec0b7..29e98f7 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn
Remove a couple kernel config variables (FS_POSIX_CAP and
FS_POSIX_MAC) that represent placeholders for unimplemented
functionality.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
compile-tested on i386.
fs/xfs/xfs_cap.h | 15 ---
fs/xfs/xfs_mac.h
On Sun, 28 Jan 2007, Eric Sandeen wrote:
> Robert P. J. Day wrote:
> > Remove a couple kernel config variables (FS_POSIX_CAP and
> > FS_POSIX_MAC) that represent placeholders for unimplemented
> > functionality.
> >
> > Signed-off-by: R
tainer, as you can
see by the suffix "_DEBUG". but if that's the case, it's my feeling
that macros like that should *not* start with the "CONFIG_" prefix,
which should be reserved for user-configurable selections only.
but that's just my $0.02.
rday
--
==
Add the inline function "is_power_of_2()" to log2.h, where the value
zero is *not* considered to be a power of two.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
while people are coming up with more and more clever ways to do
rounding, we can at least add the chec
On Tue, 30 Jan 2007, Nick Piggin wrote:
> Robert P. J. Day wrote:
> > Add the inline function "is_power_of_2()" to log2.h, where the value
> > zero is *not* considered to be a power of two.
>
> >
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]&g
nd third macros *won't* consider zero a power of
two, while the second one *will*. hence the need for a single
standard for all of this, just to play it safe.
rday
p.s. in case you missed it, that was a not-so-subtle plea to please
just apply this patch so we can move on.
--
==========
On Tue, 30 Jan 2007, Jan Engelhardt wrote:
>
> On Jan 30 2007 09:45, Robert P. J. Day wrote:
> >seriously, though, there is the potential of breaking something with
> >this change since you can see how there is some inconsistency in how
> >it's done *now* just for
On Wed, 31 Jan 2007, Nick Piggin wrote:
> Robert P. J. Day wrote:
> > On Tue, 30 Jan 2007, Nick Piggin wrote:
> >
> >
> > > Robert P. J. Day wrote:
> > >
> > > > Add the inline function "is_power_of_2()" to log2.h, where th
it as a
project for the kernel janitors, they might not realize what you had
in mind. so it's in your best interest to start cleaning this up on
your own.
just my $0.02 (Cdn.)
rday
--
Robert P. J. Day
Linux Consulting, Training and Annoy
Centralize the kernel config option for debugging semaphores and
modify the macro for frv to use that config option instead.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
at the moment, two architectures have support for debugging
semaphores: alpha (with a local Kconfig
On Wed, 31 Jan 2007, Michal Piotrowski wrote:
> On 31/01/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> >
> > Centralize the kernel config option for debugging semaphores and
> > modify the macro for frv to use that config option instead.
> >
> >
On Wed, 31 Jan 2007, Michal Piotrowski wrote:
> On 31/01/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > On Wed, 31 Jan 2007, Michal Piotrowski wrote:
> >
> > > On 31/01/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > > >
> > &
On Wed, 31 Jan 2007, Chuck Ebbert wrote:
> Robert P. J. Day wrote:
> > Replace apparent typo of CONFIG_MT_SMP with CONFIG_MIPS_MT_SMP.
> >
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> >
> > ---
> >
> > diff --git a/arch/mips/mips-
On Thu, 1 Feb 2007, David Howells wrote:
>
> Robert P. J. Day <[EMAIL PROTECTED]> wrote:
>
> > +#define is_power_of_4(x) is_power_of_2(x) && (ffs(x) & 1))
>
> If this is such a commonly implemented op, it should probably be implemented
> globally t
Fix misspelled "spin_lock_irqrestore" to read
"spin_unlock_irqrestore" instead.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index 4c698a7..25f7cf4 100644
--- a/drivers/scsi/gdth.c
+++ b/drivers/scsi
For Sparc, PPC and CRIS, replace declarations of an array of
SPIN_LOCK_UNLOCKED with an array of __RAW_SPIN_LOCK_UNLOCKED.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
given that the macro SPIN_LOCK_UNLOCKED is deprecated in favour of
the named version of spin locks, it
g. If you want networking, use "init 3."
> +* Boot parameter "1" boots the dump-capture kernel into single-user mode
> + without networking. If you want networking, use "3".
i'm not sure you want to totally remove those first two lines, they
appear to talk
. More precisely, any arguments that could not be parsed (because
> the kernel does not know them) are handed down to the init program
> as arguments and/or environment variables.
whoops, ignore my last post, i misread the critical words.
rday
--
==
way, you get the idea. have at it.
rday
--
============
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamh
Rename the incorrect macro name "REISERFS_PROC_INFO" to
"CONFIG_REISERFS_PROC_INFO".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
what the heck ... might as well patch the ones i found.
diff --git a/fs/reiserfs/procfs.c b/fs/reiserfs/procfs.c
index ecc
Rename the incorrect macro name "NR_CPUS" to "CONFIG_NR_CPUS".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 4381469..e6bf4b9 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -70,
On Fri, 2 Feb 2007, Robert P. J. Day wrote:
>
> Rename the incorrect macro name "NR_CPUS" to "CONFIG_NR_CPUS".
>
> Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
ACK!! ignore, ignore! duh.
rday
--
==========
Rename the (apparently) incorrect macro name WIRELESS_EXT to
CONFIG_WIRELESS_EXT.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
this one i'm not sure about since there really is a WIRELESS_EXT
macro defined in the header file:
include/linux/wireless.h:#define WIRE
Replace the apparently incorrect macro name "NTFS_DEBUG" with
"CONFIG_NTFS_DEBUG".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/fs/ntfs/attrib.c b/fs/ntfs/attrib.c
index c577d8e..2154d03 100644
--- a/fs/ntfs/attrib.c
+++ b/fs/ntfs/attrib.c
On Fri, 2 Feb 2007, Alexey Dobriyan wrote:
> On 2/2/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > Rename the incorrect macro name "REISERFS_PROC_INFO" to
> > "CONFIG_REISERFS_PROC_INFO".
>
> It isn't incorrect. It's setup in reis
On Fri, 2 Feb 2007, Anton Altaparmakov wrote:
> Hi,
>
> On Fri, 2007-02-02 at 05:46 -0500, Robert P. J. Day wrote:
> > Replace the apparently incorrect macro name "NTFS_DEBUG" with
> > "CONFIG_NTFS_DEBUG".
> >
> > Signed-off-by: Robert P
In addition to EXPERIMENTAL and BROKEN, define the maturity level
options DEPRECATED and OBSOLETE.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
we'd discussed this a while back but nothing seemed to be finalized
one way or the other so, as a followup to the exchange
since no one (at least, no one in the current tree)
uses FIELD_SIZEOF as it is, so it's not as if it would be a disruptive
change in the slightest.
opinions?
rday
--
================
Robert P. J. Day
Linux Consulting, Training and
Remove the last vestiges of the long-deprecated "MAP_ANON" page
protection flag: use "MAP_ANONYMOUS" instead.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
fs/aio.c |2 +-
fs/binfmt_elf_fdpic.c |2 +-
include/asm-alpha/mman
i've got a one-line perl command that runs through include/linux and
standardizes all of the "#endif" directives for "__KERNEL__" into a
single variant
#endif /* __KERNEL__ */
where all of the whitespace bits above are a single space and nothing
more.
while this is clearly just aesthetic an
Delete the __ATTR-related macro definitions since these are now
defined in include/linux/sysfs.h.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/include/linux/configfs.h b/include/linux/configfs.h
index a7f0150..fef6f3d 100644
--- a/include/linux/configfs.h
as a followup to my previous patch submission, is there any value to
the definition of "struct configfs_attribute" in configfs.h anymore,
given a similar structure in sysfs.h?
configfs.h:
---
struct configfs_attribute {
const char *ca_name;
struct module
Replace kmalloc()+memset() combination with kzalloc().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
auditfilter.c |3 +--
futex.c |4 +---
kexec.c |3 +--
3 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/kernel/auditfilter.c b/
Convert all obvious combinations of kmalloc()+memset() to single
kzalloc() in the fs/ directory.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
binfmt_elf_fdpic.c |3 +--
seq_file.c |3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --gi
Convert the single obvious instance in lib/ of kmalloc() + memset()
to kzalloc().
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/lib/kobject.c b/lib/kobject.c
index 744a4b1..7ce6dc1 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -111,10 +111,9 @
Remove comment referring to non-existent kzalloc_node() routine.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/mm/allocpercpu.c b/mm/allocpercpu.c
index eaa9abe..9adcf4d 100644
--- a/mm/allocpercpu.c
+++ b/mm/allocpercpu.c
@@ -55,7 +55,6 @@ void *percpu_populat
On Sun, 3 Dec 2006, Alan wrote:
> > if (!p) {
> > - p = kmalloc(sizeof(*p), GFP_KERNEL);
> > + p = kzalloc(sizeof(*p), GFP_KERNEL);
> > if (!p)
> > return -ENOMEM;
> > file->private_data = p;
> > }
> > - memset(p, 0, sizeof(
Convert the single available instance of kmalloc() + memset() to
kzalloc() in the fs/ directory.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
(Re-submission of earlier patch, but omitting erroneous part of
that patch. Sorry about that. Nothing but decaf in the house.)
Convert the single changeable instance of kmalloc() + memset() to
kzalloc() in the ipc/ directory.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
ok, i *think* this one's valid. now i'll go work on something else.
diff --git a/ipc/sem.c b/ipc/sem.c
index 21b3289
what is the rationale for both the kobject structs and the kset
structs having a kobj_type? can those values possibly be different?
from kobject.h:
...
* kset - a set of kobjects of a specific type, belonging
* to a specific subsystem.
*
* All kobjects of a kset should be e
On Sun, 3 Dec 2006, Randy Dunlap wrote:
> On Sun, 3 Dec 2006 08:31:50 -0500 (EST) Robert P. J. Day wrote:
>
> >
> > Replace kmalloc()+memset() combination with kzalloc().
> >
> > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
> >
> > --
This is a *proposed* restructuring of the DD menu so that one can
see and select/de-select entire submenus without having to enter each
submenu.It's also immediately obvious visually which submenus are
currently active.
Based on Randy Dunlap's earlier suggestion, it uses the kbuild
"menuc
On Wed, 6 Dec 2006, Randy Dunlap wrote:
> On Wed, 6 Dec 2006 09:33:46 -0500 (EST) Robert P. J. Day wrote:
>
> >
> > This is a *proposed* restructuring of the DD menu so that one can
> > see and select/de-select entire submenus without having to enter each
> > sub
Rewrite a number of the Kconfig files under the drivers/ directory
so that those driver submenus can be selected or de-selected
directly from the Drivers menu using the kbuild "menuconfig" feature
without having to enter the submenu itself.
Signed-off-by: Robert P. J. Day <[EM
as a followup to my previous patch (and before i build on top of
that), perhaps someone can clarify some of these bits of curiosity:
1) although "Sound" is listed in the Device Drivers menu, its actual
source directory is at the top level of the kernel source tree, and
it's the *only* entry in
Rewrite the Fusion MPT Kconfig file so that all of MPT functionality
is entirely selectable from "Device drivers."
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
The original Kconfig file seems to have an odd structure, as you can
see from the first
Remove all apparently unnecessary "!=n" symbol comparisons from
Kconfig files.
---
According to the parser itself (scripts/kconfig/expr.c), that
comparison is superfluous:
/*
* bool FOO!=n => FOO
*/
drivers/block/Kconfig |2 +-
drivers/block/paride/Kconfig|
Replace all appropriate kmalloc() + memset() combinations with
kzalloc() throughout the sound/ directory.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
sound/oss/ac97_codec.c |3 +--
sound/oss/ad1889.c |3 +--
sound/oss/btaudio.c
On Fri, 8 Dec 2006, Mariusz Kozlowski wrote:
> Hello,
>
>
> > Replace all appropriate kmalloc() + memset() combinations with
> > kzalloc() throughout the sound/ directory.
>
> [... cut ...]
>
> > diff --git a/sound/oss/i810_audio.c b/sound/oss/i810_audio.c
> > index c3c8a72..f5e31f1 100644
> > -
i just noticed that there are numerous invocations of kcalloc()
where the hard-coded first arg of # elements is "1", which seems like
an inappropriate use of kcalloc().
the only rationale i can see is that kcalloc() guarantees that the
memory will be set to zero, so i'm guessing that this for
Change a logical comparison to the proper bitwise comparison.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
diff --git a/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
b/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c
index 92afa3b..0b9cc8a 100644
--- a/arch/i386/kernel/cpu/cpuf
Some calls to kcalloc() appear to have the first two args in the
wrong order.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
drivers/macintosh/smu.c |2 +-
drivers/net/skge.c |2 +-
drivers/scsi/sym53c8xx_2/sym_hipd.c |2 +-
drivers/us
perhaps i'm just being clueless about the authorship protocol here,
but i'm a bit hacked off by noticing that at least one submitted patch
of mine was apparently re-submitted (albeit slightly modified) a few
days later by another poster and applied under that poster's name.
on sun, dec 3, i s
On Sat, 9 Dec 2006, Benjamin Herrenschmidt wrote:
> > p.s. it's possible that this is all just a wild coincidence, of
> > course. stranger things have happened.
>
> ... or a genuine mistake.
sure, as i wrote above, i'm willing to accept that. but it still
leaves an open issue -- once one subm
On Sat, 9 Dec 2006, Jeff Garzik wrote:
> The protocol is simply to do best to give credit where credit is
> due. If your patch is taken directly, most likely it is a mistake if
> attribution was dropped. If your patch was modified, often that
> patch will get checked in under the name of the pers
On Sat, 9 Dec 2006, Tim Schmielau wrote:
> i wrote:
> > but given that i'm trying to follow the kernel guidelines and keep
> > each submission as a logically-related chunk, in many cases, i
> > have to wait for one patch to be applied before i can submit the
> > next one. and, at the moment, ther
On Sat, 9 Dec 2006, Pekka Enberg wrote:
> On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > @@ -705,7 +705,7 @@ static int uss720_probe(struct usb_inter
> > /*
> > * Allocate parport interface
> > */
> > -
On Sat, 9 Dec 2006, Pekka Enberg wrote:
> On 12/9/06, Pekka Enberg <[EMAIL PROTECTED]> wrote:
> > You really ought to send these cleanups to [EMAIL PROTECTED] with LKML
> > cc'd to get them merged.
>
> ...or even better, the relevant maintainer.
normally what i would do but, in the case of that p
On Sat, 9 Dec 2006, Pekka Enberg wrote:
> On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > argh, in that i've already mentioned that, following the guidelines in
> > "SubmittingPatches", i prefer that each of my patches have one logical
> &g
On Sat, 9 Dec 2006, Pekka Enberg wrote:
> On 12/9/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> > no. those two submissions represent two logically different "fixes"
> > and i have no intention of combining them.
>
> Like I said, fixing the order o
All kcalloc() calls of the form "kcalloc(1,...)" are converted to
the equivalent kzalloc() calls, and a few kcalloc() calls with the
incorrect ordering of the first two arguments are fixed.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
drivers/ata/pdc_adma.c
On Sat, 9 Dec 2006, Stefan Richter wrote:
> Robert P. J. Day wrote:
> > drivers/ata/pdc_adma.c |4 ++--
> > drivers/macintosh/smu.c |2 +-
> > drivers/mtd/rfd_ftl.c |2 +-
> > drivers/net/phy/phy_device.c|2
Replace the very few remaining "depends" Kconfig directives with
"depends on".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Given the recent patch that was applied to make this transformation,
might as well finish it off and deal with those last thr
there are numerous places throughout the source tree that apparently
calculate the size of an array using the construct
"sizeof(fubar)/sizeof(fubar[0])". see for yourself:
$ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" *
but we already have, from "include/linux/kernel.h":
#define ARRAY
Change the remaining two instances of "kcalloc(1,...)" to
"kzalloc()".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Now that that general change has been merged into Linus' tree, I've
added a check for that to an ongoing "coding style
i've posted on this before so here's a slightly-updated patch that
uses the kbuild "menuconfig" feature to make numerous entries under
the Device drivers menu selectable on the spot. if folks think this
is a good idea, what's the best way to get it in?
i could officially submit the patch as
Correct mis-spellings of "algorithm", "appear", "consistent" and
(shame, shame) "kernel".
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
Documentation/video4linux/bttv/Insmod-options |2 +-
arch/m32r/lib/usercopy.c
Remove the "#if 0"ed call to smp_commence, which is clearly
obsolete.
Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]>
---
There appears to be no value to leaving that call in the code, given
that the source file "arch/ia64/kernel/smpboot.c" explains:
"
On Thu, 14 Dec 2006, Zach Brown wrote:
> > there are numerous places throughout the source tree that
> > apparently calculate the size of an array using the construct
> > "sizeof(fubar)/sizeof(fubar[0])". see for yourself:
> > $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" *
>
> Indeed, ther
On Thu, 14 Dec 2006, Randy Dunlap wrote:
> David Weinehall wrote:
> > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Randy Dunlap wrote:
> >
> > [snip]
> >
> > > +but no space after unary operators:
> > > + sizeof ++ -- & * + - ~ ! defined
> >
> > Uhm, that doesn't compute... If you d
On Fri, 15 Dec 2006, Miguel Ojeda wrote:
> On 12/13/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote:
> >
> > there are numerous places throughout the source tree that apparently
> > calculate the size of an array using the construct
> > "sizeof(fuba
On Thu, 14 Dec 2006, Randy Dunlap wrote:
> On Thu, 14 Dec 2006 19:07:27 -0500 (EST) Robert P. J. Day wrote:
>
> > On Thu, 14 Dec 2006, Randy Dunlap wrote:
> >
> > > David Weinehall wrote:
> > > > On Thu, Dec 07, 2006 at 12:48:38AM -0800, Ra
On Fri, 15 Dec 2006, Jan Engelhardt wrote:
>
> >>> Indeed, there seems to be lots of potential clean-up there.
> >>> Including duplicate macros like:
> >>>
> >>> ./drivers/ide/ide-cd.h:#define ARY_LEN(a) ((sizeof(a) / sizeof(a[0])))
> >>
> >> not surprisingly, i have a script "arraysize.sh":
> >..
On Fri, 15 Dec 2006, Tim Schmielau wrote:
> On Fri, 15 Dec 2006, Robert P. J. Day wrote:
> > On Fri, 15 Dec 2006, Jan Engelhardt wrote:
> > > Even sizeof a / sizeof *a
> > >
> > > may happen.
> >
> > yes, sadly, there are a number of those as well.
On Sat, 16 Dec 2006, Pavel Machek wrote:
> Hi!
>
> > there are numerous places throughout the source tree that apparently
> > calculate the size of an array using the construct
> > "sizeof(fubar)/sizeof(fubar[0])". see for yourself:
> >
> > $ grep -Er "sizeof\((.*)\) ?/ ?sizeof\(\1\[0\]\)" *
>
301 - 400 of 924 matches
Mail list logo
