Re: [2.6.24 REGRESSION] BUG: Soft lockup - with VFS

2008-02-11 Thread Pete Zaitcev
On Tue, 12 Feb 2008 10:46:12 +0900, FUJITA Tomonori <[EMAIL PROTECTED]> wrote: > On a serious note, it seems that two scatter lists per request leaded > to this bug. Can the scatter list in struct ub_request be removed? Good question. It's an eyesore to be sure. The duplication exists for the sak

Re: Huawei E220 and usb storage

2008-02-14 Thread Pete Zaitcev
On Fri, 16 Nov 2007 14:22:56 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote: > > > The difference with huaweiAktBbo.c seems that kernel uses a nonzero > > > length. > > > Can you try zero length with the kernel? It's the second argument to the > > > last. > > > > I tried with the git patch p

Re: [2.6.24 REGRESSION] BUG: Soft lockup - with VFS

2008-02-05 Thread Pete Zaitcev
On Tue, 5 Feb 2008 14:05:06 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > Looks like you deadlocked in ub_request_fn(). I assume that you were using > ub.c in 2.6.23 and that it worked OK? If so, we broke it, possibly via > changes to the core block layer. > > I think ub.c is basically aban

Re: [2.6.24 REGRESSION] BUG: Soft lockup - with VFS

2008-02-08 Thread Pete Zaitcev
t's just Tomo or Jens made a mistake when converting to the new s/g API. Nothing to be too concerned about. I know I should've reviewed their patch closer, but it seemed too simple... -- Pete Fix up the conversion to sg_init_table(). Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED

Re: Huawei E220 and usb storage

2008-02-25 Thread Pete Zaitcev
On Wed, 20 Feb 2008 07:57:23 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote: > > that you did, after taking care of detection and initialization. > > Look at his dmesg in comment #44 in this: > > Yes, that looks very similar. Someone reported on the bug that a firmware update exists to resolv

sk->state_chage is not called for listening sockets

2001-04-12 Thread Pete Zaitcev
Hello: Suppose for a moment, that I have an in-kernel daemon, listening on a TCP socket, and that the said daemon is interested to know when connection becomes established. To that end it puts something into sk->state_change. However, when connection is established, state_chenge is not called (in

Re: usb-uhci.c problems in latest kernels?

2001-04-14 Thread Pete Zaitcev
> usb-uhci.c: interrupt, status 3, frame# 1876 This is a known problem, here is the discussion that I initiated on linux-usb-devel: http://marc.theaimsgroup.com/?t=9860950851&w=2&r=1 The right fix is to comment that printout out. In fact, that is what I commited for Red Hat 7.1 release.

So, what about kwhich on RH6.2?

2001-01-03 Thread Pete Zaitcev
Are we going to use Miquel's patch? I cannot build fresh 2.2.x on plain RH6.2 without it. The 2.2.19-pre6 comes out without it. Or is "install new bash" the official answer? Alan? -- Pete --- linux-2.2.19-pre3/scripts/kwhichSun Dec 10 16:49:45 2000 +++ linux-2.2.19-pre3-p3/scripts/kwhich Sat

Re: So, what about kwhich on RH6.2?

2001-01-03 Thread Pete Zaitcev
>Date:Wed, 03 Jan 2001 22:08:33 -0800 >From: Pete Zaitcev <[EMAIL PROTECTED]> > >Are we going to use Miquel's patch? I cannot build fresh 2.2.x on >plain RH6.2 without it. The 2.2.19-pre6 comes out without it. Or >is "install n

Re: Linux 2.2.19pre7

2001-01-09 Thread Pete Zaitcev
> o Fix kwhich versus old bash (Pete Zaitcev) A small clarification may be in order here. First, this patch comes from Miquel Smoorenburg, not from me. Second, DaveM pointed out that it fixes a non-problem. I stepped on a bug with an obscure kernel, I think it was 2.2.18-pre3, which cal

Loud screech after reboot of 2.2.18-pre22

2000-11-19 Thread Pete Zaitcev
Hi, I have a Sony VAIO Z505JE with ymfpci sound and built-in microphone and speaker. Everything worked fine with 2.2.17 plus ymfpci patch, but the 2.2.18-pre22 produces a loud screech starting as sound initializes and ending when startup scrips load mixer settings. This happens because of audio l

Re: YMF PCI - thanks, glitches, patches (fwd)

2000-12-06 Thread Pete Zaitcev
> Date: Wed, 6 Dec 2000 13:12:13 -0500 (EST) > From: Pavel Roskin <[EMAIL PROTECTED]> > cc: Jaroslav Kysela <[EMAIL PROTECTED]>, Pete Zaitcev <[EMAIL PROTECTED]>, > <[EMAIL PROTECTED]>, <[EMAIL PROTECTED]> > The native YMF PCI driver from Lin

Re: YMF PCI - thanks, glitches, patches (fwd)

2000-12-06 Thread Pete Zaitcev
> Date: Wed, 6 Dec 2000 15:00:38 -0500 (EST) > From: Pavel Roskin <[EMAIL PROTECTED]> > To: Pete Zaitcev <[EMAIL PROTECTED]> > Subject: Re: YMF PCI - thanks, glitches, patches (fwd) > > > Date: Wed, 6 Dec 2000 13:12:13 -0500 (EST) > > > From: Pavel Ros

Patch to DECODER_SET_NORM invocations

2000-11-07 Thread Pete Zaitcev
Hi, In the recent 2.2.x I discovered that saa7xxx driver expects norm to be an int, while struct video_channel defines it as __u16. This bombs if video_channel has something dirty next to it on the stack. Only one file is touched by the patch: drivers/char/buz.c, but some more code is related. T

Re: [PATCH] for YMF PCI sound cards

2000-12-08 Thread Pete Zaitcev
> Date: Fri, 8 Dec 2000 11:41:07 -0500 (EST) > From: Pavel Roskin <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > cc: <[EMAIL PROTECTED]>, Pete Zaitcev <[EMAIL PROTECTED]>, > Jaroslav Kysela <[EMAIL PROTECTED]> > --- ./drivers/sound/Co

Patch for ymfpci in test12-pre7

2000-12-10 Thread Pete Zaitcev
Hi, Linus: The attached patch fixes the following problems with ymfpci in 2.4 tree: 1. Enumeration was wrong, this bit people with several soundcards (Abhijit Menon-Sen). 2. Must use semaphore to guard open/close. 3. Old ymfpci locks up if compiled with CONFIG_SMP due to recursive calls to

Re: test1[12] + sparc + bind 9.1.0b1 == bad things

2000-12-13 Thread Pete Zaitcev
> Is this the first OOPS it prints out? I don't think so. I am > very sure it printed out messages from die_if_kernel first and > we need that initial OOPS to diagnose this bug and fix it. > > All the rest of the OOPS messages are useless and won't tell > us what the real problem is. > Late

Re: How to write patches

2000-12-29 Thread Pete Zaitcev
Jeff's descriprion is very informative, but his emphasis is somewhat different from what I find difficult with patches. First, for the life of me I was unable to remeber which argument goes first (DaveM was mad every time). Second, I kept forgetting to keep the base tree a diff against that instea

Re: SparcLinux on Sun E10000

2000-09-27 Thread Pete Zaitcev
Is it a coincidence that E1 is officially declared obsolete today? Sun never allows us to use the latest and greatest hardware. --Pete > Date: Wed, 27 Sep 2000 17:28:49 +1100 > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > From: Anton Blanchard <[EMAIL PROTECTED]> > Patches for Su

Q. about oops backtrace

2001-03-07 Thread Pete Zaitcev
Hello: I was investigating an oops and the trace looked like this: >>EIP; c01c54a9<= Trace; c01c3654 Trace; c01c0f0f Trace; c015e7e2 Trace; c01155a6 Trace; c01272a9 Trace; c0127414 Trace; c0136a2d Trace; c012722e Trace; c0127290 Trace; c0127414 Trace; c014cdec Trace; c0143f80

Re: SLAB vs. pci_alloc_xxx in usb-uhci patch [RFC: API]

2001-03-09 Thread Pete Zaitcev
> Date: Fri, 09 Mar 2001 10:29:22 -0800 > From: David Brownell <[EMAIL PROTECTED]> > > > extern void * > > > pci_pool_dma_to_cpu (struct pci_pool *pool, dma_addr_t handle); > > > > Do lots of drivers need the reverse mapping? It wasn't on my todo list > > yet. > > Some hardware (like OHCI) talk

Re: [linux-usb-devel] Re: SLAB vs. pci_alloc_xxx in usb-uhci patch [RFC: API]

2001-03-09 Thread Pete Zaitcev
l size, poisoning > and so on). And yet when Pete Zaitcev described what that > mapping code actually involved, you didn't object. So you've > succeeded in confusing me. Care to unconfuse? I did not propose an API or library which would be equal amond equals with first rate

Fix to khubd oops, hellooo?

2001-03-13 Thread Pete Zaitcev
Is my fix to khubd going anywhere? Randy, David? I have an actual, reproducible bug that I need to close. Here's my message to linux-usb-devel with explanations: http://marc.theaimsgroup.com/?l=linux-usb-devel&m=98411157628404&w=2 -- Pete diff -ur -X ../dontdiff linux-2.4.2-ac12/drivers/usb/hu

Re: scsi_scan problem.

2001-03-14 Thread Pete Zaitcev
> Date: Wed, 14 Mar 2001 21:28:14 -0500 > From: Doug Ledford <[EMAIL PROTECTED]> > A bug report I was charged with fixing (qla2x00 driver doesn't see all luns or > sees multiple identical luns in different scenarios) was not a bug in the > qla2x00 driver. [...] > The bug is that we were detect

Re: USB Mouse Problem in 2.4 Kernels - 2.2.18 Works Fine

2001-03-17 Thread Pete Zaitcev
> From: Andree Leidenfrost ([EMAIL PROTECTED]) > I am experiencing problems with a USB mouse: The machine boots, X > starts, I log on, everything works as expected. When I restart X or just > change to an alpha terminal and back to x the mouse does not work any > more. [...] > Hardware is an

Re: USB Mouse Problem in 2.4 Kernels - 2.2.18 Works Fine

2001-03-19 Thread Pete Zaitcev
> From: Andree Leidenfrost <[EMAIL PROTECTED]> > To: Pete Zaitcev <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED] > Date: 18 Mar 2001 22:50:32 +1100 > > > > I am experiencing problems with a USB mouse: The machine boots, X > > > starts, I log on, ever

Some strange patch to drivers/input/keybdev.c

2001-03-22 Thread Pete Zaitcev
Some guy sent me the attached patch. He says it allows him to use 2 additional keys on the 106 key USB keyboard. I never saw a 106 key keyboard before, USB or not. Does anyone understand what is going on? Vojtech? -- Pete --- drivers/input/keybdev.c.orig Sat Sep 2 19:01:55 2000 +++ drivers

Please review patchlet for ov511 (2.4.2-ac19)

2001-03-22 Thread Pete Zaitcev
Here is the deal: we have a guy here with a webcam and the following scenario: 1. ov511 disconnects, everything dies/releases/closes fine, 2. webcam soft starts polling open/sleep/open/sleep/... 3. ov511_probe works and reaches ov511_configure, calls video_register_device(). 4. Webcam software

Possible patch for Dell keyboard lockup

2001-03-28 Thread Pete Zaitcev
Hello, All: I have a situation where a Dell laptop would loose its keyboard after resume (thanks to Ben LaHaise for diagnosing this probelm). BIOS enables touchpad when resumed and if a user touches touchpad, "hardware" delivers IRQ 12 and will not deliver IRQ 1 until we process the mouse event.

Re: oops in uhci.c running 2.4.2-ac28

2001-04-02 Thread Pete Zaitcev
> Date: Sun, 1 Apr 2001 03:35:03 +0200 (CEST) > From: Ketil Froyn <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > While running kernel 2.4.2-ac28, I switched on spinlock debugging and > verbose BUG() reporting (I always use sysrq). Anyway, while running this I > got an oops after about 2

patchlet for cs46xx

2001-01-25 Thread Pete Zaitcev
Sorry for the nitpicking, bust since 2.4 is now "stable"... -- Pete diff -ur -X dontdiff linux-2.4.0-ac9/drivers/sound/cs46xx.c linux-2.4.0-ac9-p3/drivers/sound/cs46xx.c --- linux-2.4.0-ac9/drivers/sound/cs46xx.c Sun Jan 14 15:27:58 2001 +++ linux-2.4.0-ac9-p3/drivers/sound/cs46xx.c Wed J

Patch to run IrDA with no modules in 2.4.x

2001-01-28 Thread Pete Zaitcev
A minor problem here - module_init(irda_proto_init) got bracketed by #ifdef MODULE and became ineffective if compiled without modules. -- Pete diff -ur -X dontdiff linux-2.4.1-pre11/net/irda/af_irda.c linux-2.4.1-pre11-p3/net/irda/af_irda.c --- linux-2.4.1-pre11/net/irda/af_irda.cSat No

Maxwell strikes the heart (ECN: Clearing the air)

2001-01-29 Thread Pete Zaitcev
> From: Gregory Maxwell ([EMAIL PROTECTED]) > Date: Sun Jan 28 2001 - 14:42:04 EST > > On Sun, Jan 28, 2001 at 01:29:52PM +, James Sutherland wrote: > > > There is nothing silly with the decision, davem is simply a modern day > > > internet hero. > > > > No. If it were something essentia

Re: Ymfpci 724

2001-01-30 Thread Pete Zaitcev
> From: Simon Cahuk ([EMAIL PROTECTED]) > Date: Tue Jan 30 2001 - 14:22:26 EST > > I have a ymfpci sound chip on my motherboard. I'm using ymfpci module. > Under Q3A I get this: > sound inilializations: > Sorry but your soundcard can't do this Probably an mmap-ed sound problem or some ioctl

Patch for ymfpci and xmms

2001-02-08 Thread Pete Zaitcev
Courtesy of Manish Singh, little bit extended (I hope I did not break it too badly). Supposedly it fixes bad skipping with xmms. -- Pete diff -ur -X dontdiff linux-2.4.1/drivers/sound/ymfpci.c linux-2.4.1-p3/drivers/sound/ymfpci.c --- linux-2.4.1/drivers/sound/ymfpci.c Fri Jan 26 23:31:16 2001

Re: [PATCH] RCU in kernel/intermodule.c

2005-04-04 Thread Pete Zaitcev
On Sat, 02 Apr 2005 11:28:12 + Luca Falavigna <[EMAIL PROTECTED]> wrote: > This patch, compiled against version 2.6.12-rc1, implements RCU mechanism in > intermodule functions. This sounds like a pure and unmitigated insanity to me. Please tell us why in the world you wanted to do this. -- P

Re: 2.4.30: pwc pwc_isoc_handler() called with status -84

2005-04-06 Thread Pete Zaitcev
On Tue, 5 Apr 2005 10:55:52 -0300 Marcelo Tosatti <[EMAIL PROTECTED]> wrote: > CCing Pete. > > On Mon, Apr 04, 2005 at 08:59:57PM +0200, Gabor Z. Papp wrote: > > It was working fine with 2.4.29 and earlier kernels, often with > > 100-150 days uptime. > > > > As I upgraded to 2.4.30-rc kernels,

Re: CML2 design philosophy heads-up

2001-05-18 Thread Pete Zaitcev
> > As for the language CML2 is written in, surely C would work just as well as > > Python if the config-ruleset file is in a known format. GCC is required > > for the kernel to build, I don't see why anything else should be required > > simply to configure it. > > Menuconfig is fairly popular,

Re: CML2 design philosophy heads-up

2001-05-18 Thread Pete Zaitcev
>[about Aunt Tullie] > Because, for example, a kernel compile can be a part of the standard > install now, and you will end up with a kernel built specifically for > your machine that doesn't print 50 initialization failed messages on boot. >[...] > And you can also now run a kernel built for yo

Re: Oops on booting 2.4.4

2001-05-22 Thread Pete Zaitcev
> May 23 02:46:24 localhost kernel: Process kudzu (pid: 219, > stackpage=c7845000) > May 23 02:46:24 localhost kernel: Stack: c12607e0 0400 0400 > c73aa000 c122a060 c122a05c c122a058 c88fbb20 > May 23 02:46:24 localhost kernel:03f1 03f1 c014ab80 > c73aa3f1 c7845f9c

Patch for PM in ymfpci (against 2.4.5-pre3)

2001-05-24 Thread Pete Zaitcev
I am sorry to be a poor maintainer, people were sending me patches to enable PM support for a long time. I took most of this from Paul Stewart, fixed a buglet, and factored common parts into a function. -- Pete * PM support for suspend/resume (without pm_register, proper PCI API); * Killed some

Re: Patch for PM in ymfpci (against 2.4.5-pre3)

2001-05-24 Thread Pete Zaitcev
> From: Jeff Garzik <[EMAIL PROTECTED]> > Looks ok, only a small nit: an include and 'pmdev' are left over from > the older PM implementation, and can be removed. Oops, here's a better one. -- Pete - PM support for suspend/r

Re: Fwd: Copyright infringement in linux/drivers/usb/serial/keyspan*fw.h

2001-05-24 Thread Pete Zaitcev
> From: "Adam J. Richter" <[EMAIL PROTECTED]> > Date: Sun, 22 Apr 2001 12:53:48 -0700 > To: [EMAIL PROTECTED] > Subject: Copyright infringement in linux/drivers/usb/serial/keyspan*fw.h >[...] > I believe this infringinges the copyrights of the authors > of the code used in these drivers who

Re: [linux-usb-devel] USB oops on SMP, 2.4.5 kernel, and other problems

2001-05-26 Thread Pete Zaitcev
> From: Oleg Drokin <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED], [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Date: Sat, 26 May 2001 14:37:24 +0400 > >>EIP; c01a3162<= > Trace; c01a42fc > Trace; c01a5f9c > Trace; c01a42e0 > Trace; c019f19f > Trace; c0118a9e > Trace; c0117e62 > Trace;

Re: Plain 2.4.5 VM...

2001-05-28 Thread Pete Zaitcev
> Ouch! When compiling MySql, building sql_yacc.cc results in a ~300M > cc1plus process size. Unfortunately this leads the machine with 380M of > RAM deeply into swap: > > Mem: 381608K av, 248504K used, 133104K free, 0K shrd, 192K buff > Swap: 255608K av, 255608K used, 0K

Re: [PATCH] support for Cobalt Networks (x86 only) systems (for real this time)

2001-05-31 Thread Pete Zaitcev
> Aattached is a (large, but self contained) patch for Cobalt Networks suport > for x86 systems (RaQ3, RaQ4, Qube3, RaQXTR). Please let me know if there > is anything that would prevent this from general inclusion in the next > release. Looks interesting. Seemingly literate use of spinlocks. Of

Re: [PATCH] support for Cobalt Networks (x86 only) systems (for real this time)

2001-06-01 Thread Pete Zaitcev
> From: Tim Hockin <[EMAIL PROTECTED]> > Date: Thu, 31 May 2001 23:57:48 -0700 (PDT) > > i2c framework is not used, I wonder why. Someone thought that > > it was too heavy perhaps? If so, I disagree. > > i2c is only in our stuff because the i2c core is not in the standard kernel > yet. As soon

Re: [PATCH] support for Cobalt Networks (x86 only) systems (for real this time)

2001-06-01 Thread Pete Zaitcev
> But, each time a user cats this proc file, the user is banging the > hardware. What happens when a malicious user forks off 100 processes to > continually cat this file? :) Nothing good, probably. Same story as /proc/apm, which only hits BIOS instead (and it's debateable what is better). > S

Re: Linux 2.4.5-ac7

2001-06-04 Thread Pete Zaitcev
> AC> 2.4.5-ac7 > AC> o Make USB require PCI(me) > How about people from StrongArm sa11x0 port, who have USB host controller > (in sa companion chip) but do not have PCI? > Probably there are more such embedded architectures with USB controllers, > but not PC

Re: 2.4.5-ac7 SMP crash (hotplug race?)

2001-06-04 Thread Pete Zaitcev
>I told device to go to sleep, it reported (over serial console that I >looked at with minicom), that it turned off internal devices >(including USB client), reported it is going to sleep, and turned >serial and itself off. What does it mean "I told device to go to sleep"? What de

Re: USB bugs in 2.6.11.8, 2.6.11.10 and 2.6.12.2

2005-07-12 Thread Pete Zaitcev
On Mon, 11 Jul 2005 17:06:28 +0300, [EMAIL PROTECTED] (Markus Törnqvist) wrote: > Sorry about the bother, enabling K8 IOMMU fixed the issues. > At least that's the most relevant change I made to the conf > to fix it. This is not a good reason for crashes though. All is well that ends well, but

Re: usb mass storage bug

2005-07-12 Thread Pete Zaitcev
On Mon, 11 Jul 2005 13:30:47 -0700 (PDT), Joe Sevy <[EMAIL PROTECTED]> wrote: > Sorry, no logs or dmesg to report; just performance. > Using kernel 2.6.12: USB flash drive (san-disk cruzer > micro) Copy FROM drive is normal and quick; copy TO > drive is amazingly slow. (30 minutes for 50K file). >

Re: usb mass storage bug

2005-07-12 Thread Pete Zaitcev
On Mon, 11 Jul 2005 20:09:58 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > On Mon, Jul 11, 2005 at 01:30:47PM -0700, Joe Sevy wrote: > > Sorry, no logs or dmesg to report; just performance. > > Using kernel 2.6.12: USB flash drive (san-disk cruzer > > micro) Copy FROM drive is normal and quick; copy

Re: usb mass storage bug

2005-07-13 Thread Pete Zaitcev
On Wed, 13 Jul 2005 13:53:16 -0700, Greg KH <[EMAIL PROTECTED]> wrote: > You are right, ub isn't _that_ slow at all, I use it all the time on > some of my devices just fine. Ub actually gets terribly slow when partition size is odd (for both reading and writing). I even have a patch for it, but i

Re: pc_keyb: controller jammed (0xA7)

2005-07-14 Thread Pete Zaitcev
On Thu, 14 Jul 2005 18:27:01 +0200, Thoralf Will <[EMAIL PROTECTED]> wrote: > I didn't find any useful answer anywhere so far, hope it's ok to ask here. > I'm currently trying to get a 2.4.31 up and running on an IBM > BladeCenter HS20/8843. (base system is a stripped down RH9) > > When booting t

Patch for ub and blank CDs in 2.6.12

2005-07-14 Thread Pete Zaitcev
rride state. - Implement the Alan Stern's idea for adaptive signature checking. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> diff -urp -X dontdiff linux-2.6.12/drivers/block/ub.c linux-2.6.12-lem/drivers/block/ub.c --- linux-2.6.12/drivers/block/ub.c 2005-06-21 12:58:18.0

Fw: Oops in hidinput_hid_event

2005-07-18 Thread Pete Zaitcev
I think this patch is rather obvious, so maybe I should ask Andrew to apply it to -mm for now, to get some testing. Would that help to verify it for acceptance? -- Pete Begin forwarded message: Date: Tue, 28 Jun 2005 15:00:23 -0700 From: Pete Zaitcev <[EMAIL PROTECTED]> To: [EMAIL PROTECT

Re: Fw: Oops in hidinput_hid_event

2005-07-19 Thread Pete Zaitcev
On Tue, 19 Jul 2005 03:31:12 +0200, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, > > struct hid_usage *usage, __s32 value, struct pt_regs *regs) > > { > > - struct input_dev *input = &field->hidinput->input; > > +

Re: USB debouncing?

2005-07-19 Thread Pete Zaitcev
On Tue, 19 Jul 2005 18:24:25 +0200, DervishD <[EMAIL PROTECTED]> wrote: > I have a new MP3 player, and when I disconnect it from the USB > port, my logs says: > > <30>Jul 19 18:11:05 kernel: usb.c: USB disconnect on device 00:07.3-1 > address 2 > <27>Jul 19 18:11:06 kernel: hub.c: co

usb: printer double up()

2005-07-25 Thread Pete Zaitcev
Doing a double up() is actually safe in Linux, but still, it's a bug. This fix is present in 2.6.13-rc3. By Domen Puncer <[EMAIL PROTECTED]> up(&usblp->sem) was called twice in a row in this code path. --- linux-2.4.31/drivers/usb/printer.c 2004-08-10 13:43:36.0 -0700 +++ linux-2.4.31-us

Fw: Re: Elitegroup K7S5A + usb_storage problem

2005-08-06 Thread Pete Zaitcev
On Sat, 6 Aug 2005 11:49:05 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > When asked what went wrong, the device says it didn't understand the > INQUIRY command. This is a fatal error; if a device can't identify itself > there's no way for Linux to use it. > > In short, your mp3stick is

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

2005-08-06 Thread Pete Zaitcev
On Sun, 7 Aug 2005 02:22:53 +0200, Martin Maurer <[EMAIL PROTECTED]> wrote: > when i delete the files which are on the stick and do an umount/mount > cycle, the files are there again. > Copying files to the stick gives wrong results too. Curious. First of all, I have a request: do not call this

Re: Logitech Quickcam Express USB Address Aquisition Issues

2005-08-07 Thread Pete Zaitcev
On Sun, 7 Aug 2005 16:11:12 +0900, Chris White <[EMAIL PROTECTED]> wrote: > > Did it work OK under a previous kernel version? If so, which? > > I haven't attempted that, but I'll probably give a 2.6.9/2.4 series > kernel a shot later on tommorow night. Does that thing work with Windows? I stro

Re: Fw: Elitegroup K7S5A + usb_storage problem

2005-08-07 Thread Pete Zaitcev
> when i delete the files which are on the stick and do an umount/mount cycle, > the files are there again. >[... other mail ...] > I did the usbmon thing (hopefully correctly). Attached is the output. Yes, that was perfect, thanks a lot. Unfortunately, I do not see a lot of interesting things.

Re: Fw: Re: Elitegroup K7S5A + usb_storage problem

2005-08-07 Thread Pete Zaitcev
On Sun, 7 Aug 2005 22:47:40 +0200, Martin Maurer <[EMAIL PROTECTED]> wrote: > > Just out of curiosity, if you plug the player into a Windows system > > without installing any special drivers first, will Windows be able to read > > and write files okay? If it can, a USB packet trace may give Pete

Re: Problem with usb-storage and /dev/sd?

2005-08-10 Thread Pete Zaitcev
On Wed, 10 Aug 2005 21:22:43 +0200, DervishD <[EMAIL PROTECTED]> wrote: > I'm not using hotplug currently so... how can I make the USB > subsystem to assign always the same /dev/sd? entry to my USB Mass > storage devices? [...] You cannot. Just mount by label or something... Better yet, insta

Re: Problem with usb-storage and /dev/sd?

2005-08-12 Thread Pete Zaitcev
On Fri, 12 Aug 2005 12:49:28 +0200, Bodo Eggert <[EMAIL PROTECTED]> wrote: > Which label will a random USB stick have? GUID, I presume. Ask Andries Brouwer, he hacked on that, IIRC. Actually msdos has on-disk format for user-settable labels in the way analoguous to tune2fs -L label. I just do not

Re: Problem with usb-storage and /dev/sd?

2005-08-13 Thread Pete Zaitcev
On Sat, 13 Aug 2005 12:06:16 +0200 (CEST), Bodo Eggert <[EMAIL PROTECTED]> wrote: > On Fri, 12 Aug 2005, Pete Zaitcev wrote: > > On Fri, 12 Aug 2005 12:49:28 +0200, Bodo Eggert <[EMAIL PROTECTED]> wrote: > > > > > Which label will a random USB stick have? >

Re: usb camera failing in 2.6.13-rc6

2005-08-14 Thread Pete Zaitcev
On Sun, 14 Aug 2005 17:12:06 +1000, Con Kolivas <[EMAIL PROTECTED]> wrote: > A digital camera which was working fine in 2.6.11/12 now fails on 2.6.13-rc6 > (not sure when it started failing). Does it continue to work on an older kernel? I saw a USB device breaking right in the moment of reboot i

Re: usb camera failing in 2.6.13-rc6

2005-08-14 Thread Pete Zaitcev
On Sun, 14 Aug 2005 18:42:12 +1000, Con Kolivas <[EMAIL PROTECTED]> wrote: > On Sun, 14 Aug 2005 18:00, Pete Zaitcev wrote: > > On Sun, 14 Aug 2005 17:12:06 +1000, Con Kolivas <[EMAIL PROTECTED]> wrote: > Yes all those dmesgs etc were redone after it failed in rc6 as I

Re: usb camera failing in 2.6.13-rc6

2005-08-14 Thread Pete Zaitcev
On Mon, 15 Aug 2005 09:29:20 +1000, Con Kolivas <[EMAIL PROTECTED]> wrote: > > Remember that dmesg diff you sent? That's the one. If you strace > > the digikamcameracl, it probably keels over after EBUSY. > > Nice shot! Got it in one. bugzilla updated with confirmation. > > So how do we proceed

2.6.13 ub 4: Zaitcev's quasi-S/G

2005-08-14 Thread Pete Zaitcev
annot issue two or more packet commands where application expected only one. However, burning does not work completely yet. The cdrecord starts, recognizes the device, then aborts without writing a TOC. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> --- linux-2.6.13-rc6-gregkh/drivers/block

usbmon in 2.6.13: peeking into DMA areas

2005-08-15 Thread Pete Zaitcev
lop an architecure-neutral API for it (or point me that it was done already). Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.13-rc6/drivers/usb/mon/Makefile linux-2.6.13-rc6-lem/drivers/usb/mon/Makefile --- linux-2.6.13-rc6/drivers/usb/mon/Makefile 2005-08

Re: [Patch] Support UTF-8 scripts

2005-08-16 Thread Pete Zaitcev
On Mon, 15 Aug 2005 00:55:54 +0100, Alan Cox <[EMAIL PROTECTED]> wrote: > On Sul, 2005-08-14 at 15:59 -0400, Lee Revell wrote: > > I know the alternatives are available. That doesn't make it any less > > idiotic to use non ASCII characters as operators. I think it's a very > > slippery slope. W

Re: [2.6.13-rc6-latest] SCSI disk registration msgs repeat themselves

2005-08-16 Thread Pete Zaitcev
On Tue, 16 Aug 2005 21:39:33 -0700, Patrick Mansfield <[EMAIL PROTECTED]> wrote: > On Tue, Aug 16, 2005 at 11:01:30PM -0400, Chuck Ebbert wrote: > > I just added some usb-storage devices to my system and got the below. > > Why do the first four lines repeat for each device? (Not sure if > > th

Re: Fw: Oops in hidinput_hid_event

2005-07-25 Thread Pete Zaitcev
On Mon, 25 Jul 2005 20:52:26 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > Do you expect this patch: > > > --- linux-2.6.12/drivers/usb/input/hid-input.c 2005-06-21 > > 12:58:47.0 -0700 > > - struct input_dev *input = &field->hidinput->input; > > + struct input_dev *input; >

2.6.13 ub 1/3: Axboe's quasi-S/G

2005-07-30 Thread Pete Zaitcev
commands to the device. I added a small array of counters to monitor the merging (sg_stat). This may be dropped later. This patch is intended to be merged with 2.6.13 when that is available. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> diff -urp -X dontdiff linux-2.6.13-rc4/drivers/bloc

2.6.13 ub 2/3: Fold one line

2005-07-30 Thread Pete Zaitcev
Evidently, Yani Ioannou's display is wider than mine. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> --- linux-2.6.13-rc4-4seg/drivers/block/ub.c2005-07-30 22:19:55.0 -0700 +++ linux-2.6.13-rc4-lem/drivers/block/ub.c 2005-07-29 22:42:00.0 -0700 @@ -5

2.6.13 ub 3/3: death to ub_bd_rq_fn_1

2005-07-30 Thread Pete Zaitcev
When Al Viro saw the ub.c, he observed that it was a proof positive of Linus not reading patches anymore: names like fo_ob_ar_ba_2 used to cause serious fireworks. In my defence, any good scheme can be pushed to the realm of absurd if pushed far enough. Signed-off-by: Pete Zaitcev <[EM

Re: Question about usb-storage: Sometimes partitions are not recognized.

2005-08-25 Thread Pete Zaitcev
On Thu, 25 Aug 2005 15:26:27 +0200, Manuel Schneider <[EMAIL PROTECTED]> wrote: > When I plug them in, they will be recognized by hotplug (I'm using udev), the > module usb-storage will be loaded and the device nodes are created. > > BUT: There is normally just ONE device node for the disc block

Re: USB EHCI Problem with Low Speed Devices on kernel 2.6.11+

2005-08-27 Thread Pete Zaitcev
On Sat, 27 Aug 2005 15:43:11 +0200, Dominik Wezel <[EMAIL PROTECTED]> wrote: Forwarding to linux-usb-devel with comments. > Kernel > == > - 2.6.8, 2.6.11.10 and 2.6.12.4, all show same problem > Problem > === > When turning on the laptop and during POST and GrUB loading, all ports > on

Re: [linux-usb-devel] Re: USB EHCI Problem with Low Speed Devices on kernel 2.6.11+

2005-08-27 Thread Pete Zaitcev
On Sat, 27 Aug 2005 22:57:45 -0400 (EDT), Alan Stern <[EMAIL PROTECTED]> wrote: > On Sat, 27 Aug 2005, Pete Zaitcev wrote: > > > Kernel > > > == > > > - 2.6.8, 2.6.11.10 and 2.6.12.4, all show same problem > > Actually, I suspected that this may be a

Re: kernel status, "Elitegroup K7S5A"

2005-09-07 Thread Pete Zaitcev
On Mon, 5 Sep 2005 13:55:46 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > Re: Elitegroup K7S5A + usb_storage problem > [linux-usb-devel] Fw: Re: Elitegroup K7S5A + usb_storage problem This appears to be stuck. It has to have someone with a lot of patience to play with the device. Martin coll

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Pete Zaitcev
rq->errors = scsi_status; > } > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors); > - end_that_request_last(rq, uptodate); > + if (__blk_end_request(rq, error, blk_rq_bytes(rq))) > + BUG(); Acked-by: Pete Zaitcev <[EMAIL PROTECTED]>

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-13 Thread Pete Zaitcev
On Wed, 12 Dec 2007 15:38:15 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev <[EMAIL PROTECTED]> wrote: > > > - end_that_request_first(rq, uptodate, rq->hard_nr_sectors); > > > - end_that_re

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-21 Thread Pete Zaitcev
On Fri, 21 Dec 2007 00:00:04 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > I converted the usu_init_notify semaphore to normal mutex usage, and it > should still prevent the request_module before the init routine is > complete. Before it acted more like a complete, now the mutex protects > tw

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-22 Thread Pete Zaitcev
On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > Then in usu_probe_thread() your basically stopping it at the start of > the function with a down(), and the up() is just ancillary .. So you > could easily move the up() further down in the function and still have > the

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-24 Thread Pete Zaitcev
On Sun, 23 Dec 2007 08:46:37 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > I noticed you also have a spinlock held in usu_probe_thread(), the > usu_lock.. That spinlock would preclude anything inside request_module() > from sleeping.. The usu_lock is not held across request_module. In fact, i

Add the infamous Huawei E220 to option.c

2007-11-28 Thread Pete Zaitcev
Hi, All: It looks like the Huawei E220 saga is not over yet. A collegue of mine, David Russll, reported that the modem does not work reliably on Fedora 8, which does have the initializer in usb-storage. The problem stems from the fact that both option and usb-storage can bind to the modem when in

Re: Add the infamous Huawei E220 to option.c

2007-11-28 Thread Pete Zaitcev
On Thu, 29 Nov 2007 08:38:59 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Donnerstag, 29. November 2007 01:13:05 schrieb Pete Zaitcev: > > The problem stems from the fact that both option and usb-storage can bind > > to the modem when in storage mode: the former

Re: Add the infamous Huawei E220 to option.c

2007-11-29 Thread Pete Zaitcev
On Thu, 29 Nov 2007 08:44:38 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote: > 3. Make sure usbcore doesn't probe the devices in the wrong mode with the > option driver This fixes duplication. And to take it further, why don't we turn this idea around and let usb-storage fail to attach with some

Re: Add the infamous Huawei E220 to option.c

2007-11-29 Thread Pete Zaitcev
On Thu, 29 Nov 2007 09:04:28 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote: > > > Isn't it possible to fix this in option's module table? > > > > At first thought it'll need adding a field to struct usb_serial to save > > the driver_info from the ID table in usb_serial_probe. It's something I'd >

Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220

2007-12-01 Thread Pete Zaitcev
On Sat, 1 Dec 2007 09:07:38 +0100, Norbert Preining <[EMAIL PROTECTED]> wrote: > is this the only addition that should be needed, ortogether with the > changes in option to call the huawei init function? The only one. > I tried 2.6.24-rc3 with this patch only and it I again got the infinite > lo

Re: [patch 12/18] usb: mon nopage

2007-12-05 Thread Pete Zaitcev
n tests to see how it works. I'll collect any failing pieces later if any. Signed-off-by: Pete Zaitcev <[EMAIL PROTECTED]> -- Pete -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220

2007-12-05 Thread Pete Zaitcev
On Wed, 5 Dec 2007 19:23:14 +0100, Oliver Neukum <[EMAIL PROTECTED]> wrote: > Am Mittwoch, 5. Dezember 2007 17:34:23 schrieb Pete Zaitcev: > > Looks good to me, shorter than my patch, has no duplication, allows to > > use the storage, looks like a winner. Unfortunately,

Re: [PATCH] USB: option: Bind to the correct interface of the Huawei E220

2007-12-05 Thread Pete Zaitcev
use the storage, looks like a winner. Unfortunately, it leaves ub for dead, because ub cannot invoke the necessary initializer unless we move it to libusual. But oh well, I'll think about it. Took me this long to test because I had to ask kind people in England to replug the modem. Signed-off

Re: [PATCH] mct232: speed, new termios and compliance cleanups

2007-11-20 Thread Pete Zaitcev
On Mon, 19 Nov 2007 15:22:11 +, Alan Cox <[EMAIL PROTECTED]> wrote: > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> This looks good, but have a couple of comments. Maybe I can fix it up. > * we do not know how to support. We ignore them for the moment. > * XXX Rate-limit the error message,

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-14 Thread Pete Zaitcev
On Fri, 14 Dec 2007 12:04:54 -0500 (EST), Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > I have investigated all code paths which call ub_end_rq() in ub.c, > and confirmed that ub_end_rq() is always called with the queue lock > held. (sc->lock is registered as a queue lock.) Thanks for reminding me

Re: drivers/block/ub.c and multiple LUNs

2005-03-21 Thread Pete Zaitcev
here is no MAINTAINERS file entry for the ub.c driver, and Pete Zaitcev > is not even listed in the CREDITS file. I didn't think it was important, but I see now that if it helps to prevent the ub traffic from going to Matt, it ought to be done. I'll send a patch. -- Pete dif

Re: USB ioctl problem in 2.4.28

2005-01-31 Thread Pete Zaitcev
On Wed, 1 Dec 2004 14:57:41 +0200 (EET), Kaupo Arulo <[EMAIL PROTECTED]> wrote: > We can use a macro, if it is really necessary No, I prefer it explicit. See the attached patch. I changed Sergey's patch just a little, so the invalid ioctls are detected outside the lock. > IMHO it is correct to r

  1   2   3   >