Re: [PATCH v2] ARM: Remove '-p' from LDFLAGS

he same for arm64. > > > > Signed-off-by: Nathan Chancellor > > Acked-by: Ard Biesheuvel > > Acked-by: Nicolas Pitre > > Reviewed-by: Nick Desaulniers > > Reviewed-by: Stefan Agner > > You may now submit your patch to RMK's patch system: > ht

Re: [PATCH 2/2] ARM: Wrap '--pic-veneer' with ld-option

; >> > > > > > > >> > > > > > ld.lld: error: unknown argument: --pic-veneer > >> > > > > > > >> > > > > > Signed-off-by: Nathan Chancellor > >> > > > > > >> > > > > Hi Nate, > >> > > > > > >> > > > > Does this mean ld.lld is guaranteed to produce position independent > >> > > > > veneers if you build kernels that are bigger than the typical > >> > > > > range of > >> > > > > a relative branch? Just for the list, 2 patches to lld: https://github.com/ClangBuiltLinux/linux/issues/286#issuecomment-452027802 -- Thanks, ~Nick Desaulniers

undefined behavior (-Wvarargs) in security/keys/trusted.c#TSS_authhmac()

type char, short int, or float, either.` -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] [PATCH] KEYS: trusted: fix -Wvarags warning

> undefined. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/41 > > Link: https://www.eskimo.com/~scs/cclass/int/sx11c.html > > Suggested-by: David Laight > > Suggested-by: Denis Kenzior > > Suggested-by: James Bottomley > > Suggested-

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

On Mon, Oct 15, 2018 at 9:03 AM Andy Lutomirski wrote: > > On Mon, Oct 15, 2018 at 8:31 AM Josh Poimboeuf wrote: > > > > On Mon, Oct 15, 2018 at 08:22:21AM -0700, Nathan Chancellor wrote: > > > > >>> @@ -760,9 +760,11 @@ no_context(struct pt_regs *regs, unsigned long > > > > >>> error_code, > >

Re: [PATCH] x86/mm: annotate no_context with UNWIND_HINTS

On Mon, Oct 15, 2018 at 9:57 AM Nick Desaulniers wrote: > I broke this myself in commit 815f0ddb346c > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). > Thanks for the suggestion, will verify then send a patch with your > suggested by tag. Thanks everyo

Re: [PATCH] compiler.h: update definition of unreachable()

ou prefer a v2 (single patch), or an additional patch on top? > > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/204 > > Suggested-by: Andy Lutomirski > > Suggested-by: Josh Poimboeuf > > Tested-by: Nathan Chancellor > > Signed-off-by: Nick Desa

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

cked. > > Seems clang is being over cautious. Yes; did you have feedback on the Denis' proposed fix, or another? > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 > 1PT, UK > Registration No: 1397386 (Wales) -- Thanks, ~Nick Desaulniers

Re: [PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

ually just as > > simple as running 'make ARCH=arm CC=clang CROSS_COMPILE=arm-linux-gnueabi-'. > > > > Clang 7.0+ is recommended but 6.0 might work too. > > TBH I would expect to download container and run this there to make sure > that I don't break anything else. This is the first request we've had for a container in order to test a patch. If it comes up again from other folks, I think it makes sense to create one. Until then, its nice to have. It's definitely overkill for this patch. -- Thanks, ~Nick Desaulniers

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

ons, the behavior is > > undefined. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/41 > > Suggested-by: James Bottomley > > Signed-off-by: Nick Desaulniers > > --- > > security/keys/trusted.c | 14 +++--- > > 1 file chang

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

posed: https://github.com/ClangBuiltLinux/linux/issues/41#issuecomment-428365339. If that works for you and the maintainers, I can send that in patch form. > > Regards, > -Denis -- Thanks, ~Nick Desaulniers

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

hrough rules more complicated than the correct flags to pass to `tar`. https://xkcd.com/1168/ > > So instead of having unsigned char h3, can't we simply have bool h3 or > unsigned int h3? int is the default argument promotion. Proposed: https://github.com/ClangBuiltLinux/linux/issues/41#issuecomment-428365339 > > Regards, > -Denis > -- Thanks, ~Nick Desaulniers

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

between compilers, but it is free to change between versions of the same compiler (I haven't witnessed such a case yet in my limited career, but I would never say never when it comes to relying on undefined behavior). > > James > > > But in the context of this patch, can

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

On Fri, Oct 12, 2018 at 10:05 AM Nick Desaulniers wrote: > > On Fri, Oct 12, 2018 at 8:14 AM Denis Kenzior wrote: > > > > Hi James, > > > > >> So can't we simply use 'bool' or uint32 as the type for h3 instead > > >> of re-ordering e

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

ignment to be something like: > > c = !!h3; > > So in the end, I'm happy with int or unsigned int. Thanks for the feedback. I'll wait wait to see if James is also cool with that approach, and if so, send a v2 based on the next-keys branch in the security tree as per Nathan, with yours and his Suggested-by tags. -- Thanks, ~Nick Desaulniers

[PATCH] x86/mm: annotate no_context with UNWIND_HINTS

Fixes the objtool warning: arch/x86/mm/fault.o: warning: objtool: no_context()+0x220: unreachable instruction Link: https://github.com/ClangBuiltLinux/linux/issues/204 Signed-off-by: Nick Desaulniers --- arch/x86/mm/fault.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

spi_dma_prepare(struct spi_master *master, > > > - enum dma_transfer_direction dir) > > > +ep93xx_spi_dma_prepare(struct spi_master *master, int dir) > > > { > > > struct ep93xx_spi *espi = spi_master_get_devdata(master); > > > struct spi_transfer *xfer = master->cur_msg->state; > > > @@ -359,8 +358,7 @@ ep93xx_spi_dma_prepare(struct spi_master *master, > > > * Function finishes with the DMA transfer. After this, the DMA buffer is > > > * unmapped. > > > */ > > > -static void ep93xx_spi_dma_finish(struct spi_master *master, > > > - enum dma_transfer_direction dir) > > > +static void ep93xx_spi_dma_finish(struct spi_master *master, int dir) > > > { > > > struct ep93xx_spi *espi = spi_master_get_devdata(master); > > > struct dma_chan *chan; > > > -- > > > 2.19.0 > > > > > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

ter this, the DMA buffer is > * unmapped. > */ > -static void ep93xx_spi_dma_finish(struct spi_master *master, > - enum dma_transfer_direction dir) > +static void ep93xx_spi_dma_finish(struct spi_master *master, int dir) > { > struct ep93xx_spi *espi = spi_master_get_devdata(master); > struct dma_chan *chan; > -- > 2.19.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2] spi: spi-ep93xx: Change dir type in ep93xx_spi_dma_{finish,prepare}

On Thu, Oct 4, 2018 at 2:47 PM Nathan Chancellor wrote: > > On Thu, Oct 04, 2018 at 02:32:48PM -0700, Nick Desaulniers wrote: > > On Wed, Oct 3, 2018 at 7:41 PM Nathan Chancellor > > wrote: > > > > > > Clang warns when one enumerated type is implicitly conve

Re: [PATCH v3] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

espi = spi_master_get_devdata(master); > struct dma_async_tx_descriptor *rxd, *txd; > > - rxd = ep93xx_spi_dma_prepare(master, DMA_DEV_TO_MEM); > + rxd = ep93xx_spi_dma_prepare(master, DMA_FROM_DEVICE); > if (IS_ERR(rxd)) { > dev_err(&master->dev, "DMA RX failed: %ld\n", PTR_ERR(rxd)); > return PTR_ERR(rxd); > } > > - txd = ep93xx_spi_dma_prepare(master, DMA_MEM_TO_DEV); > + txd = ep93xx_spi_dma_prepare(master, DMA_TO_DEVICE); > if (IS_ERR(txd)) { > - ep93xx_spi_dma_finish(master, DMA_DEV_TO_MEM); > + ep93xx_spi_dma_finish(master, DMA_FROM_DEVICE); > dev_err(&master->dev, "DMA TX failed: %ld\n", PTR_ERR(txd)); > return PTR_ERR(txd); > } > -- > 2.19.0 > -- Thanks, ~Nick Desaulniers

Re: [PATCH] staging: emxx_udc: Remove unused device_desc declaration

GCC nor Clang emit any reference to the > variable in the final assembly. The only reason GCC doesn't warn about > this variable being unused is the sizeof function. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > --- > > This seems kind of wrong giv

Re: [PATCH v4] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

sense, thanks to review from Mika. Add a helper function to > convert between the two types as there is still a couple of locations > that need a transfer enum (and no such function exists). > > v3 -> v4: > > * Use 'conf.direction' in dmaengine_prep_slave_sg ins

Re: [PATCH] kbuild: consolidate Clang compiler flags

luated just once. > > (Or, this cc-option may not be necessary any longer.) > > Will send v2. If the ultimate goal is not evaluate cc-option more than once, removing cc-option from both KBUILD_CFLAGS and KBUILD_AFLAGS for clang is the better approach; we always want those for clang unconditionally. And if you by chance have an ancient version of clang that doesn't support those flags, you wont be able to compile a kernel anyways. Eventually we want to get Clang's integrated assembler in shape to be used to assemble the kernel, but I think we're a ways off there still. -- Thanks, ~Nick Desaulniers

Re: [PATCH] sched: Make sched_feat(x) boolean for !CONFIG_SCHED_DEBUG

sctl_sched_features & (1UL << __SCHED_FEAT_##x)) > +#define sched_feat(x) (!!(sysctl_sched_features & (1UL << __SCHED_FEAT_##x))) > > #endif /* SCHED_DEBUG && HAVE_JUMP_LABEL */ > > -- > 2.19.1.568.g152ad8e336-goog > -- Thanks, ~Nick Desaulniers

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

all after spawning as, while without `-Wa,-` shows it receiving a SIGCHLD. I've filed a bug against Clang to investigate: https://bugs.llvm.org/show_bug.cgi?id=39410 In the meantime, I think Nathan's patch is the correct way to work around this, if it is indeed a bug in Clang. Rev

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor wrote: > > On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter Anvin wrote: > > On 10/23/18 11:40, Nick Desaulniers wrote: > > > On Mon, Oct 22, 2018 at 10:11 PM Nadav Amit wrote: > > >> > >

Re: [PATCH RFC] x86: Don't include '-Wa,-' when building with Clang

On Tue, Oct 23, 2018 at 3:44 PM Nathan Chancellor wrote: > > On Tue, Oct 23, 2018 at 03:08:53PM -0700, Nick Desaulniers wrote: > > On Tue, Oct 23, 2018 at 2:58 PM Nathan Chancellor > > wrote: > > > > > > On Tue, Oct 23, 2018 at 01:01:22PM -0700, H. Peter An

Re: [PATCH] x86: Remove -pipe from KBUILD_CFLAGS

angs > indefinitely at compiling init/main.o). This happens because while Clang > accepts -pipe (and has it documented in its list of supported flags), it > silently ignores it after this 2010 commit (thanks to Nick Desaulniers > for tracking this down), meaning that gas just infinitely waits

Re: [PATCH] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll

pdate Nathan. One thing I recommend doing is including the version in the [PATCH] subject line, ie. [PATCH v2]. `git format-patch` can do this automatically for you, ex. $ git format-patch -v2 HEAD~ > > Fixes: b0cc417c1637 ("dmaengine: Add Xilinx zynqmp dma engine driver support&

Re: [PATCH] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll

On Thu, Oct 25, 2018 at 11:14 AM Nathan Chancellor wrote: > > On Thu, Oct 25, 2018 at 11:11:22AM -0700, Nick Desaulniers wrote: > > On Thu, Oct 25, 2018 at 11:06 AM Nathan Chancellor > > wrote: > > > > > > Clang warns: > > > > > > dri

Re: [PATCH 1/2] Compiler Attributes: add support for __fallthrough (gcc >= 7.1)

On Mon, Oct 22, 2018 at 11:15 AM Bernd Petrovitsch wrote: > > Hi all! > > On 22/10/18 19:54, Nick Desaulniers wrote: > > On Mon, Oct 22, 2018 at 10:50 AM Bernd Petrovitsch > > wrote: > [...] > >> PS: clang++ errors with "fallthrough annotation in unreach

Re: [PATCH] iio: adc: max9611: Avoid implicit enum conversion warning

gain' [-Wenum-conversion] > > > *csa_gain = gain_selectors[i]; > > > ~ ^ > > > 1 warning generated. > > > > > > Change the type of the variable 'gain_selectors' to int so that Clang > > > understands this is ex

Re: [PATCH] ftrace: Build with CPPFLAGS to get -Qunused-arguments

a fan of covering up those warnings via -Qunused-arguments; the flags should be feature detected via cc-option and friends rather than always added then silenced if excessive. That hides flags that are long dead/unused. Thanks for this patch! Reviewed-by: Nick Desaulniers > > scripts/M

Re: [PATCH] misc: echo: Remove unnecessary parentheses and simplify check for zero

ve them and while we're at it, simplify the zero check as '!var' is > used more than 'var == 0'. > > Reported-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Nathan, Thanks for this patch. Reviewed-by: Nick Desaulniers > --- > drivers/misc/ec

Re: [PATCH] kbuild: allow to use GCC toolchain not in Clang search path

ANG_GCC_TC) > +KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX) > +KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC) $(CLANG_PREFIX) > KBUILD_CFLAGS += $(call cc-option, -no-integrated-as) > KBUILD_AFLAGS += $(call cc-option, -no-integrated-as) > endif > -- > 2.19.0 > Thanks for this patch Stefan. Reviewed-and-tested-by: Nick Desaulniers -- Thanks, ~Nick Desaulniers

Re: [PATCH v6 3/3] x86: paravirt: make native_save_fl extern inline

On Fri, Jul 13, 2018 at 3:15 AM David Laight wrote: > > From: Nick Desaulniers > > Sent: 21 June 2018 17:23 > > > > native_save_fl() is marked static inline, but by using it as > > a function pointer in arch/x86/kernel/paravirt.c, it MUST be outlined. > >

Re: [PATCH 0/3] get_maintainer: add patch-only keyword matching

MAINTAINERS |3 + > scripts/get_maintainer.pl | 3334 > +++-- > 2 files changed, 1718 insertions(+), 1619 deletions(-) > --- > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > change-id: 20230926-get_maintainer_add_d-07424a814e72 > > Best regards, > -- > Justin Stitt > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 0/2] get_maintainer: add patch-only keyword matching

was meant to be. Now that you mention it, I see it, and it does seem consistent in that regard. Justin, is your formatter configurable to match that convention? Maybe it's still useful, as long as you configure it to stick to the pre-existing convention. -- Thanks, ~Nick Desaulniers

[PATCH v3] arm64: vdso32: drop -no-integrated-as flag

- \ CROSS_COMPILE_COMPAT=arm-linux-gnueabi- make LLVM=1 LLVM_IAS=1 \ defconfig arch/arm64/kernel/vdso32/ Suggested-by: Nathan Chancellor Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Reviewed-by: Vincenzo Frascino --- Changes V2 -> V3: * Pick up reviewed by tags. Changes

Re: [PATCH 01/15] objtool: Find a destination for jumps beyond the section end

transfer_one() falls through to the next function" > > which is what we normally do in this type of situation. > > It may be caused by UB, or a compiler bug, but either way we should > figure out the root cause. We probably want to creduce or cvise this. IIRC we still have outstanding issues with switch statements with user-annotated unreachable branches not getting eliminated. -- Thanks, ~Nick Desaulniers

Re: [PATCH 2/2] kbuild: check the minimum linker version in Kconfig

g] Error 1 > make[1]: *** [Makefile:600: syncconfig] Error 2 > make: *** [Makefile:708: include/config/auto.conf] Error 2 > > Thanks to David Laight for suggesting shell script improvements. > > Signed-off-by: Masahiro Yamada Acked-by: Nick Desaulniers > --- &g

Re: [PATCH mips-next] vmlinux.lds.h: catch more UBSAN symbols into .data

ompoundliteral* .data.$__unnamed_* > +#define DATA_MAIN .data .data.[0-9a-zA-Z_]* .data..L* > .data..compoundliteral* .data.$__unnamed_* .data.$Lubsan_* Are these sections only created when CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected? (Same with .data.$__unnamed_*) > #define SDATA_MAIN .sdata .sdata.[0-9a-zA-Z_]* > #define RODATA_MAIN .rodata .rodata.[0-9a-zA-Z_]* .rodata..L* > #define BSS_MAIN .bss .bss.[0-9a-zA-Z_]* .bss..compoundliteral* > -- > 2.30.1 > > -- Thanks, ~Nick Desaulniers

Re: [PATCH] RTIC: selinux: ARM64: Move selinux_state to a separate page

age to enhance > protection. > > Signed-off-by: Preeti Nagar This addresses my feedback from the RFC regarding the section symbols. No comment on whether there is a better approach, or the 2MB vs page alignment, but perhaps other folks cc'ed can please take a look. Acked-by: Nick Desa

Re: [PATCH v2 0/2] Clean up x86_32 stackprotector

6_32-has-stack-protector.sh | 6 +- > 20 files changed, 62 insertions(+), 265 deletions(-) > > -- > 2.29.2 > -- Thanks, ~Nick Desaulniers

Re: [PATCH v2 1/2] x86/stackprotector/32: Make the canary into a regular percpu variable

s the GS selector and updates GSBASE, which is now > always the user base. This means that the overall effect is > the same on 32-bit and 64-bit, which avoids some ifdeffery. > > Cc: Sedat Dilek > Cc: Nick Desaulniers > Signed-off-by: Andy Lutomirski > --- > arch/

[PATCH] MIPS: select ARCH_KEEP_MEMBLOCK unconditionally

CK if DEBUG_KERNEL to enable sysfs memblock debug") Cc: Masahiro Yamada Reported-by: Guenter Roeck Signed-off-by: Nick Desaulniers --- arch/mips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index e9893cd34992..702648f60e41 10

Re: [PATCH] x86/kernel: remove unneeded dead-store initialization

gt; > I get all kinds of missing python scripts: > FileNotFoundError: [Errno 2] No such file or directory: 'clang-tidy' You do have clang-tidy installed right? `which clang-tidy`? -- Thanks, ~Nick Desaulniers

Re: arm-linux-gnueabi-ld: warning: orphan section `__cpuidle_method_of_table' from `arch/arm/mach-omap2/pm33xx-core.o' being placed in section `__cpuidle_method_of_table'

/arm/include/asm/cpuidle.h defines `CPUIDLE_METHOD_OF_DECLARE` to create a static struct in such a section. Only arch/arm/mach-omap2/pm33xx-core.c uses that macro. > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org -- Thanks, ~Nick Desaulniers

Re: arm-linux-gnueabi-ld: warning: orphan section `__cpuidle_method_of_table' from `arch/arm/mach-omap2/pm33xx-core.o' being placed in section `__cpuidle_method_of_table'

On Wed, Apr 7, 2021 at 11:23 AM Arnd Bergmann wrote: > > On Wed, Apr 7, 2021 at 8:07 PM Nick Desaulniers > wrote: > > > > On Wed, Apr 7, 2021 at 3:52 AM kernel test robot wrote: > > > > > > Hi Kees, > > > > > > FYI, the erro

[PATCH 0/2] gcov: re-fix clang-11 support

fo in userspace. Nick Desaulniers (2): gcov: re-fix clang-11+ support gcov: re-drop support for clang-10 kernel/gcov/clang.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) -- 2.31.1.295.g9ea45b61b8-goog

[PATCH 1/2] gcov: re-fix clang-11+ support

Cc: sta...@vger.kernel.org #5.4+ Reported-by: Prasad Sodagudi Tested-by: Prasad Sodagudi Signed-off-by: Nick Desaulniers --- kernel/gcov/clang.c | 38 +- 1 file changed, 33 insertions(+), 5 deletions(-) diff --git a/kernel/gcov/clang.c b/kernel/gcov/clang.c

[PATCH 2/2] gcov: re-drop support for clang-10

LLVM changed the expected function signatures for llvm_gcda_emit_function() in the clang-11 release. Drop the older implementations and require folks to upgrade their compiler if they're interested in GCOV support. Signed-off-by: Nick Desaulniers --- kernel/gcov/clang.c

Re: [PATCH] lib/string: Introduce sysfs_streqcase

> work even-if the input is "min-wrongcommand". > > I found some more cases using strncasecmp to check the entire string > such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks > "disable" command with strncasecmp but it would also work if the > comman

Re: [PATCH] mailmap: update Andrey Konovalov's email address

(replying to https://lore.kernel.org/lkml/ead0e9c32a2f70e0bde6f63b3b9470e0ef13d2ee.1616107969.git.andreyk...@google.com/) Just got the bounceback, RIP. :( Marco is updating your epitaph. Acked-by: Nick Desaulniers

Re: [PATCH] mailmap: update Andrey Konovalov's email address

err..with Marco's real email address this time On Wed, Apr 7, 2021 at 1:14 PM Nick Desaulniers wrote: > > (replying to > https://lore.kernel.org/lkml/ead0e9c32a2f70e0bde6f63b3b9470e0ef13d2ee.1616107969.git.andreyk...@google.com/) > > Just got the bounceback, RIP. :( > &

Re: [PATCH 1/2] gcov: re-fix clang-11+ support

On Wed, Apr 7, 2021 at 2:21 PM Andrew Morton wrote: > > On Wed, 7 Apr 2021 11:54:55 -0700 Nick Desaulniers > wrote: > > > LLVM changed the expected function signature for > > llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 or > > newer

Re: [PATCH] x86/kernel: remove unneeded dead-store initialization

On Wed, Apr 7, 2021 at 12:07 PM Borislav Petkov wrote: > > On Wed, Apr 07, 2021 at 09:03:28PM +0200, Borislav Petkov wrote: > > On Wed, Apr 07, 2021 at 10:41:26AM -0700, Nick Desaulniers wrote: > > > You do have clang-tidy installed right? `which clang-tidy`? > > Btw,

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

me more cases using strncasecmp to check the entire string > > > such as rtrs-clt-sysfs.c does. drivers/pnp/interface.c checks > > > "disable" command with strncasecmp but it would also work if the > > > command is "disable-wrong". > > > >

[PATCH v2] gcov: re-fix clang-11+ support

Cc: sta...@vger.kernel.org #5.4+ Reported-by: Prasad Sodagudi Tested-by: Prasad Sodagudi Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor --- Changes V1 -> V2: * Carried Nathan's reviewed-by tag. * Rebased on mainline, as per Andrew. * Left off patch 2/2 from the seri

Re: [PATCH -next] lib: zstd: Make symbol 'HUF_compressWeights_wksp' static

On Thu, Apr 8, 2021 at 5:55 AM Zhao Xuehui wrote: > > The symbol 'HUF_compressWeights_wksp' is not used outside of > huf_compress.c, so this commit marks it static. Reviewed-by: Nick Desaulniers Quite a few other functions are declared in a header, but I don't see any

Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang

well the version of Clang that you were using? If it's not a binary release (built from source), would you be able to re-confirm with a released version? -- Thanks, ~Nick Desaulniers

Re: [PATCH] arm64: kvm: use -fno-jump-tables with clang

On Wed, May 23, 2018 at 4:54 AM Andrey Konovalov wrote: > On Tue, May 22, 2018 at 8:28 PM, Nick Desaulniers > wrote: > > On Fri, May 18, 2018 at 11:13 AM Marc Zyngier wrote: > >> > - you have checked that with a released version of the compiler, you > > > &

[clang] stack protector and f1f029c7bf

t revert ab94fcf528d12, or maybe a better approach? [0] https://lkml.org/lkml/2018/5/7/534 [1] https://bugs.llvm.org/show_bug.cgi?id=37512#c15 [2] https://bugs.llvm.org/show_bug.cgi?id=37512#c22 -- Thanks, ~Nick Desaulniers

Re: [GIT PULL] x86/build changes for v4.17

multiple different compilers. -- Thanks, ~Nick Desaulniers

Re: [GIT PULL] x86/build changes for v4.17

ther "features" > that the kernel requires, and maybe when all build options/configs are > really solid and working well, will we be able to properly consider it > as a reason to implement, or not implement, something in the kernel > source. Acknowledged. -- Thanks, ~Nick Desaulniers

Re: [GIT PULL] x86/build changes for v4.17

ng clang support to 0-day, since now this will fail outright to compile. -- Thanks, ~Nick Desaulniers

Re: [GIT PULL] x86/build changes for v4.17

ior". That's an actual "let's do > known invalid optimizations that are explicitly disallowed even by the > standard". Manoj already has a patch for this that looks like it's passed code review: https://reviews.llvm.org/D45289 -- Thanks, ~Nick Desaulniers

Re: [PATCH] arm/arm64: smccc: Use xN for arm64 register constraints with clang

WIP I guess it's not the end of the world if we have to raise > the minimum clang version to 7.x for newer kernels. Manoj fixed this in: https://reviews.llvm.org/rL328829 https://bugs.llvm.org/show_bug.cgi?id=36862 Looks set to ride the Clang 6.0 train. mka@ if you're planning another state of the union email, it would be good to note the clang 6.0 requirement for arm64. Is there anything left to do here? -- Thanks, ~Nick Desaulniers

[PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported

Clang does not recognize this compiler option. Reported-by: Prasad Sodagudi Signed-off-by: Nick Desaulniers --- Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 83b6c541565a..7f653c924c18 100644 --- a/Makefile +++ b/Makefile @@ -623,7

Re: [PATCH] kbuild: gcov: enable -fno-tree-loop-im if supported

er changes necessitating a v2. On Thu, Apr 26, 2018 at 2:29 PM Nick Desaulniers wrote: > Clang does not recognize this compiler option. > Reported-by: Prasad Sodagudi > Signed-off-by: Nick Desaulniers > --- > Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > d

[PATCH] crypto: blkcipher: prefer strlcpy to strncpy

Fixes stringop-truncation warnings from gcc-8. Signed-off-by: Nick Desaulniers --- crypto/ablkcipher.c | 8 crypto/blkcipher.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/crypto/ablkcipher.c b/crypto/ablkcipher.c index d880a48..e38867f 100644 --- a/crypto

[PATCH] kdb: prefer strlcpy to strncpy

Fixes stringop-truncation and stringop-overflow warnings from gcc-8. Signed-off-by: Nick Desaulniers --- kernel/debug/kdb/kdb_io.c | 2 +- kernel/debug/kdb/kdb_main.c| 4 ++-- kernel/debug/kdb/kdb_support.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel

[PATCH] tracing: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index b9061ed..b53a6c0 100644 --- a/kernel

[PATCH] ext4: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- fs/ext4/super.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index eb104e8..d47c85f 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -323,11

[PATCH] blk-wbt: tracing: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- include/trace/events/wbt.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/wbt.h b/include/trace/events/wbt.h index b048694..305252d 100644 --- a/include/trace

[PATCH] writeback: tracing: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- include/trace/events/writeback.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h index 32db72c

[PATCH] nvme: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 99b857e..b823ecb 100644 --- a/drivers/nvme/host/core.c +++ b

[PATCH] video/hdmi: prefer strlcpy to strncpy

Fixes a stringop-truncation warning from gcc-8. Signed-off-by: Nick Desaulniers --- drivers/video/hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index 111a0ab..46c184c 100644 --- a/drivers/video/hdmi.c +++ b/drivers

Re: [PATCH] tracing: prefer strlcpy to strncpy

On Mon, May 28, 2018 at 11:03 PM, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers > --- > kernel/trace/trace_events_hist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/

Re: [PATCH] writeback: tracing: prefer strlcpy to strncpy

On Mon, May 28, 2018 at 11:37 PM, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers > --- > include/trace/events/writeback.h | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > di

Re: [PATCH] blk-wbt: tracing: prefer strlcpy to strncpy

On Mon, May 28, 2018 at 11:31 PM, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers > --- > include/trace/events/wbt.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/incl

Re: [PATCH] ext4: prefer strlcpy to strncpy

On Mon, May 28, 2018 at 11:21 PM, Nick Desaulniers wrote: > Fixes a stringop-truncation warning from gcc-8. > > Signed-off-by: Nick Desaulniers > --- > fs/ext4/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/super.c b/fs/ext4

Re: [PATCH] nvme: prefer strlcpy to strncpy

On Tue, May 29, 2018 at 1:11 AM, Christoph Hellwig wrote: > On Mon, May 28, 2018 at 11:49:18PM -0700, Nick Desaulniers wrote: >> Fixes a stringop-truncation warning from gcc-8. > > What would that warning be? Maybe it actually is genuinly useful, > and switching to strlcpy j

[PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations

: Nick Desaulniers Suggested-by: H. Peter Anvin Tested-by: Sedat Dilek --- include/linux/compiler-gcc.h | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index b4bf73f5e38f..7827bdf0e5e9 100644 --- a

[PATCH v2 0/2] extern inline native_save_fl for paravirt

first two patches and added a new first patch. Nick Desaulniers (2): compiler-gcc.h: add gnu_inline to all inline declarations x86: paravirt: make native_save_fl extern inline arch/x86/include/asm/irqflags.h | 2 +- arch/x86/kernel/Makefile| 1 + arch/x86/kernel/irqflags.S | 26

Re: [PATCH v2] cifs: use correct format characters

ch > updates the format character to the correct ones for ints and unsigned > ints. > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Louis Taylor Thanks for following up on the feedback. Reviewed-by: Nick Desaulniers > --- > fs/cifs/ci

Re: [PATCH] lib/raid6: use vdupq_n_u8 to avoid endianness warnings

On Thu, Feb 28, 2019 at 10:00 AM Robin Murphy wrote: > > On 26/02/2019 20:44, Nick Desaulniers wrote: > > On Mon, Feb 25, 2019 at 11:19 PM Ard Biesheuvel > > wrote: > >> > >> On Tue, 26 Feb 2019 at 05:03, wrote: > >>> > >>> C

Re: [PATCH v2] wusb: use correct format characters

"%02hx %02hx %02hx %02hx %02hx %02hx %02hx %02hx", > +"%02hhx %02hhx %02hhx %02hhx %02hhx %02hhx %02hhx > %02hhx " > +"%02hhx %02hhx %02hhx %02hhx %02hhx %02hhx %02hhx > %02hhx", Looks like lib/vsprintf.c#format_decode() acc

Re: [PATCH] vfio/pci: use correct format characters

short' but the argument has type 'unsigned int' [-Wformat] > vendor, device, subvendor, subdevice, >^~~~~ > The types of these arguments are unconditionally defined, so this patch

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

id); > - return scnprintf(buf, PAGE_SIZE, "%s\n", pr_cdid); > + return sprintf(buf, "%16ph\n", cbaf->cdid.data); > } Great simplification overall. If you wanted to push further, cbaf_wusb_c{h|d}id_show() are basically (almost) the same function no

Re: Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

vate flags to userspace ethtool. So the variable declaration should get a `__unused` annotation then (and maybe a comment)? -- Thanks, ~Nick Desaulniers

[PATCH] x86/boot: clean up headers

clude them, and sort the headers alphabetically. Link: https://bugs.llvm.org/show_bug.cgi?id=33587 Link: https://github.com/ClangBuiltLinux/linux/issues/347 Signed-off-by: Nick Desaulniers --- Note that this only regresses for us on linux-next (not mainline). arch/x86/boot/string.c | 7 ---

Re: [PATCH v3] arm64: sysreg: make mrs_s and msr_s macros work with Clang and LTO

On Tue, Apr 16, 2019 at 10:08 AM Mark Rutland wrote: > On Mon, Apr 15, 2019 at 10:22:27AM -0700, Nick Desaulniers wrote: > > Also, I look forward to this patch for use of Clang's integrated > > assembler (regardless of LTO). I remember getting frustrated trying > > to

[PATCH] sh: require --Wl,--hash-style=sysv

Towards the goal of removing cc-ldoption, prefer ld-option, or better yet, require --Wl,--hash-style=sysv since the selftest for vdso's requires DT_HASH. Cc: Andy Lutomirsky Cc: clang-built-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/sh/k

[PATCH] ia64: require -Wl,--hash-style=sysv

-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/ia64/kernel/Makefile.gate | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/Makefile.gate b/arch/ia64/kernel/Makefile.gate index f53faf48b7ce..846867bff6d6 100644 --- a

[PATCH] mips: vdso: drop unnecessary cc-ldoption

: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/mips/vdso/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/mips/vdso/Makefile b/arch/mips/vdso/Makefile

[PATCH] s390: vdso: drop unnecessary cc-ldoption

-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/s390/kernel/vdso32/Makefile | 2 +- arch/s390/kernel/vdso64/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/vdso32/Makefile b/arch/s390/kernel/vdso32

[PATCH] x86: um: vdso: drop unnecessary cc-ldoption

-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/x86/um/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile index bf94060fc06f..0caddd6acb22 100644 --- a/arch/x86/um

[PATCH] nds32: vdso: drop unnecessary cc-ldoption

-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/nds32/kernel/vdso/Makefile | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/nds32/kernel/vdso/Makefile b/arch/nds32/kernel/vdso/Makefile index e6c50a701313..d379645cad74

[PATCH] riscv: vdso: drop unnecessary cc-ldoption

-li...@googlegroups.com Suggested-by: Masahiro Yamada Signed-off-by: Nick Desaulniers --- arch/riscv/kernel/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile index fec62b24df89..b07b765f312a 100644

<    1   2   3   4   5   6   7   8   9   10   >