Re: [PATCH 1/3] dw_mmc: Don't loop when handling an interrupt

2013-03-13 Thread Markos Chandras
On 03/13/2013 02:22 PM, Seungwon Jeon wrote: > On Tuesday, March 12, 2013, Markos Chandras wrote: >> There is no reason to loop when handling an interrupt. The "if" clauses >> will handle all of them sequentially. This also eliminates the extra loop >> we used to

Re: [PATCH 1/3] dw_mmc: Don't loop when handling an interrupt

2013-03-13 Thread Markos Chandras
On 03/13/2013 02:26 PM, Chris Ball wrote: Hi, On Wed, Mar 13 2013, Seungwon Jeon wrote: On Tuesday, March 12, 2013, Markos Chandras wrote: There is no reason to loop when handling an interrupt. The "if" clauses will handle all of them sequentially. This also eliminates the extra lo

Re: [PATCH] MIPS: SmartMIPS: Fix build

2013-10-07 Thread Markos Chandras
! Reviewed-by: Markos Chandras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-13 Thread Markos Chandras
On 06/13/13 09:34, David Miller wrote: From: Sergei Shtylyov Date: Wed, 12 Jun 2013 00:45:54 +0400 We have the user of 3Com EISA cards on this list and I've fixed EISA specific bug in this driver not long ago. Then I obviously must reject this patch. Hi David, Yes please reject this p

[PATCH] drivers: Select dependencies for the VIRTUALIZATION symbol

2013-06-07 Thread Markos Chandras
MOTEPROC && RPMSG) selects VIRTUALIZATION which has unmet direct dependencies (HAVE_KVM) Signed-off-by: Markos Chandras Cc: Ohad Ben-Cohen --- drivers/remoteproc/Kconfig | 1 + drivers/rpmsg/Kconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/remoteproc/Kconfig b/dr

Re: [PATCH] drivers: Select dependencies for the VIRTUALIZATION symbol

2013-06-09 Thread Markos Chandras
On 9 June 2013 00:40, Randy Dunlap wrote: > On 06/07/13 04:23, Markos Chandras wrote: >> The VIRTUALIZATION symbol depends on HAVE_KVM but CONFIG_REMOTEPROC >> and CONFIG_RPMSG do not select HAVE_KVM leading to the following >> warning and build problems later on: >&

Re: Build regressions/improvements in v3.10-rc1 (mips)

2013-06-11 Thread Markos Chandras
I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds > Hi Geert, My understanding is that this driver shouldn't depend on (PCI || EISA) but rather on PCI because the P

[PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Markos Chandras
om/3c59x.c:1044:3: error: implicit declaration of function 'pci_iounmap' [-Werror=implicit-function-declaration] Cc: David S. Miller Cc: Paul Gortmaker Cc: net...@vger.kernel.org Signed-off-by: Markos Chandras --- drivers/net/ethernet/3com/Kconfig | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Markos Chandras
On 11 June 2013 17:30, Paul Gortmaker wrote: > On 13-06-11 10:57 AM, Markos Chandras wrote: >> The Vortex driver depends on PCI with optional support for EISA. >> >> This fixes build problems when EISA is selected but not PCI. >> >> drivers/net/ethernet/3co

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Markos Chandras
On 11 June 2013 19:09, Sergei Shtylyov wrote: > Hello. > > > On 11-06-2013 18:57, Markos Chandras wrote: > >> The Vortex driver depends on PCI with optional support for EISA. > > >> This fixes build problems when EISA is selected but not PCI. > > >> dr

Re: [PATCH] drivers/net/ethernet/3com: Drop EISA dependency from VORTEX

2013-06-11 Thread Markos Chandras
>> configurations? Reading the code it seems to me that the PCI support >> is mandatory for the driver to build and work. > > Oh really? Having PCI disabled seems fine on today's net-next tree > from what I see below: Hi Paul, Ok I guess I was wrong then. -- Regards

[PATCH 1/3] dw_mmc: Don't loop when handling an interrupt

2013-03-12 Thread Markos Chandras
There is no reason to loop when handling an interrupt. The "if" clauses will handle all of them sequentially. This also eliminates the extra loop we used to take with no pending interrupts and we ended up breaking out of the while loop. Signed-off-by: Markos Chandras Cc: Seungwo

[PATCH 2/3] dw_mmc: Avoid adding the number of transmitted bytes twice

2013-03-12 Thread Markos Chandras
Previously, it was possible to add either 0 bytes or add nbytes twice if we broke out of the outer loop and then carry on to the "done" label. This is now fixed by adding the transferred bytes right after the pull/pop operation Signed-off-by: Markos Chandras Cc: Seungwon Jeon Cc: Jae

[PATCH 3/3] dw_mmc: Handle unaligned data submission correctly

2013-03-12 Thread Markos Chandras
ired data length or not. The patch was tested against mmc_test and all the tests passed. Signed-off-by: Markos Chandras Cc: Seungwon Jeon Cc: Jaehoon Chung Cc: Chris Ball --- The patch is based on Chris Ball's mmc-next branch drivers/mmc/host/dw_mmc.c | 33 --

Re: [PATCH v2] MIPS: Fix console output for Fulong2e system

2015-09-01 Thread Markos Chandras
MWARE_INTERFACE is not configured. As a result, the Fulong2e > system has no console. > > Fixes: 3adeb2566b9b ("MIPS: Loongson: Improve LEFI firmware interface") > Acked-by: Huacai Chen > Signed-off-by: Guenter Roeck > --- Tested-by: Markos Chandras -- markos -- To unsu

[PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map GIC user section

2015-10-12 Thread Markos Chandras
- Avoid renaming function arguments and use __gic_base_addr to hold the base GIC address prior to ioremap.] Cc: Thomas Gleixner Cc: Jason Cooper Cc: Marc Zyngier Cc: linux-kernel@vger.kernel.org Signed-off-by: Alex Smith Signed-off-by: Markos Chandras --- Changes since v1: - Move mapping code t

[PATCH v2 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-12 Thread Markos Chandras
ALL ifdef - Use gic_get_usm_range so we can do the GIC mapping in the arch/mips/kernel/vdso instead of the GIC irqchip driver] Cc: linux-kernel@vger.kernel.org Signed-off-by: Alex Smith Signed-off-by: Markos Chandras --- Changes since v1: - Use gic_get_usm_range so we can do the GIC mapping in the arch/m

Re: [PATCH] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall

2015-10-16 Thread Markos Chandras
On 10/15/2015 07:50 PM, Leonid Yegoshin wrote: > MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly > set to processing aka rt_sigaction() variant only. > > Fixed. > > Signed-off-by: Leonid Yegoshin > --- > arch/mips/include/asm/signal.h | 15 --- > arch/mi

Re: [PATCH v3] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall

2015-10-21 Thread Markos Chandras
On 10/20/2015 07:12 PM, Leonid Yegoshin wrote: > On 10/20/2015 01:35 AM, Markos Chandras wrote: >> What tree did you use for this patch? It does not seem to apply to >> mainline or Ralf's upstream-sfr. > > May I ask you to elaborate more and send me a concern details?

[PATCH v3 3/3] MIPS: VDSO: Add implementations of gettimeofday() and clock_gettime()

2015-10-21 Thread Markos Chandras
ALL ifdef - Use gic_get_usm_range so we can do the GIC mapping in the arch/mips/kernel/vdso instead of the GIC irqchip driver] Cc: linux-kernel@vger.kernel.org Signed-off-by: Alex Smith Signed-off-by: Markos Chandras --- Changes since v2: - Do not export VDSO symbols if the toolchain does not have proper

Re: [PATCH v3] MIPS64: signal: n64 kernel bugfix of MIPS32 o32 ABI sigaction syscall

2015-10-20 Thread Markos Chandras
On 10/19/2015 07:39 PM, Leonid Yegoshin wrote: > MIPS32 o32 ABI sigaction() processing on MIPS64 n64 kernel was incorrectly > set to processing aka rt_sigaction() variant only. > > Fixed. > -- > V3: Signature added. > v2: Taken in account CONFIG vars interdependencies and conditional expression >

Re: [PATCH 2/3] irqchip: irq-mips-gic: Provide function to map GIC user section

2015-10-05 Thread Markos Chandras
Hi, On 09/28/2015 11:55 AM, Marc Zyngier wrote: > On 28/09/15 11:11, Markos Chandras wrote: >> From: Alex Smith >> >> The GIC provides a "user-mode visible" section containing a mirror of >> the counter registers which can be mapped into user memory.

Re: [PATCH] MIPS,prctl: add PR_[GS]ET_FP_MODE prctl options for MIPS

2015-01-13 Thread Markos Chandras
R_GET_FP_MODE); > > or modify the current FP mode of the process: > > err = prctl(PR_SET_FP_MODE, new_mode); > > Signed-off-by: Paul Burton > Cc: Matthew Fortune > Cc: Markos Chandras Hi, I think the "MIPS,prctl" in the title should be "MIPS: prctl"

Re: [PATCH] MIPS,prctl: add PR_[GS]ET_FP_MODE prctl options for MIPS

2015-01-16 Thread Markos Chandras
On 01/13/2015 01:12 PM, Markos Chandras wrote: > On 01/08/2015 12:17 PM, Paul Burton wrote: >> Userland code may be built using an ABI which permits linking to objects >> that have more restrictive floating point requirements. For example, >> userland code may be built to ta

Re: [PATCH] MIPS64: R6: R2 emulation bugfix

2015-04-29 Thread Markos Chandras
nd more recently added than pieces of code that use > STR, e.g. unaligned.c that has been there since forever. And we do use > __stringify in many other cases. > > On the other hand STR is short and sweet, unlike __stringify. The patch overall looks good to me so here is my Review

Re: [PATCH 0/6] MIPS/BPF fixes for 4.3

2015-06-05 Thread Markos Chandras
On 06/04/2015 07:40 PM, David Miller wrote: > > I think your Subject meant to say "fixes for 4.2" right? > > Because we're currently finishing up 4.1.x and the next merge > window will be for 4.2.x > Hi David, Ralf only accepts patches for MIPS 4.2 that have been posted before 4.1-rc5. This is

Re: [PATCH 0/6] MIPS/BPF fixes for 4.3

2015-06-05 Thread Markos Chandras
On 06/04/2015 05:49 PM, Alexei Starovoitov wrote: > On 6/4/15 3:56 AM, Markos Chandras wrote: >> Here are some fixes for MIPS/BPF. The first 5 patches do some cleanup >> and lay the groundwork for the final one which introduces assembly >> helpers >> for MIPS and MIPS

[PATCH 5/6] MIPS: net: BPF: Use BPF register names to describe the ABI

2015-06-04 Thread Markos Chandras
Use the BPF register names instead of the arch register names to document how the ABI is structured. Cc: net...@vger.kernel.org Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras

[PATCH 4/6] MIPS: net: BPF: Move register definition to the BPF header

2015-06-04 Thread Markos Chandras
The registers will be used by a subsequent patch introducing ASM helpers so move them to a common header. Cc: net...@vger.kernel.org Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Marko

[PATCH 6/6] MIPS: net: BPF: Introduce BPF ASM helpers

2015-06-04 Thread Markos Chandras
: net...@vger.kernel.org Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras --- I have uploaded the script and the bpf result files in my LMO webspace in case you want to have a look. I di

[PATCH 0/6] MIPS/BPF fixes for 4.3

2015-06-04 Thread Markos Chandras
testsuite happy with all 60 tests passing. This is based in 4.1-rc6. The patchset is also available in my git tree. https://github.com/hwoarang/linux/tree/4.3-bpf The last patch also contains performance results along with the relevant scripts and data used for the analysis. Markos Chandras (6

[PATCH 2/6] MIPS: net: BPF: Replace RSIZE with SZREG

2015-06-04 Thread Markos Chandras
The RSZIE was used to determine the register width but MIPS already defines SZREG so use that instead. Cc: net...@vger.kernel.org Cc: "David S. Miller" Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Marko

[PATCH 3/6] MIPS: net: BPF: Fix stack pointer allocation

2015-06-04 Thread Markos Chandras
Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras --- arch/mips/net/bpf_jit.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/mips/net/bpf_jit.c b/arch/mips/net/bpf_jit.c index 56

[PATCH 1/6] MIPS: net: BPF: Free up some callee-saved registers

2015-06-04 Thread Markos Chandras
Cc: Daniel Borkmann Cc: Hannes Frederic Sowa Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras --- arch/mips/net/bpf_jit.c | 35 +++ arch/mips/net/bpf_jit.h | 2 ++ 2 files changed, 17 insertions(+), 20 deletions(-) diff --git a/arch/mips/net/bpf_ji

Re: [PATCH v2] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS

2014-03-12 Thread Markos Chandras
On 02/19/2014 10:15 AM, Markos Chandras wrote: The Makefile is designed to use the host toolchain so it may be unsafe to build the tests if the kernel has been configured and built for another architecture. This fixes a build problem when the kernel has been configured and built for the MIPS

Re: [PATCH 1/6][RFC] syscall: define syscall_get_arch() for each audit-supported arch

2014-03-06 Thread Markos Chandras
Hi Richard, On 03/05/2014 09:27 PM, Richard Guy Briggs wrote: Each arch that supports audit requires syscall_get_arch() to able to log and identify architecture-dependent syscall numbers. The information is used in at least two different subsystems, so standardize it in the same call across all

[PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

2014-03-06 Thread Markos Chandras
is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690 "perf tools: bfd.h/libbfd detection fails with recent binutils" See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243 CC: David S. Miller CC: Daniel Borkmann Signed-off-by: Markos Chandras --- tools/net/Makefile | 2

Re: [PATCH] Makefile: Unset stack-protector gcc flag if it is not supported

2014-02-13 Thread Markos Chandras
On 02/07/2014 05:15 PM, Markos Chandras wrote: In case the compiler does not support the stack-protector option, unset the flag to avoid build failures. Printing a warning is enough to let the user know that this flag will not be used. Fixes the following build problem when using a toolchain

Re: [PATCH] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS

2014-02-13 Thread Markos Chandras
On 02/13/2014 05:27 PM, Markos Chandras wrote: The Makefile is designed to use the host toolchain so it may be unsafe to build the tests if the kernel has been configured and built for another architecture. This fixes a build problem when the kernel has been configured and built for the MIPS

[PATCH v2] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS

2014-02-19 Thread Markos Chandras
: linux-kernel@vger.kernel.org Reported-by: Paul Gortmaker Signed-off-by: Markos Chandras --- This build problem is only reproducible on the linux-next tree at the moment Changes since v1: - Rework code so native builds are allowed on MIPS --- samples/seccomp/Makefile | 14 ++ 1 file

Re: [PATCH] Makefile: Unset stack-protector gcc flag if it is not supported

2014-02-20 Thread Markos Chandras
On 02/07/2014 05:15 PM, Markos Chandras wrote: In case the compiler does not support the stack-protector option, unset the flag to avoid build failures. Printing a warning is enough to let the user know that this flag will not be used. Fixes the following build problem when using a toolchain

Re: [PATCH] Makefile: Unset stack-protector gcc flag if it is not supported

2014-02-20 Thread Markos Chandras
On 02/20/2014 12:53 PM, Richard Weinberger wrote: On Thu, Feb 20, 2014 at 1:46 PM, Markos Chandras wrote: On 02/07/2014 05:15 PM, Markos Chandras wrote: In case the compiler does not support the stack-protector option, unset the flag to avoid build failures. Printing a warning is enough to

[PATCH] percpu-defs: Include missing linux/cache.h header

2013-10-29 Thread Markos Chandras
The percpu-defs.h header uses the cacheline_aligned* macros which are defined in the linux/cache.h header. Cc: Tejun Heo Cc: Christoph Lameter Signed-off-by: Markos Chandras --- include/linux/percpu-defs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/percpu-defs.h b

Re: MIPS seccomp and changing syscalls

2014-07-18 Thread Markos Chandras
Hi Kees, On 07/17/2014 11:29 PM, Kees Cook wrote: > Hi, > > I recently fixed a bug in seccomp on ARM that I think may be present > in the MIPS implementation too. In arch/mips/kernel/ptrace.c > syscall_trace_enter, the syscall variable is used (and returned), but > the syscall may be changed by e

[PATCH 0/2] Minor MIPS ftrace fixes

2014-09-22 Thread Markos Chandras
Hi, A few more fixes for ftrace/MIPS. The first patch fixes the value of the MCOUNT_INSN_SIZE definition which holds the total size of the mcount() call. The second one, fixes the selfpc argument for the ftrace tracing function. Markos Chandras (2): MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE

[PATCH 2/2] MIPS: mcount: Fix selfpc address for static trace

2014-09-22 Thread Markos Chandras
the proper MCOUNT_INSN_SIZE. Cc: Steven Rostedt Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras --- arch/mips/kernel/mcount.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/kernel/mcount.S b/arch/mips/kernel/mcount.S index 2f7c734771f4..3af48b7c7

[PATCH 1/2] MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE definition

2014-09-22 Thread Markos Chandras
, as described above, the MCOUNT_INSN_SIZE is used to denote the total overhead of the mcount() call. Cc: Steven Rostedt Cc: Ingo Molnar Cc: linux-kernel@vger.kernel.org Signed-off-by: Markos Chandras --- arch/mips/include/asm/ftrace.h | 2 +- arch/mips/kernel/ftrace.c | 4 +++- 2 files

Re: [PATCH 1/2] MIPS: ftrace.h: Fix the MCOUNT_INSN_SIZE definition

2014-09-23 Thread Markos Chandras
On 09/22/2014 07:25 PM, Steven Rostedt wrote: > On Mon, 22 Sep 2014 09:55:09 -0700 > David Daney wrote: > >> On 09/22/2014 06:32 AM, Markos Chandras wrote: >>> The MCOUNT_INSN_SIZE is meant to be used to denote the overall >>> size of the mcount() call. S

Re: [PATCH 2/2] MIPS: mcount: Fix selfpc address for static trace

2014-09-23 Thread Markos Chandras
On 09/22/2014 07:26 PM, Steven Rostedt wrote: > On Mon, 22 Sep 2014 14:32:59 +0100 > Markos Chandras wrote: > >> According to Documentation/trace/ftrace-design.txt, the selfpc >> should be the return address minus the mcount overhead (8 bytes). >> This brings st

Re: [PATCH V2] MIPS: bugfix of coherentio variable default setup

2014-09-11 Thread Markos Chandras
Hi Leonid, On 09/08/2014 08:10 PM, Leonid Yegoshin wrote: > Patch commit b6d92b4a6bdb880b39789c677b952c53a437028d > > MIPS: Add option to disable software I/O coherency. > > Some MIPS controllers have hardware I/O coherency. This patch > detects those and turns off software coherency

Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

2014-03-07 Thread Markos Chandras
On 03/06/2014 05:54 PM, David Miller wrote: From: Markos Chandras Date: Thu, 6 Mar 2014 09:15:54 + Fixes the following build problem with binutils-2.24 gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c In file included from bpf_jit_disasm.c:25:0: /usr/include/bfd.h:35:2: error

[PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

2014-03-10 Thread Markos Chandras
is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690 "perf tools: bfd.h/libbfd detection fails with recent binutils" See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243 CC: David S. Miller CC: Daniel Borkmann Acked-by: Daniel Borkmann Signed-off-by: Markos Chandras -

Re: [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

2014-03-11 Thread Markos Chandras
On 03/11/2014 01:53 AM, David Miller wrote: From: Markos Chandras Date: Mon, 10 Mar 2014 10:39:48 + Fixes the following build problem with binutils-2.24 gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c In file included from bpf_jit_disasm.c:25:0: /usr/include/bfd.h:35:2: error

[PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

2014-03-11 Thread Markos Chandras
ned-off-by: Markos Chandras --- Resend with net...@vger.kernel.org on CC Changes since v1: - Drop the 'bfd' word from the subject as requested by David Miller --- tools/net/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/net/Makefile b/tools/net/Ma

Re: [PATCH 2/3] arch/mips/net/bpf_jit.c: fix failure check

2014-07-17 Thread Markos Chandras
On 07/17/2014 02:27 PM, Andrey Utkin wrote: > static int pkt_type_offset(void) returned -1 in case of failure, and > actual (positive) offset value in case of success. In the only instance > of its usage, the result was saved to local "unsigned int off" variable, >which is used in a lot of plac

Re: [PATCH 2/3] arch/mips/net/bpf_jit.c: fix failure check

2014-07-17 Thread Markos Chandras
On 07/17/2014 02:58 PM, Andrey Utkin wrote: > 2014-07-17 16:52 GMT+03:00 Markos Chandras : >> Thanks for the patch. I would personally prefer to use a new signed int >> variable, but I am fine either way. > > If that's not a problem for performance etc., then i'l

Re: [PATCH] MIPS: OCTEON: make get_system_type() thread-safe

2014-07-22 Thread Markos Chandras
ype string only once during the early > boot. > > Signed-off-by: Aaro Koskinen > Cc: sta...@vger.kernel.org > --- > arch/mips/cavium-octeon/setup.c | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > It looks reasonable to me. Reviewed

Re: [PATCH] MIPS: Introduce the use of the managed version of kzalloc

2014-05-07 Thread Markos Chandras
tform_probe(struct > platform_device *pdev) > int ret; >[...] > - return ret; > + if (ret) > + return ret; > + trailing whitespace Apart from that, the patch seems to be ok. Thanks! Tested-by: Markos Chandras Reviewed-by: Markos Chandras -- markos

Re: mips:allmodconfig build failure in 3.16-rc1 due to bpf_jit code

2014-06-17 Thread Markos Chandras
t;> >>> The problem is due to a conflict with commit 348059313 (net: filter: >>> get rid of BPF_S_* >>> enum), which removed those definitions. >> >> Yep, it seems both got in this merge window from different trees. >> Don't have mips, but >

Re: mips:allmodconfig build failure in 3.16-rc1 due to bpf_jit code

2014-06-17 Thread Markos Chandras
On 06/17/2014 11:56 AM, Daniel Borkmann wrote: > On 06/17/2014 12:39 PM, Guenter Roeck wrote: >> On 06/17/2014 03:16 AM, Daniel Borkmann wrote: >>> On 06/17/2014 10:20 AM, Daniel Borkmann wrote: On 06/17/2014 04:24 AM, Guenter Roeck wrote: > mips:allmodconfig fails in 3.16-rc1 with lots of

Re: mips:allmodconfig build failure in 3.16-rc1 due to bpf_jit code

2014-06-18 Thread Markos Chandras
On 06/17/2014 08:38 PM, Alexei Starovoitov wrote: > On Tue, Jun 17, 2014 at 4:21 AM, Daniel Borkmann wrote: >> On 06/17/2014 01:09 PM, Markos Chandras wrote: >> ... >>> >>> Thanks for these instructions. I will try them myself once I find some >>> >>

Re: linux-next: manual merge of the random tree with the net-next tree

2013-11-14 Thread Markos Chandras
On 11/12/2013 08:46 PM, Stephen Rothwell wrote: Hi Daniel, On Tue, 12 Nov 2013 09:55:29 +0100 Daniel Borkmann wrote: On 11/12/2013 05:55 AM, Stephen Rothwell wrote: Today's linux-next merge of the random tree got a conflict in drivers/char/random.c between commit 0244ad004a54 ("random32: ad

[PATCH] Makefile: Unset stack-protector gcc flag if it is not supported

2014-02-07 Thread Markos Chandras
ake[2]: *** [scripts/mod/empty.o] Error 1 make[2]: *** Waiting for unfinished jobs scripts/Makefile.build:455: recipe for target 'scripts/mod' failed Cc: Michal Marek Cc: linux-kbu...@vger.kernel.org Signed-off-by: Markos Chandras --- Makefile | 2 ++ 1 file changed, 2 insertio

Release of Linux MTI-3.14-LTS kernel

2014-09-08 Thread Markos Chandras
Imagination Technologies is pleased to announce the release of its 3.14 LTS (Long-Term Support) MIPS kernel. The changelog below is based off the stable Linux 3.14.10 release done by Greg Kroah-Hartman in commit bbae7add628cfe96a1facd578dd1eddcd1030de7 back on June 30th. The code repository is host

[PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-09 Thread Markos Chandras
4:7: error: 'TIOCSRS485' undeclared (first use in this function) drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared (first use in this function) This patch adds these missing definitions Cc: Ricardo Ribalda Delgado Cc: Cc: Cc: Signed-off-by: Markos Chandra

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/09/2014 08:17 PM, Greg KH wrote: > On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: >> Commit e676253b19b2d269cccf67fdb1592120a0cd0676 >> (serial/8250: Add support for RS485 IOCTLs) added cases for the >> TIOC{S,G}RS485 commands but this bro

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote: > Hello Greg > > Sorry, Probably my bad :). I did resend a new patch using the _IO* > macros, that has been now merged to tty-next > > Regards! > > On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras > wrote: >

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote: > Hello Markos > > Sorry for the mess. I have already send a new patch for mips using the > _IO* macros > > Just to put things a bit into context: > > I did made the patch for serial and tested it only in x86. I wrongly > infer that the IOCT

Re: [PATCH] Documentation: filter: Add MIPS to architectures with BPF JIT

2014-09-10 Thread Markos Chandras
On 08/29/2014 04:33 PM, Daniel Borkmann wrote: > On 08/29/2014 04:23 PM, Markos Chandras wrote: >> MIPS supports BPF JIT since v3.16-rc1 >> >> Cc: Randy Dunlap >> Cc: "David S. Miller" >> Cc: Daniel Borkmann >> Cc: Alexei Starovoitov >>

Re: [PATCH] Documentation: filter: Add MIPS to architectures with BPF JIT

2014-09-10 Thread Markos Chandras
On 09/10/2014 02:31 PM, Daniel Borkmann wrote: > On 09/10/2014 03:23 PM, Markos Chandras wrote: >> On 08/29/2014 04:33 PM, Daniel Borkmann wrote: >>> On 08/29/2014 04:23 PM, Markos Chandras wrote: >>>> MIPS supports BPF JIT since v3.16-rc1 >>>> >&g

[PATCH] Documentation: filter: Add MIPS to architectures with BPF JIT

2014-09-10 Thread Markos Chandras
MIPS supports BPF JIT since v3.16-rc1 Cc: Randy Dunlap Cc: "David S. Miller" Cc: Daniel Borkmann Cc: Alexei Starovoitov Cc: linux-...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Acked-by: Daniel Borkmann Signed-off-by: Markos Chandras --- Documentation/networking/filt

[PATCH] SPI: spi-au1550: Fix build problem in au1550_spi_remove

2014-08-20 Thread Markos Chandras
:21: error: 'r' undeclared (first use in this function) release_mem_region(r->start, sizeof(psc_spi_t)); Cc: Mark Brown Cc: Himangi Saraogi Cc: linux-...@vger.kernel.org Cc: linux-m...@linux-mips.org Signed-off-by: Markos Chandras --- This has only been compile

[PATCH] Documentation: filter: Add MIPS to architectures with BPF JIT

2014-08-29 Thread Markos Chandras
MIPS supports BPF JIT since v3.16-rc1 Cc: Randy Dunlap Cc: "David S. Miller" Cc: Daniel Borkmann Cc: Alexei Starovoitov Cc: linux-...@vger.kernel.org Signed-off-by: Markos Chandras --- Based on v3.17-rc2 --- Documentation/networking/filter.txt | 6 +++--- 1 file changed, 3 insert

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 12:07 PM, Richard Cochran wrote: > On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote: >> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile >> index 293d6c09a11f..397c1cd2eda7 100644 >> --- a/Documentation/ptp/Makefile >&

Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-21 Thread Markos Chandras
On 10/21/2014 01:52 PM, Richard Cochran wrote: > (adding Peter Foley to CC ...) > > On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote: >> On 10/21/2014 12:07 PM, Richard Cochran wrote: >>> On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras

Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems

2014-10-30 Thread Markos Chandras
Hi, On 10/30/2014 01:48 AM, Leonid Yegoshin wrote: > A default dma_alloc_coherent() fails to alloc a coherent memory on > non-coherent > systems in case of device->coherent_dma_mask covering the whole memory space. > > In case of non-coherent systems the coherent memory on MIPS is restricted by

Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems

2014-10-30 Thread Markos Chandras
On 10/30/2014 09:51 AM, James Hogan wrote: > Hi Markos, > > On 30/10/14 09:48, Markos Chandras wrote: >>> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> index f9f4486

Boot problems on Malta with EVA (bisected to 12220dea07f1 "mm/slab: support slab merge")

2014-10-28 Thread Markos Chandras
Hi, It seems I am unable to boot my Malta with EVA. The problem appeared in the 3.18 merge window. I bisected the problem (between v3.17 and v3.18-rc1) and I found the following commit responsible for the broken boot. commit 12220dea07f1ac6ac717707104773d771c3f3077 Author: Joonsoo Kim Date: Th

Re: Boot problems on Malta with EVA (bisected to 12220dea07f1 "mm/slab: support slab merge")

2014-10-28 Thread Markos Chandras
On 10/28/2014 01:01 PM, Joonsoo Kim wrote: > 2014-10-28 19:45 GMT+09:00 Markos Chandras : >> Hi, >> >> It seems I am unable to boot my Malta with EVA. The problem appeared in >> the 3.18 merge window. I bisected the problem (between v3.17 and >> v3.18-rc1)

Re: Boot problems on Malta with EVA (bisected to 12220dea07f1 "mm/slab: support slab merge")

2014-10-28 Thread Markos Chandras
On 10/28/2014 01:19 PM, Markos Chandras wrote: > On 10/28/2014 01:01 PM, Joonsoo Kim wrote: >> 2014-10-28 19:45 GMT+09:00 Markos Chandras : >>> Hi, >>> >>> It seems I am unable to boot my Malta with EVA. The problem appeared in >>> the 3.18 merge wind

Re: Boot problems on Malta with EVA (bisected to 12220dea07f1 "mm/slab: support slab merge")

2014-10-28 Thread Markos Chandras
On 10/28/2014 02:21 PM, Joonsoo Kim wrote: > 2014-10-28 22:48 GMT+09:00 Joonsoo Kim : >> 2014-10-28 22:24 GMT+09:00 Markos Chandras : >>> On 10/28/2014 01:19 PM, Markos Chandras wrote: >>>> On 10/28/2014 01:01 PM, Joonsoo Kim wrote: >>>>> 2014-10-2

Re: Boot problems on Malta with EVA (bisected to 12220dea07f1 "mm/slab: support slab merge")

2014-10-28 Thread Markos Chandras
On 10/28/2014 03:00 PM, Joonsoo Kim wrote: > 2014-10-28 23:32 GMT+09:00 Markos Chandras : >> On 10/28/2014 02:21 PM, Joonsoo Kim wrote: >>> 2014-10-28 22:48 GMT+09:00 Joonsoo Kim : >>>> 2014-10-28 22:24 GMT+09:00 Markos Chandras : >>>>> On 10/28/2014

[PATCH] staging: xlr_net: Replace obsolete nlm_cop2_{enable,restore} macros

2014-10-02 Thread Markos Chandras
andran C Cc: net...@vger.kernel.org Signed-off-by: Markos Chandras --- drivers/staging/netlogic/xlr_net.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index 9bf407d6241a..469f75f0f818 100

Re: [PATCH 6/6] MIPS: net: BPF: Introduce BPF ASM helpers

2015-08-14 Thread Markos Chandras
On Thu, Aug 13, 2015 at 10:42:46PM +0200, Aurelien Jarno wrote: > > This patch relies on R2 instructions, and thus the Linux kernel fails to > build when targetting non-R2 CPUs. See for example: > > https://buildd.debian.org/status/fetch.php?pkg=linux&arch=mipsel&ver=4.2%7Erc6-1%7Eexp1&stamp=1439

Re: [PATCH] MIPS: fix build failure

2015-10-28 Thread Markos Chandras
On 10/28/2015 10:08 AM, Sudip Mukherjee wrote: > While building for mips defconfig the build failed with the error: > In function 'create_elf_tables': > arch/mips/include/asm/elf.h:425:14: error: > 'AT_SYSINFO_EHDR' undeclared (first use in this function) > > AT_SYSINFO_EHDR is defined in uapi/as

Re: [PATCH] MIPS: fix build failure

2015-10-28 Thread Markos Chandras
On 10/28/2015 10:18 AM, Markos Chandras wrote: > On 10/28/2015 10:08 AM, Sudip Mukherjee wrote: >> While building for mips defconfig the build failed with the error: >> In function 'create_elf_tables': >> arch/mips/include/asm/elf.h:425:14: error: >> '

[PATCH] Documentation: ptp: Fix build failure on MIPS cross builds

2014-10-20 Thread Markos Chandras
@vger.kernel.org Signed-off-by: Markos Chandras --- Documentation/ptp/Makefile | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile index 293d6c09a11f..397c1cd2eda7 100644 --- a/Documentation/ptp/Makefile +++ b/Documentation/ptp/Makefi

Re: [PATCH 3.19 000/177] 3.19.7-stable review

2015-05-05 Thread Markos Chandras
On 05/04/2015 01:07 AM, Guenter Roeck wrote: > On 05/02/2015 12:00 PM, Greg Kroah-Hartman wrote: >> This is the start of the stable review cycle for the 3.19.7 release. >> There are 177 patches in this series, all will be posted as a response >> to this one. If anyone has any issues with these bei

Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction"

2015-03-11 Thread Markos Chandras
On 02/23/2015 10:52 PM, David Daney wrote: > From: David Daney > > This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed. > > There are two problems: > > 1) It breaks OCTEON, which will now crash in early boot with: > > Kernel panic - not syncing: No TLB refill handler yet (CPU type:

[PATCH 1/3] irqchip: irq-mips-gic: Add new functions to start/stop the GIC counter

2015-03-23 Thread Markos Chandras
: Andrew Bresticker Cc: Qais Yousef Cc: Signed-off-by: Markos Chandras --- drivers/irqchip/irq-mips-gic.c | 21 + include/linux/irqchip/mips-gic.h | 2 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index

[PATCH 0/3] GIC counter fixes

2015-03-23 Thread Markos Chandras
Hi, Here are a few patches to ensure the GIC counter is running before we attempt to use it since the default value on a MIPS core can be '1' which means the GIC counter will be stopped after a CPU reset. These patches are based on 4.0-rc1. Markos Chandras (3): irqchip: irq-mips-gi

[PATCH 3/3] MIPS: Malta: malta-time: Ensure GIC counter is running

2015-03-23 Thread Markos Chandras
Start the GIC counter before we try to determine its frequency. Cc: Signed-off-by: Markos Chandras --- arch/mips/mti-malta/malta-time.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/mips/mti-malta/malta-time.c b/arch/mips/mti-malta/malta-time.c index ce02dbdedc62

[PATCH 2/3] clocksource: mips-gic-timer: Ensure GIC counter is running

2015-03-23 Thread Markos Chandras
Start the GIC counter after configuring the clocksource since there are no guarantees the counter will be running after a CPU reset. Cc: Daniel Lezcano Cc: Thomas Gleixner Cc: Signed-off-by: Markos Chandras --- drivers/clocksource/mips-gic-timer.c | 3 +++ 1 file changed, 3 insertions

[PATCH] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}

2015-03-18 Thread Markos Chandras
fifo relatively used and it can result to Tx fifo underflow errors. As a result of which, it's best to setup the SRAM on supported controllers so we can always use the NOUFLO bit. Cc: Cc: Cc: Cc: Don Fry Signed-off-by: Markos Chandras --- drivers/net/ethernet/amd/pcnet32.c

Re: [PATCH] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}

2015-03-19 Thread Markos Chandras
Hi Don, On Wed, Mar 18, 2015 at 07:07:34PM -0700, Don Fry wrote: > One little change to the comment is needed. See below > > Don > > On Wed, 2015-03-18 at 20:10 +, Markos Chandras wrote: > > + if (sram) { > > + /* > > +* The SRAM

[PATCH v2] net: ethernet: pcnet32: Setup the SRAM and NOUFLO on Am79C97{3,5}

2015-03-19 Thread Markos Chandras
fifo relatively used and it can result to Tx fifo underflow errors. As a result of which, it's best to setup the SRAM on supported controllers so we can always use the NOUFLO bit. Cc: Cc: Cc: Cc: Don Fry Signed-off-by: Markos Chandras --- Changes since v1: - Fix comment --- driver

Re: MIPS: CONFIG_CPU_MIPS_R6?

2015-02-15 Thread Markos Chandras
On Sat, Feb 14, 2015 at 06:26:45PM +0100, Paul Bolle wrote: > Your commit 33d73a3d4159 ("MIPS: lib: memset: Add MIPS R6 support") is > included in yesterday's linux next (ie, next-20150213). I noticed > because a script I use to check linux-next spotted a trivial problem > with it. > > It added a

Re: MIPS: FP32XX_HYBRID_FPRS

2015-02-16 Thread Markos Chandras
On Sat, Feb 14, 2015 at 06:33:59PM +0100, Paul Bolle wrote: > On Sat, 2015-02-14 at 17:57 +0100, Paul Bolle wrote: > > Your d8fb6537f1d4 ("MIPS: kernel: elf: Improve the overall ABI and FPU > > mode checks") is included in yesterday's linux-next (ie, next-20150213). > > I noticed because a script I

Re: linux-next: Tree for Feb 17 (mips build failures)

2015-02-18 Thread Markos Chandras
On Wed, Feb 18, 2015 at 07:37:40AM +1100, Stephen Rothwell wrote: > Hi Guenter, > > [Add Ralf to cc] > > On Tue, 17 Feb 2015 09:20:36 -0800 Guenter Roeck wrote: > > > > Build results: > > total: 121 pass: 109 fail: 12 > > Failed builds: > > mips:defconfig > > mips:allmodconfig > >

Re: linux-next: Tree for Feb 17 (mips build failures)

2015-02-18 Thread Markos Chandras
On Wed, Feb 18, 2015 at 05:54:57AM -0800, Guenter Roeck wrote: > On 02/18/2015 01:14 AM, Markos Chandras wrote: > > On Wed, Feb 18, 2015 at 07:37:40AM +1100, Stephen Rothwell wrote: > >> Hi Guenter, > >> > >> [Add Ralf to cc] > >> > >> On Tue,

  1   2   >