On 11 June 2013 17:30, Paul Gortmaker <paul.gortma...@windriver.com> wrote: > On 13-06-11 10:57 AM, Markos Chandras wrote: >> The Vortex driver depends on PCI with optional support for EISA. >> >> This fixes build problems when EISA is selected but not PCI. >> >> drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of >> function 'pci_iomap' [-Werror=implicit-function-declaration] >> drivers/net/ethernet/3com/3c59x.c:1044:3: error: implicit declaration of >> function 'pci_iounmap' [-Werror=implicit-function-declaration] >> >> Cc: David S. Miller <da...@davemloft.net> >> Cc: Paul Gortmaker <paul.gortma...@windriver.com> >> Cc: net...@vger.kernel.org >> Signed-off-by: Markos Chandras <markos.chand...@imgtec.com> >> --- >> drivers/net/ethernet/3com/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/3com/Kconfig >> b/drivers/net/ethernet/3com/Kconfig >> index 1c71c76..5c67f44 100644 >> --- a/drivers/net/ethernet/3com/Kconfig >> +++ b/drivers/net/ethernet/3com/Kconfig >> @@ -66,7 +66,7 @@ config PCMCIA_3C589 >> >> config VORTEX >> tristate "3c590/3c900 series (592/595/597) \"Vortex/Boomerang\" >> support" >> - depends on (PCI || EISA) && HAS_IOPORT >> + depends on PCI && HAS_IOPORT > > How can this fix it? The way I read your change is that you > have now made it impossible to select for EISA=y and PCI=n, > thus breaking EISA only configurations who would find their > driver support gone when they run "make oldconfig". > > P. > -- > >> select NET_CORE >> select MII >> ---help--- >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
Hi Paul, The driver does not seem to build if you only have EISA=y and PCI=n. Does this driver really support EISA only configurations? Reading the code it seems to me that the PCI support is mandatory for the driver to build and work. -- Regards, Markos Chandras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
