RE: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

2017-06-21 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Saturday, June 17, 2017 11:35 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; a...@infradead.org; l...@kernel.org; > platform-driver- > x...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [

RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

2017-10-16 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Monday, October 16, 2017 2:33 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net; >

RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

2017-10-16 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Monday, October 16, 2017 8:37 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; andy.shevche...@gmail.com; linux- > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org; > quasi...@g

RE: staging: rtsx: Add support for RTS5260

2017-10-16 Thread Mario.Limonciello
> -Original Message- > From: Lee Jones [mailto:lee.jo...@linaro.org] > Sent: Friday, October 13, 2017 4:15 PM > To: Limonciello, Mario > Cc: rui_f...@realsil.com.cn; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@driverdev.osuosl.org; ricky...@realtek.com; > wei_w...@re

RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Monday, October 16, 2017 4:57 PM > To: Limonciello, Mario > Cc: pali.ro...@gmail.com; andy.shevche...@gmail.com; linux- > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org; > quasi...@

RE: [PATCH v9 04/17] platform/x86: dell-wmi: allow 32k return size in the descriptor

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, October 17, 2017 1:47 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, October 17, 2017 2:04 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Limonciello, Mario > Sent: Tuesday, October 17, 2017 2:11 PM > To: 'Pali Rohár' > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net; > mj...@google.com; h...@lst

RE: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, October 17, 2017 2:25 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; andy.shevche...@gmail.com; linux- > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org; > quasi...@

RE: [PATCH v9 03/17] platform/x86: dell-wmi: clean up wmi descriptor check

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, October 17, 2017 1:45 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH v9 05/17] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-10-17 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Tuesday, October 17, 2017 1:59 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH v11 14/15] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-11-01 Thread Mario.Limonciello
> > +/* This structure may be modified by the firmware when we enter > > + * system management mode through SMM, hence the volatiles > > + */ > > +struct calling_interface_buffer { > > + __u16 class; > > Hey Mario, > > I just realized that there is a slight problem calling this identifier >

RE: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-11-01 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Wednesday, November 1, 2017 3:19 AM > To: Darren Hart > Cc: Limonciello, Mario ; > andy.shevche...@gmail.com; linux-kernel@vger.kernel.org; platform-driver- > x...@vger.kernel.org; l...@kernel.org; quasi...@googl

RE: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

2017-10-26 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of AceLan Kao > Sent: Thursday, October 26, 2017 2:54 AM > To: Darren Hart ; Andy Shevchenko > ; linux-kernel@vger.kernel.org; platform-driver- > x...@vger.

RE: [PATCH] platform/x86: dell-*wmi*: Relay failed initial probe to dependent drivers

2017-11-03 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Thursday, November 2, 2017 7:57 PM > To: Limonciello, Mario > Cc: Andy Shevchenko ; LKML ker...@vger.kernel.org>; platform-driver-...@vger.kernel.org; > pali.ro...@gmail.com > Subject: Re: [PATCH] platform/x86:

RE: [PATCH v12 00/16] Introduce support for Dell SMBIOS over WMI

2017-11-03 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Thursday, November 2, 2017 7:50 PM > To: Limonciello, Mario > Cc: Andy Shevchenko ; LKML ker...@vger.kernel.org>; platform-driver-...@vger.kernel.org; Andy Lutomirski > ; quasi...@google.com; pali.ro...@gmail.c

RE: [PATCH v12 00/16] Introduce support for Dell SMBIOS over WMI

2017-11-03 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Friday, November 3, 2017 4:01 PM > To: Limonciello, Mario > Cc: andy.shevche...@gmail.com; linux-kernel@vger.kernel.org; platform-driver- > x...@vger.kernel.org; l...@kernel.org; quasi...@google.com; > pali.ro..

RE: [PATCH 2/2] platform/x86: dell-*wmi*: Relay failed initial probe to dependent drivers

2017-11-03 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Friday, November 3, 2017 7:53 PM > To: Limonciello, Mario > Cc: Andy Shevchenko ; LKML ker...@vger.kernel.org>; platform-driver-...@vger.kernel.org; > pali.ro...@gmail.com > Subject: Re: [PATCH 2/2] platform/x8

RE: drivers/x86: add thinkpad-wmi

2017-11-06 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Corentin Chary > Sent: Saturday, November 4, 2017 10:23 AM > To: Limonciello, Mario > Cc: Darren Hart ; Andy Shevchenko > ; platform-driver-...@vger.k

RE: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

2017-10-18 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Wednesday, October 18, 2017 2:29 AM > To: Greg KH ; Alan Cox > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net

RE: [PATCH v9 11/17] platform/x86: dell-smbios-smm: test for WSMT

2017-10-18 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Wednesday, October 18, 2017 2:09 PM > To: Pali Rohár > Cc: Limonciello, Mario ; Andy Shevchenko > ; LKML ; platform- > driver-...@vger.kernel.org; Andy Lutomirski ; > quasi...@google.com; r...@rjwysocki.net; mj.

RE: [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI

2017-10-18 Thread Mario.Limonciello
> -Original Message- > From: Limonciello, Mario > Sent: Wednesday, October 18, 2017 8:56 AM > To: 'Pali Rohár' ; Greg KH ; Alan Cox > > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net; > m

RE: [PATCH v10 11/15] platform/x86: dell-smbios-smm: test for WSMT

2017-10-19 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Thursday, October 19, 2017 1:09 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

2017-10-27 Thread Mario.Limonciello
> > > > Looking at the comment for serial8250_get_port, it sounds like the serial > > driver > > doesn't really want other drivers using this function outside of > > suspend/resume > callback. > > > > /** > > * serial8250_get_port - retrieve struct uart_8250_port > > * @line: serial line number

RE: [PATCH v11 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-10-30 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Monday, October 30, 2017 6:47 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...@vger.kernel.org; Andy > Lutomirski ; quasi...@google.com; r...@rjwysocki.net;

RE: [PATCH v11 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

2017-10-30 Thread Mario.Limonciello
> > Hint: you can move this check out of j-loop as condition is independent > of it. That's true, thanks. > > Also how many tokens are there? Is not quadratic solution too slow? > ~< 250 on most machines is what I've seen. To me that that's a small enough number that this is quick. It only

RE: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc

2018-06-20 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Wednesday, June 20, 2018 7:17 PM > To: Kees Cook > Cc: LKML; Andy Shevchenko; Platform Driver; Mihai Donțu; Limonciello, Mario > Subject: Re: [PATCH] platform/x86: wmi: Do not mix pages and kmalloc > > On Wed, J

RE: [PATCH v3] Support intel-vbtn based tablet mode switch

2018-01-23 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Marco Martin > Sent: Tuesday, January 23, 2018 6:42 AM > To: linux-kernel@vger.kernel.org > Cc: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infrade

Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

2017-05-12 Thread Mario.Limonciello
> Some testing reports suggest that this will fix the issues we've > seen on Dell laptops. It think it also makes sense to revert the quirk that was created based upon the previous aggressiveness of re-entry to PS4 on those machines. Are you expecting to split that up into a second patch also t

Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

2017-05-12 Thread Mario.Limonciello
>Yes, mostly. I've written the patch, but I was planning to target it >at 4.12 or 4.13 but not -stable. It's mostly just a cleanup and has >no real power saving benefit since the RSTe timeouts are so absurdly >conservative that I doubt PS4 will happen in practical usage. OK. >Perhaps >in suspe

RE: [PATCH 1/2] ACPI / PM: Use Low Power S0 Idle on more systems

2018-01-10 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Wednesday, January 10, 2018 6:26 AM > To: Linux ACPI > Cc: Andy Shevchenko ; Darren Hart > ; LKML ; Linux PM p...@vger.kern

RE: [PATCH 1/2] ACPI / PM: Use Low Power S0 Idle on more systems

2018-01-11 Thread Mario.Limonciello
> -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of Rafael J. > Wysocki > Sent: Wednesday, January 10, 2018 4:23 PM > To: Limonciello, Mario > Cc: Rafael J. Wysocki ; ACPI Devel Maling List a...@vger.kernel.org>; Andy Shevchenko ; > Darren Hart ; Lin

RE: [PATCH] platform/x86: dell-laptop: Guard SMBIOS calls with a mutex

2018-01-30 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Tuesday, January 30, 2018 5:03 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...

RE: [PATCH] ACPI: Parse entire table as a term_list for Dell XPS 9570 and Precision M5530

2018-01-30 Thread Mario.Limonciello
> -Original Message- > From: Schmauss, Erik [mailto:erik.schma...@intel.com] > Sent: Tuesday, January 30, 2018 12:38 PM > To: Andy Shevchenko ; Kai-Heng Feng > > Cc: Rafael J. Wysocki ; Len Brown ; ACPI > Devel Maling List ; Linux Kernel Mailing List > ker...@vger.kernel.org>; Limoncie

RE: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than globally

2018-01-31 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Wednesday, January 31, 2018 3:08 AM > To: Andy Shevchenko > Cc: Limonciello, Mario ; Darren Hart > ; LKML ; Platform Driver > > Subject: Re: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap > rather t

RE: Dell docking station & Dell Embedded Controller & PS/2 devices

2018-02-01 Thread Mario.Limonciello
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Thursday, February 1, 2018 1:30 PM > To: Pali Rohár > Cc: Limonciello, Mario ; linux- > in...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: Dell docking station & Dell Embedded Controll

RE: Dell docking station & Dell Embedded Controller & PS/2 devices

2018-02-01 Thread Mario.Limonciello
> -Original Message- > From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] > Sent: Thursday, February 1, 2018 3:14 PM > To: Limonciello, Mario > Cc: Pali Rohár ; linux-in...@vger.kernel.org; lkml > ker...@vger.kernel.org> > Subject: Re: Dell docking station & Dell Embedded Controlle

RE: [PATCH] Support tablet mode switch for Dell laptops

2018-01-18 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Andy Shevchenko > Sent: Thursday, January 18, 2018 9:13 AM > To: Marco Martin ; Limonciello, Mario > > Cc: Linux Kernel Mailing List ; Matthew Garrett >

RE: [PATCH v2] r8152: disable RX aggregation on Dell TB16 dock

2018-01-18 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, January 18, 2018 10:57 AM > To: David Miller > Cc: Hayes Wang ; gre...@linuxfoundation.org; linux- > u...@vger.kernel.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org; > Limonciello,

RE: [PATCH] Support tablet mode switch for Dell laptops

2018-01-19 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Friday, January 19, 2018 10:01 AM > To: Dmitry Torokhov > Cc: linux-kernel@vger.kernel.org; mj...@srcf.ucam.org; dvh...@infradead.org

RE: [PATCH] platform/x86: dell-laptop: Filter out spurious keyboard backlight change events

2018-01-05 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Friday, January 5, 2018 5:07 AM > To: Andy Shevchenko > Cc: Hans de Goede ; Darren Hart > ; Andy Shevchenko ; Platform > Driver ; L

RE: [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering support

2018-01-05 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Friday, January 5, 2018 5:13 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; Andy Shevchenko ; > LKML ; platform-driver-...

RE: [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering support

2018-01-05 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Friday, January 5, 2018 8:44 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; andy.shevche...@gmail.com; linux- > ker...@vge

RE: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

2018-01-26 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Thursday, January 25, 2018 5:06 PM > To: Darren Hart > Cc: Alexander Abrosimov ; Matthew Garrett > ; Limonciello, Mario ; Andy > Shevchenko ; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org >

RE: [PATCH v5] Support intel-vbtn based tablet mode switch

2018-01-26 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Marco Martin > Sent: Friday, January 26, 2018 5:21 AM > To: linux-kernel@vger.kernel.org > Cc: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradea

RE: [PATCH v5] Support intel-vbtn based tablet mode switch

2018-01-26 Thread Mario.Limonciello
> -Original Message- > From: Marco Martin [mailto:notm...@gmail.com] > Sent: Friday, January 26, 2018 10:18 AM > To: Andy Shevchenko > Cc: Linux Kernel Mailing List ; Matthew Garrett > ; Pali Rohár ; Darren Hart > ; Andy Shevchenko ; Bhushan Shah > ; Platform Driver ; > Limonciello, Mario

RE: [PATCH v5] Support intel-vbtn based tablet mode switch

2018-01-26 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, January 26, 2018 10:28 AM > To: Limonciello, Mario > Cc: Marco Martin ; Linux Kernel Mailing List ker...@vger.kernel.org>; Matthew Garrett ; Pali Rohár > ; Darren Hart ; Andy Shevchenko > ; Bhu

RE: [PATCH v10 12/15] platform/x86: dell-smbios: Add filtering support

2018-01-29 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Saturday, January 27, 2018 8:51 AM > To: Limonciello, Mario > Cc: dvh...@infradead.org; andy.shevche...@gmail.com; linux- > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org; > quasi...

RE: [PATCH v7] Support intel-vbtn based tablet mode switch

2018-01-29 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Monday, January 29, 2018 12:57 PM > To: Marco Martin > Cc: Platform Driver ; Limonciello, Mario > ; Andy Shevchenko ; Pali > Rohár ; Darren Hart ; Matthew > Garrett ; Linux Kernel Mailing List ker...@v

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-11 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Pali Rohár > Sent: Saturday, March 10, 2018 6:38 PM > To: Limonciello, Mario > Cc: kai.heng.f...@canonical.com; mj...@srcf.ucam.org; dvh...@infradead.or

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-11 Thread Mario.Limonciello
> -Original Message- > From: Lukas Wunner [mailto:lu...@wunner.de] > Sent: Saturday, March 10, 2018 2:51 PM > To: Kai Heng Feng > Cc: Pali Rohár ; mj...@srcf.ucam.org; > dvh...@infradead.org; a...@infradead.org; Limonciello, Mario > ; ti...@suse.com; platform-driver- > x...@vger.kernel.org

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-11 Thread Mario.Limonciello
> > I think the missing aspect is that this is only used in AIO and laptop form > > factors where the discrete graphics is in a non-removable form factor. > > Why we are not checking if kernel is running on AIO or laptop form > factor then? Or it is not possible? Kai Heng, can you please confirm

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Mario.Limonciello
> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 2:54 AM > To: dvh...@infradead.org; Limonciello, Mario > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Dell Inc. XPS 13 9343/0TM99H fails

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-12 Thread Mario.Limonciello
> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 1:51 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: Dell Inc. XPS 13 9343/0TM99H f

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Mario.Limonciello
> -Original Message- > From: Dominik Brodowski [mailto:li...@dominikbrodowski.net] > Sent: Tuesday, March 13, 2018 2:44 PM > To: Limonciello, Mario ; Darren Hart > > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails to b

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-13 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Tuesday, March 13, 2018 3:56 PM > To: Limonciello, Mario > Cc: pali.ro...@gmail.com; mj...@srcf.ucam.org; dvh...@infradead.org; > a...@infradead.org; ti...@suse.com; platform-driver-...@vger.kernel.org;

RE: [PATCH v3 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-03-05 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Darren Hart > Sent: Tuesday, March 6, 2018 7:49 AM > To: Limonciello, Mario > Cc: andy.shevche...@gmail.com; pali.ro...@gmail.com; linux- > ker...@vger.

RE: [PATCH] power/hibernate: Make passing hibernate offsets more friendly

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net] > Sent: Monday, March 19, 2018 5:11 AM > To: Limonciello, Mario > Cc: linux-a...@vger.kernel.org; LKML > Subject: Re: [PATCH] power/hibernate: Make passing hibernate offsets more > friendly > > On Tuesday, March

RE: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10 version 1607 and 1703 OSI strings

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: Sasha Levin [mailto:alexander.le...@microsoft.com] > Sent: Monday, March 19, 2018 11:07 AM > To: linux-kernel@vger.kernel.org; sta...@vger.kernel.org > Cc: Limonciello, Mario ; Bob Moore > ; Erik Schmauss ; Rafael J . > Wysocki ; Sasha Levin > > Subject: [PATCH

RE: uvcvideo: Unknown video format,00000032-0002-0010-8000-00aa00389b71

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: Paul Menzel [mailto:pmenzel+linux-me...@molgen.mpg.de] > Sent: Wednesday, March 21, 2018 7:35 AM > To: Laurent Pinchart > Cc: linux-me...@vger.kernel.org; linux-kernel@vger.kernel.org; it+linux- > me...@molgen.mpg.de; Limonciello, Mario > Subject: Re: uvcvideo

RE: [PATCH AUTOSEL for 4.15 050/124] ACPICA: Recognize the Windows 10 version 1607 and 1703 OSI strings

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: Sasha Levin [mailto:alexander.le...@microsoft.com] > Sent: Monday, March 19, 2018 10:48 AM > To: linux-kernel@vger.kernel.org; sta...@vger.kernel.org > Cc: Limonciello, Mario ; Bob Moore > ; Erik Schmauss ; Rafael J . > Wysocki ; Sasha Levin > > Subject: [PATCH

RE: [PATCH] power/hibernate: Make passing hibernate offsets more friendly

2018-03-26 Thread Mario.Limonciello
> -Original Message- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of Rafael J. > Wysocki > Sent: Monday, March 26, 2018 4:38 AM > To: Limonciello, Mario > Cc: Rafael J. Wysocki ; ACPI Devel Maling List a...@vger.kernel.org>; Linux Kernel Mailing List > > Subject: R

RE: [PATCH 4.15 004/122] platform/x86: dell-laptop: Allocate buffer on heap rather than globally

2018-03-07 Thread Mario.Limonciello
Greg, Can you please make sure that the one that came in right after this is also applied at the same time? https://www.spinics.net/lists/stable/msg215268.html As you recommended before they weren't squashed together, but they should both come in at the same time. Thanks, > -Original Mess

RE: [PATCH 1/2] dell-led: Change dell-led.h to dell-common.h

2018-03-07 Thread Mario.Limonciello
> -Original Message- > From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, March 8, 2018 3:12 PM > To: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradead.org; > a...@infradead.org; Limonciello, Mario ; > ti...@suse.com > Cc: platform-driver-...@vger.kernel.or

RE: [PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-07 Thread Mario.Limonciello
> -Original Message- > From: Kai-Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, March 8, 2018 3:12 PM > To: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradead.org; > a...@infradead.org; Limonciello, Mario ; > ti...@suse.com > Cc: platform-driver-...@vger.kernel.or

RE: [PATCH 2/2] platform/x86: dell-*: Add interface for switchable graphics status query

2018-03-08 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Thursday, March 8, 2018 4:20 PM > To: Limonciello, Mario > Cc: mj...@srcf.ucam.org; pali.ro...@gmail.com; dvh...@infradead.org; > a...@infradead.org; ti...@suse.com; platform-driver-...@vger.kernel.org;

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-09 Thread Mario.Limonciello
> -Original Message- > From: Kai Heng Feng [mailto:kai.heng.f...@canonical.com] > Sent: Friday, March 9, 2018 5:30 PM > To: Pali Rohár > Cc: mj...@srcf.ucam.org; dvh...@infradead.org; a...@infradead.org; > Limonciello, Mario ; ti...@suse.com; platform- > driver-...@vger.kernel.org; Linux K

RE: [PATCH v2 3/3] ALSA: hda: Disabled unused audio controller for Dell platforms with Switchable Graphics

2018-03-09 Thread Mario.Limonciello
> > Pali is your concern that this code for matching vendor/subsystem is running > > on non-Dell too? The only other recommendation I think that can be to > > restrict > > to matching Dell OEM strings in SMBIOS table, but I don't think that's any > > better > > than the matching for VID/SSVID. >

RE: Dell Inc. XPS 13 9343/0TM99H fails to boot v4.16-rc5

2018-03-13 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Wednesday, March 14, 2018 5:43 AM > To: Limonciello, Mario > Cc: li...@dominikbrodowski.net; platform-driver-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: Dell Inc. XPS 13 9343/0TM99H fails

RE: [PATCH 0/5] Update and move Dell drivers dell_rbu and dcdbas

2018-09-26 Thread Mario.Limonciello
> On Tue, Sep 25, 2018 at 10:34 PM Stuart Hayes > wrote: > > > > From: Stuart Hayes > > > > The dell_rbu and dcdbas drivers need some changes, and should be moved to > > drivers/platform/x86. Additionally, dell_rbu needs a maintainer, and the > > listed maintainer for dcdbas is inactive and need

RE: [PATCH] platform/x86: intel-wmi-thunderbolt: Add dynamic debugging

2018-09-26 Thread Mario.Limonciello
> > On Wed, Sep 26, 2018 at 7:11 PM Mario Limonciello > wrote: > > > > Some users have been reporting issues with thunderbolt being turned off > > before fully initialized. This is suspected to be caused by userspace > > turning off the Thunderbolt controller using intel-wmi-thunderbolt > > prem

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-06-29 Thread Mario.Limonciello
> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Thursday, June 28, 2018 1:19 PM > To: alex.h...@canonical.com; dvh...@infradead.org; a...@infradead.org > Cc: platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org; > r...@rjwys

RE: [PATCH] platform/x86: dell-smbios-wmi: make function dell_smbios_wmi_call static

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Saturday, June 30, 2018 7:10 AM > To: Limonciello, Mario; Darren Hart; Andy Shevchenko; platform-driver- > x...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject:

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Monday, July 2, 2018 7:41 AM > To: Srinivas Pandruvada > Cc: Limonciello, Mario; Alex Hung; Darren Hart; Andy Shevchenko; Platform > Driver; > Linux Kernel Mailing List; Rafael J. Wysocki > Subject: Re:

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, June 29, 2018 2:30 PM > To: Stuart Hayes > Cc: Darren Hart; Limonciello, Mario; Linux Kernel Mailing List; Platform > Driver > Subject: Re: [PATCH v3] dcdbas: Add support for WSMT ACPI table >

RE: [PATCH v3] dcdbas: Add support for WSMT ACPI table

2018-07-02 Thread Mario.Limonciello
> > > I don't believe SMM communication ACPI table has ever been implemented by > Dell > > on server or client BIOS. I do agree this table describes the behavior > > that DCDBAS > driver > > has used since before even UEFI BIOS pretty accurately. > > So, EPS table has been for ages in Dell mach

RE: [RFC PATCH] ata: ahci: Enable DEVSLP by default on x86 modern standby platform

2018-07-02 Thread Mario.Limonciello
> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Monday, July 2, 2018 5:09 PM > To: Hans de Goede; Tejun Heo > Cc: r...@rjwysocki.net; alan@intel.com; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux...@vger.kernel.or

Re: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-06 Thread Mario.Limonciello
>I strongly advocate for vendors to have more control over their drivers, >but this scenario really frustrates me. I don't think I can justify this >to Linus as a fix. But before we just say "no" (because hey, I want >these fixes available as early as possible too), let's ask Rafael if he >has an o

RE: [PATCH] dell-laptop: Fix backlight detection

2018-07-08 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Sunday, July 8, 2018 8:09 AM > To: Damien Thébault > Cc: Matthew Garrett; Darren Hart; Andy Shevchenko; Limonciello, Mario; > platform- > driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [P

RE: [PATCH 5/5] thunderbolt: Add support for runtime PM

2018-07-08 Thread Mario.Limonciello
> -Original Message- > From: Yehezkel Bernat [mailto:yehezkel...@gmail.com] > Sent: Sunday, July 8, 2018 2:56 AM > To: Mika Westerberg > Cc: lu...@wunner.de; LKML; Andreas Noever; michael.ja...@intel.com; > r...@rjwysocki.net; christ...@kellner.me; Limonciello, Mario > Subject: Re: [PATCH 5

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-08 Thread Mario.Limonciello
> -Original Message- > From: Srinivas Pandruvada [mailto:srinivas.pandruv...@linux.intel.com] > Sent: Saturday, July 7, 2018 8:44 AM > To: Darren Hart; Andy Shevchenko > Cc: Limonciello, Mario; Alex Hung; Andy Shevchenko; Platform Driver; Linux > Kernel > Mailing List; Rafael J. Wysocki >

RE: [PATCH v2] platform/x86: intel-hid: Add support for Device Specific Methods

2018-07-09 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Monday, July 9, 2018 4:07 PM > To: Limonciello, Mario > Cc: srinivas.pandruv...@linux.intel.com; andy.shevche...@gmail.com; > alex.h...@canonical.com; a...@infradead.org; platform-driver- > x...@vger.kernel.org;

RE: [PATCH v2] dcdbas: Add support for WSMT ACPI table

2018-05-27 Thread Mario.Limonciello
> -Original Message- > From: Warzecha, Douglas > Sent: Friday, May 25, 2018 2:02 PM > To: Stuart Hayes > Cc: Limonciello, Mario; Dominguez, Jared; linux-kernel@vger.kernel.org > Subject: RE: [PATCH v2] dcdbas: Add support for WSMT ACPI table > > > On 05/16/2018 9:06 AM, Stuart Hayes wro

RE: wmi: usercopy: Kernel memory overwrite attempt detected to spans multiple pages (offset 0, size 4104)

2018-06-18 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Mihai Don?u > Sent: Sunday, June 17, 2018 2:30 PM > To: Kees Cook > Cc: LKML; Darren Hart; Andy Shevchenko; Platform Driver > Subject: Re: wmi: usercopy:

RE: [PATCH resend v4] dell_rbu: make firmware payload memory uncachable

2018-07-06 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Stuart Hayes > Sent: Friday, July 6, 2018 11:19 AM > To: linux-kernel@vger.kernel.org > Cc: Takashi Iwai; Andy Shevchenko; dvh...@infradead.org; Platfo

RE: `ucsi_acpi: probe of USBC000:00 failed with error -12` on Dell XPS 13 9370

2018-05-17 Thread Mario.Limonciello
> -Original Message- > From: Heikki Krogerus [mailto:heikki.kroge...@linux.intel.com] > Sent: Thursday, May 17, 2018 4:00 AM > To: Limonciello, Mario > Cc: g...@kroah.com; pmenzel+linux-...@molgen.mpg.de; linux- > u...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: `ucsi_acpi:

RE: Sometimes unusable i2c-hid devices in 4.17-rcX

2018-05-17 Thread Mario.Limonciello
> -Original Message- > From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] > Sent: Thursday, May 17, 2018 9:28 AM > To: Limonciello, Mario > Cc: linux-input; linux-kernel@vger.kernel.org > Subject: Re: Sometimes unusable i2c-hid devices in 4.17-rcX > > Hi Mario, > > On Wed, May

RE: [PATCH] platform/x86: intel-hid: Missing power button release on some Dell models

2019-01-07 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Jérôme de Bretagne > Sent: Sunday, January 6, 2019 11:57 AM > To: Alex Hung > Cc: platform-driver-...@vger.kernel.org; Andy Shevchenko; Darren Hart; > Limonciello, Mario; Rafael J.

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
> -Original Message- > From: Hayes Wang > Sent: Sunday, January 6, 2019 9:54 PM > To: Mark Lord; Kai Heng Feng > Cc: Ansis Atteka; David Miller; g...@kroah.com; rom...@fr.zoreil.com; > net...@vger.kernel.org; nic_swsd; linux-kernel@vger.kernel.org; linux- > u...@vger.kernel.org; Limonciell

RE: r8152: data corruption in various scenarios

2019-01-07 Thread Mario.Limonciello
> -Original Message- > From: Mark Lord > Sent: Monday, January 7, 2019 12:06 PM > To: Limonciello, Mario; hayesw...@realtek.com; kai.heng.f...@canonical.com > Cc: aatt...@nicira.com; da...@davemloft.net; g...@kroah.com; > rom...@fr.zoreil.com; net...@vger.kernel.org; nic_s...@realtek.com;

RE: A different PD controller firmware problem?

2018-11-08 Thread Mario.Limonciello
Ted, Sorry for my delayed responses. > > On Tue, Sep 11, 2018 at 01:02:00PM +, mario.limoncie...@dell.com wrote: > > > I tried 9370 and it detects the adapter correctly. IIRC I did the same > > > for 5530 and it worked as well. > > > > Thanks for confirming that. Hopefully the same change c

RE: issues with suspend on Dell XPS 13 2-in-1

2018-10-12 Thread Mario.Limonciello
> -Original Message- > From: Dennis Gilmore > Sent: Friday, October 12, 2018 8:39 AM > To: Pandruvada, Srinivas > Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Limonciello, > Mario > Subject: Re: issues with suspend on Dell XPS 13 2-in-1 > It appears I'm being added to t

RE: issues with suspend on Dell XPS 13 2-in-1

2018-10-14 Thread Mario.Limonciello
> El vie, 12-10-2018 a las 17:46 +, mario.limoncie...@dell.com > escribió: > > > -Original Message- > > > From: Dennis Gilmore > > > Sent: Friday, October 12, 2018 8:39 AM > > > To: Pandruvada, Srinivas > > > Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; > > > Limonciel

RE: [PATCH v5] dcdbas: Add support for WSMT ACPI table

2018-07-16 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Friday, July 13, 2018 9:35 AM > To: Stuart Hayes > Cc: Limonciello, Mario; Darren Hart; Linux Kernel Mailing List; Platform > Driver > Subject: Re: [PATCH v5] dcdbas: Add support for WSMT ACPI table >

RE: Sometimes unusable i2c-hid devices in 4.17-rcX

2018-05-22 Thread Mario.Limonciello
Benjamin, > -Original Message- > From: Benjamin Tissoires [mailto:benjamin.tissoi...@gmail.com] > Sent: Friday, May 18, 2018 1:18 PM > To: Limonciello, Mario > Cc: linux-input; linux-kernel@vger.kernel.org > Subject: Re: Sometimes unusable i2c-hid devices in 4.17-rcX > > On Thu, May 17, 2

RE: [RFC] power/hibernate: Make passing hibernate offsets more friendly

2018-02-28 Thread Mario.Limonciello
> -Original Message- > From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > Sent: Wednesday, February 28, 2018 12:11 PM > To: Limonciello, Mario > Cc: Rafael J . Wysocki ; ACPI Devel Maling List a...@vger.kernel.org>; LKML > Subject: Re: [RFC] power/hibernate: Make passing hibern

RE: [PATCH v3 3/3] platform/x86: dell-smbios: Link all dell-smbios-* modules together

2018-03-01 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Thursday, March 1, 2018 11:49 AM > To: Limonciello, Mario > Cc: Andy Shevchenko ; pali.ro...@gmail.com; > LKML ; platform-driver-...@vger.kernel.org > Subject: Re: [PATCH v3 3/3] platform/x86: dell-smbios: Link

RE: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10 version 1607 and 1703 OSI strings

2018-03-28 Thread Mario.Limonciello
> -Original Message- > From: Moore, Robert [mailto:robert.mo...@intel.com] > Sent: Wednesday, March 28, 2018 12:16 PM > To: Limonciello, Mario ; > alexander.le...@microsoft.com; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Cc: Schmauss, Erik ; Wysocki, Rafael J > > Subject: RE:

RE: [PATCH AUTOSEL for 4.4 093/167] ACPICA: Recognize the Windows 10 version 1607 and 1703 OSI strings

2018-03-28 Thread Mario.Limonciello
> -Original Message- > From: Moore, Robert [mailto:robert.mo...@intel.com] > Sent: Wednesday, March 28, 2018 2:53 PM > To: Limonciello, Mario ; > alexander.le...@microsoft.com; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org > Cc: Schmauss, Erik ; Wysocki, Rafael J > > Subject: RE:

RE: drivers/platform/x86/dell-smbios-wmi.c:66: undefined reference to `wmidev_evaluate_method'

2018-04-27 Thread Mario.Limonciello
> -Original Message- > From: Randy Dunlap [mailto:rdun...@infradead.org] > Sent: Friday, April 27, 2018 12:56 PM > To: kbuild test robot; Limonciello, Mario > Cc: kbuild-...@01.org; linux-kernel@vger.kernel.org; Darren Hart (VMware) > Subject: Re: drivers/platform/x86/dell-smbios-wmi.c:66:

  1   2   3   4   5   >