> -----Original Message----- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Saturday, June 17, 2017 11:35 AM > To: Limonciello, Mario <mario_limoncie...@dell.com> > Cc: dvh...@infradead.org; a...@infradead.org; l...@kernel.org; > platform-driver- > x...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance > number > > On Friday 16 June 2017 18:33:54 mario.limoncie...@dell.com wrote: > > > -----Original Message----- > > > From: Limonciello, Mario > > > Sent: Thursday, June 15, 2017 10:16 AM > > > To: 'Pali Rohár' <pali.ro...@gmail.com>; Darren Hart > > > <dvh...@infradead.org> Cc: Andy Shevchenko <a...@infradead.org>; > > > Andy Lutomirski <l...@kernel.org>; > > > platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: RE: [PATCH] RFC: platform/x86: wmi: Fix check for method > > > instance number > > > > > > > -----Original Message----- > > > > From: Pali Rohár [mailto:pali.ro...@gmail.com] > > > > Sent: Thursday, June 15, 2017 8:59 AM > > > > To: Limonciello, Mario <mario_limoncie...@dell.com>; Darren Hart > > > > <dvh...@infradead.org> > > > > Cc: Andy Shevchenko <a...@infradead.org>; Andy Lutomirski > > > > > > <l...@kernel.org>; > > > > > > > platform-driver-...@vger.kernel.org; linux-kernel@vger.kernel.org > > > > Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method > > > > instance number > > > > > > > > Mario, are you able to check if instance number passed to > > > > wmi_evaluate_method in following dell WMI drivers is correct and > > > > should be really 1? > > > > > > > > I suspect that it should be zero, as instance number is indexed > > > > from zero. > > > > > > > > There is no comment in those dell WMI drivers why it is 1, nor > > > > what 1 means. > > > > > > > > Ideally it needs to be checked in ACPI byte code, MOF file and > > > > WDG dump. > > > > > > I think you're likely correct. I don't have a box that supports > > > alienware-wmi or dell-wmi-led.c handy at the current moment to > > > confirm this hypothesis though. I'll confirm this later. > > > > > > I didn't realize it was zero indexed when I wrote alienware-wmi, > > > and I'm guessing the author of dell-wmi-led didn't either. > > > > > > The reason it's probably working is the ACPI byte code isn't > > > actually checking the instance since most times _WDG will only > > > call out one instance. > > > > I confirmed you're correct. Switching instance over to 0 works > > properly on an ASM200 (supported by alienware-wmi). > > Can you check what is the value in the instance_count in _WDG? >
Instance count is 1. Thanks,
