> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com]
> Sent: Monday, January 29, 2018 12:57 PM
> To: Marco Martin <notm...@gmail.com>
> Cc: Platform Driver <platform-driver-...@vger.kernel.org>; Limonciello, Mario
> <mario_limoncie...@dell.com>; Andy Shevchenko <a...@infradead.org>; Pali
> Rohár <pali.ro...@gmail.com>; Darren Hart <dvh...@infradead.org>; Matthew
> Garrett <mj...@srcf.ucam.org>; Linux Kernel Mailing List <linux-
> ker...@vger.kernel.org>; Bhushan Shah <bhus...@gmail.com>
> Subject: Re: [PATCH v7] Support intel-vbtn based tablet mode switch
>
> On Sat, Jan 27, 2018 at 6:35 PM, Marco Martin <notm...@gmail.com> wrote:
> > Some laptops such as Dell Inspiron 7000 series have the
> > tablet mode switch implemented in Intel ACPI,
> > the events to enter and exit the tablet mode are 0xCC and 0xCD
> >
>
> It doesn't apply :-(
Marco, I can see it applies on 4.15 but it's not applying on
platform-drivers-x86/testing.
It's most likely this commit you need to rebase on top of:
commit 1c3fdf125ef416227e43fdedf6b5097c41e8c467
Author: Darren Hart (VMware) <dvh...@infradead.org>
Date: Fri Dec 8 14:57:54 2017 -0800
platform/x86: intel-vbtn: Simplify autorelease logic
The new notify_handler logic determining if autorelease should be used or
not is a bit awkward, and can result in more than one call to
sparse_keymap_report_event for the same event (scancode). The nesting
and long lines also made it difficult to read.
Simplify the logic by eliminating a level of nesting with a goto and
always calculate autorelease and val so we can make a single call to
sparse_keymap_report_event.
Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org>
Reviewed-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Tested-by: Stefan Brüns <stefan.bru...@rwth-aachen.de>
Cc: AceLan Kao <acelan....@canonical.com>
>
> > CC: platform-driver-...@vger.kernel.org
> > CC: Matthew Garrett <mj...@srcf.ucam.org>
> > CC: "Pali Rohár" <pali.ro...@gmail.com>
> > CC: Darren Hart <dvh...@infradead.org>
> > CC: Mario Limonciello <mario_limoncie...@dell.com>
> > CC: Andy Shevchenko <a...@infradead.org>
> >
> > Signed-off-by: Marco Martin <notm...@gmail.com>
> >
> > Reviewed-by: Mario Limonciello <mario.limoncie...@dell.com>
> > Acked-by: Pali Rohár <pali.ro...@gmail.com>
> > ---
> > drivers/platform/x86/intel-vbtn.c | 22 ++++++++++++++++++++++
> > 1 file changed, 22 insertions(+)
> >
> > diff --git a/drivers/platform/x86/intel-vbtn.c
> > b/drivers/platform/x86/intel-vbtn.c
> > index 58c5ff3..0979811 100644
> > --- a/drivers/platform/x86/intel-vbtn.c
> > +++ b/drivers/platform/x86/intel-vbtn.c
> > @@ -26,6 +26,9 @@
> > #include <linux/suspend.h>
> > #include <acpi/acpi_bus.h>
> >
> > +/* When NOT in tablet mode, VGBS returns with the flag 0x40 */
> > +#define TABLET_MODE_FLAG 0x40
> > +
> > MODULE_LICENSE("GPL");
> > MODULE_AUTHOR("AceLan Kao");
> >
> > @@ -42,6 +45,8 @@ static const struct key_entry intel_vbtn_keymap[] = {
> > { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } }, /* volume-up key
> > release */
> > { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } }, /* volume-down key
> > press */
> > { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key
> release */
> > + { KE_SW, 0xCC, { .sw = { SW_TABLET_MODE, 1 } } }, /* Tablet mode
> > in */
> > + { KE_SW, 0xCD, { .sw = { SW_TABLET_MODE, 0 } } }, /* Tablet mode
> > out */
> > { KE_END },
> > };
> >
> > @@ -88,6 +93,7 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
> >
> > static int intel_vbtn_probe(struct platform_device *device)
> > {
> > + struct acpi_buffer vgbs_output = { ACPI_ALLOCATE_BUFFER, NULL };
> > acpi_handle handle = ACPI_HANDLE(&device->dev);
> > struct intel_vbtn_priv *priv;
> > acpi_status status;
> > @@ -110,6 +116,22 @@ static int intel_vbtn_probe(struct platform_device
> *device)
> > return err;
> > }
> >
> > + status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
> > + /* VGBS being present and returning something means
> > + * we have a tablet mode switch
> > + */
> > + if (ACPI_SUCCESS(status)) {
> > + union acpi_object *obj = vgbs_output.pointer;
> > +
> > + if (obj && obj->type == ACPI_TYPE_INTEGER) {
> > + input_report_switch(priv->input_dev,
> > +
> > SW_TABLET_MODE,
> > +
> > !(obj->integer.value & TABLET_MODE_FLAG));
> > + }
> > + }
> > +
> > + kfree(vgbs_output.pointer);
> > +
> > status = acpi_install_notify_handler(handle,
> > ACPI_DEVICE_NOTIFY,
> > notify_handler,
> > --
> > 2.7.4
> >
>
>
>
> --
> With Best Regards,
> Andy Shevchenko
