timings.
Note that the wakeup gpio is not intended to be used as a wakeup source,
but rather to detect the current power state of the device (active or
hibernate).
Reviewed-by: Rob Herring
Signed-off-by: Johan Hovold
---
.../devicetree/bindings/gnss/sirfstar.txt | 45
simply
means that the main supply is disabled in STANDBY and OFF (the optional
backup supply is kept enabled while the driver is bound).
Note that timepulse-support is not yet implemented.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 13
drivers/gnss/Makefile | 3 +
drivers/gnss
this this is the main reason for not using the generic
serial implementation for this driver).
Note that timepulse-support is left unimplemented.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 12 ++
drivers/gnss/Makefile | 3 +
drivers/gnss/sirf.c | 407
nary
"UBX" UBX
Note that both SiRF and UBX type receivers typically support a subset of
NMEA 0183 with vendor extensions (e.g. to allow switching to the vendor
protocol).
Signed-off-by: Johan Hovold
---
Documentation/ABI/testing/sysfs-class-gnss | 15 +++
MAINTAINERS
cripts and services.
While the current interface is kept minimal, it could be extended using
IOCTLs, sysfs or uevents as needs and proper abstraction levels are
identified and determined (e.g. for device and feature identification).
Signed-off-by: Johan Hovold
---
MAINTAINERS | 6
Describe generic properties for GNSS receivers.
Reviewed-by: Rob Herring
Signed-off-by: Johan Hovold
---
.../devicetree/bindings/gnss/gnss.txt | 36 +++
MAINTAINERS | 1 +
2 files changed, 37 insertions(+)
create mode 100644
, STANDBY and OFF.
Signed-off-by: Johan Hovold
---
drivers/gnss/Kconfig | 7 ++
drivers/gnss/Makefile | 3 +
drivers/gnss/serial.c | 275 ++
drivers/gnss/serial.h | 47
4 files changed, 332 insertions(+)
create mode 100644 drivers/gnss/serial.c
Add binding for u-blox GNSS receivers.
Note that the u-blox product names encodes form factor (e.g. "neo"),
chipset (e.g. "8") and variant (e.g. "q"), but that only formfactor and
chipset is used for the compatible strings (for now).
Signed-off-by: Johan Hovold
---
On Fri, Jun 01, 2018 at 11:33:11AM +0200, Pavel Machek wrote:
> Hi!
>
> > This series adds a new subsystem for GNSS receivers (e.g. GPS
> > receivers).
> >
> > While GNSS receivers are typically accessed using a UART interface they
> > often also support other I/O interfaces such as I2C, SPI and
On Fri, Jun 01, 2018 at 12:26:12PM +0200, Pavel Machek wrote:
> On Fri 2018-06-01 11:49:59, Johan Hovold wrote:
> > On Fri, Jun 01, 2018 at 11:33:11AM +0200, Pavel Machek wrote:
> > This series adds an abstraction for GNSS receivers so that they can be
> > detected by usersp
ding")
Reported-by: Andrew Morton
Signed-off-by: Johan Hovold
---
This applies to the char-misc tree.
.../devicetree/bindings/vendor-prefixes.txt.rej| 10 --
1 file changed, 10 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/vendor-prefixes.t
Here are a couple of fixes for issues discovered through inspection
along with some clean ups.
Johan
Johan Hovold (4):
rtc: omap: fix potential crash on power off
rtc: omap: fix resource leak in registration error path
rtc: omap: add missing register lock in error path
rtc: omap: drop
For completeness re-lock the registers also in the power-off error path.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 6a7b804c3074..7f9ee559dd99 100644
--- a/drivers/rtc/rtc
Drop unnecessary register write-unlock around two read accesses.
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 7f9ee559dd99..323ff55cc165 100644
--- a/drivers/rtc/rtc-omap.c
stroj
Cc: Tony Lindgren
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/rtc/rtc-omap.c b/drivers/rtc/rtc-omap.c
index 39086398833e..c214b69a8787 100644
--- a/drivers/rtc/rtc-omap.c
+++ b/drivers
Make sure to deregister the pin controller in case rtc registration
fails.
Fixes: 57072758623f ("rtc: omap: switch to rtc_register_device")
Cc: stable # 4.14
Cc: Alexandre Belloni
Signed-off-by: Johan Hovold
---
drivers/rtc/rtc-omap.c | 4 +++-
1 file changed, 3 insertions(+),
On Fri, Jun 22, 2018 at 04:10:21PM +0100, Martyn Welch wrote:
> On Wed, 2018-06-20 at 19:41 +, Karoly Pados wrote:
> > Here I argue the following multiple ways. First, I say that claiming
> > that a pin which is used as an input is actually an output is not
> > only confusing, but also much le
On Tue, Jun 12, 2018 at 02:41:41PM +0200, Johan Hovold wrote:
> Make sure to set the mem device release callback before calling
> put_device() in a couple of probe error paths so that the containing
> object also gets freed.
>
> Fixes: d1de6d6c639b ("soc: qcom: Remote file
Make sure to set the mem device release callback before calling
put_device() in a couple of probe error paths so that the containing
object also gets freed.
Fixes: d1de6d6c639b ("soc: qcom: Remote filesystem memory driver")
Cc: stable # 4.15
Cc: Bjorn Andersson
Signed-off-by: Jo
hange the mem allocation scheme to make
Documentation/kobject.txt happy")
Cc: stable # 3.6
Cc: Mauro Carvalho Chehab
Signed-off-by: Johan Hovold
---
drivers/edac/i7core_edac.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/edac/i7cor
56b109e3a5 ("EDAC: Handle error path in edac_mc_sysfs_init() properly")
Cc: stable # 3.6
Cc: Denis Kirjanov
Cc: Mauro Carvalho Chehab
Signed-off-by: Johan Hovold
---
drivers/edac/edac_mc_sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/edac/edac_
On Tue, Jun 05, 2018 at 11:47:52PM +0200, Pavel Machek wrote:
> Hi!
>
> > > udev solves device discovery pretty well; I don't think that's good
> > > thing to optimize for.
> >
> > It's about grouping related devices together, devices which share some
> > common functionality. In this case, provi
Make sure to free all resources associated with the ida on module
exit.
Fixes: cd6484e1830b ("serdev: Introduce new bus for serial attached devices")
Cc: stable # 4.11
Signed-off-by: Johan Hovold
---
drivers/tty/serdev/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/d
Hi Ricardo,
On Mon, Jun 11, 2018 at 01:52:16PM +0200, Ricardo Ribalda Delgado wrote:
> There are some situations where it is interesting to load/remove serdev
> devices dynamically, like during board bring-up or when we are
> developing a new driver or for devices that are neither described via
>
On Thu, Jun 14, 2018 at 01:06:59PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Johan
> On Thu, Jun 14, 2018 at 12:48 PM Johan Hovold wrote:
> >
> > Hi Ricardo,
> >
> > On Mon, Jun 11, 2018 at 01:52:16PM +0200, Ricardo Ribalda Delgado wrote:
> > > There are
On Thu, Jun 14, 2018 at 04:06:18PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Johan,
> On Thu, Jun 14, 2018 at 3:34 PM Johan Hovold wrote:
> > And there are more issues with the series which are less apparent than
> > the rx (and partial tx) regression.
>
> Any hin
On Thu, Jun 14, 2018 at 05:20:40PM +0200, Ricardo Ribalda Delgado wrote:
> Hi Johan,
> On Thu, Jun 14, 2018 at 4:55 PM Johan Hovold wrote:
> >
> > On Thu, Jun 14, 2018 at 04:06:18PM +0200, Ricardo Ribalda Delgado wrote:
> > > Hi Johan,
> > > On Thu, Jun 14,
[ Sorry about the late reply. ]
On Wed, May 09, 2018 at 06:57:06AM -0700, Tony Lindgren wrote:
> * Johan Hovold [180509 13:12]:
> > It seems we really should not be using the negative autosuspend to
> > configure the RPM behaviour the way these drivers do. Perhaps a new
> >
On Wed, May 09, 2018 at 07:05:50AM -0700, Tony Lindgren wrote:
> * Johan Hovold [180509 09:20]:
> > On Tue, May 08, 2018 at 05:56:08PM +0200, Sebastian Reichel wrote:
> > > I think using open/close for runtime pm is good enough for GPS,
> > > since it regularly sends d
is now looks good to me:
Reviewed-by: Johan Hovold
Johan
On Thu, Dec 06, 2018 at 04:10:07PM +0530, Balakrishna Godavarthi wrote:
> Hi Johan,
>
> On 2018-12-05 11:55, Johan Hovold wrote:
> > On Fri, Nov 30, 2018 at 08:32:44PM +0530, Balakrishna Godavarthi wrote:
> >> + ret = serdev_device_write(hu->serdev, &cmd, sizeof(
Hi Song,
Sorry about the late reply.
On Thu, Dec 06, 2018 at 02:02:21PM +0800, Song Qiang wrote:
>
> On 12/5/18 11:17 PM, Anatolij Gustschin wrote:
> > Hi,
> >
> > On Wed, 5 Dec 2018 22:10:40 +0800
> > Song Qiang songqiang1304...@gmail.com wrote:
> > ...
> >> I've been developing some iio device
On Sun, Dec 09, 2018 at 08:58:02PM +0100, Andreas Kemnade wrote:
> Hi,
>
> On Wed, 5 Dec 2018 11:21:49 +0100
> Johan Hovold wrote:
>
> > Fix activation helper which would return -ETIMEDOUT even if the last
> > retry attempt was successful.
> >
> > A
On Mon, Dec 17, 2018 at 07:43:26PM +0530, Balakrishna Godavarthi wrote:
> wcn3990 requires a power pulse to turn ON/OFF along with
> regulators. Sometimes we are observing the power pulses are sent
> out with some time delay, due to queuing these commands. This is
> causing synchronization issues w
On Thu, Dec 13, 2018 at 06:01:47AM -0500, Scott Chen wrote:
> Add device ids to pl2303 for the HP POS pole displays:
> LM920: 03f0:026b
> TD620: 03f0:0956
> LD960TA: 03f0:4439
> LD220TA: 03f0:4349
> LM940: 03f0:5039
>
> Signed-off-by: Scott Chen
Applied for -next, thanks.
Johan
On Thu, Nov 22, 2018 at 10:37:16PM +0530, Nishad Kamdar wrote:
> Convert the GPIO driver to use the GPIO irqchip library
> GPIOLIB_IRQCHIP instead of reimplementing the same.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Retained irq.h and irqdomain.h headers.
> - Dropped function
On Thu, Nov 22, 2018 at 10:38:18PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated old non-descriptor
> interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Resolved compilation errors.
> ---
> drivers/staging/greybus/arche-apb-ctrl.c | 159
On Thu, Nov 22, 2018 at 10:39:24PM +0530, Nishad Kamdar wrote:
> Use the gpiod interface instead of the deprecated
> old non-descriptor interface.
>
> Signed-off-by: Nishad Kamdar
> ---
> Changes in v2:
> - Move comment to the same line as to what it applies to.
> ---
> drivers/staging/greybus/
On Fri, Dec 14, 2018 at 06:02:40PM +0530, Balakrishna Godavarthi wrote:
> Hi Johan,
>
> On 2018-12-12 22:12, Johan Hovold wrote:
> > On Thu, Dec 06, 2018 at 04:10:07PM +0530, Balakrishna Godavarthi wrote:
> >> uart_write_wakeup()->ttyport_write_wakeup()->
On Sat, Dec 08, 2018 at 07:05:12PM +0100, Tore Anderson wrote:
> The HP lt4132 is a rebranded Huawei ME906s-158 LTE modem.
>
> The interface with protocol 0x16 is "CDC ECM & NCM" according to the *.inf
> files included with the Windows driver. Attaching the option driver to it
> doesn't result in
On Fri, Dec 07, 2018 at 02:50:42AM +, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate':
> drivers/usb/serial/mos7840.c:1584:16: warning:
> variable 'number' set but not used [-Wunused-but-set-va
On Thu, Dec 20, 2018 at 09:41:16PM +0800, Jia-Ju Bai wrote:
> In drivers/usb/serial/garmin_gps.c,
> the functions garmin_read_bulk_callback() and garmin_write_bulk_callback()
> may be concurrently executed.
>
> In garmin_write_bulk_callback() on line 969:
> kfree(urb->transfer_buffer);
> In g
Fix "gpiio5" typo in the (currently unused) blsp2_uart1 4-pin sleep
config.
Fixes: 22e6789f9493 ("arm64: dts: msm8996: add blsp2_uart1 pinctrl")
Cc: Srinivas Kandagatla
Signed-off-by: Johan Hovold
---
arch/arm64/boot/dts/qcom/msm8996-pins.dtsi | 2 +-
1 file changed, 1 inse
On Mon, Jan 07, 2019 at 02:48:26PM +0100, Oliver Neukum wrote:
> On Fr, 2019-01-04 at 12:21 +0100, Andreas Färber wrote:
> > Switch from tty_port_register_device() to tty_port_register_device_serdev()
> > and from tty_unregister_device() to tty_port_unregister_device().
> >
> > On removal of a se
On Sat, Jan 05, 2019 at 12:43:48AM +0100, Andreas Färber wrote:
> Hi Rob,
>
> Am 04.01.19 um 18:07 schrieb Rob Herring:
> > On Fri, Jan 4, 2019 at 5:21 AM Andreas Färber wrote:
> >>
> >> Ignore our device in cdc-acm probing and add a new driver for it,
> >> dispatching to cdc-acm for the actual i
On Sun, Jan 06, 2019 at 06:16:12PM +0100, Tomasz Duszynski wrote:
> Add support for Plantower PMS7003 particulate matter sensor.
>
> Signed-off-by: Tomasz Duszynski
> +static int pms7003_do_cmd(struct pms7003_state *state, u8 cmd)
> +{
> + /*
> + * commands have following format:
> +
On Mon, Jan 07, 2019 at 08:31:49AM +0100, Max Schulze wrote:
> Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
> device
I rephrased the summary and comment above since you're adding a new
device id to an existing driver (rather than a new driver).
> T: Bus=02 Lev=01 Prnt=
On Mon, Jan 07, 2019 at 05:21:58PM +0100, Loys Ollivier wrote:
>
> On Fri 04 Jan 2019 at 09:19, Johan Hovold wrote:
>
> > On Thu, Jan 03, 2019 at 05:04:35PM +0100, Loys Ollivier wrote:
> >>
> >> As suggested by Neil Armstrong - this GNSS device seems to b
On Thu, Jan 03, 2019 at 05:04:35PM +0100, Loys Ollivier wrote:
>
> As suggested by Neil Armstrong - this GNSS device seems to behave like
> most generic GNSS receivers.
> I'll send a v2 with a generic driver that works for both GlobalTop and
> u-blox.
That doesn't sound right to me. Judging from
On Sun, Oct 28, 2018 at 02:46:24PM +0100, Marcel Holtmann wrote:
> >> +#define VERSION "0.1"
> >
> > We don't version kernel drivers individually, so please drop this here
> > and below.
>
> if we don’t then maybe send patches to remove MODULE_VERSION first.
> Otherwise this is totally fine to d
On Sun, Oct 07, 2018 at 09:06:18PM -0700, H. Peter Anvin wrote:
> From: "H. Peter Anvin (Intel)"
>
> It turns out that Alpha is the only architecture that never
> implemented BOTHER and IBSHIFT, which is otherwise ages old. This is
> one thing that has held up glibc support for this feature (all
On Tue, Oct 23, 2018 at 01:32:56PM -0500, Rob Herring wrote:
> On Tue, Oct 23, 2018 at 4:21 AM Johan Hovold wrote:
> >
> > Hi Rob,
> >
> > On Tue, Sep 04, 2018 at 03:05:57PM +0200, Johan Hovold wrote:
> > > I think Rob will be picking up any patches that re
; Signed-off-by: Jeremiah Mahler
> Signed-off-by: Johan Hovold
> Signed-off-by: Sasha Levin
This isn't a bug fix, but more of a clean up patch and hence does not
qualify for stable. So specifically the stable tag was left out on
purpose.
I never got a chance to talk to you in Edinburgh
Fixes: e7181d005e84 ("USB: qcserial: Add support for HP lt4112 LTE/HSPA+ Gobi
> 4G Modem")
> Signed-off-by: Bjørn Mork
> Signed-off-by: Johan Hovold
> Signed-off-by: Sasha Levin
This one is interesting though; it was marked for stable and has a
proper fixes tag for a commi
On Fri, Oct 26, 2018 at 11:02:24AM +0200, Bjørn Mork wrote:
> Johan Hovold writes:
>
> > Note that the stable tag above lacks a version comment (e.g. "# 4.19"),
> > but I can see how that may be too subtle to convey this (and not all
> > maintainers use those).
[ Adding Hans, Rafael, Rob and more people from the below thread. ]
On Fri, Oct 26, 2018 at 08:57:22AM +, Einar Vading wrote:
> Hi,
>
> I think that this could explain your problem:
> https://marc.info/?l=linux-acpi&m=152464754828003&w=2
>
> "In short, when we added ACPI support to serdev,
Hi Rob,
On Tue, Sep 04, 2018 at 03:05:57PM +0200, Johan Hovold wrote:
> Hi all,
>
> On Mon, Aug 27, 2018 at 10:21:44AM +0200, Johan Hovold wrote:
> > Several drivers currently use of_find_compatible_node() to lookup child
> > nodes while failing to notice that the of_find_
On Mon, Jul 16, 2018 at 12:00:28PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Jul 15, 2018 at 03:39:35PM +0200, Johan Hovold wrote:
> > Since commit edc6afc54968 ("[PATCH] tty: switch to ktermios and new
> > framework") arbitrary baud rates can be requested using BOTHER a
From: Colin Ian King
The structure ubx_gserial_ops is local to the source and does not need
to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'ubx_gserial_ops' was not declared. Should it be static?
Signed-off-by: Colin Ian King
Signed-off-by: Jo
m")
Signed-off-by: Dan Carpenter
Signed-off-by: Johan Hovold
---
drivers/gnss/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c
index f30ef8338b3a..4291a0dd22aa 100644
--- a/drivers/gnss/core.c
+++ b/drivers/gnss/core.c
@
Hi Greg,
Here's a resend of two gnss fixes for char-misc-next which I noted you
haven't picked up directly (I'll continue picking these up an forwarding
to you in batches if that's alright).
Thanks,
Johan
Colin Ian King (1):
gnss: ubx: make struct ubx_gserial_ops static
Dan Carpenter (1):
Hi Niklas,
On Mon, Jul 16, 2018 at 01:35:22PM +0200, Niklas Cassel wrote:
> For of_find_node_by_name(), you typically pass what the previous call
> returned. Therefore, of_find_node_by_name() increases the refcount of
> the returned node, and decreases the refcount of the node passed as the
> firs
On Mon, Jul 16, 2018 at 12:48:45PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 16, 2018 at 12:42:01PM +0200, Johan Hovold wrote:
> > Hi Greg,
> >
> > Here's a resend of two gnss fixes for char-misc-next which I noted you
> > haven't picked up direct
On Mon, Jul 16, 2018 at 03:29:31PM +0200, Niklas Cassel wrote:
> On Mon, Jul 16, 2018 at 02:01:34PM +0200, Johan Hovold wrote:
> > Hi Niklas,
> >
> > On Mon, Jul 16, 2018 at 01:35:22PM +0200, Niklas Cassel wrote:
> > > For of_find_node_by_name(), you typical
Hi Marijn and Lee,
On Tue, Jul 19, 2022 at 11:18:48PM +0200, Marijn Suijten wrote:
> Inherit PM660L PMIC LPG/triled block configuration from downstream
> drivers and DT sources, consisting of a triled block with automatic
> trickle charge control and source selection, three colored led channels
>
On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote:
> Note that I have one more unmerged leds patch around, that hasn't been looked
> at either. Would it help to send this once again, perhaps with more
> reviewers/
> testing (Johan, would you mind taking a look too)?
>
> https://lor
On Tue, Dec 19, 2023 at 11:06:08AM +0100, Marijn Suijten wrote:
> On 2023-12-19 10:33:25, Johan Hovold wrote:
> > On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote:
> >
> > > Note that I have one more unmerged leds patch around, that hasn't been
> &g
he sysfs property
> clearly presents a value of `-1`.
>
> Signed-off-by: Marijn Suijten
> Reviewed-by: Bjorn Andersson
> Tested-by: Bjorn Andersson
Looks correct to me:
Reviewed-by: Johan Hovold
On Wed, Apr 07, 2021 at 05:24:52PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 07, 2021 at 12:45:25PM +0200, Johan Hovold wrote:
> > Now that all USB serial drivers supports changing the closing_wait
> > parameter through TIOCSSERIAL (setserial), we can remove the related
>
On Thu, Apr 08, 2021 at 09:48:38AM +0200, Oliver Neukum wrote:
> Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold:
> > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
> > serial devices is only useful for setting the close_delay and
> > cl
On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote:
> Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold:
> > TIOCSSERIAL is a horrid, underspecified, legacy interface which for most
> > serial devices is only useful for setting the close_delay and
> > cl
On Thu, Apr 08, 2021 at 01:34:12PM +0200, Oliver Neukum wrote:
> Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold:
> > On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote:
> > > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold:
>
&g
the current line speed can still be retrieved through the
standard termios interfaces.
Fixes: 18c75720e667 ("USB: allow users to run setserial with cdc-acm")
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
: ba2d8ce9db0a ("cdc-acm: implement TIOCSSERIAL to avoid blocking
close(2)")
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 96e221803fa6..43e31dad4831 100644
--- a/d
r CDC and that the current line speed can still be retrieved
through the standard termios interfaces (3/3)
Johan Hovold (3):
Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL"
USB: cdc-acm: fix unprivileged TIOCCSERIAL
USB: cdc-acm: fix TIOCGSERIAL implementation
driver
this is hardly something we need to worry about.
Cc: Anthony Mallet
Cc: sta...@vger.kernel.org
Signed-off-by: Johan Hovold
---
drivers/usb/class/cdc-acm.c | 11 ++-
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index
On Thu, Apr 08, 2021 at 02:51:21PM +0200, Greg Kroah-Hartman wrote:
> Turns out there is a lot of tty-internal stuff in include/linux/tty.h
> that do not belong there. Create a internal-to-the-tty-layer .h file
> for these types of things and move function prototypes to it instead of
> being in th
Signed-off-by: Johan Hovold
---
drivers/usb/serial/metro-usb.c | 4 ++--
drivers/usb/serial/upd78f0730.c | 7 +++
drivers/usb/serial/usb-serial.c | 32
3 files changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/usb/serial/metro-usb.c b/dri
On Thu, Apr 08, 2021 at 08:01:08PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 08, 2021 at 04:25:22PM +0200, Johan Hovold wrote:
> > On Thu, Apr 08, 2021 at 02:51:21PM +0200, Greg Kroah-Hartman wrote:
> > > Turns out there is a lot of tty-internal stuff in include/linux/tty.h
s device (e.g. pseudoterminals
and serdev) in which case the device pointer will be set to NULL,
something which have bit driver authors over the years.
In retrospect perhaps this field should never have been added, but let's
at least document the current behaviour.
Signed-off-by: Johan Hovold
---
inclu
On Mon, Dec 08, 2014 at 08:06:11PM -0800, Linus Torvalds wrote:
> On Mon, Dec 8, 2014 at 4:00 AM, Lee Jones wrote:
> >
> > Johan Hovold (4):
> > mfd: Use mfd_add_hotplug_devices() helper
>
> This clashed with the earlier fix "mfd: viperboard: Fix
> pl
On Tue, Dec 09, 2014 at 12:44:09PM -0800, Linus Torvalds wrote:
> On Tue, Dec 9, 2014 at 2:00 AM, Johan Hovold wrote:
> So when you do "git log" with a pathname specifier, git obviously no
> longer shows you all the history. In particular, it shows you the
> relevant hist
On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote:
> This driver is for the NovaTech 124 4x serial expansion board for the
> NovaTech OrionLXm.
>
> Firmware source code can be found here:
> https://github.com/novatechweb/nt124
Great, and thanks for the patch!
> Signed-off-by: Ge
On Mon, Dec 29, 2014 at 10:49:34PM +, Peterson, David wrote:
> commit 975ae8b32bc5f52a5456e42c3c3310937c6fe833
> Author: David Peterson
> Date: Mon Dec 29 15:59:37 2014 -0600
The above does not belong in the commit message (i.e. mail body).
Please read Documentation/SubmittingPatches, and c
On Sat, Dec 27, 2014 at 01:32:41AM -0600, Preston Fick wrote:
> Fixing typo for MeshConnect IDs. The original PID (0x8875) is not in
> production and is not needed. Instead it has been changed to the official
> production PID (0x8857).
Make sure to use line breaks in your commit messages. I fixe
On Tue, Dec 23, 2014 at 12:57:16PM -0800, Richard wrote:
> > This driver is a bit of a mess. Could you try the patch below and
> > see if it fixes the problem?
>
> Yes. Thank you. That fixes the issue. I can now plug in the Keyspan
> USB adapter to my new running system without the kernel fre
[ +CC: linux-usb]
On Mon, Jan 05, 2015 at 08:46:52PM +, Peterson, David wrote:
> From: David Peterson
Almost there. Patch looks fine now, but the mail Subject (commit
summary) is malformed (includes a sign-off tag).
Care to resend with a subject like
"USB: cp210x: add ids for CEL U
On Tue, Jan 06, 2015 at 03:00:52PM +, Peterson, David wrote:
> From: David Peterson
>
> Added virtual com port VID/PID entries for CEL USB sticks and MeshWorks
> devices
>
> Signed-off-by: David Peterson
Applied, thanks.
Johan
> ---
> drivers/usb/serial/cp210x.c | 3 +++
> 1 file chang
On Thu, Nov 27, 2014 at 01:57:14PM +0200, Octavian Purdila wrote:
> @@ -753,11 +759,42 @@ static const struct usb_device_id dln2_table[] = {
>
> MODULE_DEVICE_TABLE(usb, dln2_table);
Place the new callbacks above the device id table.
> +static int dln2_suspend(struct usb_interface *iface, pm_
On Fri, Dec 05, 2014 at 01:51:17PM +0200, Octavian Purdila wrote:
> On Fri, Dec 5, 2014 at 12:17 PM, Johan Hovold wrote:
> > On Thu, Nov 27, 2014 at 01:57:14PM +0200, Octavian Purdila wrote:
> >
> >> @@ -753,11 +759,42 @@ static const struct
On Fri, Dec 05, 2014 at 03:05:45PM +0200, Octavian Purdila wrote:
> On Fri, Dec 5, 2014 at 2:06 PM, Johan Hovold wrote:
> > On Fri, Dec 05, 2014 at 01:51:17PM +0200, Octavian Purdila wrote:
> >> On Fri, Dec 5, 2014 at 12:17 PM, Johan Hovold wrote:
> >> > And surely
On Sat, Nov 29, 2014 at 11:49:04AM +0530, Muthu Mani wrote:
> Adds support for USB-I2C/GPIO interfaces of Cypress Semiconductor
> CYUSBS234 USB-Serial Bridge controller.
>
> Details about the device can be found at:
> http://www.cypress.com/?rID=84126
>
> Signed-off-by: Muthu Mani
> Signed-off-b
submit patch. Please let me know if anything
> wrong.
> $ git format-patch -s -n -v4 master..Driver_v4
> $ git send-email --smtp-encryption=tls --smtp-server=
> --smtp-user=m...@cypress.com --smtp-server-port= --to="Samuel Ortiz
> " --to="Lee Jones "
&
On Sun, Dec 21, 2014 at 11:33:39PM -0600, Preston Fick wrote:
Please add a proper commit message here describing why this is needed.
Are there any devices with the original PID or was that just a typo?
> Signed-off-by: Preston Fick
> ---
> drivers/usb/serial/cp210x.c | 2 +-
> 1 file changed, 1
clock mode.
Turns out that the problem seemingly worked-around by the above
mentioned commit was really due to a hardware-configuration issue, where
the PHY was in fact strapped to address 3 rather than 0.
Tested-by: Bruno Thomsen
Signed-off-by: Johan Hovold
---
drivers/net/phy/mic
On Sun, Jan 25, 2015 at 06:33:48PM +0900, Alexandre Courbot wrote:
> On Tue, Jan 13, 2015 at 9:00 PM, Johan Hovold wrote:
> > Fix attribute-creation race with userspace by using the default group
> > to create also the contingent gpio device attributes.
> >
> > Fixes:
Here are two more fixes for long-standing memory leaks in the gpio sysfs
interface (for v3.19).
Johan
Johan Hovold (2):
gpio: sysfs: fix memory leak in gpiod_export_link
gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low
drivers/gpio/gpiolib-sysfs.c | 3 ++-
1 file changed, 2
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when creating a link.
Fixes: a4177ee7f1a8 ("gpiolib: allow exported GPIO nodes to be named
using sysfs links")
Cc: stable # v2.6.32
Signed-off-by: Johan Hovold
--
Fix memory leak in the gpio sysfs interface due to failure to drop
reference to device returned by class_find_device when setting the
gpio-line polarity.
Fixes: 0769746183ca ("gpiolib: add support for changing value polarity
in sysfs")
Cc: stable # v2.6.33
Signed-off-by: Jo
On Wed, Jan 21, 2015 at 03:24:27PM -0500, Lennart Sorensen wrote:
> Added the USB serial console device ID for Siemens Ruggedcom devices
> which have a USB port for their serial console.
>
> Signed-off-by: Len Sorensen
> ---
> drivers/usb/serial/cp210x.c |1 +
> 1 file changed, 1 insertion(+
401 - 500 of 2824 matches
Mail list logo
