On Thu, Apr 08, 2021 at 02:51:21PM +0200, Greg Kroah-Hartman wrote: > Turns out there is a lot of tty-internal stuff in include/linux/tty.h > that do not belong there. Create a internal-to-the-tty-layer .h file > for these types of things and move function prototypes to it instead of > being in the system-wide header file. > > Along the way clean up the use of some old tty-only debugging macros and > use the in-kernel dev_*() calls instead.
I'm afraid that's not a good idea since not all ttys have a corresponding class device. Notable exception include pseudo terminals and serdev. While dev_printk() can handle a NULL device argument without crashing, we'll actually lose log information by removing the tty printk helpers. Johan
