Add a dependency on PRINTK for these 2 CONFIG options
Signed-off-by: Joe Perches
---
Add bcc's for the affected arch maintainers to avoid long recipient list
arch/alpha/Kconfig.debug |2 +-
arch/arm/Kconfig.debug|2 +-
arch/blackfin/Kconfig.debug |1 +
arch/he
Remove wanrouter as it's obsolete and has not been updated
by sangoma since 2.4.3 or so and it's not used anymore.
Remove obsolete cyclomx drivers.
Update files that include now deleted wanrouter bits.
Signed-off-by: Joe Perches
---
On Tue, 2012-11-13 at 14:44 -0500, David Mi
Mark it so.
Signed-off-by: Joe Perches
---
MAINTAINERS |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4b062ff..fb78c54 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1901,7 +1901,7 @@ F:scripts/checkpatch.pl
CHINESE
On Tue, 2012-11-13 at 17:17 -0500, David Miller wrote:
> From: Joe Perches
> Date: Tue, 13 Nov 2012 12:17:25 -0800
>
> > That seems an odd workflow as it leaves dangling CONFIG_
> > options set, but I guess it doesn't hurt so here it is.
>
> As you said it
On Wed, 2012-11-14 at 14:17 +0200, Vladimir Kondratiev wrote:
> Introduce debug_hex_dump() that can be dynamically controlled, similar to
> pr_debug.
(added Jason Baron, Jim Cromie, GregKH and lkml to cc's)
[]
> diff --git a/include/linux/printk.h b/include/linux/printk.h
[]
> @@ -220,6 +220,20 @
On Wed, 2012-11-14 at 18:18 +0200, Vladimir Kondratiev wrote:
> And, here it goes (can I call it PATCH?):
Don't see why not.
> From: Vladimir Kondratiev
[]
> Introduce debug_hex_dump() that can be dynamically controlled, similar to
> pr_debug.
>
> Also, make print_hex_dump_bytes() dynamically c
On Mon, 2012-11-05 at 15:03 -0800, Kees Cook wrote:
> This config item has not carried much meaning for a while now and is
> almost always enabled by default. As agreed during the Linux kernel
> summit, it is being removed. This will discourage future addition of
> CONFIG_EXPERIMENTAL while it is
Add a test for reuse of macro arguments to highlight
any possible side-effects from this reuse.
Avoid this check on token name pasting and when the
argument is used in a typeof or a __builtin.
Signed-off-by: Joe Perches
---
There are times when using a temporary for macro arguments
is overkill
On Tue, 2012-11-06 at 15:36 -0800, Andrew Morton wrote:
> On Thu, 1 Nov 2012 00:12:18 -0700
> Joe Perches wrote:
> > Linux kernel doesn't like floating point, say so.
[]
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> >
On Tue, 2012-11-06 at 12:00 -0800, Andrew Morton wrote:
> On Tue, 06 Nov 2012 02:35:39 -0800
> Joe Perches wrote:
>
> > Add a test for reuse of macro arguments to highlight
> > any possible side-effects from this reuse.
> >
> > Avoid this check on token name pas
Remove wanrouter as it's obsolete and has not been updated
by sangoma since 2.4.3 or so and it's not used anymore.
Remove obsolete cyclomx drivers.
Update defconfig files that enable wanrouter.
Update files that include now deleted wanrouter bits.
Signed-off-by: Joe Perches
---
Doc
On Wed, 2012-12-26 at 11:10 +0900, Namjae Jeon wrote:
> 2012/12/26, Jaegeuk Kim :
> > Hi,
> Hi Jaegeuk.
> >
> > Could you make them follow the file system convention?
> > Something like "F2FS: blah blah~".
> Yes, I agree.
>
> >
> > Otherwise, how about adding a debugging function to express the p
On Wed, 2012-12-26 at 13:22 +0900, Namjae Jeon wrote:
> 2012/12/26, Joe Perches :
> > On Wed, 2012-12-26 at 11:10 +0900, Namjae Jeon wrote:
> >> 2012/12/26, Jaegeuk Kim :
> >> > Could you make them follow the file system convention?
> >> > Something l
On Fri, 2012-12-28 at 17:39 +0100, Anders Larsen wrote:
> On 2012-12-28 16:49, Masanari Iida wrote:
> > Correct spelling typo in printk within various drivers.
> > ---
> > diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c
[]
> > @@ -402,7 +402,7 @@ cfcnfg_linkup_rsp(struct cflayer *layer, u8
> >
On Fri, 2012-12-28 at 20:27 +0100, Geert Uytterhoeven wrote:
> For removed files, get_maintainer.pl doesn't find any maintainers (besides
> the default linux-kernel@vger.kernel.org), as it only looks at the "+++"
> lines, which are "/dev/null" for removals.
> Fix this by extending the parsing to th
On Fri, 2012-12-28 at 16:09 +, Al Viro wrote:
> On Thu, Dec 27, 2012 at 11:36:13PM -0800, Eric W. Biederman wrote:
> > But then I am probably peculiar keeping an index of the source code in
> > my head. When I need to look for something and I don't know where to
> > find it I do.
> >
> > git-
On Sat, 2012-12-29 at 09:56 -0800, Greg Kroah-Hartman wrote:
> On Fri, Dec 28, 2012 at 08:23:04PM -0800, Roland Dreier wrote:
> > From: Roland Dreier
> >
> > print_prefix() passes a NULL buf to print_time() to get the length of
> > the time prefix; when printk times are enabled, the current code
On Sat, 2012-12-29 at 14:27 -0800, Roland Dreier wrote:
> On Sat, Dec 29, 2012 at 12:08 PM, Joe Perches wrote:
> > Sylvan Munaut did something similar
> > https://lkml.org/lkml/2012/12/5/168
>
> Missed that and duplicated the debugging :(
> Sorry Sylvain.
>
> I gu
On Wed, 2013-01-02 at 16:27 -0700, Lance Ortiz wrote:
> These changes make cper_print_aer more consistent with aer_print_error
> and clean things up by elimiating the use of the prefix variable and
> replacing it with dev_printk.
[]
> v7-v8 Updated to use dev_printk instated of prefix. Changed
> lo
Add YA check to printk style.
dev_ uses are functions and generate smaller
object code than dev_printk(KERN_.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 10 ++
1 file changed, 10 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4d2c7df
Get people to stop adding __devinit and __devexit section markings.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 6 ++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4d2c7df..325caa7 100755
--- a/scripts/checkpatch.pl
+++ b
On Wed, 2013-01-02 at 18:34 -0600, Bjorn Helgaas wrote:
> On Wed, Jan 2, 2013 at 6:06 PM, Joe Perches wrote:
> > Add YA check to printk style.
> >
> > dev_ uses are functions and generate smaller
> > object code than dev_printk(KERN_.
[]
> > diff --git
On Wed, 2013-01-02 at 23:35 -0800, Dmitry Torokhov wrote:
> On Thu, Jan 03, 2013 at 04:25:09PM +1300, Tony Prisk wrote:
> > +static void __init vt8500_timer_init(void)
> > +{
> > + struct device_node *np;
> > + int timer_irq;
> > +
> > + np = of_find_matching_node(NULL, vt8500_timer_ids);
> >
On Thu, 2013-01-03 at 10:08 +, Andy Whitcroft wrote:
> On Wed, Jan 02, 2013 at 04:06:34PM -0800, Joe Perches wrote:
> > Add YA check to printk style.
> >
> > dev_ uses are functions and generate smaller
> > object code than dev_printk(KERN_.
[]
> > diff --git
Add YA check to printk style.
dev_ uses are functions and generate smaller
object code than dev_printk(KERN_.
Signed-off-by: Joe Perches
---
V2: Remove unnecessary copy/paste logic from pr_
conversion above it.
scripts/checkpatch.pl | 9 +
1 file changed, 9 insertions(+)
diff
On Thu, 2013-01-03 at 03:01 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.
just trivia:
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/intel_pow
On Thu, 2013-01-03 at 07:10 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.
[]
> +static int window_size_set(const char *arg, const struct kernel_param *kp)
> +{
> +
On Thu, 2013-01-03 at 23:49 -0800, Eric Dumazet wrote:
> In various network workloads, __do_softirq() latencies can be up
> to 20 ms if HZ=1000, and 200 ms if HZ=100.
> This patch changes the fallback to ksoftirqd condition to :
> - A time limit of 2 ms.
[]
> diff --git a/kernel/softirq.c b/kernel
On Fri, 2013-01-04 at 00:23 -0800, Eric Dumazet wrote:
> On Fri, 2013-01-04 at 00:15 -0800, Joe Perches wrote:
> > Perhaps MAX_SOFTIRQ_TIME should be
> > #define MAX_SOFTIRQ_TIME msecs_to_jiffies(2)
> > though it would be nicer if it were a compile time constant.
>
.
Prefix the old exported symbols/functions with __
Signed-off-by: Joe Perches
---
include/linux/jiffies.h | 136 ++--
kernel/time.c | 106 +
2 files changed, 144 insertions(+), 98 deletions(-)
diff --git a
Currently these DBG statements are emitted at KERN_DEFAULT.
Change the macro to emit at KERN_DEBUG.
This can help avoid unexpected message interleaving.
Signed-off-by: Joe Perches
---
Another way to fix this message interleaving...
drivers/acpi/glue.c |9 +++--
1 files changed, 7
On Tue, 2012-12-18 at 14:59 +0530, Durgadoss R wrote:
> This patch creates sensor level APIs, in the
> generic thermal framework.
Just some trivial notes.
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
[]
> +static ssize_t
> +sensor_temp_show(struct device *dev, stru
On Tue, 2012-12-18 at 14:59 +0530, Durgadoss R wrote:
> This patch adds a new thermal_zone structure to
> thermal.h. Also, adds zone level APIs to the thermal
> framework.
[]
> diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
> +#define GET_INDEX(tz, ptr, indx, type)
Avoid specifying include paths with uapi/...
as userspace should not use that path.
Neaten message line wrapping above.
Signed-off-by: Joe Perches
cc: David Howells
---
scripts/checkpatch.pl |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b
On Tue, 2012-12-18 at 09:33 -0600, Steve French wrote:
> On Tue, Dec 18, 2012 at 9:19 AM, Borislav Petkov wrote:
> > On Tue, Dec 18, 2012 at 10:07:02AM -0500, Jeff Layton wrote:
> >> Yeah, not many do, but presumably they'll set it once and forget about
> >> it. Once someone straightens them out,
On Tue, 2012-12-18 at 18:19 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 01:39:48PM -0600, Jacob Shin wrote:
> > Add MCE decoding logic for AMD Family 16h processors.
[]
> > + switch (xec) {
> > + case 0x04 ... 0x05:
> > + pr_cont("Parity error in %s
On Tue, 2012-12-18 at 19:33 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 10:24:29AM -0800, Joe Perches wrote:
> > or without all the unnecessary parens and using char:
> >
> > pr_cont("%cBUFF parity error\n", xec == 4 ? 'I' :
On Tue, 2012-12-18 at 19:28 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 11:09:43AM -0800, Joe Perches wrote:
> > This needs a new test here to avoid chirping
> > on files that aren't added, deleted or renamed.
> >
> > next if ($realfile eq $
On Tue, 2012-12-18 at 19:17 +, David Howells wrote:
> Joe Perches wrote:
>
> > + if ($path =~ "^uapi/") {
> > + ERROR("UAPI_INCLUDE",
> > + "#includ
On Tue, 2012-12-18 at 21:31 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote:
> > If no patch is attached, you should get
> >
> > ERROR: Does not appear to be a unified-diff format patch
>
> Well, it needs to handle the case wh
On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> Oh well, enough games for today.
Maybe try this tomorrow?
scripts/checkpatch.pl | 40 ++--
1 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.p
On Tue, 2012-12-18 at 15:06 -0600, Jacob Shin wrote:
> Add MCE decoding logic for AMD Family 16h processors.
More trivia:
> diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
[]
> @@ -64,6 +64,10 @@ EXPORT_SYMBOL_GPL(to_msgs);
> const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GE
On Tue, 2012-12-18 at 20:35 +, David Howells wrote:
> Joe Perches wrote:
[]
> > arch/powerpc/include/asm/kvm_para.h
> > ...
> > -#include
> > +#include
>
> No, that is a correct alteration.
>
> The example I gave was:
>
> - #include
>
On Tue, 2012-12-18 at 16:30 -0800, Andrew Morton wrote:
> On Wed, 28 Nov 2012 15:50:57 +0900
> Jonghwa Lee wrote:
>
> > Add driver for support max77686 rtc.
> > MAX77686 rtc support smpl and wtsr mode. It has two alarm register
> > which can be used for alarming to wake system up. This drvier use
Avoid specifying internal uapi #include paths with uapi/...
as userspace should not use and never see that.
Neaten message line wrapping above.
Signed-off-by: Joe Perches
cc: David Howells
---
scripts/checkpatch.pl |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a
On Wed, 2012-12-19 at 09:42 +0300, Dan Carpenter wrote:
> On Wed, Dec 19, 2012 at 12:39:59AM +0100, Cong Ding wrote:
> > clean the checkpatch warnings in ring_sw.c. mostly are 80 characters per
> > line
> > issue.
[]
> > diff --git a/drivers/staging/iio/ring_sw.c b/drivers/staging/iio/ring_sw.c
[]
On Wed, 2012-12-19 at 07:13 +, Jonathan Cameron wrote:
> Err. This whole file is going away in the coming cycle anyway so I am
> not going to take cleanup patches for it.
That's the best kind of staging cleanup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
th
On Wed, 2012-12-19 at 16:07 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 01:33:19PM -0800, Joe Perches wrote:
> > On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> > > Oh well, enough games for today.
> >
> > Maybe try this tomorrow?
On Tue, 2012-12-11 at 14:19 -0800, Joe Perches wrote:
> On Tue, 2012-12-11 at 19:49 -0200, Cesar Eduardo Barros wrote:
> > I could not find the maintainer for the MAINTAINERS file, so sending
> > directly to Linus. Sorry if I am mistaken.
>
> Thanks Cesar.
>
> Most mai
On Fri, 2012-12-21 at 13:04 -0600, Rob Landley wrote:
> On 12/21/2012 09:52:22 AM, Joe Perches wrote:
> > On Tue, 2012-12-11 at 14:19 -0800, Joe Perches wrote:
> > > On Tue, 2012-12-11 at 19:49 -0200, Cesar Eduardo Barros wrote:
> > > > I could not find the maintaine
On Fri, 2012-12-21 at 18:43 -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 5 Nov 2012 20:39:33 +0900
> YAMANE Toshiaki escreveu:
>
> > fixed below checkpatch error.
> > - ERROR: trailing statements should be on next line
> >
> > Signed-off-by: YAMANE Toshiaki
> > ---
> > drivers/staging/media/
On Sun, 2012-12-23 at 11:01 +, Andy Furniss wrote:
> Borislav Petkov wrote:
>
> > [ 28.191072] radeon: `0' invalid for parameter `wb'
> >
> > although the whole driver blubber didn't appear on the console fterwards
> > aso something got turned off allright.
> >
> > Then, I went and tried "ra
On Thu, 2012-11-15 at 19:04 -0200, Gustavo Padovan wrote:
> if one
> wants use bluetooth on linux he/she needs HCI core, L2CAP and SCO. Those were
> three different modules in the past, but at some point we concluded it does
> not
> makes sense to have the split.
You could remove the unused CONFI
On Thu, 2012-11-15 at 22:03 +0100, Markus Grabner wrote:
> Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > The reason this is hitting the 80 character limit is because
> > "LINE6_INDEX_PCM_ALSA_CAPTURE_STREAM" is 35 characters long. It
> > isn't even clear from the name what it
On Fri, 2012-11-16 at 00:43 +0100, Markus Grabner wrote:
> On Thursday 15 November 2012 14:12:31 Joe Perches wrote:
> > On Thu, 2012-11-15 at 22:03 +0100, Markus Grabner wrote:
> > > Am Mittwoch, 14. November 2012, 17:33:05 schrieb Dan Carpenter:
> > > > The reason th
Preprocessor directives and asm statements should be
allowed to have a line continuation.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d2d5ba1..019f9be 100755
On Fri, 2012-11-16 at 08:02 +0100, Geert Uytterhoeven wrote:
> On Fri, Nov 16, 2012 at 7:21 AM, Joe Perches wrote:
> > Preprocessor directives and asm statements should be
> > allowed to have a line continuation.
>
> For preprocessor directives I agree.
>
> But wh
On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> Move ipack header files to include/linux/ directory where they belong to.
Why do these belong in include/linux?
What's wrong with path relative includes?
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
On Fri, 2012-11-16 at 19:14 +0100, Samuel Iglesias Gonsálvez wrote:
> On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote:
> > On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote:
> > > Move ipack header files to include/linux/ directory where they belong to.
>
Preprocessor directives and asm statements should be
allowed to have a line continuation.
Signed-off-by: Joe Perches
---
V2:
Make the check for preprocessor directives work properly
# is not optional.
scripts/checkpatch.pl |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff
On Fri, 2012-11-16 at 22:04 +0200, Eilon Greenstein wrote:
> On Fri, 2012-11-16 at 11:55 -0800, David Rientjes wrote:
> > On Fri, 16 Nov 2012, Eilon Greenstein wrote:
> >
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > > index 21a9f5d..7a9c153 100755
> > > --- a/scripts/checkp
On Sat, 2012-11-17 at 05:19 +0900, YAMANE Toshiaki wrote:
> Modify qt_status_change_check() and delete qt_status_change().
>
> Signed-off-by: YAMANE Toshiaki
> ---
> drivers/staging/serqt_usb2/serqt_usb2.c | 53
> +--
> 1 file changed, 22 insertions(+), 31 deletion
Use bitmap_weight to count the total number of bits set in bitmap.
Signed-off-by: Joe Perches
---
sound/usb/endpoint.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index 34de6f2..51a9aa3 100644
--- a/sound/usb
On Sat, 2012-11-17 at 14:33 +0200, Constantine Shulyupin wrote:
> From: Constantine Shulyupin
>
> debugfs_remove() can take a NULL, so let's check and warn about that.
>
> Signed-off-by: Constantine Shulyupin
> ---
> scripts/checkpatch.pl |8
> 1 file changed, 8 insertions(+)
>
>
On Sat, 2012-11-17 at 16:36 +0200, Constantine Shulyupin wrote:
> From: Constantine Shulyupin
>
> debugfs_remove() and debugfs_remove_recursive() can take a NULL, so let's
> check and warn about that.
>
> Channegs since v1:
>
> - added debugfs_remove_recursivere
> - all tests for pattenrs are
On Sat, 2012-11-17 at 20:54 +0200, Constantine Shulyupin wrote:
> From: Constantine Shulyupin
Hi Constantine.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +# check for needless debugfs_remove() and debugfs_remove_recursive*() checks
> + if ($line =~ /\b(d
On Sun, 2012-11-18 at 11:47 +0200, Vladimir Kondratiev wrote:
> I see 2 drivers that use dynamic prefix:
>
> - mentioned above drivers/tty/ipwireless/hardware.c
> - drivers/isdn/hardware/mISDN/
>
> I see several options:
>
> 1) require prefix_str to be constant. Patch code mentioned. For example
On Sun, 2012-11-18 at 19:01 +0200, Vladimir Kondratiev wrote:
> In case this option wins, patch follows. There is no need for
> 2-nd one to fix existing drivers.
Thanks Vladimir.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
On Tue, 2012-11-06 at 08:02 -0700, Toshi Kani wrote:
> This patch introduces acpi_pr_(), where is a kernel
> message level such as err/warn/info, to support improved logging
> messages for ACPI, esp. for hotplug operations.
[]
> diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
[]
> @
On Mon, 2012-11-19 at 20:44 +0530, Arpith Easow Alexander wrote:
> This is a patch to the vmk80xx.c file that replaces the printk with dev_dbg.
> This fixes the warnings found by the checkpatch.pl tool.
The commit message is missing description of why
some printk(KERN_INFO are converted to dev_dbg
On Mon, 2012-11-19 at 08:51 -0700, Toshi Kani wrote:
> On Mon, 2012-11-19 at 00:56 -0800, Joe Perches wrote:
> > is acpi_bus.h really the right file for these prototypes?
> This interface is limited for ACPI, so it should be declared in a header
> file under include/acpi. Among th
On Tue, 2012-11-20 at 14:29 +, Andy Whitcroft wrote:
> This all looks sensible, though we still have three blocks doing the
> same thing. How about we standardise this check into a single check,
> generating the capacity from the matched name.
[]
> diff --git a/scripts/checkpatch.pl b/scripts
On Tue, 2012-11-20 at 16:50 +0200, Constantine Shulyupin wrote:
> >> On Tue, 2012-11-20 at 14:29 +, Andy Whitcroft wrote:
> >> Perhaps just
> >> WARN("NEEDLESS_IF",
> >
> > I would cirtainly be happy with that, I was trying to avoid changing the
> > capacity for th
On Tue, 2012-11-20 at 15:37 +, Andy Whitcroft wrote:
> Consolidate the if (foo) bar(foo) detectors into a single check. Add
> debugfs_remove and family.
>
> Based on a patch by Constantine Shulyupin .
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
>
> +# check for needle
On Tue, 2012-11-20 at 16:39 +, Andy Whitcroft wrote:
> On Tue, Nov 20, 2012 at 07:51:17AM -0800, Joe Perches wrote:
> > On Tue, 2012-11-20 at 15:37 +, Andy Whitcroft wrote:
> > > Consolidate the if (foo) bar(foo) detectors into a single check. Add
> > >
On Tue, 2013-04-16 at 20:18 +, Haiyang Zhang wrote:
> > From: David Miller [mailto:da...@davemloft.net]
> > It works fine, but it's unclean.
> > Keep the req_id type as "u64", because that's what it is, a 64-bit request
> > ID.
> I will make this update and submit a new patch, with the added
CONFIG_USB_STORAGE_DEBUG
is set.
$ size drivers/usb/storage/built-in.o*
textdata bss dec hex filename
140133 55296 70312 265741 40e0d drivers/usb/storage/built-in.o.new
147494 55248 70296 273038 42a8e drivers/usb/storage/built-in.o.old
Signed-off-by: Joe Perches
On Wed, 2013-04-17 at 10:14 -0400, Alan Stern wrote:
> On Tue, 16 Apr 2013, Joe Perches wrote:
> > Reduce the size of the objects by consolidating
> > the duplicated USB_STORAGE into a single function.
[]
> Is there any reasonable way to change this so that US_DEBUGP gets
> c
On Wed, 2013-04-17 at 14:47 -0400, Alan Stern wrote:
> On Wed, 17 Apr 2013, Joe Perches wrote:
[]
> > +int usb_stor_dbg(const struct us_data *us, const char *fmt, ...)
> > +{
> > + struct va_format vaf;
> > + va_list args;
> > + int r;
&
On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote:
> On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote:
> > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8;
> > index + 1)
> > Please
> Wondering wh
On Thu, 2013-04-18 at 16:05 +1000, Stephen Rothwell wrote:
> After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
>
> ERROR: "usb_stor_dbg" [drivers/usb/storage/ums-usbat.ko] undefined!
[...]
> Caused by commit 75b9130e8af6 ("usb: storage: Add usb_stor_dbg
On Thu, 2013-04-18 at 10:57 -0400, Alan Stern wrote:
> On Wed, 17 Apr 2013, Joe Perches wrote:
>
> > On Wed, 2013-04-17 at 14:47 -0400, Alan Stern wrote:
> > > On Wed, 17 Apr 2013, Joe Perches wrote:
> > []
> > > > +int usb_stor_dbg(co
On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote:
> On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote:
> > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote:
> > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote:
> > > > >
Fix allmodconfig link error introduced by commit 75b9130e8a
("usb: storage: Add usb_stor_dbg, reduce object size")
Export the symbol usb_stor_dbg.
Add export.h
Signed-off-by: Joe Perches
---
drivers/usb/storage/debug.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/u
On Fri, 2013-04-19 at 11:45 +0200, Gertjan van Wingerde wrote:
> Hi Joe,
Hello Gertjan.
> On Fri, Apr 19, 2013 at 10:33 AM, Joe Perches wrote:
> > Reduce object size ~2% using more current logging styles.
[]
> > +/* Utility printing macros */
> > +#de
On Fri, 2013-04-19 at 10:35 -0700, Greg Kroah-Hartman wrote:
> On Wed, Apr 17, 2013 at 08:00:55PM -0700, Joe Perches wrote:
> > Use a more current logging style with dev_printk
> > where possible.
[]
> With your other patch applied, this one seems to not apply to my tree:
I'
Use a more current logging style.
Convert homegrown ERROR/INFO macros to pr_.
Convert homegrown parse_err macros to pr_err and
expand hidden flow control.
Signed-off-by: Joe Perches
---
drivers/mtd/devices/block2mtd.c | 58 ++---
1 file changed, 31
On Fri, 2013-04-19 at 12:55 -0400, Jörn Engel wrote:
> On Fri, 19 April 2013 10:59:35 -0700, Joe Perches wrote:
> > }
> > list_add(&dev->list, &blkmtd_device_list);
> > - INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
> > -
On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote:
> I agree that a creeping list of exceptions where CamelCase
> is to be overlooked would be bad, but I would argue that
> perhaps my exceptions aren't actual CamelCase - they're
> (pretending to be) SI units, and just happen to match the
> Cam
Many existing variable names use SI like variants that
should be otherwise obvious and acceptable.
Whitelist them from the CamelCase message.
Suggested-by: Phil Carmody
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git a/scripts
On Wed, 2013-06-12 at 12:17 -0400, Jason Cooper wrote:
> On Wed, Jun 12, 2013 at 09:02:15AM -0700, Joe Perches wrote:
> > On Wed, 2013-06-12 at 15:59 +0300, Phil Carmody wrote:
> > > I agree that a creeping list of exceptions where CamelCase
> > > is to be overlooke
Just use struct ctl_table.
Signed-off-by: Joe Perches
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 58453b8..17315d7 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -5080,7 +5080,7
On Thu, 2013-06-13 at 19:32 +0200, Tomasz Figa wrote:
[]
> Similarly for Kukjin, he's listed as the main Samsung maintainer already,
> but AFAIK in this case the script can't infer this based on directory
> structure. Let's see how it's done for other Samsung drivers:
A pattern could be added th
On Thu, 2013-06-13 at 21:25 +0300, Andy Shevchenko wrote:
> On Thu, Jun 13, 2013 at 5:37 PM, Alexey Brodkin
> wrote:
> > Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> > instantiated in some legacy ARC (Synopsys) FPGA Boards such as
> > ARCAngel4/ML50x.
>
> Much better. But st
It's clearer to use struct ctl_table instead
Joe Perches (33):
arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table
frv: Convert use of typedef ctl_table to struct ctl_table
ia64: crash: Convert use of typedef ctl_table to struct ctl_table
mips: lasat: sysctl: Co
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches
---
arch/arm/kernel/isa.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kernel/isa.c b/arch/arm/kernel/isa.c
index 3464859..9d1cf71 100644
--- a/arch/arm/kernel/isa.c
+++ b
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches
---
arch/mips/lasat/sysctl.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/mips/lasat/sysctl.c b/arch/mips/lasat/sysctl.c
index f27694f..3b7f65c 100644
--- a/arch/mips
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches
---
arch/ia64/kernel/crash.c | 4 ++--
arch/ia64/kernel/perfmon.c | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c
index b942f40
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches
---
arch/frv/kernel/pm.c | 8
arch/frv/kernel/sysctl.c | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/frv/kernel/pm.c b/arch/frv/kernel/pm.c
index 0b57992..ac767d9
This typedef is unnecessary and should just be removed.
Signed-off-by: Joe Perches
---
arch/powerpc/kernel/idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/idle.c b/arch/powerpc/kernel/idle.c
index 939ea7e..d7216c9 100644
--- a/arch/powerpc
701 - 800 of 10416 matches
Mail list logo
