On Sat, 2012-11-17 at 20:54 +0200, Constantine Shulyupin wrote:
> From: Constantine Shulyupin <co...@makelinux.com>
Hi Constantine.
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +# check for needless debugfs_remove() and debugfs_remove_recursive*() checks
> + if ($line =~ /\b(debugfs_remove(?:_recursive)?)$expr/) {
> + WARN("NEEDLESS_DEBUGFS_REMOVE",
> + "$1(NULL) is safe this check is probably
> not required\n" . $hereprev);
> + }
OK,
> +# check for needless debugfs_remove_recursive() and
> debugfs_remove_recursive*() checks
> + if ($line =~
> /\b(debugfs_remove_recursive(?:_recursive)?)$expr/) {
> + WARN("NEEDLESS_DEBUGFS_REMOVE_RECURSIVE",
> + "$1(NULL) is safe this check is probably
> not required\n" . $hereprev);
> + }
You don't need thus second block.
The first check finds both
debugfs_remove(foo)
and
debugfs_remove_recursive(bar)
The second one is redundant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
