On Fri, 2012-10-05 at 21:09 -0700, Christopher Heiny wrote:
[]
Just some trivial comments:
> diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
[]
> @@ -0,0 +1,1529 @@
[]
> +static ssize_t delay_write(struct file *filp, const char __user *buffer,
> +
On Sun, 2012-10-07 at 20:52 +0530, Laxman Dewangan wrote:
> Add error prints when memory allocation failed for
> tps65090 data. Also cleanups the melloc arguments.
The new dev_err is unnecessary.
A dump_stack is already done on alloc failures.
The sizeof(* is ok.
> diff --git a/drivers/mfd/tps65
On Sun, 2012-10-07 at 19:18 +0200, Julia Lawall wrote:
> On Sun, 7 Oct 2012, walter harms wrote:
> > Am 07.10.2012 18:44, schrieb Julia Lawall:
> >> On Sun, 7 Oct 2012, walter harms wrote:
> >>> Am 07.10.2012 17:38, schrieb Julia Lawall:
> Introduce use of I2c_MSG_READ/WRITE/OP, for readabilit
On Sun, 2012-10-07 at 20:56 +0200, Julia Lawall wrote:
> >> Some people thought that it would be nice to have the macros rather than
> >> the inlined field initializations, especially since there is no flag for
> >> write. A separate question is whether an array of one element is useful,
> >> or w
On Sun, 2012-10-07 at 23:43 +0200, Julia Lawall wrote:
> On Sun, 7 Oct 2012, Joe Perches wrote:
> >> Are READ and WRITE the action names? They are really the important
> >> information in this case.
> >
> > Yes, most (all?) uses of _READ and _WRITE mac
On Mon, 2012-10-08 at 14:02 +0530, Rajagopal Venkat wrote:
> On 8 October 2012 13:44, MyungJoo Ham wrote:
[]
> > Thank you!
[]
> Thanks for reviewing and testing this patchset.
Both of you quoted all of the original large patch.
That's quite impolite to all the rest of us on this
list.
Please c
On Mon, 2012-10-08 at 16:39 +0200, Jiri Kosina wrote:
> The module parameter that turns debugging mode (which basically means
> printing a few extra lines during runtime) is in '#if 0' block. Forcing
> everyone who would like to see how entropy is behaving on his system seems
> to be a little bi
On Mon, 2012-10-08 at 21:54 +0200, "Jan H. Schönherr" wrote:
> Am 08.10.2012 21:24, schrieb Kay Sievers:
> > On Fri, Sep 28, 2012 at 4:56 PM, Kay Sievers wrote:
> >> On Fri, Sep 28, 2012 at 4:49 PM, "Jan H. Schönherr"
> >>> Given that I'm able to fix the racing case, would you be in favor of
> >>>
On Tue, 2012-10-09 at 00:31 +0530, Anmol Sarma wrote:
> Changed all user visible multi-line stings to single line.
Another patch might be to add
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
before any #include and
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/android/binde
On Tue, 2012-10-09 at 21:40 +0530, Adil Mujeeb wrote:
> Repalces printk's with pr_debug
[]
> diff --git a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> b/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> index 0ca857a..48fe622 100644
> --- a/linux-3.6-rc7/drivers/staging/winbond/wbusb.c
> +++ b/li
On Wed, 2012-10-10 at 18:38 +0200, Peter Senna Tschudin wrote:
> This patch remove a semicolon after if(...) that is preventing the
> error check to work correctly. Removing this semicolon will change the
> code behavior, but this is intended.
>
> The semantic patch that finds this problem is as f
Reduces object size and should be slightly faster.
allyesconfig:
$ size net/core/pktgen.o*
textdata bss dec hex filename
522514293 11824 68368 10b10 net/core/pktgen.o.new
523104293 11848 68451 10b63 net/core/pktgen.o.old
Signed-off-by: Joe Perches
Reduces object size and should be slightly faster.
allyesconfig:
$ size net/core/pktgen.o*
textdata bss dec hex filename
522844321 11840 68445 10b5d net/core/pktgen.o.new
523104293 11848 68451 10b63 net/core/pktgen.o.old
Signed-off-by: Joe Perches
ipv4 and ipv6 use different styles for these tests.
ipv4_is_(__be32)
ipv6_addr_(struct in6_addr *)
Perhaps it'd be good to convert the ipv4 tests to the ipv6 style.
There are ~100 instances of ipv4_is_ tests treewide.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" i
Maybe all the is__ether_addr functions should be renamed
to eth_addr_ for more api/style symmetry.
$ git grep --name-only -E "\bis_\w+_ether_addr" | \
xargs sed -r -i -e 's/\bis_(\w+)_ether_addr\b/eth_addr_\1/g'
$ git diff --shortstat
304 files changed, 690 insertions(+), 690 deletions(-)
May
On Fri, 2012-11-30 at 06:49 -0500, Jeff Layton wrote:
> On Thu, 29 Nov 2012 11:37:19 -0800
> Joe Perches wrote:
>
> > Make the compilation work again when CIFS_DEBUG is not #define'd.
> >
> > Add format and argument verification for the various macros when
On Fri, 2012-11-30 at 06:56 -0500, Jeff Layton wrote:
> On Thu, 29 Nov 2012 11:37:20 -0800
> Joe Perches wrote:
>
> > Rather than havign a permanently enabled #define, allow
> > control over it.
> >
> > This can reduce the size of the module by ~100KB which
On Fri, 2012-11-30 at 10:07 -0500, Jeff Layton wrote:
> On Fri, 30 Nov 2012 06:57:40 -0800
> Joe Perches wrote:
> > On Fri, 2012-11-30 at 06:56 -0500, Jeff Layton wrote:
> > > On Thu, 29 Nov 2012 11:37:20 -0800
> > > Joe Perches wrote:
> > > > Rather
On Fri, 2012-11-30 at 17:04 +0200, Felipe Balbi wrote:
> On Fri, Nov 30, 2012 at 09:18:54AM -0500, Li Wu wrote:
> > This is a initial driver for STMicroelectronics multi touch
> > capacitive touchscren FingertipK. It supports maximum 10 fingers,
> > based on I2C interface.
[]
> diff --git a/drivers
On Fri, 2012-11-30 at 13:39 -0700, Lance Ortiz wrote:
> This patch will provide a more reliable and easy way for user-space
> applications to have access to AER logs rather than reading them from the
> message buffer. It also provides a way to notify user-space when an AER
> event occurs.
Please r
On Sat, 2012-12-01 at 19:50 +0100, Stefan Beller wrote:
> Hello,
>
> I was just browsing the shortlog and it looked to
> me as if there are many double entries, i.e. the same person
> being there with multiple email addresses.
>
> So I wrote a script, which finds double names and adds them
> to
On Sat, 2012-10-20 at 09:22 -0700, Joe Perches wrote:
> Use the normal kernel test instead of a module specific one.
ping?
> Signed-off-by: Joe Perches
> ---
> found when doing that larger style conversion,
> might as well submit it.
>
> drivers/net/ethernet/intel/ixgb
On Fri, 2012-11-30 at 09:39 -0600, Steve French wrote:
> But ... the need still remains for more tracing for cifs (I run into
> this a few times a month at least when debugging) - does anyone have
> any ideas for how to add dynamic trace points to cifs (has anyone even
> done it for the vfs?) - is
On Mon, 2012-12-03 at 11:33 -0700, Lance Ortiz wrote:
> This header file will define a new trace event that will be triggered when
> a AER event occurs. The following data will be provided to the trace
> event.
trivial notes:
> diff --git a/include/trace/events/ras.h b/include/trace/events/ras.h
On Mon, 2012-12-03 at 20:20 +, Ortiz, Lance E wrote:
> > > +#define correctable_error_string \
> > > + {BIT(0),"Receiver Error"}, \
> > > + {BIT(6),"Bad TLP"}, \
> > > + {BIT(7),"Bad DLLP"},\
> > > + {B
On Tue, 2012-12-04 at 10:04 -0700, Lance Ortiz wrote:
> These changes make cper_print_aer more consistent with aer_print_error
> which is called in the AER interrupt case. The string in the variable
> 'prefix' is printed at the beginning of each print statement in
> cper_print_aer(). The prefix is
(resending due to bounces, sorry for any inconvenience)
On Fri, 2012-11-30 at 09:39 -0600, Steve French wrote:
> But ... the need still remains for more tracing for cifs (I run into
> this a few times a month at least when debugging) - does anyone have
> any ideas for how to add dynamic trace poin
On Wed, 2012-12-05 at 16:08 +, James Hogan wrote:
> Add source files from the Thread Binary Interface (TBI) library which
> provides useful low level operations and traps/context management.
[]
> arch/metag/tbx/tbicache.c | 462
>
Could you pleas
On Wed, 2012-12-05 at 16:48 -0500, Jason Baron wrote:
> Here's a collection of the latest dynamic debug patches that I have
> pending.
Any update on the jump table support?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
On Wed, 2012-10-17 at 11:47 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:34, Joe Perches wrote:
> > I believe you are quoting KBUILD_MODNAME
>
> Yes. :(
> Far better output with this. Thanks.
Oh good, but please use a space between KBUILD_MODNAME
and the quoted ":
On Wed, 2012-10-17 at 12:03 +0530, Viresh Kumar wrote:
> On 17 October 2012 11:56, Joe Perches wrote:
> > Oh good, but please use a space between KBUILD_MODNAME
> > and the quoted ": ".
>
> Anything technical behind it or just for code formatting?
Just code forma
On Wed, 2012-10-17 at 13:13 +0200, Borislav Petkov wrote:
> mce_ser, mce_bios_cmci_threshold and mce_disabled are the last three
> bools which need conversion. Move them to the mca_config struct and
> adjust usage sites accordingly.
[]
> diff --git a/arch/x86/kernel/cpu/mcheck/mce.c
> b/arch/x86/k
On Thu, 2012-10-18 at 00:01 +0900, Sangho Yi wrote:
> I removed trailing whitespaces and removed unnecessary whitespaces and
> indentation tabs.
[]
> diff --git a/drivers/power/wm831x_power.c b/drivers/power/wm831x_power.c
[]
> @@ -632,9 +632,8 @@ static __devexit int wm831x_power_remove(struct
>
On Wed, 2012-10-17 at 20:53 +0530, Viresh Kumar wrote:
> On 16 October 2012 17:14, hongbo.zhang wrote:
[]
> > diff --git a/drivers/thermal/db8500_cpufreq_cooling.c
> > b/drivers/thermal/db8500_cpufreq_cooling.c
[]
> > +#include
> > +#include
> > +#include
> > +#include
> > +#include
> > +#in
Add and use a convenience inline to get an irq by name.
Signed-off-by: Joe Perches
---
Perhaps this is a better alternative to code reflowing.
include/linux/mfd/wm831x/core.h | 8
drivers/input/touchscreen/wm831x-ts.c | 7 ++-
drivers/power/wm831x_power.c | 20
On Thu, 2012-10-18 at 10:36 +0200, Mischa Jonker wrote:
> This adds support for the PS/2 block that is used in various ARC FPGA
> platforms.
[]
> diff --git a/drivers/input/serio/arc_ps2.c b/drivers/input/serio/arc_ps2.c
[]
> +static void arc_ps2_check_rx(struct arc_ps2_data *arc_ps2,
> +
On Thu, 2012-10-18 at 09:05 +, Mischa Jonker wrote:
> Hi Joe,
>
> >> + while (1) {
> >infinite loop with bad hardware?
> >Perhaps a jiffies timeout?
>
> What do you suggest? Add a counter and limit the maximum number of iterations
> to an arbitrary number (say 1000)?
Yes, something like th
On Fri, 2012-10-19 at 01:31 +0900, Sangho Yi wrote:
> I fixed lines over 80 characters per line.
If you really must do these things, please use
checkpatch.pl --strict for guidance on how to align
function arguments.
> diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c
[]
> @@ -6
On Fri, 2012-10-19 at 02:19 +0900, Sangho Yi wrote:
> Added a space between comma and an argument on the function definition
Hi Sangho.
Please don't just be a checkpatch robot, but look at the
code and see if you can improve it.
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> inde
The __used attribute prevents gcc from eliminating
unnecessary, otherwise optimized away, metadata for
debugging logging messages.
Remove the __used attribute.
Signed-off-by: Joe Perches
---
include/linux/dynamic_debug.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
On Thu, 2012-10-18 at 12:40 -0700, Greg KH wrote:
> On Thu, Oct 18, 2012 at 12:07:03PM -0700, Joe Perches wrote:
> > The __used attribute prevents gcc from eliminating
> > unnecessary, otherwise optimized away, metadata for
> > debugging logging messages.
> >
>
On Thu, 2012-10-18 at 16:16 -0700, Andrew Morton wrote:
> On Tue, 16 Oct 2012 23:06:04 -0700
> Joe Perches wrote:
>
> > Make printk a bit more readable.
[]
> OK, nobody's allowed to change the printk code for two months.
[filelist]
> It wouldn't hurt to describe
On Thu, 2012-10-18 at 16:16 -0700, Andrew Morton wrote:
> It wouldn't hurt to describe the design here a bit. How was the code
> partitioned and what is the role of each file?
>
> That's reasonably obvious from the names, but some might wonder about
> the difference between printk_log and printk_
On Fri, 2012-10-19 at 08:33 +0800, Daniel J Blueman wrote:
> Previously a new line is implicitly added in the no GSI case:
>
> [7.185182] pci 0001:00:12.0: can't derive routing for PCI INT A
> [7.191352] pci 0001:00:12.0: PCI INT A: no GSI
> [7.195956] - using ISA IRQ 10
>
> The code
Use the standard test for a non-zero ipv6 address.
Signed-off-by: Joe Perches
---
net/core/pktgen.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index d1dc14c..1d1c216 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
Make the ether_addr tests use a similar style to ipv6_ tests.
Add backward compatibility #defines to keep current is__ether_addr
code working until completely converted.
Signed-off-by: Joe Perches
---
include/linux/etherdevice.h | 36 ++--
1 files changed, 22
*)
ipv4_addr_(__be32)
ipv6_addr_(const struct in6_addr *)
Add temporary backward compatibility #defines for the old names too.
Joe Perches (21):
etherdevice: Rename is__ether_addr tests to eth_addr_
net: Convert is__ether_addr uses to eth_addr_
arch: Convert is__ether_addr uses to eth_addr_
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
net/802/stp.c |4 +-
net/8021q/vlan_dev.c |6 ++--
net/8021q/vlan_netlink.c |2 +-
net/batman-adv/bat_iv_ogm.c
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
arch/arm/mach-davinci/board-mityomapl138.c |2 +-
arch/arm/mach-pxa/colibri-pxa3xx.c |2 +-
arch/avr32/boards/atngw100/setup.c |2 +-
arch/avr32/boards/atstk1000
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/net/wireless/adm8211.c |2 +-
drivers/net/wireless/airo.c|4 ++--
drivers/net/wireless/at76c50x-usb.c|8
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/staging/ccg/u_ether.c |6 +++---
drivers/staging/csr/sme_wext.c |2 +-
drivers/staging/et131x/et131x.c|4
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/scsi/bnx2fc/bnx2fc_els.c |4 ++--
drivers/scsi/bnx2fc/bnx2fc_fcoe.c |2 +-
drivers/scsi/fcoe/fcoe.c | 12 ++--
drivers/scsi/fcoe/fcoe_ctlr.c |8
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/of/of_net.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/of/of_net.c b/drivers/of/of_net.c
index ffab033..452dcf6 100644
--- a/drivers/of/of_net.c
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/s390/net/qeth_l2_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
index e67e025
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/usb/gadget/u_ether.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/u_ether.c b/drivers/usb/gadget/u_ether.c
index 6458764..d6a5577
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/uwb/address.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/uwb/address.c b/drivers/uwb/address.c
index 8739c4f..ba4e4cf 100644
--- a/drivers/uwb
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
Documentation/networking/driver.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/networking/driver.txt
b/Documentation/networking/driver.txt
index
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
include/net/llc_if.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/llc_if.h b/include/net/llc_if.h
index b595a00..cce2942 100644
--- a/include/net
Make the ipv4_is_ tests use a similar style to ipv6_ tests.
Add backward compatibility #defines to keep current ipv4_is_
code working until completely converted.
Signed-off-by: Joe Perches
---
include/linux/in.h | 40
1 files changed, 28 insertions
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
net/bridge/br_multicast.c |4 +-
net/core/netpoll.c|2 +-
net/core/pktgen.c | 10 +++---
net/ipv4/arp.c
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
drivers/infiniband/core/cma.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
drivers/net/wireless/ath/ath6kl/wmi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c
b/drivers/net
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
drivers/parisc/led.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/parisc/led.c b/drivers/parisc/led.c
index f2f501e..8951fd1 100644
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
include/linux/lockd/lockd.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/lockd/lockd.h b/include/linux/lockd/lockd.h
index
Use the new ipv4_addr_ functions to be consistent with
the ipv6_addr_ and eth_addr_ style.
Signed-off-by: Joe Perches
---
include/net/sctp/constants.h | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/net/sctp/constants.h b/include/net/sctp/constants.h
Convert the old ether_addr tests to eth_addr_.
Adds api consistency.
Signed-off-by: Joe Perches
---
drivers/infiniband/hw/amso1100/c2.c |2 +-
drivers/infiniband/hw/nes/nes_nic.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/amso1100/c2.c
b
(trimmed over long cc list from original 00/21 post)
On Fri, 2012-10-19 at 09:04 +0200, Eric Dumazet wrote:
> On Thu, 2012-10-18 at 20:55 -0700, Joe Perches wrote:
> > ethernet, ipv4, and ipv6 address testing uses 3 different api naming styles.
> >
> > ethernet uses: is
(cc list trimmed)
On Fri, 2012-10-19 at 11:55 -0400, Pavel Roskin wrote:
> On Fri, 19 Oct 2012 09:04:14 +0200
> Eric Dumazet wrote:
>
> > Yes they are some names discrepancies, thats a big deal.
> >
> > And we have alloc_skb() / kfree_skb() / skb_clone()
> >
> > Why not skb_alloc() / skb_free
Use the normal kernel test instead of a module specific one.
Signed-off-by: Joe Perches
---
found when doing that larger style conversion,
might as well submit it.
drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 27
On Sat, 2012-10-20 at 12:22 -0400, Frederic Weisbecker wrote:
> lets implement the printk tick using irq work.
Hi Frederic.
Can you redo this change please against -next in a few days?
Andrew Morton picked up this series,
https://lkml.org/lkml/2012/10/17/41
but it's not yet in -next.
https://l
On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> Fixed all instances of strings spanning multiple lines from checkpatch.pl.
[]
> diff --git a/drivers/staging/android/binder.c
> b/drivers/staging/android/binder.c
[]
> @@ -556,7 +556,7 @@ static int binder_update_page_range(struct binder_proc
On Sun, 2012-10-21 at 12:05 +1000, Cruz Julian Bishop wrote:
> is there currently any way to insert, say,
> a comment that filters out the next line for checkpatch
> errors?
>
> For example,
>
> /* checkpatch_ignore_(rulename) */
> (Long line that can't be broken here)
Nope. checkpatch is a stu
waOn Mon, 2012-10-22 at 10:37 +0100, David Howells wrote:
> Joe Perches wrote:
>
> > On Sat, 2012-10-20 at 23:33 +0100, Ken O'Brien wrote:
> > ...
> > > - pr_err("binder: %d: binder_alloc_buf failed to "
> > > +
Line continuations are not normal kernel style.
Bleat a warning when used outside of a macro definition.
Signed-off-by: Joe Perches
---
On Mon, 2012-10-22 at 09:02 -0400, Peter Hurley wrote:
> On Mon, 2012-10-22 at 05:15 -0700, Joe Perches wrote:
> > waOn Mon, 2012-10-22 at 10:37 +01
On Mon, 2012-10-22 at 06:16 -0700, Joe Perches wrote:
> Line continuations are not normal kernel style.
> Bleat a warning when used outside of a macro definition.
[]
> Maybe this patch:
bad patch, please ignore.
--
To unsubscribe from this list: send the line "unsubscribe linux-
On Mon, 2012-10-22 at 18:22 -0700, Randy Dunlap wrote:
> On 10/22/2012 05:09 PM, a...@linux-foundation.org wrote:
Hi Randy.
> on i386, when CONFIG_PRINTK is not enabled:
[]
> case 1. CONFIG_TTY_PRINTK=y, CONFIG_EARLY_PRINTK=y
>
> see config-r8272
[]
> case 2. CONFIG_TTY_PRINTK=n, CONFIG_EARL
On Thu, 2012-12-06 at 09:35 +, James Hogan wrote:
> On 05/12/12 18:53, Joe Perches wrote:
> > On Wed, 2012-12-05 at 16:08 +, James Hogan wrote:
> >> Add source files from the Thread Binary Interface (TBI) library which
> >> provides useful low level operations a
On Thu, 2012-12-06 at 13:39 -0800, Andrew Morton wrote:
> On Thu, 6 Dec 2012 18:05:57 +0100
> Jan H. Sch__nherr wrote:
>
> > This is the second iteration of my try to clean up and fix some bugs around
> > printk().
>
> We're a few days away from 3.7, which is not a good time to be sending
> lar
On Thu, 2012-12-06 at 18:09 +0100, Sylvain Munaut wrote:
> The "%5lu" part of the sprintf only guarantees a minimum length,
> not a maximum one. This patch should make it correct for any
> possible timestamp.
>
> This problem dates back from the printk conversion to records AFAICT.
>
> I've teste
On Thu, 2012-12-06 at 16:19 -0800, Andrew Morton wrote:
> On Thu, 06 Dec 2012 15:37:30 -0800
> Joe Perches wrote:
> > Can you please pick this up for -next now and I'll
> > redo my patches against -next for -rc1 so I'm not
> > delayed until 3.9?
>
> It w
On Fri, 2012-12-07 at 07:04 -0800, Greg Kroah-Hartman wrote:
> On Fri, Dec 07, 2012 at 12:47:36PM +0100, "Jan H. Schönherr" wrote:
> > Am 07.12.2012 03:51, schrieb Joe Perches:
> > > On Thu, 2012-12-06 at 16:19 -0800, Andrew Morton wrote:
> > >> On Th
On Sat, 2012-12-08 at 15:34 -0200, Peter Senna Tschudin wrote:
> This semantic patch looks for semicolons that can be removed without
> changing the semantics of the code. The confidence is moderate
> because there are some false positives on cases like:
>
> b/drivers/mmc/host/cb710-mmc.c:589
>
On Sat, 2012-12-08 at 16:13 -0200, Peter Senna Tschudin wrote:
> On Sat, Dec 8, 2012 at 3:45 PM, Joe Perches wrote:
> > On Sat, 2012-12-08 at 15:34 -0200, Peter Senna Tschudin wrote:
> >> This semantic patch looks for semicolons that can be removed without
> >> changin
: Joe Perches
---
scripts/checkpatch.pl |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f27b0b5..bd2616d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -230,7 +230,7 @@ our $Inline = qr{inline
Even though the kernel doesn't support using floating point constants,
add a regex for them.
Support forms like: 0x123p1, 123e-1, 1.23, 1.5e23f
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/sc
Store the camelcase variables in a hash and only emit a
warning on the first use of each new variable.
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 19 +--
1 files changed, 13 insertions(+), 6 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
On Sun, 2012-12-09 at 10:15 +, Przemo Firszt wrote:
> Replace printk with netdev_printk helpers, dev_printk helpers or
> pr_err/warn/info if there is no device info available.
Here's a few trivial comments
> @@ -84,8 +83,8 @@ static u32 rtl871x_open_fw(struct _adapter *padapter, const
> u8 *
On Mon, 2012-12-10 at 12:46 +0300, Dan Carpenter wrote:
> On Sun, Dec 09, 2012 at 10:15:10AM +, Przemo Firszt wrote:
> > Replace leading spaces with tab
[]
> > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
[]
> > static int r871
On Mon, 2012-12-10 at 15:21 +0300, Dan Carpenter wrote:
> On Mon, Dec 10, 2012 at 03:49:46AM -0800, Joe Perches wrote:
> > checkpatch parenthesis alignment of arguments checks are
> > emitted only when adding --strict to the command line.
> Even with --strict checkpatch.p
a Tschudin
Signed-off-by: Joe Perches
---
scripts/checkpatch.pl | 18 --
1 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f18750e..73302d8 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3450,
On Tue, 2012-12-11 at 12:12 -0800, Greg KH wrote:
> On Tue, Dec 11, 2012 at 03:08:31PM -0500, Jason Baron wrote:
> > On Tue, Dec 11, 2012 at 11:36:46AM -0800, Luis R. Rodriguez wrote:
> > > On Tue, Dec 04, 2012 at 11:28:26AM +0200, Vladimir Kondratiev wrote:
> > > > Hi Jason,
> > > >
> > > > Do yo
On Tue, 2012-12-11 at 19:49 -0200, Cesar Eduardo Barros wrote:
> I could not find the maintainer for the MAINTAINERS file, so sending
> directly to Linus. Sorry if I am mistaken.
Thanks Cesar.
Most maintainers patches are picked up by Andrew Morton (cc'd)
--
To unsubscribe from this list: send
On Mon, 2012-11-12 at 02:12 -0500, Chris Ball wrote:
> Hi,
>
> On Sun, Nov 11 2012, Tushar Behera wrote:
> > Yes, I can do that. I did split it specifically so that we could drop
> > any patches if required.
> >
> > I will wait for a word from Chris regarding what he prefers.
>
> I would want to
On Mon, 2012-11-12 at 14:43 -0800, Kees Cook wrote:
> On Mon, Nov 5, 2012 at 8:18 PM, Joe Perches wrote:
> > On Mon, 2012-11-05 at 15:03 -0800, Kees Cook wrote:
> >> This config item has not carried much meaning for a while now and is
> >> almost always enabled by de
On Fri, 2012-11-02 at 06:49 -0700, Joe Perches wrote:
> On Wed, 2012-10-24 at 20:43 -0700, Joe Perches wrote:
> > Make printk a bit more readable.
>
> Andrew? Are you going to apply this again for -next?
Andrew? Any answer?
> > Created directory:
> > kernel/prin
while it is being phased out.
You should also cc Andrew Morton (cc'd)
> Cc: Andy Whitcroft
> Cc: Joe Perches
> Signed-off-by: Kees Cook
> ---
> scripts/checkpatch.pl | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/scripts/chec
On Mon, 2012-11-12 at 15:11 -0800, Kees Cook wrote:
> On Mon, Nov 12, 2012 at 3:06 PM, Joe Perches wrote:
> > On Mon, 2012-11-12 at 14:50 -0800, Kees Cook wrote:
> >> + WARN("CONFIG_EXPERIMENTAL",
> >> + &quo
On Mon, 2012-11-12 at 15:26 -0800, Andrew Morton wrote:
> On Mon, 12 Nov 2012 14:54:10 -0800
> Joe Perches wrote:
>
> > On Fri, 2012-11-02 at 06:49 -0700, Joe Perches wrote:
> > > On Wed, 2012-10-24 at 20:43 -0700, Joe Perches wrote:
> > > > Make printk a bi
On Mon, 2012-11-12 at 14:03 -0800, Jacob Pan wrote:
> Intel PowerClamp driver performs synchronized idle injection across
> all online CPUs. The goal is to maintain a given package level C-state
> ratio.
style trivia:
[]
> diff --git a/drivers/thermal/intel_powerclamp.c
> b/drivers/thermal/inte
On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
> I don't think this works as intended. '|' higher precedence than ?: so
> the bitwize OR "0 | (val & STR_MOST)" is a no-op.
>
> I have re-written it to be more clear.
[]
> diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
[]
> @@ -2581,9
601 - 700 of 10416 matches
Mail list logo
