On Thu, 2012-10-18 at 00:01 +0900, Sangho Yi wrote:
> I removed trailing whitespaces and removed unnecessary whitespaces and
> indentation tabs.
[]
> diff --git a/drivers/power/wm831x_power.c b/drivers/power/wm831x_power.c
[]
> @@ -632,9 +632,8 @@ static __devexit int wm831x_power_remove(struct
> platform_device *pdev)
> int irq, i;
>
> for (i = 0; i < ARRAY_SIZE(wm831x_bat_irqs); i++) {
> - irq = wm831x_irq(wm831x,
There is a trailing space here...
> - platform_get_irq_byname(pdev,
> - wm831x_bat_irqs[i]));
but there's nothing wrong with this.
> + irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev,
> + wm831x_bat_irqs[i]));
ugh.
If you're really going to do these sorts of changes
just to minimize overall line length, please keep
arguments aligned on parentheses where appropriate.
Maybe use a temporary if you're really concerned about
overall line length.
for (i = 0; i < ARRAY_SIZE(wm831x_bat_irqs); i++) {
irq = platform_get_irq_byname(pdev, wm831x_bat_irqs[i]);
irq = wm831x_irq(wm831x, irq);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
