On Mon, 2012-12-10 at 12:46 +0300, Dan Carpenter wrote: > On Sun, Dec 09, 2012 at 10:15:10AM +0000, Przemo Firszt wrote: > > Replace leading spaces with tab [] > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c > > b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c [] > > static int r871x_set_wpa_ie(struct _adapter *padapter, char *pie, > > - unsigned short ielen) > > + unsigned short ielen) > > The original version is better because it lines up correctly. > > Checkpatch doesn't complain for me so I'm not sure what the story is > here.
Parenthesis alignment isn't described in CodingStyle. It's maintainer's preference. Whether or not it should be is a different question. checkpatch parenthesis alignment of arguments checks are emitted only when adding --strict to the command line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
