On 11/27/2012 06:13 AM, Nitin Gupta wrote:
> On 11/22/2012 06:42 PM, Minchan Kim wrote:
>> Lockdep complains about recursive deadlock of zram->init_lock.
>> Because zram_init_device could be called in reclaim context and
>> it requires a page with GFP_KERNEL.
>>
>> We can fix it via replacing GFP_K
On 11/27/2012 08:26 AM, Nitin Gupta wrote:
> For every allocated object, zram maintains the the handle, size,
> flags and count fields. Of these, only the handle is required
> since zsmalloc now provides the object size given the handle.
> The flags field was needed only to mark a given page as zer
On 11/28/2012 03:35 AM, Minchan Kim wrote:
> Lockdep complains about recursive deadlock of zram->init_lock.
> [1] made it false positive because we can't request IO to zram
> before setting disksize. Anyway, we should shut lockdep up to
> avoid many reporting from user.
>
> This patch allocates zr
)
> reclaim
> pageout
> write_page from fs
> fs_lock <-- deadlock
>
> This patch fixes it by using GFP_NOIO. In read path, we
> reorganize code flow so that kmap_atomic is called after the
> GFP_NOIO allocation.
For the all
this patch solves the problem.
>
> It'd be nice to know about the problem in more detail. I'm also
> curious on why you decided on GFP_ATOMIC for the read path and
> GFP_NOIO in the write path.
This is because we're holding a kmap_atomic page in the read path.
On 01/28/2013 02:26 PM, Pekka Enberg wrote:
> On Mon, Jan 28, 2013 at 1:24 PM, Jerome Marchand wrote:
>> On 01/28/2013 08:16 AM, Pekka Enberg wrote:
>>> On Mon, Jan 28, 2013 at 2:38 AM, Minchan Kim wrote:
>>>> Now zram allocates new page with GFP_KERNEL in zram
Reports enhanced partition statistics in sysfs.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
fs/partitions/check.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff -uprN -X linux-2.6/Documentation/dontdiff
linux-2.6.orig/fs/partitions/check.c
Updates the enhanced partition statistics in generic block layer
besides the disk statistics.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
block/blk-core.c | 34 ++
block/blk-merge.c |6 ++
fs/partitions/check.c |7 +++
i
This patch contain the core infrastructure of enhanced partition
statistics. It adds to struct hd_struct the same stats data as struct
gendisk and define basics function to manipulate them.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
include/linux/genhd.h
0.00 0.00 24 0
Any comments ?
Regards,
Jerome Marchand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Updates the enhanced partition statistics in ATA over Ethernet driver
(not tested).
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
drivers/block/aoe/aoecmd.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -uprN -X linux-2.6/Documentation/dontdiff
linux-2.
Reports enhanced partition statistics in /proc/diskstats.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
block/genhd.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff -uprN -X linux-2.6/Documentation/dontdiff linux-2.6.orig/block/genhd.c
Removes the now unused old partition statistic code.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
block/blk-core.c |4
fs/partitions/check.c |2 --
include/linux/genhd.h |1 -
3 files changed, 7 deletions(-)
diff -uprN -X linux-2.6/Documentation/dontdiff lin
Update the documentation to reflect the change in userspace interface.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
Documentation/ABI/testing/procfs-diskstats | 22 ++
Documentation/ABI/testing/sysfs-block | 28 +++
Documentation/iosta
overcommit_ratio variable can still be used to set and read
the ratio with a 1% precision. That way, overcommit_ratio interface
isn't broken in any way that I can imagine.
Signed-off-by: Jerome Marchand
---
include/linux/mman.h |6 ++--
include/linux/sysctl.h |2 +
kernel/sys
On 09/05/2013 04:41 PM, Dave Hansen wrote:
> On 09/05/2013 05:51 AM, Jerome Marchand wrote:
>> This patch adds the new overcommit_ratio_ppm sysctl variable that
>> allow to set overcommit ratio with a part per million precision.
>> The old overcommit_ratio variable can sti
On 09/06/2013 12:11 AM, Pavel Machek wrote:
> hi!
>
This patch adds the new overcommit_ratio_ppm sysctl variable that
allow to set overcommit ratio with a part per million precision.
The old overcommit_ratio variable can still be used to set and read
the ratio with a 1% precisi
a part per million precision.
The old overcommit_ratio variable can still be used to set and read
the ratio with a 1% precision. That way, overcommit_ratio interface
isn't broken in any way that I can imagine.
Signed-off-by: Jerome Marchand
---
Documentation/sysctl/vm.txt|
On 09/06/2013 03:47 PM, Sergey Senozhatsky wrote:
> Calling handle_pending_slot_free() for every RW operation may
> cause unneccessary slot_free_lock locking, because most likely
> process will see NULL slot_free_rq. handle_pending_slot_free()
> only when current detects that slot_free_rq is not NU
On 09/06/2013 03:52 PM, Sergey Senozhatsky wrote:
> `zram->init_done != 0' equals to `zram->meta != NULL', so init_done
> can be removed.
The name init_done is self explanatory, meta isn't. You could for
instance write a function with an explicit name to test for
initialization.
Jerome
>
> Sign
On 09/09/2013 03:21 PM, Dan Carpenter wrote:
> On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote:
Calling handle_pending_slot_free() for every RW operation may
cause unneccessary slot_free_lock locking, because most likely
process will see NULL slot_free_rq. handle_p
On 09/09/2013 02:34 PM, Dan Carpenter wrote:
> On Fri, Sep 06, 2013 at 06:21:20PM +0300, Sergey Senozhatsky wrote:
>> @@ -558,14 +563,12 @@ static void zram_reset_device(struct zram *zram, bool
>> reset_capacity)
>> flush_work(&zram->free_work);
>>
>> down_write(&zram->init_lock);
>> -
On 09/09/2013 03:46 PM, Jerome Marchand wrote:
> On 09/09/2013 03:21 PM, Dan Carpenter wrote:
>> On Mon, Sep 09, 2013 at 03:49:42PM +0300, Sergey Senozhatsky wrote:
>>>>> Calling handle_pending_slot_free() for every RW operation may
>>>>> cause unneccessa
Since commit f40d1e4 (mm: compaction: acquire the zone->lock as late as
possible), isolate_freepages_block() takes the zone->lock itself. The
function description however still states that the zone->lock must be
held.
This patch removes this outdated statement.
Signed-off-by: Jerome
ck in.
This patch sets the page dirty when direct_IO() fails. It fixes a memory
corruption that happened while using swap-over-NFS.
Signed-off-by: Jerome Marchand
---
mm/page_io.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/mm/page_io.c b/mm/page_io.c
index 78eee32..04
Hi,
Please write a commit message, no matter how straightforward a patch may
seem to you.
Also the subject suffers from dyslexia: it's dev_to_zram, not zram_to_dev.
Thanks,
Jerome
On 06/03/2013 05:42 PM, Jiang Liu wrote:
> Signed-off-by: Jiang Liu
> ---
> drivers/staging/zram/zram_sysfs.c | 13
On 06/03/2013 05:42 PM, Jiang Liu wrote:
> Function valid_io_request() should verify the entire request doesn't
> exceed the zram device, otherwise it will cause invalid memory access.
>
> Signed-off-by: Jiang Liu
> ---
> drivers/staging/zram/zram_drv.c | 4
> 1 file changed, 4 insertions(+
The patch seems right, but the title is wrong: this is not a error recovery
path.
Also, the description is missing again.
Jerome
On 06/03/2013 05:42 PM, Jiang Liu wrote:
> Signed-off-by: Jiang Liu
> ---
> drivers/staging/zram/zram_drv.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
On 06/04/2013 05:09 PM, Jiang Liu wrote:
> On Tue 04 Jun 2013 09:15:43 PM CST, Jerome Marchand wrote:
>> On 06/03/2013 05:42 PM, Jiang Liu wrote:
>>> Function valid_io_request() should verify the entire request doesn't
>>> exceed the zram device, otherwise it
Hi Jiang,
Could you please state the changes that happened between v1 and v2.
That would be really helpful to the reviewers, and probably even more
useful to the maintainer.
Thanks,
Jerome
On 06/04/2013 06:05 PM, Jiang Liu wrote:
> Now there's no caller of zram_get_num_devices(), so kill it.
> A
On 06/04/2013 06:06 PM, Jiang Liu wrote:
> zram_free_page() is protected by down_write(&zram->lock) when called by
> zram_bvec_write(), but there's no such protection when called by
> zram_slot_free_notify(), which may cause wrong states to zram object.
>
> There are two possible consequences of t
On 06/04/2013 06:06 PM, Jiang Liu wrote:
> On error recovery path of zram_init(), it leaks the zram device object
> causing the failure. So change create_device() to free allocated
> resources on error path.
>
> Signed-off-by: Jiang Liu
> Cc: sta...@vger.kernel.org
Acked-b
On 06/04/2013 06:06 PM, Jiang Liu wrote:
> Use atomic64_xxx() to replace open-coded zram_stat64_xxx().
> Some architectures have native support of atomic64 operations,
> so we can get rid of the spin_lock() in zram_stat64_xxx().
> On the other hand, for platforms use generic version of atomic64
> i
On 06/05/2013 06:21 PM, Jiang Liu wrote:
> On Wed 05 Jun 2013 08:02:12 PM CST, Jerome Marchand wrote:
>> On 06/04/2013 06:06 PM, Jiang Liu wrote:
>>> Use atomic64_xxx() to replace open-coded zram_stat64_xxx().
>>> Some architectures have native support of atomic64 operat
On 06/06/2013 04:36 PM, Jiang Liu wrote:
> On Thu 06 Jun 2013 05:37:19 PM CST, Jerome Marchand wrote:
>> On 06/05/2013 06:21 PM, Jiang Liu wrote:
>>> On Wed 05 Jun 2013 08:02:12 PM CST, Jerome Marchand wrote:
>>>> On 06/04/2013 06:06 PM, Jiang Liu wrote:
>>&g
he order of destroy_device(zram)
> and zram_reset_device(zram), that will cause deadlock issues to the
> zram sysfs handler.
>
> So fix it by holding an extra reference to zram->disk before calling
> destroy_device(zram).
>
> Signed-off-by: Jiang Liu
> Cc: sta...@vger.kerne
e zram_slot_free_notify() to acquire writer lock on zram->lock
> before calling zram_free_page().
>
> Signed-off-by: Jiang Liu
> Cc: sta...@vger.kernel.org
Acked-by: Jerome Marchand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
On 06/04/2013 06:06 PM, Jiang Liu wrote:
> When doing a patial write and the whole page is filled with zero,
> zram_bvec_write() will free uncmem twice.
>
> Signed-off-by: Jiang Liu
> Cc: sta...@vger.kernel.org
I thought I acked this one already. I guess I didn't.
Acked
On 06/07/2013 10:09 AM, Minchan Kim wrote:
> On Fri, Jun 07, 2013 at 12:07:26AM +0800, Jiang Liu wrote:
>> Function valid_io_request() should verify the entire request are within
>> the zram device address range. Otherwise it may cause invalid memory
>> access when accessing/modifying zram->meta->t
mem_used_total; done
> Thread 2:
> while true; do echo 8M > disksize; echo 1 > reset; done
>
> Signed-off-by: Jiang Liu
> Acked-by: Minchan Kim
> Cc: sta...@vger.kernel.org
Acked-by: Jerome Marchand
--
To unsubscribe from this list: send the line "u
On 06/26/2013 02:28 PM, Sergey Senozhatsky wrote:
> Commit 9b3bb7abcdf2df0f1b2657e6cbc9d06bc2b3b36f (remove
> zram_sysfs file (v2)) accidentally made zram_reset_device()
> racy. Protect zram_reset_device() call with zram->lock.
>
> Signed-off-by: Sergey Senozhatsky
Acked-b
The same calculation is currently done in three different places.
Factor that code so future changes has to be made at only one place.
Signed-of-by: Jerome Marchand
---
fs/proc/meminfo.c|5 +
include/linux/mman.h | 12
mm/mmap.c|4 +---
mm/nommu.c
a 2TB machine it represents no less than
20GB).
This patch adds the new overcommit_kbytes sysctl variable that allow a
much finer grain.
Signed-of-by: Jerome Marchand
---
Documentation/sysctl/vm.txt| 12
Documentation/vm/overcommit-accounting |7 ---
include
On 08/19/2013 06:55 PM, Dave Hansen wrote:
> On 08/19/2013 08:17 AM, Jerome Marchand wrote:
>> Some applications that run on HPC clusters are designed around the
>> availability of RAM and the overcommit ratio is fine tuned to get the
>> maximum usage of memory without s
On 08/19/2013 06:55 PM, Dave Hansen wrote:
> On 08/19/2013 08:17 AM, Jerome Marchand wrote:
>> Some applications that run on HPC clusters are designed around the
>> availability of RAM and the overcommit ratio is fine tuned to get the
>> maximum usage of memory without s
On 08/21/2013 06:23 PM, Dave Hansen wrote:
> On 08/21/2013 08:22 AM, Jerome Marchand wrote:
>>>> Instead of introducing yet another tunable, why don't we just make the
>>>> ratio that comes in from the user more fine-grained?
>>>>
>>>>
On 05/01/2013 09:39 AM, Simon Jeons wrote:
> Ping, ;-)
> On 04/18/2013 08:13 AM, Simon Jeons wrote:
>> Hi Jerome,
>> On 04/17/2013 08:11 PM, Jerome Marchand wrote:
>>> Since commit 62c230b, swap_writepage() calls direct_IO on swap files.
>>> However, in that ca
On 04/22/2013 10:37 PM, Andrew Morton wrote:
> On Wed, 17 Apr 2013 14:11:55 +0200 Jerome Marchand
> wrote:
>
>>
>> Since commit 62c230b, swap_writepage() calls direct_IO on swap files.
>> However, in that case page isn't redirtied if I/O fails, and is therefor
On 01/21/2013 06:21 AM, Minchan Kim wrote:
> Lockdep complains about recursive deadlock of zram->init_lock.
> [1] made it false positive because we can't request IO to zram
> before setting disksize. Anyway, we should shut lockdep up to
> avoid many reporting from user.
>
On 01/21/2013 06:21 AM, Minchan Kim wrote:
> Now zram document syas "set disksize is optional"
> but partly it's wrong. When you try to use zram firstly after
> booting, you must set disksize, otherwise zram can't work because
> zram gendisk's size is 0. But once you do it, you can use zram freely
On 01/22/2013 01:07 AM, Minchan Kim wrote:
> Now zram allocates new page with GFP_KERNEL in zram I/O path
> if IO is partial. Unfortunately, It may cuase deadlock with
> reclaim path so this patch solves the problem.
>
> Cc: Nitin Gupta
> Cc: Jerome Marchand
> Cc: s
complain.
Jerome
---
>From ebb3514c4ee18276da7c5ca08025991b493ac204 Mon Sep 17 00:00:00 2001
From: Jerome Marchand
Date: Thu, 22 Nov 2012 09:07:40 +0100
Subject: [PATCH] staging: zram: Avoid lockdep warning
zram triggers a lockdep warning. The cause of it is the call to
zram_init_device() fro
On 11/23/2012 12:34 AM, Minchan Kim wrote:
> On Thu, Nov 22, 2012 at 12:13:24PM +0100, Jerome Marchand wrote:
>> On 11/21/2012 09:37 AM, Minchan Kim wrote:
>>> Hi alls,
>>>
>>> Today, I saw below complain of lockdep.
>>> As a matter of fact, I knew it
Hi,
Between 2.4 and 2.6, some I/O statistic informations concerning partitions
disappeared as a result of earlier merging of requests. As a consequence, less
statistics are available for partitions than for disks in sysfs and
/proc/diskstats. This batch of patches brings back the lost statistic
This patch contain the core infrastructure of enhanced partition statistics.
It adds to struct hd_struct the same stats data as struct gendisk and define
basics function to manipulate them.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
genhd.h
Updates the enhanced partition statistics in generic block layer besides the
disk statistics.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c | 40
fs/partitions/check.c |7 +++
include/linux/genhd.h |
Updates the enhanced partition statistics in ATA over Ethernet driver (not
tested).
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
aoecmd.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff -urNp -X linux-2.6/Documentation/dontdiff
linux-2.6.orig/drivers/blo
Updates the enhanced partition statistics in cciss driver.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
cciss.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -urNp -X linux-2.6/Documentation/dontdiff
linux-2.6.orig/drivers/block/cciss.c linux-2.6/drivers
Updates the enhanced partition statistics in SMART2 driver (not tested).
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
cpqarray.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -urNp -X linux-2.6/Documentation/dontdiff
linux-2.6.orig/drivers/block/cpqarray.c lin
Reports enhanced partition statistics in sysfs.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
check.c | 26 +-
1 file changed, 21 insertions(+), 5 deletions(-)
diff -urNp -X linux-2.6/Documentation/dontdiff
linux-2.6.orig/fs/partitions/check.c linux-
Reports enhanced partition statistics in /proc/diskstats.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
genhd.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff -urNp -X linux-2.6/Documentation/dontdiff linux-2.6.orig/block/genhd.c
lin
Removes the now unused old partition statistic code.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c |4
fs/partitions/check.c |2 --
include/linux/genhd.h |1 -
3 files changed, 7 deletions(-)
diff -urNp -X linux-2.6/Documentation/dontdiff lin
Randy Dunlap wrote:
>
> The format of the /proc file is not changed except to add data
> at the end of each line. Is that correct?
>
No. The line concerning partitions will display different data. The new format
match the current format
concerning disks.
Current partition format:
major minor
Randy Dunlap wrote:
> On Thu, 13 Dec 2007 18:36:45 +0100 Jerome Marchand wrote:
>
>> Randy Dunlap wrote:
>>> The format of the /proc file is not changed except to add data
>>> at the end of each line. Is that correct?
>>>
>> No. The line concerning pa
Fix a memory leak in alloc_disk_node(). Don't forget to free 'dkstats' when the
allocation of 'part' failed.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
genhd.c |1 +
1 file changed, 1 insertion(+)
diff --git a/block/genhd.c b/block/genhd.c
inde
The nr_sector argument of drive_stat_acct() is not used anymore since the read
and write sectors statistics are now updated in end_that_request_first(). This
patch removes the useless argument.
Signed-off-by: Jerome Marchand <[EMAIL PROTECTED]>
---
ll_rw_blk.c | 12 ++--
On 08/20/2015 02:23 PM, Mel Gorman wrote:
> On Mon, Jul 27, 2015 at 01:25:47PM +0200, Jerome Marchand wrote:
>> On 07/27/2015 12:52 PM, Mel Gorman wrote:
>>> On Wed, Jul 22, 2015 at 03:46:16PM +0200, Jerome Marchand wrote:
>>>> On 07/22/2015 02:23 PM, Trond Myklebu
On 10/21/2015 04:39 PM, Vlastimil Babka wrote:
> On 10/05/2015 05:01 AM, Hugh Dickins wrote:
>> On Fri, 2 Oct 2015, Vlastimil Babka wrote:
>> As you acknowledge in the commit message, if a file of 100 pages
>> were copied to tmpfs, and 100 tasks map its full extent, but they
>> all mess around wit
bka
> Acked-by: Konstantin Khlebnikov
> Acked-by: Michal Hocko
Acked-by: Jerome Marchand
signature.asc
Description: OpenPGP digital signature
reed, this is much better than the current situation. I don't think
there is such a thing as a perfect accounting of shared pages anyway.
>
> Signed-off-by: Vlastimil Babka
> Acked-by: Konstantin Khlebnikov
Acked-by: Jerome Marchand
signature.asc
Description: OpenPGP digital signature
on
graph tracer)
Signed-off-by: Pratyush Anand
Signed-off-by: Jerome Marchand
---
arch/arm64/include/asm/stacktrace.h | 2 +-
arch/arm64/kernel/stacktrace.c | 4
arch/arm64/kernel/time.c| 2 +-
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/inc
On 16/01/18 18:57, Catalin Marinas wrote:
> On Fri, Jan 12, 2018 at 11:48:32AM +0100, Jerome Marchand wrote:
>> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
>> index 76809ccd309c..5a528c58ef68 100644
>> --- a/arch/arm64/kernel/stacktrace.c
>&
On 14/03/2024 11:49, Jerome Marchand wrote:
The kernel panic during the initialization of the osnoise tracer when
booting with "ftrace=osnoise" or "ftrace=timerlat" option.
BTW, while this fixes this issue for osnoise and timerlat, another issue,
remains with timerlat w
age struct
should not be swept under the carpet.
>
> Signed-off-by: Kirill A. Shutemov
Acked-by: Jerome Marchand
> ---
> include/linux/mm.h | 9 -
> include/linux/mm_types.h | 8
> 2 files changed, 12 insertions(+), 5 deletions(-)
>
> diff --git
;
>> This patch adds heuristic which decides to reuse existing anon_vma instead
>> of forking new one. It counts vmas and direct descendants for each anon_vma.
>> Anon_vma with degree lower than two will be reused at next fork.
>> As a result each anon_vma has either alive
by: Minchan Kim
Acked-by: Jerome Marchand
On a side note, when zram->meta replaced init_done, no comment was
added in zram structure to explain that. Things could be made more
explicit.
---
Subject: [PATCH] zram: explicitely state that zram->meta is used to determine
the init state
zra
On 01/23/2015 06:58 AM, Minchan Kim wrote:
> The zram->stat handling should be procted by init_lock.
> Otherwise, user could see stale value from the stat.
>
> Signed-off-by: Minchan Kim
Acked-by: Jerome Marchand
signature.asc
Description: OpenPGP digital signature
On 01/23/2015 03:24 PM, Sergey Senozhatsky wrote:
> On (01/23/15 14:58), Minchan Kim wrote:
>> We don't need to call zram_meta_free, zcomp_destroy and zs_free
>> under init_lock. What we need to prevent race with init_lock
>> in reset is setting NULL into zram->meta (ie, init_done).
>> This patch d
On 01/26/2015 02:33 AM, Minchan Kim wrote:
> Hello,
>
> On Sat, Jan 24, 2015 at 12:47:07AM +0900, Sergey Senozhatsky wrote:
>> On (01/23/15 15:48), Jerome Marchand wrote:
>>> Date: Fri, 23 Jan 2015 15:48:05 +0100
>>> From: Jerome Marchand
>>> To: Ser
On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> With new refcounting all subpages of the compound page are not nessessary
> have the same mapcount. We need to take into account mapcount of every
> sub-page.
>
> Signed-off-by: Kirill A. Shutemov
> Tested-by: Sasha Levin
On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> We're going to allow mapping of individual 4k pages of THP compound
> page. It means we cannot rely on PageTransHuge() check to decide if
> map/unmap small page or THP.
>
> The patch adds new argument to rmap functions to indicate whether we want
y mapcount
> takes page reference, so this way we can guarantee, that the PMD is the
> only mapping.
>
> This approach can give false negative if somebody pinned the page, but
> that doesn't affect correctness.
>
> Signed-off-by: Kirill A. Shutemov
> Tested-by: Sash
against split.
>
> Signed-off-by: Kirill A. Shutemov
> Tested-by: Sasha Levin
Acked-by: Jerome Marchand
> ---
> mm/gup.c | 8 +---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index ebdb39b3e820..eaeeae15006b 10064
doesn't belong to VM_LOCKED
> vmas. But this is user-visible change: we screw up Mlocked accouting
> reported in meminfo, so I had to leave this approach aside.
>
> We can bring something better later, but this should be good enough for
> now.
>
> Signed-off-by: Kirill A. S
gt; Tested-by: Sasha Levin
Acked-by: Jerome Marchand
> ---
> mm/huge_memory.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index fa3d4f78b716..ffc30e4462c1 100644
> --- a/mm/huge_memory.c
> +++ b/mm
nly PMD.
>
> Signed-off-by: Kirill A. Shutemov
> Tested-by: Sasha Levin
Acked-by: Jerome Marchand
> ---
> arch/powerpc/mm/subpage-prot.c | 2 +-
> arch/x86/kernel/vm86_32.c | 6 +-
> include/linux/huge_mm.h| 8 ++--
> mm/gup.c
e_page() can fail.
>
> Signed-off-by: Kirill A. Shutemov
> Acked-by: Christoph Lameter
> Tested-by: Sasha Levin
Acked-by: Jerome Marchand
> ---
> include/linux/vm_event_item.h | 4 +++-
> mm/huge_memory.c | 2 +-
> mm/vmstat.c | 4 +++-
&g
On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> We are going to use migration entries to stabilize page counts. It means
By "stabilize" do you mean "protect" from concurrent access? I've seen
that you use the same term in seemingly the same sense several times (at
least in patches 15, 16, 23,
On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> With new refcounting we don't need to mark PMDs splitting. Let's drop code
> to handle this.
>
> Arch-specific code will removed separately.
This series only removed code from x86 arch. Does that mean other arches
patches will come later?
Jerom
On 04/23/2015 11:03 PM, Kirill A. Shutemov wrote:
> Let's define page_mapped() to be true for compound pages if any
> sub-pages of the compound page is mapped (with PMD or PTE).
>
> On other hand page_mapcount() return mapcount for this particular small
> page.
>
> This will make cases like page_
On 05/28/2015 01:53 PM, Jeff Layton wrote:
> On Tue, 26 May 2015 15:20:46 +0200
> Jerome Marchand wrote:
>
>>
>> Commit dad2b015 added an rcu read lock around the call to xs_swapper()
>> in nfs_activate()/deactivate(), which can sleep, thus raising a bug at
>>
structures before seq_read() tries to
access them.
Copying the all lock_class structures instead of just their pointers
would be an easy fix, but it seems quite wasteful. This patch copies
only the needed data into the lock_stat_data structure.
Signed-off-by: Jerome Marchand
---
kernel/locking
On 06/03/2015 07:05 PM, Kirill A. Shutemov wrote:
> Hello everybody,
>
> Here's new revision of refcounting patchset. Please review and consider
> applying.
>
> The goal of patchset is to make refcounting on THP pages cheaper with
> simpler semantics and allow the same THP compound page to be map
On 06/22/2015 03:21 PM, Kirill A. Shutemov wrote:
> On Tue, Jun 16, 2015 at 03:17:13PM +0200, Jerome Marchand wrote:
>> On 06/03/2015 07:05 PM, Kirill A. Shutemov wrote:
>>> Hello everybody,
>>>
>>> Here's new revision of refcounting patchset. Please revi
On 06/02/2015 11:30 AM, Peter Zijlstra wrote:
> On Fri, May 29, 2015 at 02:47:15PM +0200, Jerome Marchand wrote:
>> When opening /proc/lock_stat, lock_stat_open() makes a copy of
>> all_lock_classes list in the form of an array of ad hoc structures
>> lock_stat_data that ref
On 06/02/2015 12:50 PM, Peter Zijlstra wrote:
> On Tue, Jun 02, 2015 at 11:54:13AM +0200, Jerome Marchand wrote:
>>
>> I guess I jumped to conclusion here and my explanation is wrong. However
>> there is still a bug which occurs when the kernel tries to access
>&g
On 02/24/2014 06:51 AM, Joonsoo Kim wrote:
> zram is ram based block device and can be used by backend of filesystem.
> When filesystem deletes a file, it normally doesn't do anything on data
> block of that file. It just marks on metadata of that file. This behavior
> has no problem on disk based
On 02/24/2014 04:02 PM, Joonsoo Kim wrote:
> 2014-02-24 22:36 GMT+09:00 Jerome Marchand :
>> On 02/24/2014 06:51 AM, Joonsoo Kim wrote:
>>> zram is ram based block device and can be used by backend of filesystem.
>>> When filesystem deletes a file, it normally doesn'
On 02/24/2014 04:56 PM, Joonsoo Kim wrote:
> 2014-02-25 0:15 GMT+09:00 Jerome Marchand :
>> On 02/24/2014 04:02 PM, Joonsoo Kim wrote:
>>> 2014-02-24 22:36 GMT+09:00 Jerome Marchand :
>>>> On 02/24/2014 06:51 AM, Joonsoo Kim wrote:
>>>>> zram is ram bas
On 02/25/2014 02:08 AM, Minchan Kim wrote:
> zram_meta_alloc could be failed so caller should check it.
> Otherwise, your system will be hang.
>
> Cc:
> Signed-off-by: Minchan Kim
Acked-by: Jerome Marchand
> ---
> drivers/block/zram/zram_drv.c | 2 ++
> 1 fi
1 - 100 of 248 matches
Mail list logo
