Re: [PATCH 46/74] x86, lto: Disable fancy hweight optimizations for LTO

2012-08-20 Thread Jan Beulich
>>> On 20.08.12 at 13:18, Andi Kleen wrote: >> That's not the point: The point really is that you could allow the >> alternative regardless of LTO, and just penalize the LTO case >> by having even the asm clobber the registers that a function call >> would not preserve. > > That's just what a no

apparent regressions from TLB range flushing page set

2012-08-20 Thread Jan Beulich
Alex, without even having run that code yet, I think I see two bugs here, both of which I'm pretty sure I pointed out at least once during the review cycle: For one, while TLB_FLUSH_ALL gets passed as 'end' argument to flush_tlb_others(), the Xen code was made to check its 'start' parameter. Sec

[PATCH] ix86: tighten asmlinkage_protect()

2013-01-22 Thread Jan Beulich
move those variables into registers) and generally results in better code (because we know the arguments are in memory anyway, and are frequently - if not always - used just once, with the second [compiler visible] use in asmlinkage_protect() itself being a fake one). Signed-off-by: Jan Beulich

Re: [Xen-devel] What went in Linux 3.6, 3.7 and 3.8 from Xen standpoint.

2013-02-15 Thread Jan Beulich
>>> On 15.02.13 at 17:26, Konrad Rzeszutek Wilk wrote: > v3.7: > - Initial support for ARM working under Xen as both guest and initial > domain. > - Security fixes. > - Fix RCU warning, add fallback code for old hypervisors, fix memory leaks in >gntdev driver, fix some pvops calls failing,

Re: [Xen-devel] Patches for v3.9 for the Linux kernel.

2013-02-15 Thread Jan Beulich
>>> On 15.02.13 at 17:34, Konrad Rzeszutek Wilk wrote: > I know that the PVH patches are not in the Xen tree. I am hoping that > at least the hypercalls _are_ OK with everybody so we can continue on > with this. Please don't commit to anything that isn't in the hypervisor tree yet. IOW I'd like y

Re: [PATCH 1/3] x86, mm: Include the entire kernel memory map in trampoline_pgd

2012-10-15 Thread Jan Beulich
>>> On 10.10.12 at 12:45, Matt Fleming wrote: > On Thu, 2012-10-04 at 11:01 +0100, Jan Beulich wrote: >> >>> On 04.10.12 at 11:18, Matt Fleming wrote: >> > On Thu, 2012-10-04 at 07:32 +0100, Jan Beulich wrote: >> >> Btw., once this set of your

commit fe04ddf7c2910362f3817c8156e41cbd6c0ee35d reverts unrelated changes

2012-10-15 Thread Jan Beulich
Michal, is there any reason why that commit reverts two other changes (to arch/x86/Makefile and scripts/Makefile.fwinst) without any mention of the reason for this in the description? Also, Greg, didn't this get merged into stable a little too quickly? Thanks, Jan -- To unsubscribe from this li

Re: [Xen-devel] [PATCH] xen: tmem: selfballooning should be enabled when xen tmem is enabled

2012-11-21 Thread Jan Beulich
>>> On 20.11.12 at 23:42, Dan Magenheimer wrote: > Konrad: Any chance this can get in for the upcoming window? > (Or is it enough of a bug fix that it can go in at an -rcN?) > > It was just pointed out to me that some kernels have > cleancache and frontswap and xen_tmem enabled but NOT > xen_self

RE: [Xen-devel] [PATCH] xen: tmem: selfballooning should be enabled when xen tmem is enabled

2012-11-21 Thread Jan Beulich
>>> On 21.11.12 at 16:42, Dan Magenheimer wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Wednesday, November 21, 2012 1:21 AM >> To: Dan Magenheimer >> Cc: xen-de...@lists.xen.org; Konrad Wilk; linux-kernel@vger.kernel.org >> Sub

Re: [PATCH v2 01/11] kexec: introduce kexec_ops struct

2012-11-23 Thread Jan Beulich
>>> On 23.11.12 at 02:56, Andrew Cooper wrote: > On 23/11/2012 01:38, H. Peter Anvin wrote: >> I still don't really get why it can't be isolated from dom0, which would > make more sense to me, even for a Xen crash. >> > > The crash region (as specified by crashkernel= on the Xen command line) >

Re: [PATCH v2 01/11] kexec: introduce kexec_ops struct

2012-11-23 Thread Jan Beulich
>>> On 22.11.12 at 18:37, "H. Peter Anvin" wrote: > I actually talked to Ian Jackson at LCE, and mentioned among other > things the bogosity of requiring a PUD page for three-level paging in > Linux -- a bogosity which has spread from Xen into native. It's a page > wasted for no good reason, s

Re: [PATCH v2 01/11] kexec: introduce kexec_ops struct

2012-11-23 Thread Jan Beulich
>>> On 23.11.12 at 11:37, Daniel Kiper wrote: > On Fri, Nov 23, 2012 at 09:53:37AM +, Jan Beulich wrote: >> >>> On 23.11.12 at 02:56, Andrew Cooper wrote: >> > On 23/11/2012 01:38, H. Peter Anvin wrote: >> >> I still don't really get why

[PATCH] x86/perf_events: build fix

2012-11-23 Thread Jan Beulich
. Also get the Knight's Corner definitions in sync. Signed-off-by: Jan Beulich --- arch/x86/kernel/cpu/perf_event_knc.c |4 ++-- arch/x86/kernel/cpu/perf_event_p6.c |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) --- 3.7-rc6/arch/x86/kernel/cpu/perf_event_knc.c +++ 3.7-rc6-x86

[PATCH] x86/EFI: properly init-annotate BGRT code

2012-11-23 Thread Jan Beulich
These items are only ever referenced from initialization code. Signed-off-by: Jan Beulich --- arch/x86/platform/efi/efi-bgrt.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) --- 3.7-rc6/arch/x86/platform/efi/efi-bgrt.c +++ 3.7-rc6-x86-BGRT-init/arch/x86/platform/efi/efi

[PATCH] x86: convert a few mistaken __cpuinit annotations to __init

2012-11-23 Thread Jan Beulich
The first two are functions serving as initcalls; the SFI one is only being called from __init code. Signed-off-by: Jan Beulich --- arch/x86/kernel/cpu/intel_cacheinfo.c |2 +- arch/x86/mm/tlb.c |2 +- arch/x86/platform/sfi/sfi.c |2 +- 3 files changed

your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"

2013-01-14 Thread Jan Beulich
Ondrej, I see two problems with this patch: For one, on a system without i8042 the code at the place it got inserted ought to incur a stall of 1s (50us * I8042_CTL_TIMEOUT [1] * 2). I believe that this code should not be run before i8042_controller_check() completed successfully, but at the ve

Re: your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"

2013-01-14 Thread Jan Beulich
>>> On 14.01.13 at 09:29, Ondrej Zary wrote: > On Monday 14 January 2013, Jan Beulich wrote: >> Ondrej, >> >> I see two problems with this patch: For one, on a system without >> i8042 the code at the place it got inserted ought to incur a stall of >> 1s

[PATCH] fix setup_efi_pci()

2013-01-14 Thread Jan Beulich
This fixes three issues: - missing parentheses around a flag test - wrong memory type used for allocation intended to persist post-boot - four similar build warnings on 32-bit (casts between different size pointers and integers) Signed-off-by: Jan Beulich --- arch/x86/boot/compressed/eboot.c

Re: your patch "x86, 8042: Enable A20 using KBC to fix S3 resume on some MSI laptops"

2013-01-14 Thread Jan Beulich
>>> On 14.01.13 at 09:54, Ondrej Zary wrote: > On Monday 14 January 2013, Jan Beulich wrote: >> >>> On 14.01.13 at 09:29, Ondrej Zary wrote: >> > On Monday 14 January 2013, Jan Beulich wrote: >> >> Second, considering that enabling A20 (eve

Re: [Xen-devel] kernel 3.7+ cpufreq regression on AMD system running as dom0

2013-01-14 Thread Jan Beulich
>>> On 14.01.13 at 17:34, Borislav Petkov wrote: > On Mon, Jan 14, 2013 at 04:58:54PM +0100, Stefan Bader wrote: >> --- a/drivers/acpi/processor_perflib.c >> +++ b/drivers/acpi/processor_perflib.c >> @@ -340,6 +340,9 @@ static void amd_fixup_frequency(struct acpi_processor_px > *px >> if

[PATCH] Xen: properly bound buffer access when parsing cpu/*/availability

2013-01-15 Thread Jan Beulich
At the same time reduce the local buffers to 16 bytes each. Signed-off-by: Jan Beulich --- a/drivers/xen/cpu_hotplug.c +++ b/drivers/xen/cpu_hotplug.c @@ -25,10 +25,10 @@ static void disable_hotplug_cpu(int cpu) static int vcpu_online(unsigned int cpu) { int err; - char dir[32

Re: [PATCH] utilize _Static_assert() for BUILD_BUG_ON() when the compiler supports it

2012-12-13 Thread Jan Beulich
>>> On 13.12.12 at 01:29, Daniel Santos wrote: > Wow, it's really easy to miss parallel development on the same issue. > Sorry for my late response to this thread. I started another thread > addressing these issues (as well as a few others) back in September > (https://lkml.org/lkml/2012/9/28

Re: [PATCH] xen/blkback: prevent repeated backend_changed invocations

2012-12-13 Thread Jan Beulich
>>> On 11.12.12 at 21:50, Olaf Hering wrote: > backend_changed might be called multiple times, which will leak > be->mode. Make sure it will be called only once. Remove some unneeded > checks. Also the be->mode string was leaked, release the memory on > device shutdown. So I decided to make an at

Re: [GIT PULL] x86/uapi for 3.8

2012-12-17 Thread Jan Beulich
>>> On 15.12.12 at 19:35, Linus Torvalds wrote: > On Sat, Dec 15, 2012 at 8:33 AM, Markus Trippelsdorf > wrote: >> On 2012.12.14 at 17:47 -0800, Linus Torvalds wrote: >>> >>> Ho humm. Anybody else see anything strange? >> >> Yes. I'm seeing a BUG early during boot on my machine (RIP=NULL): >> >>

Re: [GIT PULL] x86/uapi for 3.8

2012-12-17 Thread Jan Beulich
>>> On 17.12.12 at 16:44, Linus Torvalds wrote: > On Mon, Dec 17, 2012 at 1:04 AM, Jan Beulich wrote: >> >> How about this being caused by using the same lower level >> page table entries that swapper_pg_dir uses, namely including >> the _PAGE_GLOBAL bits? efi

Re: [GIT PULL] x86/uapi for 3.8

2012-12-17 Thread Jan Beulich
>>> On 17.12.12 at 17:39, "H. Peter Anvin" wrote: > Right, I think you nailed this one. This patch copies PTEs from the > kernel PTEs and thus they will have the global bit set. It obviously > makes no sense to *copy* PTEs from the kernel and yet leaving the global > bit set, which means there a

Re: [PATCH 01/11] kexec: introduce kexec_ops struct

2012-09-28 Thread Jan Beulich
>>> On 27.09.12 at 20:06, Daniel Kiper wrote: > Some kexec/kdump implementations (e.g. Xen PVOPS) on different archs could > not use default functions or require some changes in behavior of kexec/kdump > generic code. To cope with that problem kexec_ops struct was introduced. > It allows a develop

Re: [PATCH 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2012-09-28 Thread Jan Beulich
>>> On 27.09.12 at 20:06, Daniel Kiper wrote: > Some implementations (e.g. Xen PVOPS) could not use part of identity page > table > to construct transition page table. It means that they require separate > PUDs, > PMDs and PTEs for virtual and physical (identity) mapping. To satisfy that > requi

Re: [PATCH 06/11] x86/xen: Add i386 kexec/kdump implementation

2012-09-28 Thread Jan Beulich
>>> On 27.09.12 at 20:06, Daniel Kiper wrote: > Add i386 kexec/kdump implementation. So this as well as the subsequent patch introduces quite a bit of duplicate code. The old 2.6.18 kernel had an initial pair of cleanup patches (attached in their forward ported form for 3.6-rc6) that would allow

Re: [PATCH 05/11] x86/xen: Register resources required by kexec-tools

2012-10-01 Thread Jan Beulich
>>> On 28.09.12 at 18:21, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 27, 2012 at 08:06:32PM +0200, Daniel Kiper wrote: >> +for (i = 0; i < cpus; ++i) { > > Any specific reason for using '++i' instead of 'i++' ? For people occasionally also writing C++ code this is the canonical form. Jan -

Re: [PATCH 06/11] x86/xen: Add i386 kexec/kdump implementation

2012-10-01 Thread Jan Beulich
>>> On 01.10.12 at 14:52, Daniel Kiper wrote: > On Fri, Sep 28, 2012 at 09:11:47AM +0100, Jan Beulich wrote: >> Finally, as noticed in an earlier patch already, you appear to >> re-introduce stuff long dropped from the kernel - the forward >> ported kern

Re: [Xen-devel] kernel 3.7+ cpufreq regression on AMD system running as dom0

2013-01-16 Thread Jan Beulich
>>> On 15.01.13 at 18:53, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 14, 2013 at 05:34:45PM +0100, Borislav Petkov wrote: >> On Mon, Jan 14, 2013 at 04:58:54PM +0100, Stefan Bader wrote: >> > --- a/drivers/acpi/processor_perflib.c >> > +++ b/drivers/acpi/processor_perflib.c >> > @@ -340,6 +340,9 @

Re: [Xen-devel] [PATCH] xen/grant-table: Force to use v1 of grants.

2013-01-17 Thread Jan Beulich
>>> On 17.01.13 at 13:22, Matt Wilson wrote: > On Wed, Jan 16, 2013 at 04:22:49PM -0500, Konrad Rzeszutek Wilk wrote: >> We have the framework to use v2, but there are no backends that >> actually use it. The end result is that on PV we use v2 grants >> and on PVHVM v1. The v1 has a capacity of 51

Re: [PATCH] fix setup_efi_pci()

2013-01-17 Thread Jan Beulich
>>> On 17.01.13 at 13:29, Matt Fleming wrote: > On Mon, 2013-01-14 at 08:59 +, Jan Beulich wrote: >> This fixes three issues: >> - missing parentheses around a flag test >> - wrong memory type used for allocation intended to persist post-boot >> - four sim

RE: [Xen-devel] [PATCH] xen/swiotlb: Exchange to contiguous memory for map_sg hook

2013-01-07 Thread Jan Beulich
>>> "Xu, Dongxiao" 01/07/13 8:17 AM >>> > From: Jan Beulich [mailto:jbeul...@suse.com] > >>> On 20.12.12 at 02:23, "Xu, Dongxiao" wrote: >> > Take the libata case as an example, the static DMA buffer locates >> > (dev->lin

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2013-01-07 Thread Jan Beulich
>>> On 04.01.13 at 18:25, Daniel Kiper wrote: > Right, so where is virtual mapping of control page established? > I could not find relevant code in SLES kernel which does that. In the hypervisor (xen/arch/x86/machine_kexec.c:machine_kexec_load()). xen/arch/x86/machine_kexec.c:machine_kexec() then

Re: [PATCH v3 02/11] x86/kexec: Add extra pointers to transition page table PGD, PUD, PMD and PTE

2013-01-07 Thread Jan Beulich
>>> On 07.01.13 at 13:52, Daniel Kiper wrote: > On Mon, Jan 07, 2013 at 09:48:20AM +, Jan Beulich wrote: >> >>> On 04.01.13 at 18:25, Daniel Kiper wrote: >> > Right, so where is virtual mapping of control page established? >> > I could not find

Re: [PATCH] drivers/xen: avoid out-of-range write in xen_add_device

2013-01-07 Thread Jan Beulich
>>> On 07.01.13 at 16:08, Konrad Rzeszutek Wilk wrote: > On Sat, Jan 05, 2013 at 02:18:46PM -0500, Nickolai Zeldovich wrote: >> xen_add_device() in drivers/xen/pci.c allocates a struct >> physdev_pci_device_add on the stack and then writes to optarr[0]. >> The previous declaration of struct physde

Re: [patch] x86: fix ESP corruption CPU bug (take 2)

2005-09-05 Thread Jan Beulich
Stas, Petr, I know it's been a while since this was discussed and integrated into mainline, but I just now came across this, and following all of the original discussion that I was able to locate I didn't see any mention of a potential different approach to solving the problem which, as it would a

[PATCH] fix split-include dependency

2005-09-06 Thread Jan Beulich
be) generated as a side effect of executing config targets, include/linux should be created prior to running the respective sub-make. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> --- /home/jbeulich/tmp/linux-2.6.13/Makefile2005-08-29 01:41:01.0 +0200 +++ 2.6.13/Makefile 2

[PATCH] resubmit: i386 NMI handler stack check adjustments

2005-09-06 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Stack pointer comparisons for the NMI on debug stack check/fixup were incorrect. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> --- /home/jbeulich/tmp/linux-2.6.13/arch/i386/kernel/entry.S2005

[PATCH] x86_64: watchdog frequency calculation adjustments

2005-09-06 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Like previously done for i386, get the x86_64 watchdog tick calculation into a state where it can also be used on CPUs with frequencies beyond 4GHz. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> ---

Re: [patch] kbuild: building with a mostly-clean /usr/src/linux and O=

2005-09-07 Thread Jan Beulich
seems I'm afraid: With the version of this patch that just went in, Jan Beulich <[EMAIL PROTECTED]> found a bug when building vmlinux.lds on i386. He triggered it by by putting poisoned version.h and autoconf.h files in /usr/src/linux. With the additional changes (rediff against linux-

[PATCH] minor ELF definitions addition

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) A trivial addition to the EFL definitions. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/linux/elf.h 2.6.13-elf/include/linux/elf.h --- 2.6.13/include/linux/elf.h 2005-08-29

[PATCH] boot-time ioremap alternative

2005-09-08 Thread Jan Beulich
for i386 and x86_64) and doesn't require alternative boot-time interfaces. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/setup.c 2.6.13-early-ioremap/arch/i386/kernel/setup.c --- 2.6.13/arch/i386/kernel/setup.c 2005-08-29 01:41:01.0 +0200

[PATCH] minor fbcon_scroll adjustment

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) An adjustment to the SM_DOWN case of fbcon_scroll to match the behavior of SM_UP. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/drivers/video/console/fbcon.c 2.6.13-fbcon-logo-scrol

[PATCH] constify font data

2005-09-08 Thread Jan Beulich
normal kernel code, such a guarantee seems rather desirable. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/drivers/video/console/fbcon.c 2.6.13-fonts-const/drivers/video/console/fbcon.c --- 2.6.13/drivers/video/console/fbcon.c2005-08-29 01:41:01.0 +0200 +++

[PATCH] free initrd mem adjustment

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Besides freeing initrd memory, also clear out the now dangling pointers to it, to make sure accidental late use attempts can be detected. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.1

Re: [PATCH] minor ELF definitions addition

2005-09-08 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 16:32:16 >>> >On Thu, Sep 08, 2005 at 04:30:03PM +0200, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> A trivial addition

[PATCH] pass irq handling status down to low-level code

2005-09-08 Thread Jan Beulich
ation communicated from the respective interrupt handler. For this to fully work, additional adjustments are necessary, so this is meant ot only be the first step.) Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/irq.c 2.6.13-irqreturn/arch/i386/kernel/irq.c ---

[PATCH] matroxfb adjustments

2005-09-08 Thread Jan Beulich
a kernel debugger might obtain that before the initial mode change. Finally, some return code corrections to fit the generic fb code. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/drivers/video/matrox/matroxfb_base.c 2.6.13-matroxfb/drivers/video/matrox/matroxfb_

[PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Debugging and maintenance support code occasionally needs to know not only of module insertions, but also modulke removals. This adds a notifier chain for this purpose. Signed-off-by: Jan Beulich <[EM

[PATCH] i386 CFI annotations

2005-09-08 Thread Jan Beulich
producing similar information for all C sources. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/entry.S 2.6.13-i386-cfi/arch/i386/kernel/entry.S --- 2.6.13/arch/i386/kernel/entry.S 2005-08-29 01:41:01.0 +0200 +++ 2.6.13-i386-cfi/arch/i386/kernel/e

[PATCH] adjust .version updating

2005-09-08 Thread Jan Beulich
tless increments). Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/Makefile 2.6.13-version-update/Makefile --- 2.6.13/Makefile 2005-08-29 01:41:01.0 +0200 +++ 2.6.13-version-update/Makefile 2005-09-01 11:32:13.0 +0200 @@ -624,8 +624,13 @@ quiet_cm

[PATCH] add stricmp

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) While strnicmp existed in the set of string support routines, stricmp didn't, which this patch adjusts. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/linux/string.h 2.6

[PATCH] fix i386 cmpxchg

2005-09-08 Thread Jan Beulich
esn't support it (like was already happening for the byte, word, and long ones). Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/Kconfig 2.6.13-i386-cmpxchg/arch/i386/Kconfig --- 2.6.13/arch/i386/Kconfig2005-08-29 01:41:01.0 +0200 +++ 2.6.13-i

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 17:16:24 >>> >On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> Debugging and main

[PATCH] move i386's enabling of fxsr and xmmxcpt

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Move some code unrelated to any dealing with hardware bugs from i386's bugs.h to a more logical place. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/traps.c

[PATCH] fix i386 interrupt re-enabling in die()

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Rather than blindly re-enabling interrupts in die(), save their state upon entry and then restore that state. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/traps.c

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>> Debugging and maintenance support code occasionally needs to know not >> only of module insertions, but also modulke removals. This adds a >> notifier >> chain for this purpose. >> >> >> diff -Npru 2.6.13/kernel/module.c >> 2.6.13-rmmod-notifier/kernel/module.c >> --- 2.6.13/kernel/module.c 2

Re: [PATCH] add stricmp

2005-09-08 Thread Jan Beulich
>>> Christoph Hellwig <[EMAIL PROTECTED]> 08.09.05 17:17:54 >>> >On Thu, Sep 08, 2005 at 05:05:06PM +0200, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> While strnicmp exi

[PATCH] fix i386 init initializers

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) An addition and a fix to the static i386 initializers. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/asm-i386/processor.h 2.6.13-i386-init/include/asm-i386/processor.h ---

[PATCH] abstraction of i386 machine check handlers

2005-09-08 Thread Jan Beulich
: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/cpu/mcheck/k7.c 2.6.13-i386-machine-check/arch/i386/kernel/cpu/mcheck/k7.c --- 2.6.13/arch/i386/kernel/cpu/mcheck/k7.c 2005-08-29 01:41:01.0 +0200 +++ 2.6.13-i386-machine-check/arch/i386/kernel/cpu/mcheck/k7.c 2

[PATCH] introduce THREAD_ORDER to i386

2005-09-08 Thread Jan Beulich
to use per- CPU stacks) will soon follow. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/asm-offsets.c 2.6.13-i386-THREAD_SIZE_asm/arch/i386/kernel/asm-offsets.c --- 2.6.13/arch/i386/kernel/asm-offsets.c 2005-08-29 01:41:01.0 +0200 +++ 2.6.1

Re: [PATCH] add stricmp

2005-09-08 Thread Jan Beulich
>The only general, usable strnicmp safe for general kernel use would be a >full all singing all dancing UTF-8 symbol aware arbitary locale >implementation. And that we *definitely* do not want in kernel. Then you'd want to immediately get rid of the mentioned, pre-exisiting strnicmp(). Jan - To u

[PATCH] re-export genapic on i386

2005-09-08 Thread Jan Beulich
s the situation. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/mach-generic/probe.c 2.6.13-i386-genapic/arch/i386/mach-generic/probe.c --- 2.6.13/arch/i386/mach-generic/probe.c 2005-08-29 01:41:01.0 +0200 +++ 2.6.13-i386-genapic/arch/i386/mach-gene

[PATCH] fix i386 condition to call nmi_watchdog_tick

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Don't call nmi_watchdog_tick() when this isn't enabled. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/traps.c 2.6.13-i386-watchdog-active/arch/i38

Re: [PATCH] rmmod notifier chain

2005-09-08 Thread Jan Beulich
>It's possible to do this a bit differently, if I'm guessing right at >what NLKD does. The following is from the KGDB patches (trimmed of some >other, unrelated to the notify part code): Hmm, yes, this seems to be the better way to go. Thanks, Jan - To unsubscribe from this list: send the line "

[PATCH] allow CONFIG_FRAME_POINTER for x86-64

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Allow building the x86-64 kernels with frame pointers if so needed. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/lib/Kconfig.debug 2.6.13-x86_64-frame-pointer/lib/Kconfig.debug ---

[PATCH] x86-64 CFI annotation fixes and additions

2005-09-08 Thread Jan Beulich
sent patch adding such annotations to i386 code) to enable them separatly rather than only along with adding full debug information. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/x86_64/ia32/ia32entry.S 2.6.13-x86_64-cfi/arch/x86_64/ia32/ia32entry.S --- 2.6.13/arch/

[PATCH] adjust x86-64 HPET definitions

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Adjust, correct, and complete the HPET definitions for x86-64. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/asm-x86_64/hpet.h 2.6.13-x86_64-hpet/include/asm-x86_64/

[PATCH] x86-64 cmpxchg adjustment

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) While only cosmetic for x86-64, this adjusts the cmpxchg code appearantly inherited from i386 to use more generic constraints. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/inclu

[PATCH] set stack pointer in init_tss and init_thread

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Set the stack pointer correctly in init_thread and init_tss. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/x86_64/kernel/init_task.c 2.6.13-x86_64-init/arch/x86_64/kernel/init_

[PATCH] add and handle NMI_VECTOR

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Declare NMI_VECTOR and handle it in the IPI sending code. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/include/asm-x86_64/hw_irq.h 2.6.13-x86_64-nmi-ipi/include/asm-x86_64/hw

[PATCH] fix x86-64 interrupt re-enabling in oops_end()

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Rather than blindly re-enabling interrupts in oops_end(), save their state in oope_begin() and then restore that state. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/x86_64/

[PATCH] fix x86-64 condition to call nmi_watchdog_tick

2005-09-08 Thread Jan Beulich
(Note: Patch also attached because the inline version is certain to get line wrapped.) Don't call nmi_watchdog_tick() when this isn't enabled. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/x86_64/kernel/io_apic.c 2.6.13-x86_64-watchdog-active/arch/x86_64/

Re: [discuss] [PATCH] add and handle NMI_VECTOR II

2005-09-08 Thread Jan Beulich
>Index: linux/include/asm-x86_64/hw_irq.h >=== >--- linux.orig/include/asm-x86_64/hw_irq.h >+++ linux/include/asm-x86_64/hw_irq.h >@@ -52,7 +52,7 @@ struct hw_interrupt_type; > #define ERROR_APIC_VECTOR 0xfe > #define RESCHEDULE_VE

Re: [PATCH] i386 CFI annotations

2005-09-08 Thread Jan Beulich
>>> Tom Rini <[EMAIL PROTECTED]> 08.09.05 18:13:34 >>> >On Thu, Sep 08, 2005 at 05:57:55PM +0200, Jan Beulich wrote: > >> >> + CFI_ADJUST_CFA_OFFSET 4;\ >> >> + /*CFI_REL_OFFSET es, 0;*/\ >> >> pushl %ds; \ >> >> + CF

Re: [discuss] [PATCH] add and handle NMI_VECTOR II

2005-09-09 Thread Jan Beulich
>> >Index: linux/arch/x86_64/kernel/traps.c >> >=== >> >--- linux.orig/arch/x86_64/kernel/traps.c >> >+++ linux/arch/x86_64/kernel/traps.c >> >@@ -931,7 +931,7 @@ void __init trap_init(void) >> >set_system_gate(IA32_SYSCALL_VECTOR,

[PATCH] fix i386 double fault handler

2005-09-09 Thread Jan Beulich
handler to account for the fact that both GDT and TSS aren't in static kernel space anymore. This patch depends upon the presence of THREAD_ORDER, as added in a previously submitted patch. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> diff -Npru 2.6.13/arch/i386/kernel/cpu/common.c

Re: [discuss] [PATCH] add and handle NMI_VECTOR II

2005-09-09 Thread Jan Beulich
>>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 09:14:07 >>> >> ??? This is what the code doing the setup does. But the question was - >> what do you need the IDT entry for? > >Without an IDT entry you cannot receive it? But that's the point - if it's delivered as an NMI, it'll arrive through vector

Re: [discuss] [PATCH] x86-64 CFI annotation fixes and additions

2005-09-09 Thread Jan Beulich
>The UNWIND_INFO part has still some problems - in particular it is lying >on all other architectures which don't check it yet. I made it dependent >on X86_64 right now. I don't think so. First, the i386 patch also adds the same (as I indicated), and second this controls also the -fasynchronous-ex

Re: [discuss] [PATCH] fix x86-64 condition to call nmi_watchdog_tick

2005-09-09 Thread Jan Beulich
>>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 10:43:01 >>> >On Thursday 08 September 2005 18:11, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> Don't call nmi_watchdog_tick(

Re: [discuss] [PATCH] add and handle NMI_VECTOR

2005-09-09 Thread Jan Beulich
Here it is. >>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 10:50:01 >>> On Thursday 08 September 2005 18:07, Jan Beulich wrote: > (Note: Patch also attached because the inline version is certain to get > line wrapped.) > > Declare NMI_VECTOR and handle it in the

Re: [discuss] [PATCH] allow CONFIG_FRAME_POINTER for x86-64

2005-09-09 Thread Jan Beulich
>>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 10:54:11 >>> >On Thursday 08 September 2005 18:04, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> Allow building the x86-64 kernel

Re: [discuss] [PATCH] x86-64 cmpxchg adjustment

2005-09-09 Thread Jan Beulich
>>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 10:57:07 >>> >On Thursday 08 September 2005 18:03, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> While only cosmetic for x

Re: [PATCH] rmmod notifier chain (attempt 2)

2005-09-09 Thread Jan Beulich
>>> Tom Rini <[EMAIL PROTECTED]> 08.09.05 17:33:14 >>> >On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote: >It's possible to do this a bit differently, if I'm guessing right at >what NLKD does. The following is from the KGDB patches (trimmed o

Re: [discuss] [PATCH] allow CONFIG_FRAME_POINTER for x86-64

2005-09-09 Thread Jan Beulich
> But why would anyone want frame pointers on x86-64? I'd put the question differently: Why should x86-64 not allow what other architectures do? But of course, I'm not insisting on this patch to get in, it just seemed an obvious inconsistency... Jan - To unsubscribe from this list: send the line

Re: [PATCH] fix i386 interrupt re-enabling in die() (attempt 2)

2005-09-09 Thread Jan Beulich
>>> Zwane Mwaikambo <[EMAIL PROTECTED]> 08.09.05 19:37:20 >>> >On Thu, 8 Sep 2005, Jan Beulich wrote: > >> diff -Npru 2.6.13/arch/i386/kernel/traps.c >> 2.6.13-i386-die-irq/arch/i386/kernel/traps.c >> --- 2.6.13/arch/i386/kernel/traps.c 2005-08-2

Re: [PATCH] new kallsyms approach

2005-09-09 Thread Jan Beulich
>I don't think it's a good idea to have two different ways >to do kallsyms. Either we should always use your new >way in standard KALLSYMS or not do it at all. I agree, but I wanted to retain the old mechanism not the least because of the space constraints you mention. >The major decision factor

[PATCH] reduce x86-64 bug frame by 4 bytes

2005-09-09 Thread Jan Beulich
reduce x86-64 bug frame by 4 bytes From: Jan Beulich <[EMAIL PROTECTED]> (Note: Patch also attached because the inline version is certain to get line wrapped.) As mentioned before, the size of the bug frame can be further reduced while continuing to use instructions to encode the infor

Re: [PATCH] rmmod notifier chain

2005-09-09 Thread Jan Beulich
>> That's funny - on one hand I'm asked to not submit huge patches (not by >> you, but by others), but on the other hand not having the consuming code >> in the same patch as the providing one is now deemed to be a problem. > >Nope. > >Each patch should do a single logical thing. That doesn't mean

Re: [PATCH 0/4] add task handling notifier

2008-01-08 Thread Jan Beulich
>>> Andrew Morton <[EMAIL PROTECTED]> 25.12.07 23:05 >>> >On Sun, 23 Dec 2007 12:26:21 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > >> On Thu, Dec 20, 2007 at 01:11:24PM +, Jan Beulich wrote: >> > With more and more sub-systems/

Re: [PATCH] Revert "x86: optimize page faults like all other achitectures and kill notifier cruft"

2008-01-09 Thread Jan Beulich
>That change has been in the mainline tree for nearly three months. All >these affected parties have left it until the eve of 2.6.24 to actually >tell us about it. This is causing me sympathy problems :( Not true - I complained about this on Dec 3rd (attached), with the result of not getting a r

Re: [PATCH 10 of 10] xen: mask out PWT too

2008-01-09 Thread Jan Beulich
That's somewhat ugly, as it will need to be undone/modified for Dom0 and physical device access support. Jan >>> Jeremy Fitzhardinge <[EMAIL PROTECTED]> 08.01.08 23:00 >>> The hypervisor doesn't allow PCD or PWT to be set on guest ptes, so make sure they're masked out. Also, fix up some previous

Re: [PATCH 00 of 10] x86: unify asm/pgtable.h

2008-01-09 Thread Jan Beulich
>The "problem" is a BUG() in pageattr_64.c:change_page_attr(), which to >me looks spurious. It arises because __PAGE_KERNEL_* doesn't contain >_PAGE_GLOBAL, but PAGE_KERNEL_* does. When ioremap() >change_page_attr(), it does so in a way that guarentees that the test > > if (pgprot_val(pr

Re: [PATCH 1/4] add task handling notifier: base definitions

2008-01-09 Thread Jan Beulich
>> +BLOCKING_NOTIFIER_HEAD(task_notifier_list); >> +EXPORT_SYMBOL_GPL(task_notifier_list); >> +ATOMIC_NOTIFIER_HEAD(atomic_task_notifier_list); >> +EXPORT_SYMBOL_GPL(atomic_task_notifier_list); >> + > >When these global notifier lists were proposed years ago folks at SGI >loudly objected with conce

Re: [PATCH 0/4] add task handling notifier

2008-01-09 Thread Jan Beulich
>> Am I to conclude then that there's no point in addressing the issues other >> people pointed out? While I (obviously, since I submitted the patch >> disagree), >> I'm not certain how others feel. My main point for disagreement here is (I'm >> sorry to repeat this) that as long as certain code i

[PATCH] make module_sect_attrs private to kernel/module.c

2008-01-10 Thread Jan Beulich
No-one else is using these afaics. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> --- include/linux/module.h | 17 - kernel/module.c| 16 +++- 2 files changed, 15 insertions(+), 18 deletions(-) --- linux-2.6.24-rc7/include/linux/module.h 2008

[PATCH] fix verify_export_symbols()

2008-01-10 Thread Jan Beulich
When the newer export flavors were added, it was apparently forgotten to add respective code here. In order to not double the (source) size of the function, add some abstraction to reduce code duplication. Signed-off-by: Jan Beulich <[EMAIL PROTECTED]> --- kernel/module.c

<    1   2   3   4   5   6   7   8   9   10   >