>>> Andi Kleen <[EMAIL PROTECTED]> 09.09.05 10:43:01 >>> >On Thursday 08 September 2005 18:11, Jan Beulich wrote: >> (Note: Patch also attached because the inline version is certain to get >> line wrapped.) >> >> Don't call nmi_watchdog_tick() when this isn't enabled. > >Hmm, I think i will concur with Zwane's objection to this for now.
And I understand the concerns. Nevertheless, the code right now, on properly working systems and with the watchdog enabled (but not active) results in bad NMIs to be supressed (because the code returns right after calling nmi_watchdog_tick). I'd think that on systems as Zwane describes one should simply not enable the watchdog (and for this reason I continue to believe that like on i386 the default should be to have no watchdog). Jan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/