rmation, so make sure the export information
actually has the info implied by the value returned by
fsid_source.
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Cc: "Luiz Fernando N. Capitulino" <[EMAIL PROTECTED]>
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]&g
From: J. Bruce Fields <[EMAIL PROTECTED]>
Each branch of this if-then-else has a bunch of duplicated code that we
could just put at the end.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/nfsd/nfs4state.c | 30 ++
1 files change
From: J. Bruce Fields <[EMAIL PROTECTED]>
It doesn't make sense to make the callback with credentials that the
client made the setclientid with. Instead the spec requires that the
callback occur with the credentials the client authenticated *to*.
It probably doesn't matter
On Sat, Aug 25, 2007 at 04:09:27PM +0100, Dr. David Alan Gilbert wrote:
> This patch adds the address of the client that caused an
> error in sunrpc/svc.c so that you get errors that look like:
>
> svc: 192.168.66.28, port=709: unknown version (3 for prog 13, nfsd)
>
> I've seen machines wh
On Tue, Aug 28, 2007 at 09:26:36AM +1000, Neil Brown wrote:
> On Monday August 27, [EMAIL PROTECTED] wrote:
> >
> > +/* Reference counting, callback cleanup, etc., all look racy as heck.
> > + * And why is cb_set an atomic? */
>
> Agreed so do we really want this code in mainline? is the ol
On Tue, Aug 28, 2007 at 07:03:06PM +0100, Dr. David Alan Gilbert wrote:
> * J. Bruce Fields ([EMAIL PROTECTED]) wrote:
> > I also wonder whether these shouldn't all be dprintk's instead of
> > printk's. One misbehaving client could create a lot of noise in the
>
On Tue, Aug 28, 2007 at 03:12:26PM -0400, [EMAIL PROTECTED] wrote:
> On Mon, 27 Aug 2007 17:43:33 EDT, "J. Bruce Fields" said:
> > I also wonder whether these shouldn't all be dprintk's instead of
> > printk's. One misbehaving client could create a lot of
On Wed, Aug 29, 2007 at 09:37:00AM -0400, Peter Staubach wrote:
> There are a lot of ways to discover who is throwing trash
> at your system other than the kernel printing messages.
>
> Tools such as tcpdump and tethereal/wireshark make much better
> tools for this purpose.
The use of printk's and
On Wed, Aug 29, 2007 at 05:27:39PM +0200, Michal Piotrowski wrote:
> FS
>
> Subject : [NFSD OOPS] 2.6.23-rc1-git10
> References : http://lkml.org/lkml/2007/8/2/462
> Last known good : ?
> Submitter : Andrew Clayton <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By : ?
On Thu, Aug 30, 2007 at 04:42:33PM +0200, Jan Engelhardt wrote:
>
> On Aug 30 2007 10:29, Trond Myklebust wrote:
> >On Thu, 2007-08-30 at 16:12 +0200, Jan Engelhardt wrote:
> >>
> >> with NFS3, there is this 'root hole', i.e. any person who has a root
> >> account (perhaps by use of a laptop) ca
On Thu, Aug 30, 2007 at 11:04:00AM -0400, Trond Myklebust wrote:
> With CIFS or other password based protocols (including RPCSEC_GSS)
Well, rpcsec_gss isn't inherently password based, and you can
authenticate in some way that doesn't actually give away your password
(or other long-lived credential
On Fri, Aug 31, 2007 at 02:35:19PM -0400, Morrison, Tom wrote:
> This is a follow-up...
>
> After a huge pain in the rear upgrading from a
> 2.6.11++ to a 2.6.23-rc3 (I'll give the powerpc
> folks a 'piece' of my mind on that front) - the
> NFS hang problem that I was experiencing on the
> olde
e NULL checks, it didn't add a check for -ENOENT.
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
---
fs/nfsd/vfs.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index a0c2b25..
We've got two nfsd patches that fix a regression and a possible oops, so
both should probably go in before the 2.6.23 release.
Patches will follow, but they're also available from "for-linus" at:
ssh://linux-nfs.org/~bfields/exports/linux.git for-linus
--b.
Neil Brown (2):
knfsd: Fixed
rmation, so make sure the export information
actually has the info implied by the value returned by
fsid_source.
Signed-off-by: Neil Brown <[EMAIL PROTECTED]>
Cc: "Luiz Fernando N. Capitulino" <[EMAIL PROTECTED]>
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]&g
On Thu, Sep 06, 2007 at 01:44:05PM +0530, Satyam Sharma wrote:
> /dev/kmem was just an example -- IMHO differentiating between kernel and
> userspace from a security p.o.v. is always tricky.
The things that come to mind are /dev/kmem and module-loading. What
else is there? And what is it that ma
On Thu, Sep 06, 2007 at 01:59:50PM +0530, Satyam Sharma wrote:
> Oh and btw, note that we're talking of the (lack of) security of a
> "running kernel" here -- because across reboots, there is /really/
> *absolutely* no such thing as "kernelspace security" because the superuser
> will simply switch
On Fri, Aug 03, 2007 at 01:01:09PM +1000, Neil Brown wrote:
> The core issue is this:
>
> We need to map IPADDRESS to THING, and THING + PATH to EXPORTPOINT.
> (roughly).
> So what do we choose for "THING"?
>
> One obvious option is the dotted quad of the IP address.
> People tend to have large
On Fri, Jul 27, 2007 at 01:29:00PM -0400, Trond Myklebust wrote:
> On Fri, 2007-07-27 at 13:16 -0400, Jeff Garzik wrote:
> > Trond Myklebust wrote:
> > > Jeff and Bruce, could you please try to reproduce the problem after
> > > either applying patches 001 to 004 or just the single NFS_ALL patch
> >
On Fri, Aug 03, 2007 at 03:13:36PM -0400, J. Bruce Fields wrote:
> On Fri, Jul 27, 2007 at 01:29:00PM -0400, Trond Myklebust wrote:
> > On Fri, 2007-07-27 at 13:16 -0400, Jeff Garzik wrote:
> > > Trond Myklebust wrote:
> > > > Jeff and Bruce, could you please try
On Thu, Aug 09, 2007 at 05:27:45PM +0200, [EMAIL PROTECTED] wrote:
> This is needed to be able to correctly implement open-unlink-fsetattr
> semantics in some filesystem such as sshfs, without having to resort
> to "silly-renaming".
How do you plan to do that?
--b.
-
To unsubscribe from this list
On Fri, Jul 27, 2007 at 01:09:13PM -0400, Michael Tharp wrote:
> Ray Lee wrote:
> > But yes, if we had a full filesystem events notifier, then we could
> > just toss updatedb aside and have the benefit of a live index into the
> > system. It's been suggested before, at least by me. Other projects
>
On Mon, Jul 30, 2007 at 02:55:14PM +0200, Stefan Walter wrote:
> There are however two issues for which we could not find an easy
> solution:
>
> 1. For every client rpc.mountd and the kernel seem to exchange
> and use lists with _all_ netgroups used in exports that are
> relevant for gra
On Wed, Aug 01, 2007 at 10:35:41PM -0400, Lee Revell wrote:
> On 7/31/07, Ingo Molnar <[EMAIL PROTECTED]> wrote:
> > Almost all of the Reiser3
> > code runs under the BKL, and the only other major kernel infrastructure
> > that has BKL dependencies is the TTY code.
>
> Also NFS:
>
> $ grep -rIi l
On Thu, Aug 02, 2007 at 11:32:55AM -0400, Jeff Layton wrote:
> On Tue, 31 Jul 2007 10:48:24 -0400
> "J. Bruce Fields" <[EMAIL PROTECTED]> wrote:
> > That's an interesting problem. Thanks for the report!
> >
> > I don't believe that long comma-de
On Fri, Aug 10, 2007 at 10:17:04PM +0200, Willy Tarreau wrote:
> I've read pro-plain text arguments, so I'll not repeat them. I also see
> another advantage to plain text : it's very easy to draw ascii-art
> diagrams of anything. It only takes a few minutes, is always inline
> and readable with any
On Fri, Aug 10, 2007 at 10:51:17PM +0200, Willy Tarreau wrote:
> The problem I have with asciidoc is that it's a nightmare to get it
> to work. It's what GIT uses, and after spending a whole day trying
> to *build* that thing, I finally resigned and asked Junio if he could
> publish the pre-formatt
On Tue, Aug 14, 2007 at 11:22:58PM +0200, Adrian Bunk wrote:
> On Thu, Aug 09, 2007 at 01:51:06AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.23-rc2-mm1:
> >...
> > git-nfsd.patch
> >...
> > git trees
> >...
>
>
> do_probe_callback() can become static.
Oops, thanks; applied.--b.
Sorry for the delayed response:
On Wed, Oct 17, 2007 at 03:32:01PM -0700, Andrew Morton wrote:
> On Tue, 16 Oct 2007 15:35:57 -0400
> "J. Bruce Fields" <[EMAIL PROTECTED]> wrote:
>
> > From: J. Bruce Fields <[EMAIL PROTECTED]>
> >
> > Well, it&#x
nfsd_setattr
Dr. David Alan Gilbert (1):
knfsd: Add source address to sunrpc svc errors
J. Bruce Fields (15):
nfsd: tone down inaccurate dprintk
nfsd: remove unused cache_for_each macro
knfsd: delete code made redundant by map_new_errors
knfsd: cleanup of nfsd4 cmp_
On Mon, Oct 15, 2007 at 03:30:41PM -0200, Guilherme Amadio wrote:
> I read the messages about the company list and now this CS projects list and
> I was wondering if is there any similar list of labs/universities that host
> PhD projects related to the Linux kernel. I am thinking about switching
git://linux-nfs.org/~bfields/lock-tests.git
and I'm mainly depending on those and connectathon locking tests for
now.)
--b.
J. Bruce Fields (7):
locks: reverse order of posix_locks_conflict() arguments
locks: kill redundant local variable
locks: fix flock_lock
From: J. Bruce Fields <[EMAIL PROTECTED]>
As it stands this comment is confusing, and not quite grammatical.
Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
---
fs/dcache.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/dcache.c b/fs/dcache.c
i
From: J. Bruce Fields <[EMAIL PROTECTED]>
Well, it's not especially important that target->d_iname get the
contents of dentry->d_iname, but it's important that it get initialized
with *something*, otherwise we're just exposing some random piece of
memory to anyone who
On Wed, Oct 17, 2007 at 06:38:52PM +0300, Ismail Dönmez wrote:
> Wednesday 17 October 2007 Tarihinde 18:33:18 yazmıştı:
> > Known issue ?
> >
> >
> > Thanks,
> > Badari
> >
> > CHK include/linux/version.h
> > CHK include/linux/utsrelease.h
> > CC arch/x86/kernel/asm-offsets.s
> >
On Mon, Nov 05, 2007 at 05:32:39PM +0100, Jan Blunck wrote:
> I'm embedding struct path into struct svc_expkey.
Looks straightforward to me, thanks.
Acked-by: J. Bruce Fields <[EMAIL PROTECTED]>
--b.
>
> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]>
On Fri, Nov 09, 2007 at 11:59:46AM +0100, Przemyslaw Wegrzyn wrote:
> Steve French wrote:
> > You are correct that the CIFS code calls SendReceive in cases in which
> > the buffer may be too small to fit a large SMB response, and that
> > should be fixed (e.g. to avoid possible overflows due to a s
On Fri, Nov 09, 2007 at 01:35:22PM -0800, Dave Hansen wrote:
> On Fri, 2007-11-09 at 16:26 -0500, Trond Myklebust wrote:
> > > #include
> > > #include
> > > #include
> > > +#include
> > > #include
> > > #include
> > > #include
> > > @@ -1303,7 +1304,7 @@ static inline void
> > > nfs4_
On Thu, Feb 08, 2007 at 06:38:48PM +0200, Menny Hamburger wrote:
> I have a piece of code in my 2.6 kernel that associates an ioctl
> file_operation to nfs in file.c and dir.c.
> This ioctl sends the nfs_fh to a userland application.
Doesn't /proc/fs/nfsd/filehandle do what you want already?
See
On Tue, Feb 06, 2007 at 10:37:37AM +, Christoph Hellwig wrote:
> On Tue, Feb 06, 2007 at 09:26:14PM +1100, Neil Brown wrote:
> > What would be the benefit of having private non-visible vfsmounts?
> > Sounds like a recipe for confusion?
> >
> > It is possible that mountd might start doing bind-
On Tue, Feb 13, 2007 at 03:13:01PM -0800, Trond Myklebust wrote:
> On Sun, 2007-02-11 at 10:06 +0200, Menny Hamburger wrote:
> > We implement our own nfsd in user space - so the kernel nfsd (as well
> > as the lockd) are disabled.
> > We need the handle in order to associate a kernel file handle w
On Tue, Feb 13, 2007 at 03:19:40PM -0800, Trond Myklebust wrote:
> On Tue, 2007-02-13 at 18:16 -0500, J. Bruce Fields wrote:
> > On Tue, Feb 13, 2007 at 03:13:01PM -0800, Trond Myklebust wrote:
> > > On Sun, 2007-02-11 at 10:06 +0200, Menny Hamburger wrote:
> > > >
On Mon, Jun 18, 2007 at 04:30:33PM -0400, Theodore Tso wrote:
> Well, I just want to make sure people know that Samba isn't asking for
> it any more, and I don't know of any current requests outstanding from
> any of the userspace projects. So there's no one we need to ship off
> to the re-educati
I missed a compile warning here, apologies.
--b.
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index c79f742..fbbbcab 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -3204,7 +3204,7 @@ get_nfs4_grace_period(void)
}
static void
-set_max_delegations()
+set_max_delegations
The authorship information got lost on these last two patches--both were
originally by Meelap Shah <[EMAIL PROTECTED]>.
(The problem may have been that I had a From: line for him but not a
Signed-off-by: line?)
--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
On Thu, Jun 21, 2007 at 12:28:01PM -0400, bfields wrote:
> The authorship information got lost on these last two patches--both were
> originally by Meelap Shah <[EMAIL PROTECTED]>.
>
> (The problem may have been that I had a From: line for him but not a
> Signed-off-by: line?)
Hm, no, actually I
On Tue, Jul 03, 2007 at 05:32:00PM -0600, Andreas Dilger wrote:
> On Jul 03, 2007 18:15 -0400, J. Bruce Fields wrote:
> > How will nfsd tell whether it can really on a given filesystem's
> > i_version, or whether it should fall back on ctime?
>
> Good question.
We
Could you fold the below into this patch? Without this the server can
oops on attempts to access a filesystem not exported to the request's
source address! Thanks to Olga Kornievskaia for the testing that found
this.
--b.
diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 333e5cf..582b494 1
On Tue, Jul 10, 2007 at 08:19:16PM -0400, Mingming Cao wrote:
> On Tue, 2007-07-10 at 18:22 -0700, Andrew Morton wrote:
> > And how does the NFS server know that the filesystem implements i_version?
> > Will a zero-value of i_version have special significance, telling the
> > server to not send th
On Wed, Jul 11, 2007 at 01:21:55PM +1000, Neil Brown wrote:
> And just by-the-way, the server doesn't really have the option of not
> sending the attribute. If i_version isn't defined, it has to fake
> something using mtime, and hope that is good enough.
ctime, actually--the change attribute is a
On Wed, Jul 11, 2007 at 09:28:06AM -0500, Dave Kleikamp wrote:
> On Wed, 2007-07-11 at 15:05 +1000, Neil Brown wrote:
> > It just occurred to me:
> >
> > If i_version is 64bit, then knfsd would need to be careful when
> > reading it on a 32bit host. What are the locking rules?
>
> How does knf
On Thu, May 24, 2007 at 05:55:54PM +0100, David Howells wrote:
> +/*
> + * initialise the lock manager thread if it isn't already running
> + */
> +static int afs_init_lock_manager(void)
> +{
> + if (!afs_lock_manager) {
> + afs_lock_manager = create_singlethread_workqueue("kafs_loc
On Sun, May 27, 2007 at 12:55:30AM +0100, David Howells wrote:
> J. Bruce Fields <[EMAIL PROTECTED]> wrote:
>
> > > + if (!afs_lock_manager) {
> > > + afs_lock_manager = create_singlethread_workqueue("kafs_lockd");
> > > + if (
On Sun, May 27, 2007 at 09:51:10AM +0100, David Howells wrote:
> J. Bruce Fields <[EMAIL PROTECTED]> wrote:
> > So if I request a write lock while holding a read lock, my request will
> > be denied?
>
> At the moment, yes. Don't the POSIX and flock lock-handling r
On Sun, May 27, 2007 at 06:34:42AM -0400, Jeff Garzik wrote:
>
> Unlike many of the bogus warnings spewed by gcc, this one actually
> complains about a real bug:
No, the calls to posix_acl_valid() in nfs4_acl_posix_to_nfsv4() ensure
that the passed-in acl has ACL_USER_OBJ, ACL_GROUP_OBJ, and ACL_
On Tue, May 29, 2007 at 10:47:06AM -0700, Linus Torvalds wrote:
> On Tue, 29 May 2007, Nish Aravamudan wrote:
> > The man-page is pretty good. There used to be
> > http://www.kernel.org/pub/software/scm/git/docs/howto/isolate-bugs-with-bisect.txt,
> > but it's 404 now...
>
> That file got folded i
On Mon, May 28, 2007 at 11:19:21PM -0400, Jeff Garzik wrote:
> J. Bruce Fields wrote:
> >But I don't want anyone else wasting their time on this. Should we cave
> >in and add the initialization here just to shut up gcc? Or would a
> >comment here help?
>
> Given
On Tue, May 29, 2007 at 10:34:41AM +0100, David Howells wrote:
> I'll need to test the upgrade/downgrade case. I don't know whether the AFS
> server supports that. If it doesn't, I can emulate downgrade, but not upgrade
> - not unless I only ever ask it for exclusive locks.
>
> Lock upgrading is
One more vague question I had while skimming the previous version--
On Tue, May 29, 2007 at 03:54:27PM +0100, David Howells wrote:
> +static void afs_grant_locks(struct afs_vnode *vnode, struct file_lock *fl)
> +{
> + struct file_lock *p, *_p;
> +
> + list_move_tail(&fl->fl_u.afs.link, &vn
On Wed, May 30, 2007 at 09:35:32AM +0100, David Howells wrote:
> J. Bruce Fields <[EMAIL PROTECTED]> wrote:
>
> > --without having tried to understand how they're actually used, these
> > data structures (like the pending_locks and granted_locks lists) seem to
>
On Fri, Jul 13, 2007 at 12:33:10AM -0700, Andrew Morton wrote:
> On Tue, 10 Jul 2007 12:22:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote:
>
> > With this patchset it becomes possible to list a number of different
> > security flavours that maybe used to access an exported filesystem,
> > and to att
From: J. Bruce Fields <[EMAIL PROTECTED]>
The value of nperbucket calculated here is too small--we should be
rounding up instead of down--with the result that the index j in the
following loop can overflow the raparm_hash array. At least in my case,
the next thing in memory turns out
From: J. Bruce Fields <[EMAIL PROTECTED]>
Share a little common code, reverse the arguments for consistency, drop
the unnecessary "inline", and lowercase the name.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/nfsd/auth.c |3 ++-
fs
From: J. Bruce Fields <[EMAIL PROTECTED]>
I converted the various export-returning functions to return -ENOENT
instead of NULL, but missed a few cases.
This particular case could cause actual bugs in the case of a krb5
client that doesn't match any ip-based client and that is trying
On Fri, 13 Jul 2007 11:42:28 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Fri, 13 Jul 2007 14:10:25 -0400 "J. Bruce Fields" <[EMAIL PROTECTED]>
> wrote:
> > On Fri, Jul 13, 2007 at 12:33:10AM -0700, Andrew Morton wrote:
> > > Please consider feed
From: J. Bruce Fields <[EMAIL PROTECTED]>
EX_RDONLY is only called in one place; just put it there.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/nfsd/vfs.c | 12
include/linux/nfsd/export.h | 12
2 files changed
From: J. Bruce Fields <[EMAIL PROTECTED]>
We can now assume that rqst_exp_get_by_name() does not return NULL; so
clean up some unnecessary checks.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/nfsd/vfs.c |4 ++--
1 files changed, 2 insertions(+), 2 dele
On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote:
> On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote:
>
> > +static void exp_flags(struct seq_file *m, int flag, int fsid,
> > + uid_t anonu, uid_t anong, struct nfsd4_fs_locations *fsloc)
> > +{
> > + s
On Thu, Jul 19, 2007 at 02:35:56PM +0200, Cornelia Huck wrote:
> On Thu, 19 Jul 2007 15:19:40 +0300 (EEST),
> Meelis Roos <[EMAIL PROTECTED]> wrote:
>
> > Trying to compile todays git with modular AFS and gcc 4.1.3 prerelease
> > in Debian unstable (gcc version 4.1.3 20070629 (prerelease) (Debian
On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote:
> On Wednesday July 18, [EMAIL PROTECTED] wrote:
> > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote:
> > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote:
> > >
> > > > +static void exp_flags(struct
On Thu, May 10, 2007 at 02:56:15PM -0400, Doug Chapman wrote:
> A recent regression (introduced after 2.6.21) was caught by the LTP test
> fcntl11. It appears that F_GETLK is not properly checking for existing
> F_RDLCK and allows taking out a write lock.
Ouch.
> This can be demonstrated by eith
On Thu, May 10, 2007 at 03:30:50PM -0400, bfields wrote:
> On Thu, May 10, 2007 at 02:56:15PM -0400, Doug Chapman wrote:
> > A recent regression (introduced after 2.6.21) was caught by the LTP test
> > fcntl11. It appears that F_GETLK is not properly checking for existing
> > F_RDLCK and allows ta
On Thu, May 10, 2007 at 03:38:59PM -0400, bfields wrote:
> On Thu, May 10, 2007 at 03:30:50PM -0400, bfields wrote:
> > On Thu, May 10, 2007 at 02:56:15PM -0400, Doug Chapman wrote:
> > > A recent regression (introduced after 2.6.21) was caught by the LTP test
> > > fcntl11. It appears that F_GETL
On Thu, May 10, 2007 at 05:01:05PM -0400, Doug Chapman wrote:
> You are partly right on the test however note that it is using a start
> and len that are specific to the RDLCK so that should _only_ conflict
> with that lock. I did notice that the LTP test is taking a new lock on
> the entire file
On Thu, May 10, 2007 at 05:04:21PM -0400, bfields wrote:
> On Thu, May 10, 2007 at 05:01:05PM -0400, Doug Chapman wrote:
> > You are partly right on the test however note that it is using a start
> > and len that are specific to the RDLCK so that should _only_ conflict
> > with that lock. I did no
ictly necessary, since the caller already does this; but it seems
less likely to cause confusion in the future.
Thanks to Doug Chapman for the bug report.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/locks.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-
The git tree at
git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git
could be set up in a simpler way:
$ git ls-remote
git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git
fc4b5be9e651d3e71b54541e0315fc82211b42b5refs/heads/option_export
59a1fe35614c
On Wed, May 16, 2007 at 08:55:19AM -0500, Roger Heflin wrote:
> Running bonnie over nfs on a RHEL4.4 client against a 2.6.21.1 server
> got me this crash after about 4 hours of running on the server:
>
> This was running lvm -> ext3 -> nfs nfsclient (RHEL4.4).
Yipes. Has this happened only
This code would benefit from a little more explanation.
Also, I screwed up the previous patch and forgot to delete a line, so the
calculation here is off; fix it.
Signed-off-by: J. Bruce Fields <[EMAIL PROTECTED]>
---
fs/nfsd/nfs4state.c | 16 +++-
1 files changed, 15 inse
On Wed, Jun 27, 2007 at 07:36:13PM -0700, Andrew Morton wrote:
> How's this?
Makes sense to me, thanks. I guess fs/nsfd/nfssvc:nfsd_create_serv()
should be similarly modified? It calculates the size of per-nfsd-thread
buffers used to hold requests, which will eventually be allocated with
an allo
On Sun, Jul 01, 2007 at 03:37:16AM -0400, Mingming Cao wrote:
> This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used
> for 64-bit inode versions. This field will store the higher 32 bits of the
> version, while Jean Noel's patch has added support to store the lower 32-bits
On Mon, Jul 02, 2007 at 10:58:33AM -0400, Mingming Cao wrote:
> Trond or Bruce, can you please review these patch series and ack if you
> agrees?
Thanks, looks like what we need!
How will nfsd tell whether it can really on a given filesystem's
i_version, or whether it should fall back on ctime?
From: J. Bruce Fields <[EMAIL PROTECTED]>
Trivial typo and grammar fixes.
Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]>
---
fs/anon_inodes.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/anon_inodes.c b/fs/anon_inodes.c
index 4
On Sun, May 20, 2007 at 01:37:13PM +0300, [EMAIL PROTECTED] wrote:
> Hello Oleg,
>
> I've done some more tests and quite frankly I think this is really related
> to the dreaded ''fglrx.ko'' module. It seems to me that it is much easier
> to reproduce the problem if that damn module is loaded. It
On Thu, Apr 19, 2007 at 03:34:01PM -0400, Jeff Garzik wrote:
> David Brown wrote:
> >>What is the easiest way to completely undo a pull, reverting the branch
> >>to the HEAD present before the pull?
> >>
> >
> >If the pull doesn't merge successfully then usually doing a `git-reset
> >--hard` will b
On Sun, Mar 25, 2007 at 04:58:32PM +0200, Adrian Bunk wrote:
> nfs4_acl_add_ace() can now be removed.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: J. Bruce Fields <[EMAIL PROTECTED]>
--b.
-
To unsubscribe from this list: send the line "unsubscribe linu
On Sat, Apr 07, 2007 at 04:36:33PM -0400, Theodore Tso wrote:
> 1) Deprecate telldir/seekdir() altogether. Relatively few progams use
> this functionality, and it is highly questionable how useful it is,
> anyway. If you use telldir/seekdir and keep the cookie for a long
> time, even the POSIX-pr
On Wed, Apr 11, 2007 at 08:10:37PM +0100, David Howells wrote:
> Add security support to the AFS filesystem. Kerberos IV tickets are
> added as RxRPC keys are added to the session keyring with the klog
> program. open() and other VFS operations then find this ticket with
> request_key() and eithe
On Wed, Apr 11, 2007 at 09:10:32PM +0100, David Howells wrote:
> J. Bruce Fields <[EMAIL PROTECTED]> wrote:
>
> > Just curious--when is the actual crypto done? There doesn't seem to be
> > any in this patch.
>
> See AF_RXRPC patch:
>
> ht
On Thu, Apr 12, 2007 at 08:21:16AM -0400, Theodore Tso wrote:
> Again, compared to a directory fd cache, what you're proposing a huge
> hit to the filesystem, and at the moment, given that telldir/seekdir
> is rarely used by everyone else, it's mainly NFS which is the main bad
> actor here by insis
On Tue, Mar 27, 2007 at 07:39:10PM +, Thorsten Kranzkowski wrote:
> Mar 16 16:57:06 Marvin kernel: svc: bad direction 268435456, dropping request
> Mar 16 17:58:19 Marvin kernel: svc: bad direction 268435456, dropping request
> Mar 16 19:55:49 Marvin kernel: svc: bad direction 268435456, droppi
On Tue, Mar 27, 2007 at 01:34:21PM -0700, Phy Prabab wrote:
> Here is a little bit more information on my issue with slowlaris and
Could you just use their name? It's a little distracting otherwise.
> knfs 2.6.21-rc4/5 (actually appears in 2.4.20.x). Running this from
> the client (x.org source
On Wed, Mar 28, 2007 at 07:05:36PM +, Thorsten Kranzkowski wrote:
> I'll let a tcpdump run this evening and see if I can correlate the message
> with anything.
>
> If you have a printk or other patch for me to try, just let me know.
Well, just for fun, you could try something like this--shou
On Fri, Mar 30, 2007 at 08:51:45PM +, Thorsten Kranzkowski wrote:
> The source address obviously isn't from my local net, and the clear
> text speaks for itself.
Woah, yeah, neato. OK, I guess that makes me a lot more willing to
believe any "impossible" error in linux/net/sunrpc/svc.c:svc_pro
On Sat, Mar 31, 2007 at 12:14:37PM +1000, Herbert Xu wrote:
> Indeed. That patch was buggy. Sorry for not catching this earlier.
Yep, thanks for the fix. I used the wrong length, then tested with a
case where nbytes would always be less than PAGE_SIZE, which doesn't hit
this problem. Apologies
On Tue, May 01, 2007 at 12:14:11PM +1000, Neil Brown wrote:
> I don't think this BUG_ON is correct. If a readdir finds zero entries,
> then will be some trailer information in the 'tail', but page_len will
> be 0. I think the following patch is correct and could fix that.
Yep.
> Bruce: does it
Just to confirm--yep, loks fine. And I did a quick connectathon run
over krb5i just to make sure. If someone wants it:
Acked-by: J. Bruce Fields <[EMAIL PROTECTED]>
--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [E
On Fri, Jul 08, 2016 at 05:53:19PM -0400, Oleg Drokin wrote:
>
> On Jul 8, 2016, at 4:54 PM, J. Bruce Fields wrote:
>
> > On Thu, Jul 07, 2016 at 09:47:46PM -0400, Oleg Drokin wrote:
> >> It looks like we are bit overzealous about failing mkdir/create/mknod
> >&
On Thu, Jul 21, 2016 at 04:37:40PM -0400, Oleg Drokin wrote:
>
> On Jul 21, 2016, at 4:34 PM, J. Bruce Fields wrote:
>
> > On Fri, Jul 08, 2016 at 05:53:19PM -0400, Oleg Drokin wrote:
> >>
> >> On Jul 8, 2016, at 4:54 PM, J. Bruce Fields wrote:
> >>
On Fri, Jul 22, 2016 at 02:35:26AM -0400, Oleg Drokin wrote:
>
> On Jul 21, 2016, at 9:57 PM, J. Bruce Fields wrote:
>
> > On Thu, Jul 21, 2016 at 04:37:40PM -0400, Oleg Drokin wrote:
> >>
> >> On Jul 21, 2016, at 4:34 PM, J. Bruce Fields wrote:
> >>
501 - 600 of 1455 matches
Mail list logo
