-endian modes. The unit test program is available from the URL
above.
Note that only the "o32"-style system calls have been added. This is
due to the fact that I have no suitable equipment to test the other
flavors of MIPS ABI.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
Ralf Baechle пишет:
> On Tue, Feb 19, 2008 at 12:02:37AM +0300, Dmitri Vorobiev wrote:
>
>> This patch enables the system calls timerfd_create(), timerfd_settime()
>> and timerfd_gettime() for MIPS architecture.
>>
>> Please see the following Bugzilla entr
Andreas Dilger пишет:
> On Jan 04, 2008 14:41 +0100, Richard Knutsson wrote:
>>> @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where,
>>> {
>>> int err = jbd2_journal_dirty_metadata(handle, bh);
>>> if (err)
>>> - ext4_journal_abort_handle(where, __FUNCTION__,
Andreas Dilger пишет:
> On Jan 04, 2008 14:41 +0100, Richard Knutsson wrote:
>>> @@ -54,6 +54,6 @@ int __ext4_journal_dirty_metadata(const char *where,
>>> {
>>> int err = jbd2_journal_dirty_metadata(handle, bh);
>>> if (err)
>>> - ext4_journal_abort_handle(where, __FUNCTION__,
Arjan van de Ven пишет:
> Subject: move WARN_ON() out of line
> From: Arjan van de Ven <[EMAIL PROTECTED]>
> CC: Ingo Molnar <[EMAIL PROTECTED]>
> CC: Andrew Morton <[EMAIL PROTECTED]>
>
> A quick grep shows that there are currently 1145 instances of WARN_ON
> in the kernel. Currently, WARN_ON is
6 204104 2846304 7958684 79709c vmlinux.after
4941596 204104 2846304 7992004 79f2c4 vmlinux.before
$ file vmlinux
vmlinux: ELF 32-bit MSB executable, MIPS, version 1 (SYSV), statically linked,
not stripped
More than 30Kb gone, thanks a lot!
Tested-by: Dmitri Vorobiev <[EMAIL PROTECTED]&g
From: Dmitri Vorobiev <[EMAIL PROTECTED]>
I noticed that the commit f197465384bf7ef1af184c2ed1a4e268911a91e3
(MIPS Tech: Get rid of volatile in core code) broke the software
reset functionality for MIPS Malta boards in big-endian mode.
According to the MIPS Malta board user's manual,
Matthew Wilcox пишет:
> On Tue, Jan 08, 2008 at 01:16:06PM -0700, Matthew Wilcox wrote:
>> On Tue, Jan 08, 2008 at 09:03:13PM +0100, Paolo Ciarrocchi wrote:
>>> Yes of course, I've been silly in didn't verify whether the file compile
>>> but I would appreciate to know whether I'm on the right track
This patch adds a separate short and sweet function to check the
PCI clock frequency. This is to improve readability of the Malta
setup code.
Along the way, a couple of coding style violations are fixed.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTEC
This patch reformats the structure initialization code thus
making the latter look idiomatic.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_setup.c | 56 +---
1 files changed, 42 inse
Ralf,
This is the Malta cleanup, which I was talking about some time ago.
The patches should be fairly obvious. They make no functional
changes.
Build tests passed successfully when I used the default configs
for Atlas, Malta and SEAD.
Just in case, I also ran boot tests, which passed successfu
This patch adds a separate short and sweet function to initialize
the screen_info global variable.
This improves readability of the Malta board setup code.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_setup.c
After the patch: total: 34 errors, 7 warnings, 355 lines checked
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c | 27 ++-
1 files changed, 14 insertions(+), 13 deletions(-)
diff -
Neither is the mips_rtc_get_time() routine defined anywhere in
the MIPS architecture-specific code, nor does anyone call it any
more. This patch removes the extern declaration of this fossil.
This patch does not introduce any functional changes.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTEC
This patch fixes all "use tabs not spaces" warnings reported by
the checkpatch.pl script on the board-specific files.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c | 64 +++-
-tested by building the kernel for all
three boards affected by this change. All builds finished
successfully.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/atlas/atlas_setup.c |2 --
arch/mips/mips-boards/malta/malta_setup.c |2 --
arch/mips/mips-boards/s
The checkpatch.pl script reported a few warnings about header files.
This patch fixes these warnings.
Compile-tested using the default Malta config.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c
Remove comments in C99 style and make checkpatch.pl happy.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/mips-boards
This was compile-tested using default configs for the boards
affected by this change.
This patch does not introduce any functional changes.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/atlas/atlas_setup.c |4
arch/mips/mips-boards/malta/malta_s
: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_setup.c | 80 +++--
1 files changed, 42 insertions(+), 38 deletions(-)
diff --git a/arch/mips/mips-boards/malta/malta_setup.c
b/arch/mips/mips-boards/malta/malta_setup.c
index 541f4e7..2cd8f57
One helper function can become static. This patch adds the needed
keyword.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_setup.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mip
the documentation, which is no more valid.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
Documentation/mips/00-INDEX |2 -
Documentation/mips/GT64120.README | 65 -
2 files changed, 0 insertions(+), 67 deletions(-)
delete mode
This patch fixes a couple of warnings reported by checkpatch.pl.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c |3 ++-
arch/mips/mips-boards/malta/malta_setup.c |3 +--
2 files changed, 3 inse
This patch fixes two errors reported by checkpatch.pl.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/mips/mips-boards
Using the "We die here" comment right before calling the die()
function is an extremely vivid example of overcommenting.
Remove the redundant comment and save one line.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/m
This patch fixes all "line over 80 characters" warnings found
in arch/mips/mips-boards/malta/malta_int.c by the checkpatch.pl
script.
No functional changes introduced.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
arch/mips/mips-boards/malta/malta_int.c | 22 +
Michael Opdenacker пишет:
> On Friday 18 January 2008, Matt Mackall wrote:
>> Probably makes sense to define it right next to INPUT_PCSPKR in
>> drivers/input/Kconfig.
>>
>> Then do the appropriate fix for all arches mentioned in INPUT_PCSPKR.
>>
>> For extra points, you can move the duplicate pcsp
| 0|
| inode.c | 0|0 | 0|
Please consider.
Thanks,
Dmitri Vorobiev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More ma
d finished successfully.
Run time test was performed using a BFS image and verifying that the
filesystem remained functional after the change.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/inode.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/
lines checked
No functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/inode.c | 23 ---
1 files changed, 12 insertions(
functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/bfs.h |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/bfs/b
functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/dir.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --gi
the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/bfs.h |3 +++
fs/bfs/dir.c |2 --
fs/bfs/inode.c |2 --
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
index 090b96e..ecc74bb 100644
--- a/fs/bfs/bfs.h
functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/file.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --gi
lines checked
No functional changes introduced.
This patch was compile-tested by building the BFS driver both
as a module and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
include/linux/bfs_fs.h | 17 ++---
1 files changed, 10 inse
and as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/dir.c | 13 +
fs/bfs/file.c |6 --
fs/bfs/inode.c |7 +--
3 files changed, 18 insertions(+), 8 deletions(-)
diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c
index 2
as a part of the kernel proper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
fs/bfs/inode.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/bfs/inode.c b/fs/bfs/inode.c
index 7eefafb..00c54fa 100644
--- a/fs/bfs/inode.c
+++ b/fs/bfs/inode.c
@@ -15,7
Heikki Orsila пишет:
> On Fri, Jan 25, 2008 at 01:32:04AM +0300, Dmitri Vorobiev wrote:
>> diff --git a/fs/bfs/bfs.h b/fs/bfs/bfs.h
>> index 090b96e..ecc74bb 100644
>> --- a/fs/bfs/bfs.h
>> +++ b/fs/bfs/bfs.h
> ...
>> +/* inode.c */
>> +extern void
Tigran Aivazian пишет:
> On Fri, 25 Jan 2008, Dmitri Vorobiev wrote:
>
>> Heikki Orsila пишет:
>>>> +extern void dump_imap(const char *, struct super_block *);
>>>> +
>>>
>>> Functions should not be externed, remove extern keyword.
>>>
Heikki Orsila пишет:
> On Fri, Jan 25, 2008 at 02:13:00AM +0300, Dmitri Vorobiev wrote:
>> Care to explain why?
>
> Because functions are always external objects in C. I just verified that
> from K&R.
>
Yes, I know that :)
The reasons behind me using this keyword
Hi,
The patch below contains a small code clean-up for the NTFS driver: all
static char pointers to error message strings have been replaced by
static char arrays.
Please apply if you like it.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
diff --git a/fs/ntfs/attrib.c b/f
Ahmed S. Darwish wrote:
On Tue, Oct 09, 2007 at 01:55:42AM +0400, Dmitri Vorobiev wrote:
Hi,
The patch below contains a small code clean-up for the NTFS driver: all
static char pointers to error message strings have been replaced by
static char arrays.
Hi Dmitri,
Hi,
First off, I hate
inion, this file should be deleted from the 2.6 kernel tree.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
--
diff --git a/Documentation/mips/00-INDEX b/Documentation/mips/00-INDEX
index 3f13bf8..8ae9cff 100644
--- a/Documentation/mips/00-INDEX
+++ b/Documentation/mips/00-INDEX
@
.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
diff --git a/fs/namespace.c b/fs/namespace.c
index 0608388..38b4b4a 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -278,8 +278,7 @@ static inline void __mntput(struct vfsmo
void mntput_no_expire(struct vfsmount *mnt)
{
-repeat:
-
operator in this routine is
necessary, I would be grateful to you if you could explain why it is necessary.
Thanks.
Signed-off-by Dmitri Vorobiev <[EMAIL PROTECTED]>
---
diff --git a/lib/prio_tree.c b/lib/prio_tree.c
index ccfd850..d56880f 100644
--- a/lib/prio_tree.c
+++ b/lib/prio_tree.c
@@ -
ount.h. So lots of callers of mntput() in modules will end up
trying to call mntput_no_expire() from modules.
$ nm fs/fuse/fuse.ko | grep mntput_no_expire
U mntput_no_expire
- z
Signed-off-by Dmitri Vorobiev <[EMAIL PROTECTED]>
---
diff --git a/fs/namespace.c b/fs/names
get it in,
> though. It's just a cleanup and so shouldn't go in this late in the -rc
> line.
>
> Maybe Andrew will be willing to queue it until that time in -mm.
I am enclosing the patch against current -mm tree and adding Andrew to the Cc:
list.
Thanks,
Dmitri
>
>
Andrew Morton пишет:
> On Thu, 22 Nov 2007 01:49:19 +0300
> Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
>
>> Zach Brown пишет:
>>>>> This doesn't look fine. Did you test this?
>>>> Oops, my fault. Of course, I tested the patch, but kernel mo
Daniel Drake пишет:
> Being spoilt by the luxuries of i386/x86_64 I've never really had a good
> grasp on unaligned memory access problems on other architectures and decided
> it was time to figure it out. As a result I've written this documentation
> which I plan to submit for inclusion as
> Docum
frequency on big-endian
during board start-up.
Change readw() to __raw_readl().
This was tested by injecting a call to printk() and verifying
that the value of the jmpr variable was consistent with current
setting of the JP4 "PCI CLK" jumper.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTE
Ralf Baechle on Atlas board support in the linux-mips mailing list:
Maciej is promising to fix it up since a few years ;-) Aside of that it's
safe to say the Atlas is dead like a coffin nail.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
Documentation/feature-removal-s
Ralf Baechle on Atlas board support in the linux-mips mailing list:
> Maciej is promising to fix it up since a few years ;-) Aside of that it's
> safe to say the Atlas is dead like a coffin nail.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
diff --git a/Documentatio
ned-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
---
include/asm-x86/unistd_32.h |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/asm-x86/unistd_32.h b/include/asm-x86/unistd_32.h
index 9b15545..8d8f9b5 100644
--- a/include/asm-x86/unistd_32.h
+++ b/include/asm
Dmitri Vorobiev пишет:
> Hello Adrian,
>
> Last time when I had sent some BFS bugfixes to the maintainer of
> this filesystem driver, he did not respond, and Andrew Morton
> had to take care of those.
>
> For this reason, and because the patches in this little patch bom
Adrian Bunk пишет:
> On Thu, Jan 24, 2008 at 11:22:21PM +, Tigran Aivazian wrote:
>> On Fri, 25 Jan 2008, Dmitri Vorobiev wrote:
>>
>>> Heikki Orsila пишет:
>>>>> +extern void dump_imap(const char *, struct super_block *);
>>>>> +
>&g
Tigran Aivazian wrote:
> On Sat, 26 Jan 2008, Dmitri Vorobiev wrote:
>> -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
>> +inode->i_mtime = CURRENT_TIME_SEC;
>> +inode->i_atime = CURRENT_TIME_SEC;
>> +inode-
Paolo Ciarrocchi пишет:
> This file has not been modified since October so should be
> easy to integrate the following patch.
>
> Before:
> total: 214 errors, 28 warnings, 739 lines checked
>
> After:
> total: 4 errors, 28 warnings, 708 lines checked
>
> Compile tested:
>
> [EMAIL PROTECTED]:/
Paolo Ciarrocchi пишет:
> This file has not been modified since October so should be
> easy to integrate the following patch.
>
> Before:
> total: 214 errors, 28 warnings, 739 lines checked
>
> After:
> total: 4 errors, 28 warnings, 708 lines checked
>
> Compile tested:
>
> [EMAIL PROTECTED]:/
Paolo Ciarrocchi пишет:
> On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
...
>
> How should I compare the .o file?
> Simply doing a md5sum or should I do a objdump -d before?
> Or a strip?
>
Comparing the
Ingo Molnar пишет:
> * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
>
>> Paolo Ciarrocchi пишет:
>>> On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>>>> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
Ralf Baechle пишет:
> On Thu, Jan 24, 2008 at 07:52:40PM +0300, Dmitri Vorobiev wrote:
>
> Whole series queued for 2.6.25.
OK, thanks.
Dmitri
>
> Thanks,
>
> Ralf
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bod
Al Viro wrote:
> On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote:
> -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC;
> +inode->i_mtime = CURRENT_TIME_SEC;
> +inode->i_atime = CURRENT_TIME_SEC;
> +inode->i_ctime = CURRENT_TIME_SEC;
>>>
ff-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
--
diff --git a/kernel/softirq.c b/kernel/softirq.c
index bd89bc4..b0d0431 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -219,28 +219,28 @@ asmlinkage void __do_softirq(void)
trace_softirq_enter();
cpu = smp_processor_id(
omatic and thus more readable.
Thanks,
Dmitri
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
--
diff --git a/fs/namespace.c b/fs/namespace.c
index 0608388..6a0cee1 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -278,8 +278,7 @@ static inline void __mntput(struct vfsmo
void mn
ere is the answer: I am using this driver
in the context of Linux kernel classes I am teaching in the Moscow State
University and in the International Institute of Information Technology in
Pune, India.
Signed-off-by: Dmitri Vorobiev <[EMAIL PROTECTED]>
This patch fixes the fo
Andrew Morton пишет:
On Wed, 14 Nov 2007 10:30:54 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
Hi Andrew,
The kernel build fails, with following error
fs/bfs/inode.c: In function ‘bfs_iget’:
fs/bfs/inode.c:37: error: ‘ino’ redeclared as different kind of symbol
fs/bfs/inode.c:35: error:
66 matches
Mail list logo