Re: [announce] split-up -rt patch-queue, v2.6.22.1-rt2

2007-07-12 Thread Daniel Walker
On Thu, 2007-07-12 at 17:37 +0200, Ingo Molnar wrote: > We are pleased to announce something we've been working on for some > time: a finegrained, split-up patch queue of the -rt kernel patch. From > now on (as of 2.6.22.1-rt2) it will be part of every upstream -rt > release and it is available

Re: [announce] split-up -rt patch-queue, v2.6.22.1-rt2

2007-07-12 Thread Daniel Walker
On Thu, 2007-07-12 at 17:37 +0200, Ingo Molnar wrote: > We are pleased to announce something we've been working on for some > time: a finegrained, split-up patch queue of the -rt kernel patch. From > now on (as of 2.6.22.1-rt2) it will be part of every upstream -rt > release and it is available

Re: [announce] split-up -rt patch-queue, v2.6.22.1-rt2

2007-07-12 Thread Daniel Walker
On Thu, 2007-07-12 at 19:01 +0200, Thomas Gleixner wrote: > We know very well and Ingo nowhere said, that this is not a perfect > queue, but it was and still is _our_ work base and we opened it up for > the reasons explained. Easy Thomas .. I was just trying to be helpful .. > What we definitely

Re: [announce] split-up -rt patch-queue, v2.6.22.1-rt2

2007-07-12 Thread Daniel Walker
On Thu, 2007-07-12 at 20:40 +0200, Thomas Gleixner wrote: > On Thu, 2007-07-12 at 10:02 -0700, Daniel Walker wrote: > > On Thu, 2007-07-12 at 19:01 +0200, Thomas Gleixner wrote: > > > > > We know very well and Ingo nowhere said, that this is not a perfect > > &g

[PATCH 2/2] i386: sched_clock() follows percpu frequency changes -v2

2007-05-25 Thread Daniel Walker
. Comment are certainly welcome .. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- Against 2.6.22-rc2 arch/i386/kernel/tsc.c | 128 include/linux/clocksource.h | 14 +++- 2 files changed, 72 insertions(+), 70

[PATCH 1/2] non-string based tsc unstable reasons

2007-05-25 Thread Daniel Walker
Just passing a string to mark_tsc_unstable() doesn't allow real code to change based on the reason for the instablility. I changed mark_tsc_unstable() to accept a string and a flag which denotes a general reason why the tsc is unstable, and can be evaluated in code. Signed-Off-By: Daniel W

Re: [PATCH 1/2] non-string based tsc unstable reasons

2007-05-25 Thread Daniel Walker
On Fri, 2007-05-25 at 23:05 +0200, Andi Kleen wrote: > On Fri, May 25, 2007 at 12:32:10PM -0700, Daniel Walker wrote: > > Just passing a string to mark_tsc_unstable() doesn't allow real code to > > change > > based on the reason for the instablility. I changed mark_tsc_

Re: [PATCH 3/5] lockstat: core infrastructure

2007-05-29 Thread Daniel Walker
On Tue, 2007-05-29 at 14:52 +0200, Peter Zijlstra wrote: > + now = sched_clock(); > + waittime = now - hlock->waittime_stamp; > + It looks like your using sched_clock() through out .. It's a little troubling considering the constraints on the function .. Most architecture implement a

Re: [PATCH 3/5] lockstat: core infrastructure

2007-05-30 Thread Daniel Walker
On Wed, 2007-05-30 at 15:24 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > [...] Most architecture implement a jiffies sched_clock() w/ 1 > > millisecond or worse resolution.. [...] > > weird that you count importance by 'number

Re: [PATCH 3/5] lockstat: core infrastructure

2007-05-30 Thread Daniel Walker
On Wed, 2007-05-30 at 15:49 +0200, Ingo Molnar wrote: > * Steven Rostedt <[EMAIL PROTECTED]> wrote: > > > [...] We can argue that sched_clock is "good enough". If someone > > wants better accounting of locks on some other arch, they can simply > > change sched_clock to be more precise. > > exa

Re: [PATCH 3/5] lockstat: core infrastructure

2007-05-30 Thread Daniel Walker
On Wed, 2007-05-30 at 19:16 +0200, Peter Zijlstra wrote: > > >From the architecture perspective there are two low level clock hooks to > > implement one is sched_clock() , and at least one clocksource structure. > > Both do essentially the same thing. With timekeepings clocksource > > structure ac

Re: [PATCH 3/5] lockstat: core infrastructure

2007-06-01 Thread Daniel Walker
On Fri, 2007-06-01 at 15:12 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-30 at 19:16 +0200, Peter Zijlstra wrote: > > > > I think you are mistaken here; the two are similar but not > > > identical. > &g

Re: [PATCH 3/5] lockstat: core infrastructure

2007-06-01 Thread Daniel Walker
On Fri, 2007-06-01 at 17:52 +0200, Peter Zijlstra wrote: > On Fri, 2007-06-01 at 08:26 -0700, Daniel Walker wrote: > > On Fri, 2007-06-01 at 15:12 +0200, Ingo Molnar wrote: > > > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > > On Wed, 20

Re: [PATCH 3/5] lockstat: core infrastructure

2007-06-01 Thread Daniel Walker
On Fri, 2007-06-01 at 20:19 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > I see sched_clock() as fast first, accurate second. Whereas the > > > > > clocksource thing is accurate first, fast second. > > > >

Re: [PATCH 3/5] lockstat: core infrastructure

2007-06-01 Thread Daniel Walker
On Fri, 2007-06-01 at 20:30 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > So, having two interfaces, one fast and one accurate is the right > > > answer IMHO. > > > > In the case of lockstat you have two cases fa

Re: [PATCH 3/5] lockstat: core infrastructure

2007-06-01 Thread Daniel Walker
On Fri, 2007-06-01 at 20:43 +0200, Peter Zijlstra wrote: > On Fri, 2007-06-01 at 09:11 -0700, Daniel Walker wrote: > > On Fri, 2007-06-01 at 17:52 +0200, Peter Zijlstra wrote: > > > > The whole issue is that you don't have any control over what clocksource > >

Re: [PATCH -rt 3/5] asm/local.h cmpxchg

2007-07-14 Thread Daniel Walker
On Sat, 2007-07-14 at 19:57 +0200, Peter Zijlstra wrote: > === > --- > linux-2.6.22-rc6-mm1.orig/include/asm-generic/local.h 2007-07-12 > 19:44:18.0 -0700 > +++ linux-2.6.22-rc6-mm1/include/asm-generic/local.h2007-07-

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 11:54 +0200, Andi Kleen wrote: > Move it into an own file for easy sharing. > Do everything per CPU. This avoids problems with TSCs that > tick at different frequencies per CPU. > Resync properly on cpufreq changes. CPU frequency is instable > around cpu frequency changing, so

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote: > > What about using the cycles2ns() clocksource helpers, it would eliminate > > the duplication of the shift/multiply math . > > They are completely different from what clocksource provides. How so? Daniel - To unsubscribe from this list: se

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:22 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:15:38 Daniel Walker wrote: > > On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote: > > > > What about using the cycles2ns() clocksource helpers, it would eliminate > > > > the dupli

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > > > >From my perspective a downside to sched_clock is that the math is > > duplicated per architecture .. I think it would be a win to use the > > generic

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 20:00 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:43:49 Daniel Walker wrote: > > On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote: > > > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > > > > > > > >From my per

[PATCH] use defines in sys_getpriority/sys_setpriority

2007-05-10 Thread Daniel Walker
Switch to the defines for these two checks, instead of hard coding the values. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/sys.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.21/kernel

[PATCH 2/2] i386: sched_clock() follows percpu frequency changes

2007-05-12 Thread Daniel Walker
. Comment are certainly welcome .. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/i386/kernel/tsc.c | 130 +--- include/linux/clocksource.h | 14 +++- 2 files changed, 74 insertions(+), 70

[PATCH 1/2] non-string based tsc unstable reasons

2007-05-12 Thread Daniel Walker
tultz patch to add the string reasons. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/i386/kernel/cpu/cyrix.c|9 -- arch/i386/kernel/tsc.c | 39 +--- arch/x86_64/kernel/time.c |3 +-

Re: [PATCH 1/2] non-string based tsc unstable reasons

2007-05-12 Thread Daniel Walker
On Sat, 2007-05-12 at 20:56 +0200, Andi Kleen wrote: > On Saturday 12 May 2007 17:43:45 Daniel Walker wrote: > > Just passing a string to mark_tsc_unstable() doesn't allow real code to > > change > > based on the reason for the instablility. I changed mark_tsc_unstabl

Re: [PATCH 2/2] i386: sched_clock() follows percpu frequency changes

2007-05-12 Thread Daniel Walker
On Sat, 2007-05-12 at 20:58 +0200, Andi Kleen wrote: > On Saturday 12 May 2007 17:43:46 Daniel Walker wrote: > > Considering that Andi has a similar patch, I'm going to assume there > > is already justification for this.. > > I just have a patch for sched_clock, w

Re: [patch] make pit clocksource continuous

2007-05-12 Thread Daniel Walker
On Sun, 2007-05-13 at 03:18 +0400, Stas Sergeev wrote: > Hello. > > Without the attached patch, I wasn't able > to get the PIT to work as a clocksource for > high-res timers. > I don't know whether the patch is correct, > but I tested it and it works. > Can someone please tell me what exactly > do

Re: v2.6.21-rt2

2007-05-16 Thread Daniel Walker
On Wed, 2007-05-16 at 20:04 +0200, Ingo Molnar wrote: > i'm pleased to announce the v2.6.20-rt2 kernel, which can be downloaded > from the usual place: 2.6.21-rt2 ? > http://redhat.com/~mingo/realtime-preempt/ > > more info about the -rt patchset can be fo

Re: v2.6.21-rt2

2007-05-16 Thread Daniel Walker
On Wed, 2007-05-16 at 23:01 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-05-16 at 20:04 +0200, Ingo Molnar wrote: > > > i'm pleased to announce the v2.6.20-rt2 kernel, which can be downloaded > > > from the usu

Re: v2.6.21-rt2

2007-05-16 Thread Daniel Walker
On Wed, 2007-05-16 at 23:32 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > http://lkml.org/lkml/2007/5/3/368 > > > > > > hm - trace_hardirqs_on() should never be called with irqs on - > > > lockdep could br

Re: v2.6.21-rt2

2007-05-16 Thread Daniel Walker
On Thu, 2007-05-17 at 00:04 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > I don't know. irqs_off_preempt_count() could get used someplace else, > > where you would want to flip the preempt_count() check .. It seems > > s

Re: Tasklet usage in the DRM

2007-06-29 Thread Daniel Walker
On Fri, 2007-06-29 at 09:09 +0200, Michel Dänzer wrote: > I just read an article on LWN's kernel page about plans to remove > tasklets, and I thought I'd explain what the DRM is using tasklets for. > Maybe there's other ways to satisfy the requirements equally well or > even better. > > > The i91

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Daniel Walker
On Thu, 2007-05-17 at 13:17 -0500, Kumar Gala wrote: > > I haven't looked at all the new clock/timer code, is there any > utility in having support for more than one clock source? There is if the main clocksource has some issues where it can't be used. On x86 there are lots of different issues

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-18 Thread Daniel Walker
On Fri, 2007-05-18 at 19:06 +0400, Sergei Shtylyov wrote: > Daniel Walker wrote: > > >>I haven't looked at all the new clock/timer code, is there any > >>utility in having support for more than one clock source? > > > There is if the main clocksource

Re: [PATCH 2.6.21-rt2] PowerPC: decrementer clockevent driver

2007-05-19 Thread Daniel Walker
On Sat, 2007-05-19 at 13:33 +1000, Paul Mackerras wrote: > Daniel Walker writes: > > > On Fri, 2007-05-18 at 19:06 +0400, Sergei Shtylyov wrote: > > > Well, the decrementer frequency may change, at least in theory (if > > > the bus > > > clock changes

Re: v2.6.21-rt3

2007-05-21 Thread Daniel Walker
Where did the arm ep93xx changes come from? It looks like patch below came in with them in 2.6.21-rt6 .. --- linux.orig/include/asm-arm/system.h +++ linux/include/asm-arm/system.h @@ -235,8 +235,9 @@ static inline void set_copro_access(unsi * so enable interrupts over the context switch to avoi

Re: v2.6.21-rt3

2007-05-21 Thread Daniel Walker
On Mon, 2007-05-21 at 22:24 +0200, Thomas Gleixner wrote: > On Mon, 2007-05-21 at 13:11 -0700, Daniel Walker wrote: > > Where did the arm ep93xx changes come from? > > Grown out of my nose probably. > > > It looks like patch below > > came in with them in 2.6.

Re: v2.6.21-rt3

2007-05-21 Thread Daniel Walker
On Mon, 2007-05-21 at 22:36 +0200, Thomas Gleixner wrote: > On Mon, 2007-05-21 at 13:25 -0700, Daniel Walker wrote: > > On Mon, 2007-05-21 at 22:24 +0200, Thomas Gleixner wrote: > > > On Mon, 2007-05-21 at 13:11 -0700, Daniel Walker wrote: > > > > Where did th

Re: v2.6.21-rt3

2007-05-22 Thread Daniel Walker
On Tue, 2007-05-22 at 10:25 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > I copied the patch into the first email, I did look at it which is why > > you got an email. Your introducing the patch , it's for you to explain > > why

Re: [PATCH -rt] ARM TLB flush fix: don't forget to re-enable preemption

2007-05-22 Thread Daniel Walker
On Tue, 2007-05-22 at 16:01 -0700, Kevin Hilman wrote: > Add a preempt_enable() to flush_tlb_kernel_page() since -rt4 patch > adds a preempt_disable but no preempt_enable(). > > Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]> > > > --- > include/asm-arm/tlbflush.h |1 + > 1 file changed, 1

Re: [PATCH -rt] ARM TLB flush fix: don't forget to re-enable preemption

2007-05-22 Thread Daniel Walker
On Tue, 2007-05-22 at 16:41 -0700, Kevin Hilman wrote: > > Individually, yes. But the point of the preempt_disable/enable is to > make the whole sequence atomic. I was under the impression that only one of those mcr lines is called per board type, the rest just compile away? Daniel - To unsu

Re: [PATCH -rt] ARM TLB flush fix: don't forget to re-enable preemption

2007-05-23 Thread Daniel Walker
On Wed, 2007-05-23 at 09:13 -0700, Kevin Hilman wrote: > Note that my patch simply adds an enable to match the disable added by > the -rt patch. I'm not sure where the disable originally came from, but > there are disable/enable pairs scattered throughout tlbflush.h in the > -rt patch. > > If th

Re: [patch] sched_clock(): cleanups, #2

2007-05-25 Thread Daniel Walker
On Fri, 2007-05-25 at 09:17 -0700, Andrew Morton wrote: > On Fri, 25 May 2007 14:15:40 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > > -Andi (who hopes this thread will end soon now and we can all go > > back to more important issues) > > fyi, the thread has been damn useful for me. If Ingo ha

Re: hardwired VMI crap

2007-03-08 Thread Daniel Walker
On Thu, 2007-03-08 at 15:55 -0800, Zachary Amsden wrote: > > We just don't drive the local timer interrupts through the APIC, we make > hypercalls to schedule local timer alarms. Which is something we must > do for UP kernels as well, which use the PIT / PIC. So there is a need > for having

Re: Stolen and degraded time and schedulers

2007-03-13 Thread Daniel Walker
On Tue, 2007-03-13 at 13:32 -0700, Jeremy Fitzhardinge wrote: > Most of the existing clocksource infrastructure would only operate on > CLOCK_TIMEBASE_REALTIME clocksources, so I'm not sure how much overlap > there would be here. In the case of dealing with cpufreq, there's a > certain appeal to

Re: Stolen and degraded time and schedulers

2007-03-13 Thread Daniel Walker
On Tue, 2007-03-13 at 14:59 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > The frequency tracking you mention is done to some extent inside the > > timekeeping adjustment functions, but I'm not sure it's totally accurate > > for non-timekeeping,

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Tue, 2007-03-13 at 23:52 -0700, Jeremy Fitzhardinge wrote: > > > > That's true, but given a constant clock (like what sched_clock should > > have) then the accounting is similarly inaccurate. Any connection > > between the scheduler and the TSC frequency changes aren't part of the > > design AF

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Wed, 2007-03-14 at 09:37 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > Then your direction is wrong, sched_clock() should be constant ideally > > (1millisecond should really be 1millisecond). > > Rather than repeating myself, I suggest you read my original

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Wed, 2007-03-14 at 10:08 -0700, Jeremy Fitzhardinge wrote: > The actual length of the timeslices is an orthogonal issue. It may be > that you want to give processes more cpu time by making their quanta > longer to compensate for lost cpu time, but that would affect their > real-time characteri

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Wed, 2007-03-14 at 11:41 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > >From prior emails I think your suggesting that 1ms (or 5 or 10) of time > > should actually be a variable X that is changed inside sched_clock(). > > That's not the purpose

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Wed, 2007-03-14 at 12:44 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > sched_clock is used to bank real time against some specific states > > inside the scheduler, and no it doesn't _just_ measure a processes > > executing time. > > > >

Re: Stolen and degraded time and schedulers

2007-03-14 Thread Daniel Walker
On Wed, 2007-03-14 at 14:16 -0700, Jeremy Fitzhardinge wrote: > > > It's also used for some posix cpu timers > > (sched_ns) , and it used for migration thread initialization. > > sched_ns doesn't use it directly except for the case where the process > is currently running. Anyway, it's compati

Re: [PATCH] Add an offset in the cyc2ns computation to fix sched_clock jumps

2007-03-16 Thread Daniel Walker
On Fri, 2007-03-16 at 19:14 +0100, Guillaume Chazarain wrote: > Hello, > > The scheduling problems I reported in the thread: > http://lkml.org/lkml/2007/3/3/128 > are caused by the set_cyc2ns_scale() function called when the CPU speed > changes. > Changing the scale causes a warp in the value ret

[PATCH] seqlocks: trivial remove weird whitespace

2007-04-13 Thread Daniel Walker
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- include/linux/seqlock.h |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.20/include/linux/seqlock.h === --- linux-2.6.20.orig/include

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-13 Thread Daniel Walker
On Fri, 2007-04-13 at 22:21 +0200, Ingo Molnar wrote: > [announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS] > > i'm pleased to announce the first release of the "Modular Scheduler Core > and Completely Fair Scheduler [CFS]" patchset: > >http://redhat.com/~mingo/cfs-s

Re: [Announce] [patch] Modular Scheduler Core and Completely Fair Scheduler [CFS]

2007-04-13 Thread Daniel Walker
One other thing, what happens in the case of slow, frequency changing, are/or inaccurate clocks .. Is the old sched_clock behavior still tolerated? Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH 00/40] Swap over Networked storage -v12

2007-05-04 Thread Daniel Walker
On Fri, 2007-05-04 at 12:26 +0200, Peter Zijlstra wrote: > 1) introduce the memory reserve and make the SLAB allocator play nice with it. >patches 01-10 > > 2) add some needed infrastructure to the network code >patches 11-13 > > 3) implement the idea outlined above >patches 14-20 >

Re: [PATCH 00/40] Swap over Networked storage -v12

2007-05-04 Thread Daniel Walker
On Fri, 2007-05-04 at 17:38 +0200, Peter Zijlstra wrote: > > > > This is kind of a lot of patches all at once .. Have you release any of > > these patch sets prior to this release ? > > Like the -v12 suggests, this is the 12th posting of this patch set. > Some is the same, some has changed. I c

Re: [PATCH 00/40] Swap over Networked storage -v12

2007-05-04 Thread Daniel Walker
On Fri, 2007-05-04 at 14:09 -0400, Mike Snitzer wrote: > On 5/4/07, Daniel Walker <[EMAIL PROTECTED]> wrote: > > On Fri, 2007-05-04 at 17:38 +0200, Peter Zijlstra wrote: > > > > > > > > This is kind of a lot of patches all at once .. Have you release any of

Re: Need help debugging RT-preempt patch

2007-05-07 Thread Daniel Walker
On Mon, 2007-05-07 at 11:47 -0700, Tim Bird wrote: > I've applied patch-2.6.21-rt1 to a 2.6.21 kernel I'm using. > With the patch applied, but no RT-Preempt options enabled, > I'm getting network failures (eth0 transmit timeouts) on > an OMAP board. Are you sure you don't have HardIRQS in Threads

Re: Need help debugging RT-preempt patch

2007-05-07 Thread Daniel Walker
On Mon, 2007-05-07 at 14:02 -0700, Tim Bird wrote: > Daniel Walker wrote: > > Are you sure you don't have HardIRQS in Threads enabled? Also are you > > sure the kernel boots without the rt patch applied. > > Yes on both counts. I double-checked the configs. I'm us

[PATCH] clocksource: spell error in watchdog code

2007-05-08 Thread Daniel Walker
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/time/clocksource.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.21/kernel/time/clocksource.c === --- linux-2.6.21.orig/kerne

[PATCH] clocksource: spelling error in watchdog code

2007-05-08 Thread Daniel Walker
Theres more that need fixing , and fix my own subject spelling error too. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/time/clocksource.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: linux-2.6.21/kernel/time/clockso

Re: [PATCH] time : SMP friendly alignment of struct clocksource

2007-03-20 Thread Daniel Walker
On Tue, 2007-03-20 at 10:58 -0700, john stultz wrote: > > /* timekeeping specific data, ignore */ > > - cycle_t cycle_last, cycle_interval; > > - u64 xtime_nsec, xtime_interval; > > + cycle_t cycle_interval; > > + u64 xtime_interval; > > + /* > > +* Second part is written at

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 12:58 -0700, Andrew Morton wrote: > On Wed, 04 Apr 2007 09:38:32 -0700 > Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Sun, 2007-04-01 at 10:43 +0200, Thomas Gleixner wrote: > > > On Sat, 2007-03-31 at 22:23 -0700, [EMAIL PROTECTED] w

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 22:36 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The struct clocksource .list field is now required to be initialized > > before calling clocksource_register(). > > > > This is a prerequisite for simp

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 23:15 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > This is a prerequisite for simplifying the clocksource > > > > registration process. > > > > > > why? This patch only pushes som

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 23:34 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > but why do you call that a simplification? Remove 5 lines of code > > > from the generic code, by adding +1 line to every clocksource > > > dri

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 16:48 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > I vaguely remember, but I don't think this creates a maintenance > > issue .. It's not related to maintenance , it's an issue of creating a > > new clocksource .. My per

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-04 Thread Daniel Walker
On Wed, 2007-04-04 at 17:20 -0700, Jeremy Fitzhardinge wrote: > Daniel Walker wrote: > > Setting CLOCK_SOURCE_IS_CONTINUOUS is largely administration , do you > > know what that flag means? > > > > Sure, but at least it has something to do with clocks and time.

Re: + clocksource-driver-initialize-list-value.patch added to -mm tree

2007-04-05 Thread Daniel Walker
On Thu, 2007-04-05 at 09:51 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > [...] Adding a list initializer doesn't change anything.. > > Daniel, you are still in denial. OF COURSE it changes something: it adds > a line of code to a

[PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread Daniel Walker
, compile tested on x86_64 .. However, I couldn't find a !GENERIC_TIME that compiled without this change so it's untested.. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- include/linux/timekeeping.h | 10 ++ kernel/time/clocksource.c |7 +++ kernel/ti

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-05 Thread Daniel Walker
On Thu, 2007-04-05 at 14:25 -0700, john stultz wrote: > On Thu, 2007-04-05 at 14:03 -0700, Daniel Walker wrote: > > Before this change the timekeeping code would poll the clocksource > > list every interrupt. This changes that so the clocksource list is > > only checked wh

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-06 Thread Daniel Walker
On Fri, 2007-04-06 at 18:21 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Boot tested on i386, compile tested on x86_64 .. However, I couldn't > > find a !GENERIC_TIME that compiled without this chang

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Daniel Walker
On Sat, 2007-04-07 at 03:19 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 14:03:16 -0700 Daniel Walker <[EMAIL PROTECTED]> wrote: > > > Before this change the timekeeping code would poll the clocksource > > list every interrupt. This changes that so the clocksource

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-07 Thread Daniel Walker
On Sat, 2007-04-07 at 22:50 +0200, Thomas Gleixner wrote: > On Sat, 2007-04-07 at 10:43 -0700, Daniel Walker wrote: > > Looks like this path , > > > > arch/i386/kernel/tsc.c: time_cpufreq_notifier(); <-- takes xtime_lock > >

Re: [PATCH] timekeeping: drop irq-context clocksource polling

2007-04-08 Thread Daniel Walker
On Sun, 2007-04-08 at 10:33 +0200, Thomas Gleixner wrote: > > Oh well, this is a leftover from the days where we tried to use TSC > despite of frequency changes. It still modifies the scale factor of the > tsc clocksource. > > I agree that it can be removed as we switch off TSC anyway in that ca

[PATCH] clocksource: acpi_pm trivial comment update

2007-04-10 Thread Daniel Walker
Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- drivers/clocksource/acpi_pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.20/drivers/clocksource/acpi_pm.c === --- linux-2.6.20.orig/d

[PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

2007-04-11 Thread Daniel Walker
once been used for timekeeping, but not any longer .. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/i386/kernel/tsc.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Index: linux-2.6.20/arch/i386/kernel

[PATCH] sched: consolidate sched_clock drift adjustments

2007-04-11 Thread Daniel Walker
to make it explicit . Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/sched.c | 31 ++- 1 file changed, 22 insertions(+), 9 deletions(-) Index: linux-2.6.20/kernel/sched.c === --- linux-2.

Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

2007-04-11 Thread Daniel Walker
On Wed, 2007-04-11 at 13:31 -0700, Andrew Morton wrote: > On Wed, 11 Apr 2007 09:29:04 -0700 > Daniel Walker <[EMAIL PROTECTED]> wrote: > > > The locking of the xtime_lock around the cpu notifier is unessesary now. At > > one > > time the tsc was used after a

Re: [PATCH] i386 tsc: remove xtime_lock'ing around cpufreq notifier

2007-04-12 Thread Daniel Walker
On Thu, 2007-04-12 at 10:43 -0700, Jeremy Fitzhardinge wrote: > Andrew Morton wrote: > > hm. People (ab)use sched_clock() for all sorts of things nowadays. I > > wouldn't > > do anything to degrade it just on behalf of printk-timestamping. > > > > printk was the only non-scheduler-ish use I

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: > And sched_clock's use of local_irq_save/restore appears to be absolutely > correct, so I think it must be triggering a bug in either the self-tests > or lockdep itself. Why does sched_clock need to disable interrupts? Daniel - To u

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 22:59 +0200, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: > > > > > And sched_clock's use of local_irq_save/restore appears to be absolutel

Re: [patch 1/4] Ignore stolen time in the softlockup watchdog

2007-04-24 Thread Daniel Walker
On Tue, 2007-04-24 at 23:20 +0200, Andi Kleen wrote: > On Tuesday 24 April 2007 22:52:27 Daniel Walker wrote: > > On Tue, 2007-04-24 at 13:24 -0700, Jeremy Fitzhardinge wrote: > > > > > And sched_clock's use of local_irq_save/restore appears to be absolutely > &g

[PATCH] posix-cpu-clocks: cleanup clock macros

2007-04-26 Thread Daniel Walker
These macros were a little confused looking, so I cleaned then up a bit. I think this way it's a little clearer what's what .. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- include/linux/posix-timers.h | 38 +++--- 1 file changed, 27 i

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-26 Thread Daniel Walker
On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > +.mask = (1LL << 40) - 1, > +.mult = 0, /*to be caluclated*/ > +.shift = 16, > +.is_continuous = 1, > }; You should use CLOCKSOURCE_MASK() here .. > > diff --git a/include/l

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 10:38 -0400, Peter Keilty wrote: > Daniel Walker wrote: > > >On Thu, 2007-04-26 at 16:26 -0400, Peter Keilty wrote: > > > > > > > >>+.mask = (1LL << 40) - 1, > >>+.mult = 0,

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote: > > > >There is a read(), and a vread() did you modify the slow syscall path to > >use the vread()? > > > > > I miss type, read(). John mentioned that he thought fsys_mmio_ptr could be held in the vread pointer. vread() is used in x86 for v

Re: [PATCH 1/3] ia64: convert to use clocksource code

2007-04-27 Thread Daniel Walker
On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote: > > > No, but yes it can be done, overloading the meaning. > It would need to change in the future if vread was needed. > I have no strong argument against using it. > Although we may still need the IA64 define, I removed 32bit read mmio and

Re: [PATCH -mm][Take 2] clocksource init adjustments (fix bug #7426)

2007-03-04 Thread Daniel Walker
On Fri, 2007-03-02 at 15:24 -0800, john stultz wrote: > Thus the solution here is to register clocksources earlier (ideally when > the hardware is being initialized), and then we enable clocksource > selection at fs_initcall (before device_initcall). > When I was doing this in my tree I found th

Re: [5/6] 2.6.21-rc2: known regressions

2007-03-05 Thread Daniel Walker
ents) > > > References : http://lkml.org/lkml/2007/2/21/208 > > > Submitter : Daniel Walker <[EMAIL PROTECTED]> > > > Caused-By : Thomas Gleixner <[EMAIL PROTECTED]> > > > commit e9e2cdb412412326c4827fc78ba27f410d837e6e > > > Hand

Re: [5/6] 2.6.21-rc2: known regressions

2007-03-05 Thread Daniel Walker
On Mon, 2007-03-05 at 16:27 +0100, Ingo Molnar wrote: > * Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > FYI, this is not a "wont boot" problem, this should be a "NMI > > > > watchdog does not work" problem - which has far lower severit

[PATCH] fix vsyscall settimeofday

2007-03-05 Thread Daniel Walker
ttimeofday(), that way the vsyscall state doesn't get stale. Any thought John? Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- kernel/timer.c |2 ++ 1 file changed, 2 insertions(+) Index: linux-2.6.20/kernel/timer.c ===

[PATCH 1/9] clocksource: arm initialize list value

2007-03-30 Thread Daniel Walker
Update arch/arm/ with list initialization. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/arm/mach-imx/time.c |1 + arch/arm/mach-ixp4xx/common.c |1 + arch/arm/mach-netx/time.c |1 + arch/arm/mach-pxa/time.c |1 + 4 files changed, 4 insertions(+)

[PATCH 8/9] clocksource: s390 initialize list value

2007-03-30 Thread Daniel Walker
Update arch/s390 with list initialization. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/s390/kernel/time.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.20/arch/s390/kernel/time.c === --- linux-2.6.2

[PATCH 9/9] clocksource: refactor duplicate registration checking

2007-03-30 Thread Daniel Walker
-By: Daniel Walker <[EMAIL PROTECTED]> --- include/linux/clocksource.h |2 +- kernel/time/clocksource.c | 30 ++ kernel/time/jiffies.c |1 + 3 files changed, 20 insertions(+), 13 deletions(-) Index: linux-2.6.20/include/linux/clockso

[PATCH 4/9] clocksource: mips initialize list value

2007-03-30 Thread Daniel Walker
Update arch/mips/ with list initialization. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/mips/kernel/time.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.19/arch/mips/kernel/time.c === --- linux-

[PATCH 6/9] clocksource: x86_64 initialize list value

2007-03-30 Thread Daniel Walker
Update arch/x86_64/ with list initialization. Signed-Off-By: Daniel Walker <[EMAIL PROTECTED]> --- arch/x86_64/kernel/hpet.c |1 + arch/x86_64/kernel/tsc.c |1 + 2 files changed, 2 insertions(+) Index: linux-2.6.20/arch/x86_64/kernel/

<    1   2   3   4   5   6   7   8   9   >