Re: [PATCH] mtd: remove ixp2000 driver

2013-03-17 Thread Artem Bityutskiy
quot;). That commit removed the ARCH_IXP2000 Kconfig > > symbol. This removes the last driver depending on that symbol. > > > > Signed-off-by: Paul Bolle > > It turns out that Artem Bityutskiy has published a series of patches > removing this and similar drivers just yesterday: &

Re: [PATCH v6 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-18 Thread Artem Bityutskiy
y hand: > TC58NVG2S0F, TC58NVG3S0F, TC58NVG5D2, TC58NVG6D2 Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: linux-next: Tree for Mar 18 (mtdcore)

2013-03-19 Thread Artem Bityutskiy
On Mon, 2013-03-18 at 14:38 -0700, Randy Dunlap wrote: > when CONFIG_PROC_FS is not enabled: Thanks Randy, should be fixed now. -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: [PATCH -next] UBIFS: fix missing unlock on error in ubifs_remount_rw()

2013-03-19 Thread Artem Bityutskiy
On Mon, 2013-03-18 at 11:12 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function ubifs_remount_rw() > in the error handling case. > > Signed-off-by: Wei Yongjun Thanks, I fixed this up in linux-ubifs.git. -- Best Regards

Re: [PATCH v3] mtd: fix the wrong timeo for panic_nand_wait()

2013-02-03 Thread Artem Bityutskiy
write() does. > > This patch passes timeo in ms to panic_nand_wait(). > And this patch also passes timeo in jiffies(converted by msecs_to_jiffies) > to time_before() which makes the code more readable. > > Signed-off-by: Huang Shijie Pushed to l2-mtd.git, thanks! -- Best Regards, Ar

Re: [PATCH] mtd: fix random pointer dereference in OF device name handling

2013-02-04 Thread Artem Bityutskiy
On Wed, 2013-01-23 at 13:59 -0500, Paul Gortmaker wrote: > Here is the output from an mpc8548 based board. There are > three instances of missing device name here: A similar fix is already in the linux-mtd.git tree. -- Best Regards, Artem Bityutskiy signature.asc Description: Thi

Re: [PATCH] mtd: devices: elm: Removes literals in elm DT node

2013-02-04 Thread Artem Bityutskiy
On Thu, 2013-01-24 at 12:23 +0530, Philip Avinash wrote: > As part of removing generalized dependency, replace literal fields > in DT compatible field with <52> for am335x platforms. > > Signed-off-by: Philip Avinash Pushed to l2-mtd.git, thanks! -- Best Regards

Re: [PATCH v2 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-04 Thread Artem Bityutskiy
xt when bottom-posting - this would be a lot mailing-list-friendly. > -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: map: BUG() in non handled cases

2013-02-04 Thread Artem Bityutskiy
#x27;s just add a (correct) BUG() to the default case on those maps. This > will also allow us to catch potential errors in maps setup in future. > > Signed-off-by: Dmitry Eremin-Solenikov Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is

Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}

2013-02-12 Thread Artem Bityutskiy
buy you adding another "0" to all the entries? I see you add another table, which you look up if the "traditional" table does not work. Why you need to add these zeroes? -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubs

[GIT PULL] UBIFS changes for 3.9-rc6

2013-04-04 Thread Artem Bityutskiy
remounted R/W. Artem Bityutskiy (1): UBIFS: make space fixup work in the remount case fs/ubifs/super.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) -- Best Regards, Artem Bityutskiy -- To

Re: [PATCH 1/1] mtd: physmap_of: fix illegal dereference

2013-02-01 Thread Artem Bityutskiy
d-off-by: Stef van Os A similar fix already sits in the mtd tree: http://git.infradead.org/mtd-2.6.git/commit/7dfe4be351e81656ca1068e5d4ead235c7ba94b1 -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

[GIT PULL] UBIFS changes for 3.9-rc1

2013-02-25 Thread Artem Bityutskiy
8 fs/ubifs/lpt_commit.c | 14 +++--- fs/ubifs/orphan.c | 12 ++-- fs/ubifs/tnc_commit.c |2 +- fs/ubifs/ubifs.h |6 +- 5 files changed, 27 insertions(+), 15 deletions(-) -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: sen

Re: [PATCH RFC 4/5] UBIFS: Add security.* XATTR support for the UBIFS

2013-02-21 Thread Artem Bityutskiy
&ubifs_initxattrs, 0); > + mutex_unlock(&inode->i_mutex); I did not verify, but I doubt that you need i_mutex here, because you only call this function when you create an inode, before it becomes visible to VFS. Please, double-check this. Thanks!

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-12 Thread Artem Bityutskiy
+ err = check_free_space(c); if (err) goto out; @@ -1684,12 +1690,6 @@ static int ubifs_remount_rw(struct ubifs_info *c) err = dbg_check_space_info(c); } - if (c->space_fixup) { - err = ubifs_fixup_free_space(c); - i

Re: [PATCH V4 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-13 Thread Artem Bityutskiy
rchitectures, which seems to be unnecessarily big. Wouldn't 'unsigned int' be enough? Also, can we avoid having the 'id_len' field? Can the end of the sequence of ID's be marked with a '0' or '0xFF' marker instead? -- Best Regards, Arte

Re: [PATCH V4 2/3] mtd: add 4 Toshiba nand chips for the full-id case

2013-03-13 Thread Artem Bityutskiy
}, > + SZ_8K, SZ_4K, SZ_1M, 0, 8, 640}, > + {"TC58NVG6D2 64G 3.3V 8-bit", > + { .id = {0x98, 0xde, 0x94, 0x82, 0x76, 0x56, 0x04, 0x20}}, > + SZ_8K, SZ_8K, SZ_2M, 0, 8, 640}, We need a useful comment above this block explaini

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-13 Thread Artem Bityutskiy
); > > return err; > > > > Sorry ... this just locks up the unit. Am I right that to reproduce it I need any image with the 'fixup' flag set, then I should put it on the flash, mount it R/O and then remount R/W. Right? -- Best Regards, Artem Bityutskiy -- To uns

Re: MTD: UBIFS: Kernel oops when fixing up free space

2013-03-13 Thread Artem Bityutskiy
> [2.724350] Code: e352 0a08 e59da008 e28a1003 (e5f1c001) > [2.730825] ---[ end trace 9593089b6ffc6663 ]--- Can you probably enable kallsyms so that we'd see the stackdump? -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH V4 1/3] mtd: add new fields to nand_flash_dev{}

2013-03-13 Thread Artem Bityutskiy
On Wed, 2013-03-13 at 21:04 +0800, Huang Shijie wrote: > On Wed, Mar 13, 2013 at 6:54 PM, Artem Bityutskiy > wrote: > > On Thu, 2013-03-07 at 18:49 +0800, Huang Shijie wrote: > >> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > >> index 591e

Re: [PATCH v5 0/3] mtd: use the full-id as the keyword for some nand chips

2013-03-14 Thread Artem Bityutskiy
ll the details - ask questions and validate the answers. Generally, good answers have correlation with quality code. You did provide good arguments thanks! If my rationally is not convincing enough and you think this is not over-engineering, let's have the ID length field. BTW, Huan

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
e problem 3. ubinize.cfg - is needed for 'reproduce.sh'. Thanks! >From a173f8e9296562e5ece3dd2936d799001897d6c6 Mon Sep 17 00:00:00 2001 From: Artem Bityutskiy Date: Thu, 14 Mar 2013 10:49:23 +0200 Subject: [PATCH] UBIFS: make space fixup work in the remount case The UBIFS space f

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 09:54 +, Mark Jackson wrote: > On 14/03/13 09:13, Artem Bityutskiy wrote: > > On Wed, 2013-03-13 at 11:12 +, Mark Jackson wrote: > >> Sorry ... this just locks up the unit. > > > > OK, I've reproduced the issue with 3.9-rc2 in nand

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
eration, and submits the buffer to the MTD layer for the I/O. If your NAND driver is trying to DMA this memory, you may be in trouble, because vmalloced memory is often not DMA-able on many systems, especially ARM systems which do not have coherent cache support. -- Best Regards, Art

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 12:02 +, Mark Jackson wrote: > But there's also a call to crc with a size of 122880 bytes, and that's > when the oops occurs. > This is when we do the atomic LEB change. > Is this size larger than the allocated buffer ? I believe so. -- Best Reg

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-14 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 14:18 +0200, Artem Bityutskiy wrote: > > Is this size larger than the allocated buffer ? > > I believe so. Err, I mean, the buffer is large enough. I do not believe there is a stupid bug like too small buffer. This code has worked for years and I do not think it

Re: linux-next: manual merge of the l2-mtd tree with the mtd tree

2013-03-15 Thread Artem Bityutskiy
from the mtd tree and > commit edac3311879c ("mtd: nand: remove AG-AND support") from the l2-mtd > tree. > > I fixed it up (see below) and can carry the fix as necessary (no action > is required). Thanks Stephen, please, carry this one so far, I'll rebase my tree soon. --

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-15 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 13:40 +, Mark Jackson wrote: > On 14/03/13 12:23, Artem Bityutskiy wrote: > > On Thu, 2013-03-14 at 14:18 +0200, Artem Bityutskiy wrote: > >>> Is this size larger than the allocated buffer ? > >> > >> I believe so. > > >

Re: MTD : Kernel oops when remounting ubifs as read/write

2013-03-15 Thread Artem Bityutskiy
On Thu, 2013-03-14 at 11:13 +0200, Artem Bityutskiy wrote: > On Wed, 2013-03-13 at 11:12 +, Mark Jackson wrote: > > Sorry ... this just locks up the unit. > > OK, I've reproduced the issue with 3.9-rc2 in nandsim, see the details > below. The patch I proposed did

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-29 Thread Artem Bityutskiy
do we really benefit from this? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-29 Thread Artem Bityutskiy
uld we do when we meet a 1GB nand, and the cmdline is > gpmi-nand:100m(root),100m(kernel),1g(rootfs),1g(user),-(rest) Drop 'user' and 'rest' - I've sent some explanations in the previous e-mail. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-29 Thread Artem Bityutskiy
gt; use case I'd expect and intentionally wish to support. Sorry, I was not reading carefully enough. Could you please recap - are you fine with Huang's latest patch-set or not :) To me sorting and then dropping 0-size partitions looks like a simple and robust approach. -- Best Regards,

Re: [PATCH 3/3] mtd: cmdlinepart: fix the wrong partitions number when truncating occurs

2012-08-29 Thread Artem Bityutskiy
e > mtd0: 0640 0004 "boot" > mtd1: 0640 0004 "kernel" > mtd2: 3380 0004 "rootfs" > ------ > > We get the right result. > > Signed-off-by: Huang Shijie Should this have CC to -stable? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-08-31 Thread Artem Bityutskiy
hard to understand the cmdline. And also it is hard to sort the > partitions in this mixed type. So we explicitly forbid the mixed type. So "explicitly forbid" is just to add a "do not do this" comment? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/2] mtd/nand/omap2: fix omap_nand_remove segfault

2012-08-31 Thread Artem Bityutskiy
; This patch fixes following error when unloading the omap2 module: Added "Cc: sta...@vger.kernel.org" to both patches and pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions

2012-08-31 Thread Artem Bityutskiy
essage does not sound convincing, it does not explain why sorting is the right way to fix the issue, and what would be the alternatives. It actually also does not explain why exactly we currently cannot parse the example string. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2] mtd: cmdlinepart: fix the wrong check condition

2012-09-02 Thread Artem Bityutskiy
strcmp(part->mtd_id, mtd_id))) > > + if (!strcmp(part->mtd_id, mtd_id)) > > { > > for(i = 0, offset = 0; i < part->num_parts; i++) > > { > > This changes the behavior of cmdling parsing, whic

Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict

2012-09-03 Thread Artem Bityutskiy
. Add sorting 2. Add a check that partitions do not overlap and there is only one offset-less partition. How does this sound? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 2/3] mtd: cmdlinepart: sort the unsorted partitions

2012-09-03 Thread Artem Bityutskiy
if (parts[j - 1].offset > parts[j].offset) { > + struct mtd_partition tmp; > + > + tmp = parts[j - 1]; > + parts[j - 1] = parts[j]; > + parts[j] = tmp; > + }

[GIT PULL] UBI fix for v3.6-rc5

2012-09-03 Thread Artem Bityutskiy
ses. Now we fix this by using 'kmem_cache_free()' instead. -------- Artem Bityutskiy (1): UBI: fix a horrible memory deallocation bug drivers/mtd/ubi/vtbl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --

Re: RCU warning during UBI file system mount

2012-09-04 Thread Artem Bityutskiy
t; [4.28] [] (kernel_init+0x16c/0x1b4) from [] > (kernel_thread_exit+0x0/0x8) > [4.28] ---[ end trace 4d36b722759fdc4f ]--- > [4.95] UBIFS DBG (pid 58): ubifs_bg_thread: background thread > "ubifs_bgt0_0" started, PID 58 > > -Subodh > > __ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 3/4] drivers/mtd/maps/autcpu12-nvram.c: drop frees of devm_ alloc'd data

2012-09-04 Thread Artem Bityutskiy
On Sat, 2012-09-01 at 18:33 +0200, Julia Lawall wrote: > From: Julia Lawall > > devm free functions should not have to be explicitly used. > > A semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) Pushed to l2-mtd.git, thanks! -- B

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Artem Bityutskiy
; - mpc5121_nfc_free(dev, mtd); > + clk_disable(prv->clk); > return retval; > } > > @@ -857,8 +833,7 @@ static int __devexit mpc5121_nfc_remove(struct > platform_device *op) > struct mpc5121_nfc_prv *prv = chip->priv; > > nand_release(mtd); > - devm_free_irq(dev, prv->irq, mtd); > - mpc5121_nfc_free(dev, mtd); > + clk_disable(prv->clk); > > return 0; > } > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 4/4] drivers/mtd/nand/mpc5121_nfc.c: some devm_ cleanups

2012-09-04 Thread Artem Bityutskiy
mon as kzalloc, ioremap, etc. It looks like Lars is going to fix this. I am personally fine if you send patches without build-testing them. Your patches are generally of good quality and you send many of them, so build-testing each would be too much for you. And at least for MTD, I can build-test

Re: [PATCH] clk: Make the managed clk functions generically available

2012-09-11 Thread Artem Bityutskiy
gt; Ok, what's the plan? Should I add this patch to the patch tracker? I'd propose to send it to Linus for v3.6 even. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

[GIT PULL] UBI changes for 3.7-rc1

2012-10-02 Thread Artem Bityutskiy
nd a number of cleanups. -------- Artem Bityutskiy (7): UBI: print image sequence number as unsigned integer UBI: print PID in debug messages arm: sam9_l9260_defconfig: correct CONFIG_MTD_UBI_BEB_LIMIT UBI: fix autoresize handling in R/O mode UBI: comply with coding s

[GIT PULL] UBIFS changes for 3.7-rc1

2012-10-02 Thread Artem Bityutskiy
cleanups Artem Bityutskiy (8): UBIFS: print PID in debug messages UBIFS: always print full error reports UBIFS: improve scanning debug output UBIFS: fix power cut emulation for mtdram UBIFS: use __aligned

Re: [GIT PULL] UBI changes for 3.7-rc1

2012-10-02 Thread Artem Bityutskiy
On Tue, 2012-10-02 at 16:35 +0300, Artem Bityutskiy wrote: > Hi Linus, > > please, pull UBI changes. > > The following changes since commit 4cbe5a555fa58a79b6ecbb6c531b8bab0650778d: > > Linux 3.6-rc4 (2012-09-01 10:39:58 -0700) > > are available in the git reposit

Re: linux-next: build failure after merge of the ubi tree

2012-10-03 Thread Artem Bityutskiy
ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined! > ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined! I've added Richard's fastmap work there. I'll look at these failures. And yes, using the previous ubi tree is a good decision, thanks! -- Best Regards

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
; [smatch] +drivers/mtd/ubi/fastmap.c:959:3-5: ERROR: reference preceded by free on line 919 [coccinelle] +drivers/mtd/ubi/fastmap.c:967 ubi_scan_fastmap() error: double free of 'fm' [smatch] +drivers/mtd/ubi/fastmap.c:967:9-11: ERROR: reference preceded by free on line 919 [coccinelle] +drivers/mtd/ubi/fastmap.c:976 ubi_scan_fastmap() error: double free of 'fm' [smatch] +drivers/mtd/ubi/fastmap.c:976:9-11: ERROR: reference preceded by free on line 919 [coccinelle] +drivers/mtd/ubi/fastmap.c:988 ubi_scan_fastmap() error: double free of 'fm' [smatch] +drivers/mtd/ubi/fastmap.c:988:10-12: ERROR: reference preceded by free on line 919 [coccinelle] @@ @@ +drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle] checkpatch.pl has some complaints: checkpatch.pl results for patch "[PATCH 07/10] UBI: Add fastmap stuff to attach.c" WARNING:LONG_LINE: line over 80 characters #115: FILE: drivers/mtd/ubi/attach.c:1008: + ubi_msg("\"delete\" compatible internal volume %d:%d found, will remove it", total: 0 errors, 1 warnings, 550 lines checked checkpatch.pl results for the entire squashed patch-set WARNING:LONG_LINE: line over 80 characters #987: FILE: drivers/mtd/ubi/attach.c:1008: + ubi_msg("\"delete\" compatible internal volume %d:%d found, will remove it", total: 0 errors, 1 warnings, 3708 lines checked -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote: > Am Wed, 03 Oct 2012 11:25:45 +0300 > schrieb Artem Bityutskiy : > > > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: > > > UBI Fastmap is an optional feature which stores the physical to

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote: > Am Wed, 03 Oct 2012 11:25:45 +0300 > schrieb Artem Bityutskiy : > > > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: > > > UBI Fastmap is an optional feature which stores the physical to

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
error handling in that function separately. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote: > Am Wed, 03 Oct 2012 11:25:45 +0300 > schrieb Artem Bityutskiy : > > > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: > > > UBI Fastmap is an optional feature which stores the physical to

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
On Wed, 2012-10-03 at 14:05 +0300, Artem Bityutskiy wrote: > On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote: > > Am Wed, 03 Oct 2012 11:25:45 +0300 > > schrieb Artem Bityutskiy : > > > > > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote: >

Re: UBI: Fastmap request for inclusion (v19)

2012-10-03 Thread Artem Bityutskiy
On Wed, 2012-10-03 at 14:05 +0300, Artem Bityutskiy wrote: > ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined! > ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined! > ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined! >

Re: [PATCH] mtd: gpmi: remove unneccessary header

2012-10-26 Thread Artem Bityutskiy
.h:99: error: #error Unknown data abort handler type In file included from arch/arm/kernel/asm-offsets.c:18: /home/dedekind/git/l2-mtd/arch/arm/include/asm/glue-pf.h:54: error: #error Unknown prefetch abort handler type make[1]: *** [arch/arm/kernel/asm-offsets.s] Error 1 make: *** [prepare0] Error

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-12 Thread Artem Bityutskiy
hortly. Please, note that my e-mail address is not [EMAIL PROTECTED], see MAINTAINERS. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: UBI: add mtd_num sysfs attribute

2008-02-12 Thread Artem Bityutskiy
Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT-PULL] UBI updates

2008-02-12 Thread Artem Bityutskiy
Linus, please pull from git://git.infradead.org/~dedekind/ubi-2.6.git master to receive few UBI updates and fixes. Artem Bityutskiy (2): Documentation: add UBI sysfs ABI docs UBI: be verbose when debuggin is enabled S.Çağlar Onur (1): UBI: silence warning Documentation/ABI

Re: [GIT-PULL] UBI updates

2008-02-13 Thread Artem Bityutskiy
Artem Bityutskiy wrote: Linus, please pull from git://git.infradead.org/~dedekind/ubi-2.6.git master to receive few UBI updates and fixes. Artem Bityutskiy (2): Documentation: add UBI sysfs ABI docs UBI: be verbose when debuggin is enabled S.Çağlar Onur (1): UBI: silence

RE: Abnormal behavior with JFFS2 on latest kernel

2008-02-15 Thread Artem Bityutskiy
h latest kernel. No, in opposite, we have not changed it yet. The old calls were not removed from VFS and will be kept there for few releases. So we still use them - this helps to use the same UBIFS sources for older kernels. But later we'll switch to newer calls which are in fact much better for UB

Re: [PATCH 15/16] gfs2: nuke pdflush from comments

2012-07-26 Thread Artem Bityutskiy
ven, thanks, I think it is better if the whole patch-set goes in via Al Viro's tree. > -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/5] ubi: introduce ubi->bad_peb_limit

2012-07-30 Thread Artem Bityutskiy
On Thu, 2012-07-19 at 09:16 +0300, Shmulik Ladkani wrote: > On Wed, 18 Jul 2012 13:40:53 +0300 Artem Bityutskiy > wrote: > > I've also amended the Kconfig text a tiny bit and dropped the defconfig > > changes - let's have them separately as a single patch

Re: [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation

2012-07-30 Thread Artem Bityutskiy
difications in commentaries and messages and I think in variables declaration section, nothing else. I'll send you the patches separately. Thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework

2012-09-24 Thread Artem Bityutskiy
On Fri, 2012-09-07 at 18:39 +, Karicheri, Muralidharan wrote: > subsystem owner, > > Could you please review and apply this patch as needed? We need to get > this upstream before submitting the patch for Common clock framework > support for mach-davinci. If I need to follow a specific procedur

Re: [PATCH] mtd/nand/docg4: Add missing HAS_IOMEM dependency

2012-09-26 Thread Artem Bityutskiy
it-function-declaration] Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 01/10] UBI: Add fastmap on-flash data structures

2012-09-26 Thread Artem Bityutskiy
a. Despite a lot of testing you have already done, I am willing to do some testing myself as well, so I'll do c. and d. and let you know if there are issues. Could you please do b. ? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: UBI: Fastmap request for inclusion (v18)

2012-09-26 Thread Artem Bityutskiy
ameter to enable fastmap " +"automatically on images without a fastmap."); total: 0 errors, 1 warnings, 133 lines checked checkpatch.pl results for patch "[PATCH 07/10] UBI: Add fastmap stuff to attach.c" WARNING:SPLIT_STRING: quoted string split across lines #113: FILE: drivers/mtd/ubi/attach.c:1009: + ubi_msg("\"delete\" compatible internal volume" + " %d:%d found, will remove it", total: 0 errors, 1 warnings, 535 lines checked checkpatch.pl results for the entire squashed patch-set WARNING:SPLIT_STRING: quoted string split across lines #794: FILE: drivers/mtd/ubi/build.c:1469: +MODULE_PARM_DESC(fm_autoconvert, "Set this parameter to enable fastmap " +"automatically on images without a fastmap."); WARNING:SPLIT_STRING: quoted string split across lines #996: FILE: drivers/mtd/ubi/attach.c:1009: + ubi_msg("\"delete\" compatible internal volume" + " %d:%d found, will remove it", total: 0 errors, 2 warnings, 3712 lines checked -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: use the NAND_STATUS_FAIL to replace the hardcode

2012-10-26 Thread Artem Bityutskiy
On Sun, 2012-10-14 at 23:47 -0400, Huang Shijie wrote: > Use the NAND_STATUS_FAIL to replace the hardcode "0x01", > which make the code more readable. > > Signed-off-by: Huang Shijie Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Artem Bityutskiy
ed-off-by: Richard Weinberger What is pool size, I wonder? -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Artem Bityutskiy
On Thu, 2013-10-03 at 17:08 +0200, Richard Weinberger wrote: > Am 03.10.2013 17:00, schrieb Artem Bityutskiy: > > On Sat, 2013-09-28 at 15:55 +0200, Richard Weinberger wrote: > >> If no free PEBs are available refill_wl_user_pool() must not > >> return with -ENOSPC

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Artem Bityutskiy
On Thu, 2013-10-03 at 17:53 +0200, Richard Weinberger wrote: > Am 03.10.2013 17:27, schrieb Artem Bityutskiy: > > On Thu, 2013-10-03 at 17:08 +0200, Richard Weinberger wrote: > >> Am 03.10.2013 17:00, schrieb Artem Bityutskiy: > >>> On Sat, 2013-09-28 at 15:55 +

Re: [PATCH 1/7] UBI: fix refill_wl_user_pool()

2013-10-03 Thread Artem Bityutskiy
On Thu, 2013-10-03 at 18:35 +0200, Richard Weinberger wrote: > Am 03.10.2013 18:00, schrieb Artem Bityutskiy: > > On Thu, 2013-10-03 at 17:53 +0200, Richard Weinberger wrote: > >> Am 03.10.2013 17:27, schrieb Artem Bityutskiy: > >>> On Thu, 2013-10-03 at 17:08 +

Re: UBI fastmap updates

2013-10-03 Thread Artem Bityutskiy
really fastmap specific and touches generic > UBI code, "UBI: simplify image sequence test". > Pushed to linux-ubi, thanks! -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

[GIT PULL] UBIFS changes for 3.12-rc1

2013-09-16 Thread Artem Bityutskiy
changed, 4 insertions(+), 3 deletions(-) -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

[GIT PULL] UBI changes for 3.12-rc1

2013-09-16 Thread Artem Bityutskiy
c | 3 +++ 2 files changed, 4 insertions(+), 4 deletions(-) -- Best Regards, Artem Bityutskiy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [GIT PULL] UBI changes for 3.12-rc1

2013-09-16 Thread Artem Bityutskiy
On Mon, 2013-09-16 at 10:30 +0300, Artem Bityutskiy wrote: > Hi Linus, > > very few changes. I'll start using a single UBI/UBIFS tree instead > of 2 trees from now on. So in the future you'll get 1 small pull > request instead of 2 tiny ones. Also, I do realize this is

[GIT PULL] UBI fastmap for 3.7-rc1

2012-10-08 Thread Artem Bityutskiy
++ drivers/mtd/ubi/ubi-media.h | 137 + drivers/mtd/ubi/ubi.h | 118 ++- drivers/mtd/ubi/wl.c| 599 ++- 10 files changed, 2790 insertions(+), 211 deletions(-) create

Re: [PATCH 1/2] mtd: remove the de-select chip code in nand_release_device()

2012-11-30 Thread Artem Bityutskiy
lected. > > To make the balance of select/de-select chip, it's better to remove the > de-select chip code in nand_release_device() which makes the code more > clear. > > Signed-off-by: Huang Shijie Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signatur

Re: [RFC/PATCH 0/1] ubi: Add ubiblock driver

2012-11-30 Thread Artem Bityutskiy
ease(). Is it per-block device? Then I am not sure it is a good idea to automatically create them for every volume... -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [RFC/PATCH 1/1] ubi: Add ubiblock driver

2012-11-30 Thread Artem Bityutskiy
could: 1. ignore I/O barriers 2. use plain leb_unmap/leb_write instead of atomic leb change, which is faster. There could be a switch, probably an ioctl? But this is not very important now, I am just throwing an idea. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a

Re: [RFC/PATCH 0/1] ubi: Add ubiblock driver

2012-11-30 Thread Artem Bityutskiy
on top > of > flashes, even through UBI, is a good idea. Why not? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 3/3] mtd: nand: omap2: Support for hardware BCH error correction

2012-11-30 Thread Artem Bityutskiy
> + if (flip_bits > info->nand.ecc.strength) > + return 0; > + } Why do you need the second for loop? -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc

2012-11-30 Thread Artem Bityutskiy
buffer with 0xFFs. Right? > -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

[GIT PULL] UBI changes for 3.7-rc9

2012-12-04 Thread Artem Bityutskiy
hanged, 16 insertions(+), 10 deletions(-) -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: linux-next: build failure after merge of the l2-mtd tree

2012-10-18 Thread Artem Bityutskiy
"). > > > > I have used the l2-mtd tree from next-20121011 for today. > > This is still broken today. Sorry for slowness, now it should be fixed. -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 1/2] mtd: mxc_nand: fix unbalanced clk_disable() in error path

2012-12-10 Thread Artem Bityutskiy
led. > > This fixes a: > |WARNING: at drivers/clk/clk.c:472 __clk_disable+0x3c/0x78() Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH 2/2] mtd: mxc_nand: reorder part_probes to let cmdline override other sources

2012-12-10 Thread Artem Bityutskiy
ort > 'cmdlinepart' partition parsing. Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: gpmi: remove unneccessary header

2012-11-12 Thread Artem Bityutskiy
On Fri, 2012-11-09 at 20:39 -0500, Huang Shijie wrote: > Could you re-create your mxs config with "make ARCH=ARM > mxs_defconfig", and test this patch again? Done, works now, pushed your patch to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Descri

Re: [PATCH 074/193] drivers/mtd/devices: remove CONFIG_EXPERIMENTAL

2012-11-12 Thread Artem Bityutskiy
On Tue, 2012-10-23 at 13:02 -0700, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: David Woodhouse > CC: Artem Bityutskiy > CC: Robert

Re: [PATCH 074/193] drivers/mtd/devices: remove CONFIG_EXPERIMENTAL

2012-11-13 Thread Artem Bityutskiy
On Mon, 2012-11-12 at 08:43 -0800, Kees Cook wrote: > On Mon, Nov 12, 2012 at 7:36 AM, Artem Bityutskiy wrote: > > On Tue, 2012-10-23 at 13:02 -0700, Kees Cook wrote: > >> This config item has not carried much meaning for a while now and is > >> almost always enabled b

Re: [PATCH 074/193] drivers/mtd/devices: remove CONFIG_EXPERIMENTAL

2012-11-14 Thread Artem Bityutskiy
On Tue, 2012-11-13 at 09:58 -0800, Kees Cook wrote: > Cool, great. I CCed you on a few of the patches in the series; should > I just push this one mtd, or all the ones that you're CCed on? Please, carry all those touching "drivers/mtd" of them in your tree, thanks! --

Re: [PATCH v2 0/3] mtd: nand: OMAP: ELM error correction support for BCH ecc

2012-11-15 Thread Artem Bityutskiy
ed on [1] and tested with RFC: OMAP GPMC bindings > patch series > > 1. linux-next/20121030 Would you please re-send a version which cleanly applies to the l2-mtd.git tree? This series has many conflicts. Thanks! git://git.infradead.org/users/dedekind/l2-mtd.git -- Best Regards, Artem B

Re: [PATCH] mtd: map: Fix compilation warning

2012-11-15 Thread Artem Bityutskiy
t might be > passed > uninitialized. Better initialize to zero. Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [PATCH] mtd: cmdlinepart: fix the overflow of big mtd partitions

2012-11-15 Thread Artem Bityutskiy
, > and replaces the UINT_MAX with ULLONG_MAX for macros SIZE_REMAINING and > OFFSET_CONTINUOUS. > > Signed-off-by: Huang Shijie Pushed to l2-mtd.git, thanks! -- Best Regards, Artem Bityutskiy signature.asc Description: This is a digitally signed message part

Re: [RESEND PATCH] mtd: davinci: add support for parition binding nodes

2012-11-15 Thread Artem Bityutskiy
On Fri, 2012-11-02 at 10:22 -0400, Murali Karicheri wrote: > Enhance the driver to support partition subnodes inside the nand > device bindings to describe partions on the nand device. > > Signed-off-by: Murali Karicheri Pushed to l2-mtd.git, thanks! -- Best Regards, Arte

[GIT PULL] UBIFS changes for 3.7-rc6

2012-11-15 Thread Artem Bityutskiy
. Artem Bityutskiy (2): UBIFS: introduce categorized lprops counter UBIFS: fix mounting problems after power cuts fs/ubifs/find.c | 12 ++-- fs/ubifs/lprops.c |6 ++ fs/ubifs/ubifs.h |3 +++ 3 files changed, 19 insertions(+), 2 deletions

[PATCH] proc: pid/status: show all supplementary groups

2012-11-09 Thread Artem Bityutskiy
From: Artem Bityutskiy We display a list of supplementary group for each process in the /proc//status. However, we show only the first 32 groups, not all of them. Although this is rare, but sometimes processes do have more than 32 supplementary groups, and this kernel limitation breaks user

Re: [PATCH] mtd: gpmi: remove unneccessary header

2012-11-09 Thread Artem Bityutskiy
On Sat, 2012-10-27 at 10:23 +0800, Huang Shijie wrote: > 于 2012年10月26日 21:41, Artem Bityutskiy 写道: > > On Sat, 2012-10-13 at 13:03 -0400, Huang Shijie wrote: > > > The whole gpmi-nand driver has turned to pure devicetree supported. > > > So the linux/mtd/gpmi-nand.h

  1   2   3   4   5   6   7   8   9   >