On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: > Assume we have a 1GB(8Gb) nand chip. > It is legit if we set the partitions as the following: > gpmi-nand:1g@200m(rootfs),100m@0(boot),100m@100m(kernel) > > But the current code can not parse out any partition with this > cmdline. > > This patch sorts the unsorted partitions by the @offset. > For there are maybe only several partitions, i use the simple > Bubble sort algorithm. > > Signed-off-by: Huang Shijie <shij...@gmail.com>
I still cannot find time to actually think about this carefully, but the commit message does not sound convincing, it does not explain why sorting is the right way to fix the issue, and what would be the alternatives. It actually also does not explain why exactly we currently cannot parse the example string. -- Best Regards, Artem Bityutskiy
signature.asc
Description: This is a digitally signed message part