On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: > + * > + * Note: > + * If you choose to set the @offset for the <partdef>, please set all > + * the partitions with the same syntax, such as: > + * gpmi-nand:100m@0(boot),100m@100m(kernel),1g@200m(rootfs) > + * > + * Please do _NOT_ set the partitions like this: > + * gpmi-nand:100m@0(boot),100m(kernel),1g@200m(rootfs) > + * The `kernel` partition does not set with the @offset, this is not > permitted. > */
I guess it is indeed OK to sort the partitions, just makes things a lot simpler. But we probably then should also do the following: 1. Make sure there is only one partition without offset. If there are several - error out. 2. Check that partitions do not intersect - I did not notice that we do this in the code. So AFAICS, this patch is not needed and we better have the following patches: 1. Add sorting 2. Add a check that partitions do not overlap and there is only one offset-less partition. How does this sound? -- Best Regards, Artem Bityutskiy
signature.asc
Description: This is a digitally signed message part
