When a resource table is loaded by an external entity such as U-boot or
OP-TEE, we do not necessary get the device address(da) but the physical
address(pa).
This helper performs similar translation than the rproc_da_to_va()
but based on a physical address.
Signed-off-by: Arnaud Pouliquen
application.
Signed-off-by: Arnaud Pouliquen
---
update from V
- Fix missing "{" in tee_rproc_find_loaded_rsc_table inline definition.
update from V5
- make tee_rproc_get_loaded_rsc_table() local and replace this API by
tee_rproc_find_loaded_rsc_table()
- map and unmap the resourc
Hi,
On 6/19/24 17:41, Mathieu Poirier wrote:
> Hi,
>
> On Tue, Jun 11, 2024 at 09:39:01AM +0200, Arnaud Pouliquen wrote:
>> Add a remoteproc TEE (Trusted Execution Environment) driver
>> that will be probed by the TEE bus. If the associated Trusted
>> application is su
When a resource table is loaded by an external entity such as U-boot or
OP-TEE, we do not necessarily get the device address(da) but the physical
address(pa).
This helper performs similar translation than the rproc_da_to_va()
but based on a physical address.
Signed-off-by: Arnaud Pouliquen
age format defined by the TEE.
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/stm32_rproc.c | 63 ++--
1 file changed, 60 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index 8cd838df4e92..fd905b3cf
application.
Signed-off-by: Arnaud Pouliquen
---
Updates vs previous version:
- rename tee_remoteproc.* file to rmeoteproc_tee.*,
- rename TEE_REMOTEPROC config to REMOTEPROC_TEE,
- remove "stm32" in some variable declarations,
- remove useless "remoteproc_internal.h" include,
To prepare for the support of TEE remoteproc, create sub-functions
that can be used in both cases, with and without remoteproc TEE support.
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/stm32_rproc.c | 84 +++-
1 file changed, 51 insertions(+), 33 deletions
o specify the remote processor.
Signed-off-by: Arnaud Pouliquen
Reviewed-by: Rob Herring (Arm)
---
.../bindings/remoteproc/st,stm32-rproc.yaml | 58 ---
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.ya
tween the presentation
and the integration in OP-TEE).
https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds
Arnaud Pouliquen (5):
remoteproc: core: Introduce rproc_pa_to_va helper
remoteproc: Add TEE support
dt-bindings: remoteproc: Add compatibility for TEE support
remoteproc:
Hello Mathieu
On 7/2/24 18:44, Mathieu Poirier wrote:
> Good morning,
>
> On Fri, Jun 21, 2024 at 04:37:56PM +0200, Arnaud Pouliquen wrote:
>> Add a remoteproc TEE (Trusted Execution Environment) driver
>> that will be probed by the TEE bus. If the associated Trusted
>&g
On 7/3/24 17:14, Mathieu Poirier wrote:
> On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote:
>> Hello Mathieu
>>
>> On 7/2/24 18:44, Mathieu Poirier wrote:
>>> Good morning,
>>>
>>> On Fri, Jun 21, 2024 at 04:37:56PM +0200, A
On 7/4/24 17:32, Mathieu Poirier wrote:
> On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote:
>>
>>
>> On 7/3/24 17:14, Mathieu Poirier wrote:
>>> On Wed, Jul 03, 2024 at 09:19:44AM +0200, Arnaud POULIQUEN wrote:
>>>> Hello Mathieu
>&g
On 7/8/24 17:43, Mathieu Poirier wrote:
> On Fri, Jul 05, 2024 at 09:33:55AM +0200, Arnaud POULIQUEN wrote:
>>
>>
>> On 7/4/24 17:32, Mathieu Poirier wrote:
>>> On Thu, Jul 04, 2024 at 10:05:24AM +0200, Arnaud POULIQUEN wrote:
>>>>
>>>>
>
as evolved between the presentation
and the integration in OP-TEE).
https://resources.linaro.org/en/resource/6c5bGvZwUAjX56fvxthxds
Arnaud Pouliquen (7):
remoteproc: core: Introduce rproc_pa_to_va helper
remoteproc: Add TEE support
remoteproc: core: Refactor resource table cl
When a resource table is loaded by an external entity such as U-boot or
OP-TEE, we do not necessarily get the device address(da) but the physical
address(pa).
This helper performs similar translation than the rproc_da_to_va()
but based on a physical address.
Signed-off-by: Arnaud Pouliquen
To prepare for the support of TEE remoteproc, create sub-functions
that can be used in both cases, with and without remoteproc TEE support.
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/stm32_rproc.c | 84 +++-
1 file changed, 51 insertions(+), 33 deletions
application.
Signed-off-by: Arnaud Pouliquen
---
Updates vs previous version:
- add TA_RPROC_CMD_RELEASE_FW TEE command support to release firmware resources,
- add tee_rproc_release_fw() API that will be called by the remoteproc core,
- release the firmware resources in case of error in
age format defined by the TEE.
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/stm32_rproc.c | 63 ++--
1 file changed, 60 insertions(+), 3 deletions(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index 79c638936163..400a7a93b
.
- When rproc_release_fw is called on error or after stopping the remote
processor.
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/remoteproc_core.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c
b/drivers/remoteproc
o specify the remote processor.
Signed-off-by: Arnaud Pouliquen
Reviewed-by: Rob Herring (Arm)
---
.../bindings/remoteproc/st,stm32-rproc.yaml | 58 ---
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/st,stm32-rproc.ya
This patch centralizing the cleanup of the resource table into a new
helper function rproc_release_fw().
Suggested-by: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/remoteproc/remoteproc_core.c | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff
On 8/31/24 18:43, kernel test robot wrote:
> Hi Arnaud,
>
> kernel test robot noticed the following build warnings:
>
> [auto build test WARNING on 5be63fc19fcaa4c236b307420483578a56986a37]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Arnaud-P
Hello Mathieu,
On 9/13/24 18:03, Mathieu Poirier wrote:
> On Fri, Aug 30, 2024 at 11:51:47AM +0200, Arnaud Pouliquen wrote:
>> The new TEE remoteproc driver is used to manage remote firmware in a
>> secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is
>
Hi Mathieu,
On 2/12/21 12:46 AM, Mathieu Poirier wrote:
> Add a new get_loaded_rsc_table() operation in order to support
> scenarios where the remoteproc core has booted a remote processor
> and detaches from it. When re-attaching to the remote processor,
> the core needs to know where the resour
has changed when re-attaching to the remote
> processor.
>
> Reported-by: Arnaud POULIQUEN
> Signed-off-by: Mathieu Poirier
> ---
> drivers/remoteproc/remoteproc_core.c | 70 ++
> drivers/remoteproc/remoteproc_elf_loader.c | 24 +
On 4/9/21 3:59 AM, Chen Lifu wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot
> Signed-off-by: Chen Lifu
Reviewed-by
Hello Chris,
On 04/27/2018 12:59 AM, Chris Lew wrote:
> In RPMSG GLINK the chrdev device will allocate an ept as part of the
> rpdev creation. This device will not register endpoint ops even though
> it has an allocated ept. Protect against the case where the device is
> being destroyed.
>
> Sign
On 04/30/2018 10:36 AM, Arnaud Pouliquen wrote:
> Hello Chris,
>
> On 04/27/2018 12:59 AM, Chris Lew wrote:
>> In RPMSG GLINK the chrdev device will allocate an ept as part of the
>> rpdev creation. This device will not register endpoint ops even though
>> it ha
Hello Alex
We have the same needs (prepare unprepare steps) on our platform. We
tested you core patches and they answers to our need.
Just a remark below
On 05/15/2018 10:53 PM, Alex Elder wrote:
> Rename functions used when subdevices are started and stopped to
> reflect the new naming scheme.
Hello Alex,
On 05/15/2018 10:53 PM, Alex Elder wrote:
> From: Bjorn Andersson
>
> On rare occasions a subdevice might need to prepare some hardware
> resources before a remote processor is booted, and clean up some
> state after it has been shut down.
>
> One such example is the IP Accelerator
On 05/29/2018 01:51 PM, Alex Elder wrote:
> On 05/29/2018 04:16 AM, Arnaud Pouliquen wrote:
> . . .
>
>>> +unroll_preparation:
>>> + list_for_each_entry_continue_reverse(subdev, &rproc->subdevs, node) {
>>> + if (subdev->unprepare)
&g
Hi Fabien,
Please , could you add your "Tested-by" as you test it on ST platform?
Thanks
Arnaud
On 05/15/2018 10:53 PM, Alex Elder wrote:
> From: Bjorn Andersson
>
> On rare occasions a subdevice might need to prepare some hardware
> resources before a remote processor is booted, and clean up s
Hi Takashi,
On 04/17/2018 01:17 PM, Mark Brown wrote:
> On Tue, Apr 17, 2018 at 08:29:17AM +, Olivier MOYSAN wrote:
>
>> I guess the blocking patch in this patchset is the patch "add IEC958
>> channel status control helper". This patch has been reviewed several
>> times, but did not get a a
Hi Olivier,
On 03/13/2018 05:27 PM, Olivier MOYSAN wrote:
> Add support of iec958 controls for STM32 SAI.
>
> Signed-off-by: Olivier Moysan
> ---
> sound/core/pcm_iec958.c | 1 +
> sound/soc/stm/Kconfig | 1 +
> sound/soc/stm/stm32_sai_sub.c | 101
> +++
On 06/05/2018 08:29 PM, Takashi Iwai wrote:
> On Tue, 05 Jun 2018 17:50:57 +0200,
> Arnaud Pouliquen wrote:
>>
>> Hi Takashi,
>>
>> On 04/17/2018 01:17 PM, Mark Brown wrote:
>> > On Tue, Apr 17, 2018 at 08:29:17AM +, Olivier MOYSAN wrote:
>>
Hello Alex,
I have already proposed it few weeks ago.
https://lkml.org/lkml/2018/4/10/192
could you ack it, if you test it on your side?
Thanks,
Arnaud
On 04/25/2018 03:36 PM, Alex Elder wrote:
> The last commit to "remoteproc_core.c":
> 880f5b388252 remoteproc: eAPass type of shutdown to su
verify it.
If a transition is detected we consider that the DMA has switched to
the beginning of next sg.
Signed-off-by: Arnaud Pouliquen
Signed-off-by: Pierre-Yves MORDRET
---
drivers/dma/stm32-dma.c | 70 -
1 file changed, 57 insertions(+), 13
On 4/6/19 9:56 AM, xiang xiao wrote:
> On Sat, Apr 6, 2019 at 12:08 AM Arnaud Pouliquen
> wrote:
>>
>>
>>
>> On 4/5/19 4:03 PM, xiang xiao wrote:
>>> On Fri, Apr 5, 2019 at 8:33 PM Arnaud Pouliquen
>>> wrote:
>>>>
>>>>
&
On 4/8/19 3:29 PM, xiang xiao wrote:
> On Mon, Apr 8, 2019 at 8:05 PM Arnaud Pouliquen
> wrote:
>>
>>
>>
>> On 4/6/19 9:56 AM, xiang xiao wrote:
>>> On Sat, Apr 6, 2019 at 12:08 AM Arnaud Pouliquen
>>> wrote:
>>>>
>>>>
Add a description of the IOCTL and provide information on the default
value of the source and destination addresses.
Signed-off-by: Arnaud Pouliquen
---
include/uapi/linux/rpmsg.h | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/rpmsg.h b
To be coherent with the other functions which are prefixed by
rpmsg_chrdev, rename the rpmsg_char_init function.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg
To prepare the split code related to the control and the endpoint
devices in separate files:
- suppress the dependency with the rpmsg_ctrldev struct,
- rename and export the functions in rpmsg_char.h.
Suggested-by: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c
As the RPMSG_ADDR_ANY is a valid src or dst address that can be set by
user applications, migrate its definition in user API.
Signed-off-by: Arnaud Pouliquen
---
include/linux/rpmsg.h | 3 +--
include/uapi/linux/rpmsg.h | 2 ++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
The RPMsg control device is a RPMsg device, it is already
referenced in the RPMsg bus. There is only an interest to
reference the ept char devices in the rpmsg class.
This patch prepares the code split of the control and end point
devices in two separate files.
Signed-off-by: Arnaud Pouliquen
discussion thread: https://lkml.org/lkml/2021/2/4/194
Arnaud Pouliquen (16):
rpmsg: char: rename rpmsg_char_init to rpmsg_chrdev_init
rpmsg: move RPMSG_ADDR_ANY in user API
rpmsg: add short description of the IOCTL defined in UAPI.
rpmsg: char: export eptdev create an destroy functions
rpmsg
As driver is now the rpmsg_ioctl, rename the function.
In addition, initialize the rpdev addresses to RPMSG_ADDR_ANY as not
defined.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/qcom_glink_native.c | 2 +-
drivers/rpmsg/qcom_smd.c | 2 +-
drivers/rpmsg/rpmsg_ctrl.c| 2
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_glink_native.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index d4e4dd482614..ae2c03b59c55 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg
Move the code related to the rpmsg_ctrl char device to the new
rpmsg_ctrl.c module.
Manage the dependency in the kconfig.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/Kconfig | 9 ++
drivers/rpmsg/Makefile | 1 +
drivers/rpmsg/rpmsg_char.c | 163
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_smd.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 40a1c415c775..2d279c03a090 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -974,6 +974,20 @@ static
: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_ctrl.c | 21 +
include/uapi/linux/rpmsg.h | 5 +
2 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c
index 2e43b4096aa8..78c13816bfc6
Instantiate the rpmsg_ioctl device on virtio RPMsg bus creation.
This provides the possibility to expose the RPMSG_CREATE_EPT_IOCTL
to create RPMsg chdev endpoints.
Signed-off-by: Arnaud Pouliquen
---
V3:
Fix compilation issue
Reported-by: kernel test robot
Reported-by: Dan Carpenter
A RPMsg char device allows to probe the endpoint device on a remote name
service announcement. With this patch the /dev/rpmsgX interface is created
either by a user application or by the remote firmware.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 63
When the endpoint device is created by the application a destination
address as been specified in the rpmsg_channel_info structure.
Send the message to this address instead of the default one.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns
the rpmsg_eptdev context structure.
This patch prepares the introduction of a RPMsg device for the
char device. the RPMsg device will need a reference to the context.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg
on the back-end to potentially detect the error.
Without this patch for instance the GLINK driver return -EBUSY while
the virtio bus return -ENOSPC.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rpmsg/rpmsg_char.c b
Do not dynamically manage the default endpoint. The ept address must
not change.
This update is needed to manage the RPMSG_CREATE_DEV_IOCTL. In this
case a default endpoint is used and it's address must not change or
been reused by another service.
Signed-off-by: Arnaud Pouliquen
---
dr
Hi Dan,
On 2/18/21 1:27 PM, Dan Carpenter wrote:
> Hi Arnaud,
>
> url:
> https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-a-generic-IOCTL-interface-for-RPMsg-channels-management/20210217-214044
> base: https://git.kernel.org/pub/scm/linux/kernel/git/tor
Hi Dan,
On 2/18/21 1:33 PM, Dan Carpenter wrote:
> Hi Arnaud,
>
> url:
> https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/introduce-a-generic-IOCTL-interface-for-RPMsg-channels-management/20210217-214044
> base: https://git.kernel.org/pub/scm/linux/kernel/git/tor
To be coherent with the other functions which are prefixed by
rpmsg_chrdev, rename the rpmsg_char_init function.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg
Add a description of the IOCTL and provide information on the default
value of the source and destination addresses.
Signed-off-by: Arnaud Pouliquen
---
include/uapi/linux/rpmsg.h | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/rpmsg.h b
/rpmsgexport.git
Reference to the V4 discussion thread: https://lkml.org/lkml/2021/2/17/384
Arnaud Pouliquen (16):
rpmsg: char: rename rpmsg_char_init to rpmsg_chrdev_init
rpmsg: move RPMSG_ADDR_ANY in user API
rpmsg: add short description of the IOCTL defined in UAPI.
rpmsg: char: export eptdev
To prepare the split code related to the control and the endpoint
devices in separate files:
- suppress the dependency with the rpmsg_ctrldev struct,
- rename and export the functions in rpmsg_char.h.
Suggested-by: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c
As the RPMSG_ADDR_ANY is a valid src or dst address that can be set by
user applications, migrate its definition in user API.
Signed-off-by: Arnaud Pouliquen
---
include/linux/rpmsg.h | 3 +--
include/uapi/linux/rpmsg.h | 2 ++
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
As driver is now the rpmsg_ioctl, rename the function.
In addition, initialize the rpdev addresses to RPMSG_ADDR_ANY as not
defined.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/qcom_glink_native.c | 2 +-
drivers/rpmsg/qcom_smd.c | 2 +-
drivers/rpmsg/rpmsg_ctrl.c| 2
Move the code related to the rpmsg_ctrl char device to the new
rpmsg_ctrl.c module.
Manage the dependency in the kconfig.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/Kconfig | 9 ++
drivers/rpmsg/Makefile | 1 +
drivers/rpmsg/rpmsg_char.c | 163
The RPMsg control device is a RPMsg device, it is already
referenced in the RPMsg bus. There is only an interest to
reference the ept char devices in the rpmsg class.
This patch prepares the code split of the control and end point
devices in two separate files.
Signed-off-by: Arnaud Pouliquen
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_glink_native.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index d4e4dd482614..ae2c03b59c55 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg
Instantiate the rpmsg_ioctl device on virtio RPMsg bus creation.
This provides the possibility to expose the RPMSG_CREATE_EPT_IOCTL
to create RPMsg chdev endpoints.
Signed-off-by: Arnaud Pouliquen
---
V5:
Fix compilation issue
Reported-by: kernel test robot
Reported-by: Dan Carpenter
When the endpoint device is created by the application a destination
address as been specified in the rpmsg_channel_info structure.
Send the message to this address instead of the default one.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_smd.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 40a1c415c775..2d279c03a090 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -974,6 +974,20 @@ static
: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_ctrl.c | 21 +
include/uapi/linux/rpmsg.h | 5 +
2 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c
index 2e43b4096aa8..78c13816bfc6
Do not dynamically manage the default endpoint. The ept address must
not change.
This update is needed to manage the RPMSG_CREATE_DEV_IOCTL. In this
case a default endpoint is used and it's address must not change or
been reused by another service.
Signed-off-by: Arnaud Pouliquen
---
dr
A RPMsg char device allows to probe the endpoint device on a remote name
service announcement. With this patch the /dev/rpmsgX interface is created
either by a user application or by the remote firmware.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 65
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns
the rpmsg_eptdev context structure.
This patch prepares the introduction of a RPMsg device for the
char device. the RPMsg device will need a reference to the context.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg
on the back-end to potentially detect the error.
Without this patch for instance the GLINK driver return -EBUSY while
the virtio bus return -ENOSPC.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rpmsg/rpmsg_char.c b
On 2/2/21 11:42 PM, Mathieu Poirier wrote:
> On Tue, Feb 02, 2021 at 09:54:13AM +0100, Arnaud POULIQUEN wrote:
>>
>>
>> On 2/2/21 1:49 AM, Mathieu Poirier wrote:
>>> On Wed, Jan 27, 2021 at 10:21:24AM +0100, Arnaud POULIQUEN wrote:
>>>> Hi Mathieu
>
On 1/29/21 1:13 AM, Mathieu Poirier wrote:
> [...]
>
>>> It seems to me that the main point to step forward is to clarify the global
>>> design and features of the rpmsg-ctrl.
>>> Depending on the decision taken, this series could be trashed and rewritten
>>> from
>>> a blank page...To not los
On 2/2/21 1:49 AM, Mathieu Poirier wrote:
> On Wed, Jan 27, 2021 at 10:21:24AM +0100, Arnaud POULIQUEN wrote:
>> Hi Mathieu
>>
>> On 12/18/20 6:32 PM, Mathieu Poirier wrote:
>>> Following the work done here [1], this set provides support for the
>>&g
available here:
https://github.com/arnopo/rpmsgexport.git
Reference to the V2 discussion thread: https://lkml.org/lkml/2020/12/22/207
Arnaud Pouliquen (15):
rpmsg: char: rename rpmsg_char_init to rpmsg_chrdev_init
rpmsg: move RPMSG_ADDR_ANY in user API and document the API
rpmsg: char
Add a short description of the user IO controls. As the RPMSG_ADDR_ANY
is a valid src or dst address, migrate its definition to be
able to add it in description.
Signed-off-by: Arnaud Pouliquen
---
include/linux/rpmsg.h | 3 +--
include/uapi/linux/rpmsg.h | 13 +++--
2 files
To be coherent with the other functions which are prefixed by
rpmsg_chrdev, rename the rpmsg_chrdev_init function.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg
To prepare the split code related to the control and the endpoint
devices in separate files:
- suppress the dependency with the rpmsg_ctrldev struct,
- rename and export the functions in rpmsg_char.h.
Suggested-by: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c
Instantiate the rpmsg_ioctl device on virtio RPMsg bus creation.
This provides the possibility to expose the RPMSG_CREATE_EPT_IOCTL
to create RPMsg chdev endpoint.
Signed-off-by: Arnaud Pouliquen
---
V3:
Fix compilation issue
Reported-by: kernel test robot
Reported-by: Dan Carpenter
warnings
: Mathieu Poirier
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_ctrl.c | 21 +
include/uapi/linux/rpmsg.h | 5 +
2 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c
index f9b90e927fff..88eae475ef33
A RPMsg char device allows to probe the endpoint device on a remote name
service announcement. With this patch the /dev/rpmsgX interface is created
either by a user application or by the remote firmware.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 63
on the back-end to potentially detect the error.
Without this patch for instance the GLINK driver return -EBUSY while
the virtio bus return -ENOSPC.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/rpmsg/rpmsg_char.c b
Do not dynamically manage the default endpoint. The ept address must
not change.
This update is needed to manage the RPMSG_CREATE_DEV_IOCTL. In this
case a default endpoint is used and it's address must not change or
been reused by another service.
Signed-off-by: Arnaud Pouliquen
---
dr
When the endpoint device is created by the application a destination
address as been specified in the rpmsg_channel_info structure.
Send the message to this address instead of the default one.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/rpmsg_char.c | 4 ++--
1 file changed, 2 insertions
As driver is now the rpmsg_ioctl, rename the function.
In addition, to avoid probe issue related to module dependency,
move the function in the rpmsg_ctrl module. This ensure that the
rpmsg_ctrl module is loaded before that the device is created.
Signed-off-by: Arnaud Pouliquen
---
drivers
Introduce the __rpmsg_chrdev_create_eptdev internal function that returns
the rpmsg_eptdev context structure.
This patch prepares the introduction of a RPMsg device for the
char device. the RPMsg device will need a reference to the context.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_smd.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 40a1c415c775..2d279c03a090 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -974,6 +974,20 @@ static
The RPMsg control device is a RPMsg device, it is already
referenced in the RPMsg bus. There is only an interest to
reference the ept char devices in the rpmsg class.
This patch prepares the code split of the control and end point
devices in two separate files.
Signed-off-by: Arnaud Pouliquen
: Arnaud Pouliquen
---
drivers/rpmsg/qcom_glink_native.c | 16
1 file changed, 16 insertions(+)
diff --git a/drivers/rpmsg/qcom_glink_native.c
b/drivers/rpmsg/qcom_glink_native.c
index d4e4dd482614..ae2c03b59c55 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg
Move the code related to the rpmsg_ctrl char device to the new
rpmsg_ctrl.c module.
Manage the dependency in the kconfig.
Signed-off-by: Arnaud Pouliquen
---
drivers/rpmsg/Kconfig | 9 ++
drivers/rpmsg/Makefile | 1 +
drivers/rpmsg/rpmsg_char.c | 163
your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/Arnaud-Pouliquen/intro
On 2/4/21 5:53 PM, Mathieu Poirier wrote:
> On Thu, 4 Feb 2021 at 08:11, Arnaud POULIQUEN
> wrote:
>>
>>
>>
>> On 2/4/21 1:44 PM, kernel test robot wrote:
>>> Hi Arnaud,
>>>
>>> I love your patch! Yet something to improve:
>>>
Hi,
Gentle reminder, in case it has been forgotten.
Thanks,
Arnaud
On 12/17/20 3:41 PM, Arnaud Pouliquen wrote:
> From: Arnaud Pouliquen
>
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error.
> The benefit is that DEFER issue will b
/* Not having a resource table is acceptable */
> + return 0;
Would it be an over protection to set rproc->table_ptr to NULL here?
else
Reviewed-by: Arnaud Pouliquen
Thanks,
Arnaud
> + }
> +
> + if (IS_ERR(table_ptr)) {
> + ret = PTR_ERR(t
To re-attach the remote
> processor, the address of the resource table needs to be available
> at a later time than the platform driver's probe() function.
>
> Signed-off-by: Mathieu Poirier
Reviewed-by: Arnaud Pouliquen
Thanks,
Arnaud
> ---
> dri
ssible for the core
> to release the resources associated with a remote processor while
> the latter is kept operating.
>
> Signed-off-by: Mathieu Poirier
> Reviewed-by: Peng Fan
Reviewed-by: Arnaud Pouliquen
Thanks,
Arnaud
> ---
> drivers/remoteproc/remoteproc_core.c | 30 +
101 - 200 of 609 matches
Mail list logo
