On Mon, 2018-07-23 at 11:18 +0200, Nicholas Mc Guire wrote:
> wait_for_completion_timeout returns unsigned long not int so an
> appropriate
> variable is declared and the assignment and check fixed up.
>
Patch looks good.
Thanks for this
Alex
> Signed-off-by: Nicholas Mc Guire
> ---
>
> foun
On Thu, 2018-07-26 at 11:44 +, Ardelean, Alexandru wrote:
> On Mon, 2018-07-23 at 11:18 +0200, Nicholas Mc Guire wrote:
> > wait_for_completion_timeout returns unsigned long not int so an
> > appropriate
> > variable is declared and the assignment and check fixed up.
>
On Fri, 2018-11-23 at 22:23 -0200, Matheus Tavares wrote:
> Move ad2s90 resolver driver out of staging to the main tree.
>
Acked-by: Alexandru Ardelean
> Signed-off-by: Matheus Tavares
> Signed-off-by: Victor Colombo
> ---
> Changes in v3:
> - none
>
> Changes in v2:
> - Disabled git move
On Tue, 2018-11-20 at 22:30 +0530, Shreeya Patel wrote:
> ADT7316 driver no more uses platform data and hence use device tree
> data instead of platform data for assigning irq_type field.
> Switch case figures out the type of irq and if it's the default case
> then assign the default value to the i
On Tue, 2018-11-27 at 06:11 -0500, Popa, Stefan Serban wrote:
> On Lu, 2018-11-26 at 17:24 -0200, Giuliano Belinassi wrote:
> Hi, please see bellow
>
One note from me here.
> > Hi, thank you for the review
> >
> > >
> > > On Thu, 22 Nov 2018 11:01:00 +
> > > "Popa, Stefan Serban" wrote:
>
On Wed, 2018-11-14 at 23:16 +0530, Nishad Kamdar wrote:
> Add device tree table for matching vendor ID.
>
This could have been just one patch.
Something like
[PATCH v4] staging: iio: ad7816: Add device tree table.
It's no longer a series, because the other patches were applied already.
I do
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote:
> This patch adds device tree support to ad2s90 with standard
> device tree id table.
>
Hey,
Comment inline
> Signed-off-by: Matheus Tavares
> ---
> Changes in v2:
> - none
>
> drivers/staging/iio/resolver/ad2s90.c | 7 +++
> 1 f
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote:
> From: Alexandru Ardelean
>
> This patch adds a max frequency check at the beginning of ad2s90_probe
> function so that when it is set to a value above 0.83Mhz, dev_err is
> called with an appropriate message and -EINVAL is returned.
>
>
On Sun, 2018-11-18 at 02:25 -0200, Matheus Tavares wrote:
> This patch adds the device tree binding documentation for the ad2s90
> resolver-to-digital converter.
>
One minor comment inline.
> Signed-off-by: Matheus Tavares
> ---
> Changes in v2:
> - Rewritten 'spi-cpol and spi-cpha' item to sa
On Sun, 2018-11-11 at 14:30 +, Jonathan Cameron wrote:
> On Tue, 6 Nov 2018 09:24:44 +
> "Ardelean, Alexandru" wrote:
>
> > On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote:
> > > The ad7780 driver previously did not read the correct device
On Sun, 2018-11-11 at 12:58 +, Jonathan Cameron wrote:
> On Thu, 8 Nov 2018 13:44:17 +
> "Ardelean, Alexandru" wrote:
>
> > On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote:
> > > Only the ad778x have the 'gain' status bit. Check it
On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote:
> Use the gpiod interface for rdwr_pin, convert_pin and busy_pin
> instead of the deprecated old non-descriptor interface.
>
Patch looks good.
I do have some thoughts about it. See inline.
> Signed-off-by: Nishad Kamdar
> ---
> drivers/s
On Fri, 2018-11-09 at 08:05 +, Ardelean, Alexandru wrote:
> On Fri, 2018-11-09 at 13:05 +0530, Nishad Kamdar wrote:
> > Use the gpiod interface for rdwr_pin, convert_pin and busy_pin
> > instead of the deprecated old non-descriptor interface.
> >
>
> Patch l
On Fri, 2018-11-09 at 13:08 +0530, Nishad Kamdar wrote:
> Add device tree table for matching vendor ID.
One comment inline for this.
Thanks
Alex
>
> Signed-off-by: Nishad Kamdar
> ---
> drivers/staging/iio/adc/ad7816.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/s
On Mon, 2018-12-10 at 21:27 +, Jonathan Cameron wrote:
> On Sat, 8 Dec 2018 22:10:43 +0100
> Greg KH wrote:
>
> > On Sat, Dec 08, 2018 at 04:56:45PM -0200, Marcelo Schmitt wrote:
> > > Parts of this work came from contributions of Alexandru Ardelean and
> > > Dragos Bogdan, I and Gabriel woul
On Mon, 2018-11-05 at 17:14 -0200, Renato Lui Geh wrote:
> The ad7780 driver previously did not read the correct device output, as
> it read an outdated value set at initialization. It now updates its
> voltage on read.
>
Looks good from my side.
Alex
> Signed-off-by: Renato Lui Geh
> ---
> Ch
On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote:
> This patch removes the unnecessary field int_vref_mv in ad7780_state
> referring to the device's voltage.
>
Looks good from my side.
Alex
> Signed-off-by: Renato Lui Geh
> ---
> Changes in v3:
> - removed unnecessary int_vref_mv
On Wed, 2018-11-07 at 16:49 -0200, Giuliano Belinassi wrote:
> This patch allows further checking of whatever the chip is (ad778x or
> ad717x).
Hey,
The patch looks good overall.
I only have one nitpick for this patch. See inline.
And you can squash this patch with patch `[PATCH 2/3] staging: ii
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote:
> Only the ad778x have the 'gain' status bit. Check it before updating.
>
This looks good.
The only note is that it can be squashed with the 1st patch (which I noted
on the 1st patch).
> Signed-off-by: Giuliano Belinassi
> ---
> driv
On Wed, 2018-11-07 at 16:50 -0200, Giuliano Belinassi wrote:
> Previously, all pattern_masks in the chip_info table were hardcoded. Now
> they
> are generated using the PAT macros, as described in the datasheets.
>
I like this change :)
I only have nitpicks.
See inline.
> Signed-off-by: Giulian
On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote:
> Only the ad778x have the 'gain' status bit. Check it before updating
> through a new variable is_ad778x in chip_info.
>
Looks good.
Alex
> Signed-off-by: Giuliano Belinassi
> ---
> Changes in v2:
> - Squashed is_ad778x declar
On Thu, 2018-11-08 at 11:03 -0200, Giuliano Belinassi wrote:
> Previously, all pattern_masks and patterns in the chip_info table were
> hardcoded. Now they are generated using the PAT macros, as described in
> the datasheets.
One comment about indentation/whitespace.
Rest looks good.
Alex
>
>
Good catch.
Acked-by: Alexandru Ardelean
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET.
> This was fixed by assigning the correct value instead.
>
> Signed-off-by: Renato Lui Geh
> ---
> drivers/staging/iio/ad
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> The ad7780 driver previously did not read the correct device output, as
> it read an outdated value set at initialization. It now updates its
> voltage on read.
>
> Signed-off-by: Renato Lui Geh
> ---
> Changes in v3:
> - removed in
On Thu, 2018-11-01 at 11:43 -0300, Renato Lui Geh wrote:
> This patch removes the unnecessary field int_vref_mv in ad7780_state
> referring to the device's voltage.
>
> Signed-off-by: Renato Lui Geh
> ---
> Changes in v3:
> - removed unnecessary int_vref_mv from ad7780_state
>
> drivers/s
On Thu, 2018-10-18 at 12:12 +0300, Stefan Popa wrote:
> Document support for AD7606 Analog to Digital Converter.
>
Commments inline
> Signed-off-by: Stefan Popa
> ---
> .../devicetree/bindings/iio/adc/adi,ad7606.txt | 51
> ++
> MAINTAINERS
On Wed, 2019-02-27 at 16:15 +0200, Andy Shevchenko wrote:
> [External]
>
>
> On Wed, Feb 27, 2019 at 2:26 PM Ardelean, Alexandru
> wrote:
> >
> > On Wed, 2019-02-27 at 11:46 +0200, Andy Shevchenko wrote:
> > > [External]
> > >
> > >
>
On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote:
>
>
> Previously, the AD7780 driver only supported gpio for the 'powerdown'
> pin. This commit adds suppport for the 'gain' and 'filter' pin.
>
> Signed-off-by: Renato Lui Geh
> Signed-off-by: Giuliano Belinassi
> Co-developed-by: Giulia
On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
>
>
> This patch adds the new feature of reading the filter odr value for
> ad778x chips. This value is stored in the chip's state struct whenever a
> read or write call is performed on the chip's driver.
>
> This feature requires sharing
On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
>
>
> The AD7780 driver contains status pattern bits designed for checking
> whether serial transfers have been correctly performed. Pattern macros
> were previously generated through bit fields. This patch sets good
> pattern values direct
On Thu, 2019-02-28 at 11:24 -0300, Renato Lui Geh wrote:
>
>
> The ad7780 supports both the ad778x and ad717x families. Each chip has
> a corresponding ID. This patch provides a mask for extracting ID values
> from the status bits and also macros for the correct values for the
> ad7170, ad7171, a
On Thu, 2019-02-28 at 11:25 -0300, Renato Lui Geh wrote:
>
>
> To maintain consistency between ad7780_probe and ad7780_remove orders,
> regulator initialization has been moved to after GPIO initializations.
>
> Signed-off-by: Renato Lui Geh
> ---
> drivers/staging/iio/adc/ad7780.c | 26 +++
On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote:
>
The patch-series is a bit big.
I guess that the intent is to move this out-of-staging, but various patches
are holding this in it's place.
For patch series above a certain size, you could get many re-spins
[V2,3,4... so on].
You could se
On Wed, 2019-02-27 at 11:46 +0200, Andy Shevchenko wrote:
> [External]
>
>
> +Cc Vinod
>
> On Wed, Feb 27, 2019 at 11:45 AM Andy Shevchenko
> wrote:
> >
> > On Wed, Feb 27, 2019 at 10:51 AM Alexandru Ardelean
> > wrote:
> > >
> > > From: Andy Shevchenko
> > >
> > > Sometimes the user needs
On Wed, 2020-05-20 at 09:18 +0300, Sergiu Cuciurean wrote:
> [External]
>
> As part of the general cleanup of indio_dev->mlock, this change replaces
> it with a local lock on the device's state structure.
>
This requires a V2.
It produces a warning:
159 | struct iio_dev *iio_dev = iio_priv_t
-Original Message-
From: Tom Rix
Sent: Wednesday, August 5, 2020 7:02 PM
To: Ardelean, Alexandru ;
linux-...@vger.kernel.org; linux-f...@vger.kernel.org;
linux-kernel@vger.kernel.org
Cc: mturque...@baylibre.com; sb...@kernel.org; m...@kernel.org; Caprioru,
Mircea
Subject: Re: [PATCH
> -Original Message-
> From: Tom Rix
> Sent: Thursday, December 24, 2020 4:03 PM
> To: Ardelean, Alexandru ; linux-
> c...@vger.kernel.org; devicet...@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: mturque...@baylibre.com; sb...@kernel.org; robh...@kernel.org;
> -Original Message-
> From: Andy Shevchenko
> Sent: Monday, December 21, 2020 4:37 PM
> To: Ardelean, Alexandru
> Cc: linux-spi ; devicetree
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Bogdan, Dragos ;
> Mark Brown ; Rob Herring
> Subject:
> -Original Message-
> From: Alexandru Ardelean
> Sent: Friday, November 27, 2020 1:14 PM
> To: linux-in...@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicet...@vger.kernel.org
> Cc: l...@metafoo.de; dmitry.torok...@gmail.com; robh...@kernel.org;
> Ardelean,
> -Original Message-
> From: Dmitry Torokhov
> Sent: Thursday, November 19, 2020 9:24 AM
> To: linux-in...@vger.kernel.org
> Cc: Ardelean, Alexandru ; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] Input: adp5589-keys - mark suspend and resume method
> -Original Message-
> From: Dmitry Torokhov
> Sent: Thursday, November 19, 2020 9:25 AM
> To: linux-in...@vger.kernel.org
> Cc: Ardelean, Alexandru ; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] Input: adp5589-keys - use BIT()
>
> [External]
>
&
> -Original Message-
> From: Alexandru Ardelean
> Sent: Monday, November 23, 2020 4:35 PM
> To: linux-kernel@vger.kernel.org; k...@vger.kernel.org
> Cc: m...@redhat.com; gre...@linuxfoundation.org; Ardelean, Alexandru
>
> Subject: [PATCH v2] uio/uio_pci_gen
> -Original Message-
> From: Andy Shevchenko
> Sent: Tuesday, November 24, 2020 1:50 PM
> To: kernel test robot
> Cc: Ardelean, Alexandru ; linux-spi s...@vger.kernel.org>; devicetree ; Linux Kernel
> Mailing List ; kbuild-...@lists.01.org; Mark
> Brow
> -Original Message-
> From: Lars-Peter Clausen
> Sent: Tuesday, November 24, 2020 10:43 AM
> To: Ardelean, Alexandru ; linux-
> in...@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: dmitry.torok...@gmail.com
> Subject: Re: [PATCH v2 3/3] Input: adp5589-keys -
> -Original Message-
> From: Andy Shevchenko
> Sent: Friday, November 27, 2020 4:13 PM
> To: Ardelean, Alexandru
> Cc: linux-spi ; devicetree
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown
> ; Bogdan, Dragos
> Subject: R
> -Original Message-
> From: Andy Shevchenko
> Sent: Friday, November 27, 2020 4:24 PM
> To: Ardelean, Alexandru
> Cc: linux-spi ; devicetree
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown
> ; Bogdan, Dragos
> Subject:
> -Original Message-
> From: Andy Shevchenko
> Sent: Friday, November 27, 2020 4:26 PM
> To: Ardelean, Alexandru
> Cc: linux-spi ; devicetree
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Rob Herring ; Mark Brown
> ; Bogdan, Dragos
> Subject:
> -Original Message-
> From: Andrew Lunn
> Sent: Thursday, December 3, 2020 4:16 PM
> To: Ardelean, Alexandru
> Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org;
> hkallwe...@gmail.com; li...@armlinux.org.uk; da...@davemloft.net;
> k...@kernel.or
> -Original Message-
> From: Stephen Rothwell
> Sent: Monday, January 4, 2021 2:07 AM
> To: Mark Brown
> Cc: Ardelean, Alexandru ; Andy Shevchenko
> ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux Next Mailing List
> Subject: linux-next: build wa
> -Original Message-
> From: Andy Shevchenko
> Sent: Monday, January 4, 2021 3:51 PM
> To: Ardelean, Alexandru
> Cc: linux-spi ; Linux Kernel Mailing List ker...@vger.kernel.org>; Mark Brown ; Stephen Rothwell
>
> Subject: Re: [PATCH] spi: stm32: update dev_db
> -Original Message-
> From: Moritz Fischer
> Sent: Wednesday, January 27, 2021 4:39 AM
> To: Ardelean, Alexandru
> Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux-
> ker...@vger.kernel.org; mturque...@baylibre.com; sb...@kernel.org;
>
> -Original Message-
> From: Greg KH
> Sent: Friday, November 20, 2020 5:46 PM
> To: Ardelean, Alexandru
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] uio/uio_pci_generic: remove unneeded pci_set_drvdata()
>
> [External]
>
> On Thu, No
On Sun, 2019-09-08 at 12:09 +0100, Jonathan Cameron wrote:
> On Mon, 2 Sep 2019 13:26:02 +
> "Ardelean, Alexandru" wrote:
>
> > On Sun, 2019-09-01 at 21:59 -0300, Rodrigo Carvalho wrote:
> > > Move ADIS16240 driver from staging to mainline.
> > >
On Sat, 2019-09-07 at 20:54 +0800, kbuild test robot wrote:
> [External]
>
> Hi Alexandru,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
Hmm, this error should be expectable I guess: I applied this on net-next/master.
Alex
> [cannot apply to v5.3
On Tue, 2019-09-10 at 10:00 +0200, Michal Kubecek wrote:
> [External]
>
> On Mon, Sep 09, 2019 at 04:12:50PM +0300, Alexandru Ardelean wrote:
> > The `phy_tunable_id` has been named `ETHTOOL_PHY_EDPD` since it looks like
> > this feature is common across other PHYs (like EEE), and defining
> > `ET
On Sun, 2019-09-01 at 21:59 -0300, Rodrigo Carvalho wrote:
> This patch add device tree binding documentation for ADIS16240.
>
> Signed-off-by: Rodrigo Ribeiro Carvalho
> ---
> I have doubt about what maintainer I may to put in that documentation. I
> put Alexandru as maintainer because he review
On Sun, 2019-09-01 at 21:59 -0300, Rodrigo Carvalho wrote:
> Move ADIS16240 driver from staging to mainline.
>
> The ADIS16240 is a fully integrated digital shock detection
> and recorder system.
Hey,
Comments inline.
I'll probably take a look in the next days again.
There seem to be some ABI/
On Wed, 2019-08-14 at 10:57 -0700, Florian Fainelli wrote:
> [External]
>
>
>
> On 8/12/2019 4:23 AM, Alexandru Ardelean wrote:
> > The ADIN PHYs support Energy Detect Powerdown mode, which puts the PHY into
> > a low power mode when there is no signal on the wire (typically cable
> > unplugged)
On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote:
> [External]
>
Reviewed-by: Alexandru Ardelean
> From: Colin Ian King
>
> Currently the pointer val is being incorrectly incremented
> instead of the value pointed to by val. Fix this by adding
> in the missing * indirection operator.
>
>
On Wed, 2019-09-04 at 21:53 +0200, Andrew Lunn wrote:
> [External]
>
> On Wed, Sep 04, 2019 at 07:23:21PM +0300, Alexandru Ardelean wrote:
>
> Hi Alexandru
>
> Somewhere we need a comment stating what EDPD means. Here would be a
> good place.
ack
>
> > +#define ETHTOOL_PHY_EDPD_DFLT_TX_INTERV
On Wed, 2019-09-04 at 22:03 +0200, Andrew Lunn wrote:
> [External]
>
> On Wed, Sep 04, 2019 at 07:23:22PM +0300, Alexandru Ardelean wrote:
> > This driver becomes the first user of the kernel's `ETHTOOL_PHY_EDPD`
> > phy-tunable feature.
> > EDPD is also enabled by default on PHY config_init, but
On Tue, 2019-09-10 at 17:46 +0200, David Miller wrote:
> [External]
>
> From: David Miller
> Date: Tue, 10 Sep 2019 17:45:44 +0200 (CEST)
>
> > From: Alexandru Ardelean
> > Date: Fri, 6 Sep 2019 15:30:54 +0300
> >
> > > The socfpga sub-driver defines an `interface` field in the `socfpga_dwmac`
On Thu, 2019-09-12 at 18:39 -0300, Rodrigo Carvalho wrote:
> This patch add device tree binding documentation for ADIS16240.
>
> Signed-off-by: Rodrigo Ribeiro Carvalho
> ---
> V2:
> - Remove true constant for spi-cpha and spi-cpol
> - Add description field for spi-cpha and spi-cpol
> - Add
On Sun, 2019-09-15 at 08:11 -0700, Florian Fainelli wrote:
> [External]
>
>
>
> On 9/14/2019 8:29 AM, Andrew Lunn wrote:
> > On Thu, Sep 12, 2019 at 07:28:12PM +0300, Alexandru Ardelean wrote:
> >
> > > +static int adin_set_edpd(struct phy_device *phydev, u16 tx_interval)
> > > +{
> > > + u16 v
On Fri, 2019-09-13 at 15:36 +0100, Rob Herring wrote:
> [External]
>
> On Fri, Sep 06, 2019 at 04:02:56PM +0300, Alexandru Ardelean wrote:
> > This change documents the 'mac-mode' property that was introduced in the
> > 'stmmac' driver to support passive mode converters that can sit in-between
> >
On Sun, 2019-09-15 at 11:14 +0100, Jonathan Cameron wrote:
> [External]
>
> On Fri, 13 Sep 2019 14:55:49 +0300
> Alexandru Ardelean wrote:
>
> > The ADIS library is one of the few users of the new `cs_change_delay`
> > parameter for an spi_transfer.
> >
> > The introduction of the `spi_delay` s
On Sun, 2019-09-15 at 19:51 +0100, David Miller wrote:
> [External]
>
> From: Alexandru Ardelean
> Date: Thu, 12 Sep 2019 16:28:50 +0300
>
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> > b/drivers/net/ethernet/stmicro/stmmac/dwmac-
> > socfpga.c
> > index c141fe783e87..
On Mon, 2019-09-16 at 13:25 +0100, Mark Brown wrote:
> [External]
>
> On Fri, Sep 13, 2019 at 02:45:38PM +0300, Alexandru Ardelean wrote:
>
> > - u16 cs_change_delay;
> > - u8 cs_change_delay_unit;
> > + struct spi_delaycs_change_delay;
>
> This breaks the
On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote:
> [External]
>
> On Mon, Sep 16, 2019 at 12:37:12PM +, Ardelean, Alexandru wrote:
>
> > > This breaks the build as there is a user of this interface.
> > Ack.
> > Jonathan pointed this out.
> > There
On Mon, 2019-09-16 at 14:43 +0100, Mark Brown wrote:
> [External]
>
> On Mon, Sep 16, 2019 at 01:04:42PM +, Ardelean, Alexandru wrote:
> > On Mon, 2019-09-16 at 13:47 +0100, Mark Brown wrote:
> > > That v3 seems to be a small subset of this series?
> > Ack.
>
On Mon, 2019-09-16 at 12:49 +0300, Alexandru Ardelean wrote:
> On Fri, 2019-09-13 at 15:36 +0100, Rob Herring wrote:
> > [External]
> >
> > On Fri, Sep 06, 2019 at 04:02:56PM +0300, Alexandru Ardelean wrote:
> > > This change documents the 'mac-mode' property that was introduced in
> > > the
> > >
On Tue, 2019-09-17 at 14:41 +0200, Andrew Lunn wrote:
> [External]
>
> On Tue, Sep 17, 2019 at 01:30:52PM +0300, Alexandru Ardelean wrote:
> > The 'mac-mode' property is similar to 'phy-mode' and 'phy-connection-type',
> > which are enums of mode strings.
> >
> > The 'dwmac' driver supports almos
On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote:
> [External]
>
Hey,
Comments inline.
I thought I sent an initial review, but seems to have gotten lost [maybe in
my email client].
Oh well. I managed to re-do it anyway.
I tried to group them this time.
The more prominent part is
On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote:
> On Sun, 6 Oct 2019 10:12:01 +0100
> Jonathan Cameron wrote:
>
> > On Thu, 26 Sep 2019 14:18:04 +0300
> > Alexandru Ardelean wrote:
> >
> > > This will allow more flexible control to group reads & writes into a
> > > single
> > > lock
On Tue, 2019-10-08 at 06:54 +, Ardelean, Alexandru wrote:
> [External]
>
> On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote:
> > On Sun, 6 Oct 2019 10:12:01 +0100
> > Jonathan Cameron wrote:
> >
> > > On Thu, 26 Sep 2019 14:18:04 +
On Tue, 2019-10-08 at 08:47 +, Ardelean, Alexandru wrote:
> [External]
>
> On Tue, 2019-10-08 at 06:54 +, Ardelean, Alexandru wrote:
> > [External]
> >
> > On Mon, 2019-10-07 at 22:16 +0100, Jonathan Cameron wrote:
> > > On Sun, 6 Oct 2019 10:12:01
On Wed, 2019-10-09 at 15:15 +0530, Manivannan Sadhasivam wrote:
> [External]
>
> Hi Ardelean,
>
> Thanks for the quick review!
>
> On Tue, Oct 08, 2019 at 06:52:50AM +, Ardelean, Alexandru wrote:
> > On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhas
On Sun, 2019-10-06 at 10:06 +0100, Jonathan Cameron wrote:
> [External]
>
> On Sun, 6 Oct 2019 09:53:33 +0100
> Jonathan Cameron wrote:
>
> > On Thu, 26 Sep 2019 14:18:03 +0300
> > Alexandru Ardelean wrote:
> >
> > > The lock can be extended a bit to protect other elements that are not
> > > p
On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote:
> [External]
>
> Add devicetree binding for Analog Devices ADUX1020 Photometric
> sensor.
>
Hey,
Thanks for the patches.
This dt-binding docs is in text format.
dt-binding docs now need to be in YAML format.
Also, patches for dt-
On Mon, 2019-10-07 at 18:10 +0530, Manivannan Sadhasivam wrote:
> [External]
>
> Hi Ardelean,
>
> On 7 October 2019 3:51:16 PM IST, "Ardelean, Alexandru" <
> alexandru.ardel...@analog.com> wrote:
> > On Mon, 2019-10-07 at 15:40 +0530, Mani
On Wed, 2019-09-18 at 11:57 -0500, Navid Emamdoost wrote:
> [External]
>
Hey,
Good catch.
One comment inline.
> In adis_update_scan_mode, if allocation for adis->buffer fails,
> previously allocated adis->xfer needs to be released.
>
> Signed-off-by: Navid Emamdoost
> ---
> drivers/iio/imu/a
On Wed, 2019-09-18 at 12:03 -0500, Navid Emamdoost wrote:
> [External]
>
Hey,
Thanks for this patch as well.
Comments inline here as well.
> In adis_update_scan_mode_burst, if adis->buffer allocation fails release
> the adis->xfer.
>
> Signed-off-by: Navid Emamdoost
> ---
> drivers/iio/imu/a
On Thu, 2019-09-19 at 10:50 -0500, Navid Emamdoost wrote:
> In adis_update_scan_mode, if allocation for adis->buffer fails,
> previously allocated adis->xfer needs to be released.
>
> v2: added adis->xfer = NULL to avoid any potential double free.
Reviewed-by: Alexandru Ardelean
> Signed-off-by
On Thu, 2019-09-19 at 10:56 -0500, Navid Emamdoost wrote:
> In adis_update_scan_mode_burst, if adis->buffer allocation fails release
> the adis->xfer.
>
> v2: set adis->xfer = NULL to avoid any potential double free.
>
Reviewed-by: Alexandru Ardelean
> Signed-off-by: Navid Emamdoost
> ---
>
On Wed, 2019-09-25 at 10:14 -0500, Adam Ford wrote:
> [External]
>
> On Fri, Sep 20, 2019 at 2:06 AM Philipp Puschmann
> wrote:
> > Hi Andy,
> >
> > Am 20.09.19 um 05:42 schrieb Andy Duan:
> > > From: Philipp Puschmann Sent: Thursday,
> > > September 19, 2019 10:51 PM
> > > > Using only 4 DMA p
On Thu, 2019-09-26 at 11:10 +0300, Dan Carpenter wrote:
> [External]
>
> The "t" variable is unsigned so it can't be less than zero. We really
> are just trying to prevent divide by zero bugs so just checking against
> zero is sufficient.
>
> Signed-off-by: Dan Carpenter
> ---
> drivers/iio/im
On Tue, 2019-07-09 at 15:12 +0100, Mark Brown wrote:
> On Wed, Jun 26, 2019 at 07:34:38PM +0100, Jonathan Cameron wrote:
> > On Tue, 25 Jun 2019 16:13:25 +0300
> > Alexandru Ardelean wrote:
> >
> > > Some devices like the ADIS16460 IMU require a stall period between
> > > transfers, i.e. between
On Thu, 2019-07-18 at 13:50 +0100, Mark Brown wrote:
> On Wed, Jul 17, 2019 at 02:51:06PM +0300, Alexandru Ardelean wrote:
> > Some devices like the ADIS16460 IMU require a stall period between
> > transfers, i.e. between when the CS is de-asserted and re-asserted. The
> > default value of 10us is
On Sat, 2020-05-02 at 19:25 +0100, Jonathan Cameron wrote:
> On Tue, 28 Apr 2020 12:31:28 +0300
> Alexandru Ardelean wrote:
>
> > This change cleans up the driver's probe function to use only devm_
> > function variants. This also gets rid of the remove function and moves the
> > clock & regulato
On Sun, 2020-05-03 at 12:37 +0100, Jonathan Cameron wrote:
> [External]
>
> On Wed, 29 Apr 2020 10:21:29 +0300
> Alexandru Ardelean wrote:
>
> > From: Dragos Bogdan
> >
> > If the serial interface is used, the 8-bit address should be latched using
> > the rising edge of the WR/FSYNC signal.
>
On Sun, 2020-05-03 at 13:51 +0100, Jonathan Cameron wrote:
> On Wed, 29 Apr 2020 18:17:39 +0300
> Alexandru Ardelean wrote:
>
> > From: Lars-Peter Clausen
> >
> > Let the core handle the buffer scan mask management including allocation
> > and channel selection. Having this handled in a central
On Sun, 2020-05-03 at 16:39 +0100, Jonathan Cameron wrote:
> [External]
>
> On Mon, 27 Apr 2020 16:10:57 +0300
> Alexandru Ardelean wrote:
>
> > The final intent is to localize all buffer ops into the
> > industrialio-buffer.c file, to be able to add support for multiple buffers
> > per IIO devi
On Mon, 2020-04-27 at 13:00 +, Ardelean, Alexandru wrote:
> [External]
>
> On Mon, 2020-04-27 at 12:20 +, eugen.hris...@microchip.com wrote:
> > [External]
> >
> > On 15.04.2020 09:33, Ardelean, Alexandru wrote:
> >
> > > On Tue, 2020-04
On Thu, 2020-04-30 at 07:30 +, Ardelean, Alexandru wrote:
> On Mon, 2020-04-27 at 13:00 +0000, Ardelean, Alexandru wrote:
> > [External]
> >
> > On Mon, 2020-04-27 at 12:20 +, eugen.hris...@microchip.com wrote:
> > > [External]
> > >
> > >
On Thu, 2020-04-30 at 11:52 +0300, Alexandru Ardelean wrote:
> Not used anywhere.
> Looks like it was forgotten in iio.h
>
Actually, disregard this.
I've found places where 'indio_dev->debugfs_dentry' is accessed directly and
that should have used this instead.
Apologies for the spam.
> Signe
On Mon, 2019-10-14 at 12:31 +0530, Vinod Koul wrote:
> [External]
>
Hey,
> On 13-09-19, 17:54, Alexandru Ardelean wrote:
> > From: Rodrigo Alencar
> >
> > dmaengine_slave_config is called by dmaengine_pcm_hw_params when using
> > axi-i2s with axi-dmac. If device_config is NULL, -ENOSYS is ret
On Wed, 2019-10-16 at 10:38 +0530, Vinod Koul wrote:
> [External]
>
> On 15-10-19, 23:06, Lars-Peter Clausen wrote:
>
> > > > This DMA controller is a bit special.
> > > > It gets synthesized in FPGA, so the configuration is fixed and
> > > > cannot be
> > > > changed at runtime. Maybe later we w
On Wed, 2019-10-16 at 22:25 +0800, Chuhong Yuan wrote:
> ad9834_probe misses a check for devm_clk_get and may cause problems.
> Add a check like what ad9832 does to fix it.
>
This could also use a Fixes tag, but not a big deal.
Reviewed-by: Alexandru Ardelean
> Signed-off-by: Chuhong Yuan
> -
On Tue, 2019-05-07 at 17:44 -0300, Melissa Wen wrote:
> [External]
>
>
> On 05/06, Ardelean, Alexandru wrote:
> > On Sat, 2019-05-04 at 13:43 +0300, Alexandru Ardelean wrote:
> > > [External]
> > >
> > >
> > > On Sat, May 4, 2019 at 1:25
On Mon, 2019-05-06 at 17:46 +0300, andriy.shevche...@linux.intel.com wrote:
> [External]
>
>
> On Mon, May 06, 2019 at 04:45:43PM +0300, Alexandru Ardelean wrote:
> > On Fri, Apr 26, 2019 at 5:27 PM andriy.shevche...@linux.intel.com
> > wrote:
> > >
> > > On Fri, Apr 26, 2019 at 12:29:11PM +030
1 - 100 of 208 matches
Mail list logo
