Hi Lee Jones,
Am Donnerstag, dem 28.09.2023 um 15:42 +0100 schrieb Lee Jones:
> On Sat, 23 Sep 2023, André Apitzsch wrote:
>
> > This commit adds support for Kinetic KTD2026/7 RGB/White LED
> > driver.
> >
> > Signed-off-by: André Apitzsch
> > ---
> &
Add the binding description and the corresponding driver for
the Kinetic KTD2026 and KTD2027.
Signed-off-by: André Apitzsch
---
Changes in v5:
- Restructure brightness_set() + add comments to it to be easier understandable
- Add some line breaks + remove little line-wraps to improve readability
Document Kinetic KTD2026/2027 LED driver devicetree bindings.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: André Apitzsch
---
.../devicetree/bindings/leds/kinetic,ktd202x.yaml | 171 +
1 file changed, 171 insertions(+)
diff --git a/Documentation/devicetree/bindings
This commit adds support for Kinetic KTD2026/7 RGB/White LED driver.
Signed-off-by: André Apitzsch
---
drivers/leds/rgb/Kconfig| 13 +
drivers/leds/rgb/Makefile | 1 +
drivers/leds/rgb/leds-ktd202x.c | 619
3 files changed, 633
Hi Christophe,
Am Sonntag, dem 01.10.2023 um 17:15 +0200 schrieb Christophe JAILLET:
> Le 01/10/2023 à 15:52, André Apitzsch a écrit :
> > This commit adds support for Kinetic KTD2026/7 RGB/White LED
> > driver.
> >
> > Signed-off-by: André Apitzsch
>
Am Sonntag, dem 01.10.2023 um 22:46 +0200 schrieb Christophe JAILLET:
> Le 01/10/2023 à 18:56, André Apitzsch a écrit :
> > Hi Christophe,
> >
> > Am Sonntag, dem 01.10.2023 um 17:15 +0200 schrieb Christophe
> > JAILLET:
> > > Le 01/10/2023 à 15:52, André Ap
Add the binding description and the corresponding driver for
the Kinetic KTD2026 and KTD2027.
Signed-off-by: André Apitzsch
---
Changes in v6:
- Remove un-needed inits
- Narrow scope of variables
- Release of_node references on early exit
- Pass child node to dev_err() in ktd202x_setup_led_rgb
Document Kinetic KTD2026/2027 LED driver devicetree bindings.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: André Apitzsch
---
.../devicetree/bindings/leds/kinetic,ktd202x.yaml | 171 +
1 file changed, 171 insertions(+)
diff --git a/Documentation/devicetree/bindings
This commit adds support for Kinetic KTD2026/7 RGB/White LED driver.
Signed-off-by: André Apitzsch
---
drivers/leds/rgb/Kconfig| 13 +
drivers/leds/rgb/Makefile | 1 +
drivers/leds/rgb/leds-ktd202x.c | 625
3 files changed, 639
With the driver for ktd2026 recently applied to linux-leds[1], the LED
can be enabled on longcheer l8910 and l9100.
[1] https://lore.kernel.org/all/20231002-ktd202x-v6-0-26be8eefe...@apitzsch.eu/
Signed-off-by: André Apitzsch
---
André Apitzsch (2):
arm64: dts: qcom: msm8916-longcheer
l8910 uses KTD2026 LED driver. Add it to the device tree.
Tested-by: Stephan Gerhold
Signed-off-by: André Apitzsch
---
.../boot/dts/qcom/msm8916-longcheer-l8910.dts | 51 ++
1 file changed, 51 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910
l9100 uses KTD2026 LED driver. Add it to the device tree.
Signed-off-by: André Apitzsch
---
.../boot/dts/qcom/msm8939-longcheer-l9100.dts | 51 ++
1 file changed, 51 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
b/arch/arm64/boot/dts
Consider an object near to the sensor when their distance is about 4 cm
or below.
Signed-off-by: André Apitzsch
---
arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8939-longcheer-l9100.dts
b/arch/arm64/boot
Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio:
>
>
> On 10/16/23 22:18, André Apitzsch wrote:
> > Consider an object near to the sensor when their distance is about
> > 4 cm
> > or below.
> >
> > Signed-off-by: André Apitzsch
> >
Am Mittwoch, dem 18.10.2023 um 10:32 +0200 schrieb Konrad Dybcio:
>
>
> On 10/17/23 22:03, André Apitzsch wrote:
> > Am Dienstag, dem 17.10.2023 um 18:25 +0200 schrieb Konrad Dybcio:
> > >
> > >
> > > On 10/16/23 22:18, André Apitzsch wrote:
> >
Consider an object near to the sensor when their distance is about 4 cm
or below.
Reviewed-by: Konrad Dybcio
Signed-off-by: André Apitzsch
---
Changes in v2:
- add R-b
- Link to v1:
https://lore.kernel.org/r/20231016-bqm5_prox-v1-1-2acdc732b...@apitzsch.eu
---
arch/arm64/boot/dts/qcom/msm8939
Document the compatible for the MSM8926-based Motorola Moto G 4G smartphone.
Signed-off-by: André Apitzsch
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml
b/Documentation/devicetree/bindings
This dts adds support for Motorola Moto G 4G released in 2013.
Add a device tree with initial support for:
- GPIO keys
- Hall sensor
- SDHCI
- Vibrator
Signed-off-by: André Apitzsch
---
André Apitzsch (2):
dt-bindings: arm: qcom: Add Motorola Moto G 4G
ARM: dts: qcom: msm8926
Am Mittwoch, dem 13.12.2023 um 21:44 +0100 schrieb Konrad Dybcio:
>
>
> On 12/13/23 21:33, André Apitzsch wrote:
> > This dts adds support for Motorola Moto G 4G released in 2013.
> I have a similar one in my drawer.. not the 4g kind, titan IIRC?
> Wasn't this one c
This dts adds support for Motorola Moto G 4G released in 2013.
Add a device tree with initial support for:
- GPIO keys
- Hall sensor
- SDHCI
- Vibrator
Signed-off-by: André Apitzsch
---
Changes in v2:
- Make clear it's about Moto G 4G released in 2013.
- Add a-b to patch 1/2.
- Combine
Document the compatible for the MSM8926-based Motorola Moto G 4G
smartphone released in 2013.
Acked-by: Krzysztof Kozlowski
Signed-off-by: André Apitzsch
---
Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings
Am Freitag, dem 15.12.2023 um 00:37 +0100 schrieb Konrad Dybcio:
>
>
> On 12/14/23 21:59, André Apitzsch wrote:
> > This dts adds support for Motorola Moto G 4G released in 2013.
> >
> > Add a device tree with initial support for:
> >
> > -
Document Kinetic KTD2026/2027 LED driver devicetree bindings.
Reviewed-by: Krzysztof Kozlowski
Signed-off-by: André Apitzsch
---
.../devicetree/bindings/leds/kinetic,ktd202x.yaml | 171 +
1 file changed, 171 insertions(+)
diff --git a/Documentation/devicetree/bindings
Add the binding description and the corresponding driver for
the Kinetic KTD2026 and KTD2027.
Signed-off-by: André Apitzsch
---
Changes in v4:
- Annotate struct ktd202x with __counted_by
- Link to v3:
https://lore.kernel.org/r/20230906-ktd202x-v3-0-7fcb91c65...@apitzsch.eu
Changes in v3:
- Add
This commit adds support for Kinetic KTD2026/7 RGB/White LED driver.
Signed-off-by: André Apitzsch
---
drivers/leds/rgb/Kconfig| 13 +
drivers/leds/rgb/Makefile | 1 +
drivers/leds/rgb/leds-ktd202x.c | 625
3 files changed, 639
> > Should the comment be added in this commit?
> > And what exactly should the comment say?
>
> Add it to imx214_enum_frame_interval.
> Something along the lines of:
> Raw sensors should be using the VBLANK and HBLANK controls to
> determine the frame rate. However this d
Hi Ricardo,
Am Mittwoch, dem 30.10.2024 um 12:38 +0100 schrieb Ricardo Ribalda
Delgado:
> On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
> wrote:
> >
> > From: André Apitzsch
> >
> > The imx214 camera is capable of either two-lane or four-lane
>
ed by the user. Is it right, that .set_selection needs to be
implemented to change that?
The different values are set programmatically to reduce the number of
entries in the cci reg sequences to make it easier to add more modes
later.
Regards,
André
>
> On Mon, Oct 21, 2024 at 12:14 A
Hi,
Am Mittwoch, dem 30.10.2024 um 12:36 +0100 schrieb Ricardo Ribalda
Delgado:
> Hi
>
> It looks good to me, but I would like Sakari to review it. I am not
> sure if it is ok to keep the cur_mode variable.
>
> On Mon, Oct 21, 2024 at 12:14 AM André Apitzsch via B4 Relay
>
, dem 21.10.2024 um 00:13 +0200 schrieb André Apitzsch via B4
Relay:
> From: André Apitzsch
>
> Remove format and crop settings from register sequences and set them
> programmatically.
>
> Signed-off-by: André Apitzsch
> ---
> dri
and I'd like to hear back from Sakari regarding the
> get_locked_active
>
> Thanks!
>
> On Sat, Dec 7, 2024 at 9:48 PM André Apitzsch via B4 Relay
> wrote:
> >
> > From: André Apitzsch
> >
> > Add vblank control to allow changing the framerate /
>
Hi,
Am Sonntag, dem 09.02.2025 um 14:20 + schrieb Sakari Ailus:
> Hi André,
>
> On Sat, Feb 08, 2025 at 12:13:49PM +0100, André Apitzsch via B4 Relay
> wrote:
> > From: André Apitzsch
> >
> > Add of_match table for "dongwoon,dw9719" and "dongw
;d like to hear back from Sakari regarding the
> get_locked_active
>
> Thanks!
>
> On Sat, Dec 7, 2024 at 9:48 PM André Apitzsch via B4 Relay
> wrote:
> >
> > From: André Apitzsch
> >
> > Add vblank control to allow changing the framerate /
> > h
Hi,
Am Dienstag, dem 10.12.2024 um 12:34 + schrieb Sakari Ailus:
> On Sun, Dec 08, 2024 at 10:19:51PM +0100, Ricardo Ribalda Delgado
> wrote:
> > > > + state =
> > > > v4l2_subdev_get_locked_active_state(&imx214->sd);
> > >
> > > Sakari, I see that other drivers assume that the
Hi Sakari,
Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus:
> Hi André,
>
> Thanks for the update.
>
> On Fri, Dec 20, 2024 at 02:26:11PM +0100, André Apitzsch via B4 Relay
> wrote:
> > From: André Apitzsch
> >
> > The driver should dis
Hi Sakari,
Am Donnerstag, dem 09.01.2025 um 08:59 + schrieb Sakari Ailus:
> Hi André,
>
> On Wed, Jan 08, 2025 at 10:46:51PM +0100, André Apitzsch wrote:
> > Hi Sakari,
> >
> > Am Mittwoch, dem 08.01.2025 um 11:51 + schrieb Sakari Ailus:
> > > H
Am Montag, dem 10.03.2025 um 23:35 +0100 schrieb André Apitzsch:
> Hi Sakari,
>
> Am Montag, dem 10.03.2025 um 11:11 + schrieb Sakari Ailus:
> > Hi André,
> >
> > On Sat, Mar 08, 2025 at 10:47:54PM +0100, André Apitzsch via B4
> > Relay
> > wrote:
>
Am Montag, dem 07.04.2025 um 21:10 +0200 schrieb André Apitzsch:
> Am Montag, dem 10.03.2025 um 23:35 +0100 schrieb André Apitzsch:
> > Hi Sakari,
> >
> > Am Montag, dem 10.03.2025 um 11:11 + schrieb Sakari Ailus:
> > > Hi André,
> > >
> > >
Am Mittwoch, dem 23.04.2025 um 12:09 +0100 schrieb Richard Fitzgerald:
> On 21/4/25 15:15, Charles Keepax wrote:
> > On Fri, Apr 18, 2025 at 10:22:04PM +0200, André Apitzsch via B4
> > Relay wrote:
> > > From: André Apitzsch
> > >
> > > Ad
Hi Sakari,
Am Donnerstag, dem 24.04.2025 um 08:28 +0800 schrieb Ricardo Ribalda
Delgado:
> On Wed, Apr 16, 2025 at 5:22 AM André Apitzsch via B4 Relay
> wrote:
> >
> > The imx214 driver currently supports only a 24 MHz external clock.
> > But
> > there are device
Hi Sakari,
Am Montag, dem 10.03.2025 um 11:11 + schrieb Sakari Ailus:
> Hi André,
>
> On Sat, Mar 08, 2025 at 10:47:54PM +0100, André Apitzsch via B4 Relay
> wrote:
> > The imx214 driver currently supports only a 24MHz external clock.
> > But
> > there are
Hi Sakari,
thanks for the feedback. One question below.
Am Dienstag, dem 06.05.2025 um 08:05 + schrieb Sakari Ailus:
> Hi André,
>
> A few more comments below.
>
> On Mon, May 05, 2025 at 11:05:55PM +0200, André Apitzsch via B4 Relay
> wrote:
> > From: André Apit
Hello Sakari,
Am Dienstag, dem 06.05.2025 um 08:24 + schrieb Sakari Ailus:
> Hi André,
>
> On Mon, May 05, 2025 at 11:05:56PM +0200, André Apitzsch via B4 Relay
> wrote:
> > From: André Apitzsch
> >
> > Instead rely on the rate set on the clock (using ass
0:58:46AM +0200, Laurent Pinchart wrote:
> > > > On Tue, May 06, 2025 at 08:24:03AM +, Sakari Ailus wrote:
> > > > > On Mon, May 05, 2025 at 11:05:56PM +0200, André Apitzsch via
> > > > > B4 Relay wrote:
> > > > > > From: André Apitzsch
Hi Sakari,
Am Montag, dem 10.02.2025 um 09:53 + schrieb Sakari Ailus:
> Hi André,
>
> Thanks for the update.
>
> On Sun, Feb 09, 2025 at 10:51:57PM +0100, André Apitzsch via B4 Relay
> wrote:
> > From: André Apitzsch
> >
> > Document Dongwoon DW971
Am Montag, dem 16.06.2025 um 13:46 +0200 schrieb Konrad Dybcio:
> On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote:
> > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360)
> > released
> > in 2016.
> >
> > Add a device tree with initial support fo
From: André Apitzsch
Add the accelerometer, magnetometer and regulator that are present on
the Motorola Moto G 4G (2013) device.
While at it, update framebuffer supplies and temperature sensor.
Signed-off-by: André Apitzsch
---
.../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 121
Add accelerometer, magnetometer, regulator and temperature sensor alert
interrupt and update framebuffer supplies.
Signed-off-by: André Apitzsch
---
Changes in v2:
- Split commit into three commits
- Link to v1:
https://lore.kernel.org/r/20240616-peregrine-v1-1-85d14ae1a...@apitzsch.eu
From: André Apitzsch
Add alert interrupt for the temperature sensor of Motorola Moto G 4G
(2013), although not used by the driver yet.
Signed-off-by: André Apitzsch
---
arch/arm/boot/dts/qcom/qcom-msm8926-motorola-peregrine.dts | 12
1 file changed, 12 insertions(+)
diff --git a
From: André Apitzsch
Add the accelerometer, magnetometer and regulator that are present on
the Motorola Moto G 4G (2013) device.
Signed-off-by: André Apitzsch
---
.../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 85 ++
1 file changed, 85 insertions(+)
diff --git a
From: André Apitzsch
Add regulators used by the framebuffer of Motorola Moto G 4G (2013).
Signed-off-by: André Apitzsch
---
.../dts/qcom/qcom-msm8926-motorola-peregrine.dts | 24 ++
1 file changed, 24 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926
From: André Apitzsch
Patch "arm64: dts: qcom: msm8939-longcheer-l9100: Add rear flash" has
been applied twice. This reverts the older version of the patch.
Revert the commit f98bdb21cfc9 ("arm64: dts: qcom:
msm8939-longcheer-l9100: Add rear flash")
Fixes: f98bdb21cfc
From: André Apitzsch
Error handling in probe() can be a bit simpler with dev_err_probe().
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 52 --
1 file changed, 22 insertions(+), 30 deletions(-)
diff --git a/drivers/media/i2c/imx214
From: André Apitzsch
Simplify the imx214_start_streaming() by removing unneeded goto
statements, and the corresponding error label.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/media/i2c
From: André Apitzsch
Port the imx214 sensor driver to use the subdev active state.
Move all the format configuration to the subdevice state and simplify
the format handling, locking and initialization.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 129
This patch series is a collection of miscellaneous cleanups and
improvements to the imx214 driver.
The series converts the driver to the CCI helpers and adds controls
needed to make the driver work with libcamera.
The changes are inspired by the imx219 driver.
Signed-off-by: André Apitzsch
From: André Apitzsch
The imx214 camera is capable of either two-lane or four-lane operation.
Currently only the four-lane mode is supported, as proper pixel rates
and link frequences for the two-lane mode are unknown.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 37
From: André Apitzsch
Add vblank control to allow changing the framerate /
higher exposure values.
The vblank and hblank controls are needed for libcamera support.
While at it, fix the minimal exposure time according to the datasheet.
Signed-off-by: André Apitzsch
---
drivers/media/i2c
From: André Apitzsch
Define macros for all the known registers used in the register arrays,
and use them to replace the numerical addresses. This improves
readability.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 407 ++---
1 file
From: André Apitzsch
Use the new common CCI register access helpers to replace the private
register access helpers in the imx214 driver. This simplifies the driver
by reducing the amount of code.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/Kconfig | 1 +
drivers/media/i2c/imx214.c
From: André Apitzsch
The imx214 sensor supports horizontal and vertical flipping. Add
appropriate controls to the driver.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 73 +-
1 file changed, 65 insertions(+), 8 deletions(-)
diff
From: André Apitzsch
The imx214 sensor supports analogue gain up to 8x and digital gain up to
16x. Implement the corresponding controls in the driver. Default gain
values are not modified by this patch.
Signed-off-by: André Apitzsch
---
With the analogue gain control added by this patch, the
From: André Apitzsch
The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
in the mode_ registers arrays, and once via v4l2_ctrl_ops. The
latter is enough, drop the former.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 2 --
1 file changed, 2 deletions
From: André Apitzsch
Check the chip ID and stop probing if it is no imx214 sensor.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index
From: André Apitzsch
This adds V4L2_CID_TEST_PATTERN control support.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 77 --
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c
From: André Apitzsch
Remove format and crop settings from register sequences and set them
programmatically.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 137 ++---
1 file changed, 105 insertions(+), 32 deletions(-)
diff --git a
From: André Apitzsch
Use the new common CCI register access helpers to replace the private
register access helpers in the imx214 driver. This simplifies the driver
by reducing the amount of code.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/Kconfig | 1
From: André Apitzsch
The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
in the mode_ registers arrays, and once via v4l2_ctrl_ops. The
latter is enough, drop the former.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 2 --
1
From: André Apitzsch
Remove format and crop settings from register sequences and set them
programmatically.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 129 ++---
1 file changed, 97 insertions(+), 32 deletions(-)
diff --git a/drivers
From: André Apitzsch
Error handling in probe() can be a bit simpler with dev_err_probe().
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 52 --
1 file changed, 22 insertions(+), 30 deletions(-)
diff --git
From: André Apitzsch
Port the imx214 sensor driver to use the subdev active state.
Move all the format configuration to the subdevice state and simplify
the format handling, locking and initialization.
While at it, simplify imx214_start_streaming() by removing unneeded goto
statements and the
From: André Apitzsch
This adds V4L2_CID_TEST_PATTERN control support.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 77 --
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c
From: André Apitzsch
The imx214 sensor supports horizontal and vertical flipping. Add
appropriate controls to the driver.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 69 --
1 file changed, 61 insertions(+), 8 deletions(-)
diff
From: André Apitzsch
The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then
IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10),
which works out as 384MPix/s. (The 8 is 4 lanes and DDR.)
Parsing the PLL registers with the defined 24MHz input. We're in single
PLL mod
This patch series is a collection of miscellaneous cleanups and
improvements to the imx214 driver.
The series converts the driver to the CCI helpers and adds controls
needed to make the driver work with libcamera.
The changes are inspired by the imx219 driver.
Signed-off-by: André Apitzsch
From: André Apitzsch
Define macros for all the known registers used in the register arrays,
and use them to replace the numerical addresses. This improves
readability.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 407
From: André Apitzsch
Check the chip ID and stop probing if it is no imx214 sensor.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers
From: André Apitzsch
The imx214 camera is capable of either two-lane or four-lane operation.
Currently only the four-lane mode is supported, as proper pixel rates
and link frequences for the two-lane mode are unknown.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 26
From: André Apitzsch
Add vblank control to allow changing the framerate /
higher exposure values.
The vblank and hblank controls are needed for libcamera support.
While at it, fix the minimal exposure time according to the datasheet.
Signed-off-by: André Apitzsch
---
drivers/media/i2c
From: André Apitzsch
The imx214 sensor supports analogue gain up to 8x and digital gain up to
16x. Implement the corresponding controls in the driver. Default gain
values are not modified by this patch.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c
From: André Apitzsch
Port the imx214 sensor driver to use the subdev active state.
Move all the format configuration to the subdevice state and simplify
the format handling, locking and initialization.
While at it, simplify imx214_start_streaming() by removing unneeded goto
statements and the
From: André Apitzsch
The imx214 sensor supports analogue gain up to 8x and digital gain up to
16x. Implement the corresponding controls in the driver. Default gain
values are not modified by this patch.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c
From: André Apitzsch
Use the new common CCI register access helpers to replace the private
register access helpers in the imx214 driver. This simplifies the driver
by reducing the amount of code.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/Kconfig | 1
From: André Apitzsch
Error handling in probe() can be a bit simpler with dev_err_probe().
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 52 --
1 file changed, 22 insertions(+), 30 deletions(-)
diff --git
From: André Apitzsch
The imx214 camera is capable of either two-lane or four-lane operation.
Currently only the four-lane mode is supported, as proper pixel rates
and link frequences for the two-lane mode are unknown.
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 16
From: André Apitzsch
This adds V4L2_CID_TEST_PATTERN control support.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 77 --
1 file changed, 75 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c
From: André Apitzsch
Define macros for all the known registers used in the register arrays,
and use them to replace the numerical addresses. This improves
readability.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 407
From: André Apitzsch
The IMX214_REG_EXPOSURE is configured twice, once with a hardcoded value
in the mode_ registers arrays, and once via v4l2_ctrl_ops. The
latter is enough, drop the former.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 2 --
1
From: André Apitzsch
Add vblank control to allow changing the framerate /
higher exposure values.
The vblank and hblank controls are needed for libcamera support.
While at it, fix the minimal exposure time according to the datasheet.
Signed-off-by: André Apitzsch
---
drivers/media/i2c
From: André Apitzsch
Check the chip ID and stop probing if it is no imx214 sensor.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 29 +
1 file changed, 29 insertions(+)
diff --git a/drivers/media/i2c/imx214.c b/drivers
This patch series is a collection of miscellaneous cleanups and
improvements to the imx214 driver.
The series converts the driver to the CCI helpers and adds controls
needed to make the driver work with libcamera.
The changes are inspired by the imx219 driver.
Signed-off-by: André Apitzsch
From: André Apitzsch
The imx214 sensor supports horizontal and vertical flipping. Add
appropriate controls to the driver.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 69 --
1 file changed, 61 insertions
From: André Apitzsch
The driver defines IMX214_DEFAULT_LINK_FREQ 48000, and then
IMX214_DEFAULT_PIXEL_RATE ((IMX214_DEFAULT_LINK_FREQ * 8LL) / 10),
which works out as 384MPix/s. (The 8 is 4 lanes and DDR.)
Parsing the PLL registers with the defined 24MHz input. We're in single
PLL mod
Document the Dongwoon DW9719 and DW9761 dt-bindings and add the related
of_match table.
Signed-off-by: André Apitzsch
---
Changes in v3:
- Add patch to document devicetree bindings
- Add "i2c:" to the subject of the 'Add of_match table' commit message
- Link to v2:
https
From: André Apitzsch
Add of_match table for "dongwoon,dw9719" and "dongwoon,dw9761"
compatible string. This fixes automatic driver loading when using a
device-tree, and if built as a module like major linux distributions do.
Signed-off-by: André Apitzsch
---
drivers/me
From: André Apitzsch
Document Dongwoon DW9719 and DW9761 VCM devicetree bindings.
Signed-off-by: André Apitzsch
---
.../bindings/media/i2c/dongwoon,dw9719.yaml| 45 ++
1 file changed, 45 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c
From: André Apitzsch
Use the new common CCI register access helpers to replace the private
register access helpers in the imx214 driver. This simplifies the driver
by reducing the amount of code.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/Kconfig | 1
From: André Apitzsch
Error handling in probe() can be a bit simpler with dev_err_probe().
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 54 +-
1 file changed, 24 insertions(+), 30 deletions(-)
diff --git
From: André Apitzsch
Add vblank control to allow changing the framerate /
higher exposure values.
The vblank and hblank controls are needed for libcamera support.
While at it, fix the minimal exposure time according to the datasheet.
Signed-off-by: André Apitzsch
---
drivers/media/i2c
From: André Apitzsch
Define macros for all the known registers used in the register arrays,
and use them to replace the numerical addresses. This improves
readability.
Acked-by: Ricardo Ribalda
Signed-off-by: André Apitzsch
---
drivers/media/i2c/imx214.c | 407
1 - 100 of 184 matches
Mail list logo
