Hi,
> TC358765 is DSI-to-LVDS transmitter from Toshiba, used in
> OMAP44XX Blaze Tablet and Blaze Tablet2 boards.
I had a really fast look and I have few comments
> +static int tc358765_read_register(struct omap_dss_device *dssdev,
> + u16 reg, u32 *val)
> +{
Hi,
> Thanks for looking into
if you want you can put me in CC and I can review the next
patches (perhaps V2 of the patches)
> >> + mutex_lock(&tc358765_i2c->xfer_lock);
> >> + ret = i2c_transfer(tc358765_i2c->client->adapter, &msg, 1);
> >> + mutex_unlock(&tc358765_i2c->xfer_lock);
Hi Ruslan,
> TC358765 is DSI-to-LVDS transmitter from Toshiba, used in
> OMAP44XX Blaze Tablet and Blaze Tablet2 boards.
I think it's fine, just some nitpicks and checkpatch warnings
> +struct {
> + struct device *dev;
> + struct dentry *dir;
> +} tc358765_debug;
Should this be static?
Hi Dong,
On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote:
> +static int __devinit syscon_probe(struct platform_device *pdev)
> +{
> + struct device *dev = &pdev->dev;
Do we really need this variable? Anyway you are using it only
once in the dev_info.
> + struct device_node *
On Tue, Sep 04, 2012 at 07:46:02PM +0800, Dong Aisheng wrote:
> On Tue, Sep 04, 2012 at 07:35:45PM +0800, Andi Shyti wrote:
> > Hi Dong,
> >
> > On Tue, Sep 04, 2012 at 11:20:08AM +0800, Dong Aisheng wrote:
> > > +static int __devinit syscon_prob
d IRQ functionality to retu-mfd
> - added power button key driver
> - some cleanups
>
> Aaro Koskinen (4):
> i2c: introduce i2c-cbus driver
> mfd: introduce retu-mfd driver
> watchdog: introduce retu_wdt driver
> input: misc: introduce retu-pwrbutton
I had a lo
> +# $ scripts/checkpatch.pl WHATEVER > /tmpcheckpatch.log
^^
I guess you have a typo here.
I actually used this, it doesn't know what msleep is and it
fails, so that to go ahead I had to remove the msleep lines from
/tmp/checpatch.log.
Andi
--
To unsub
Hi,
> As we look at upstreaming more support for the Qualcomm MSM SoCs there are a
> number of drivers or library like routines that are unique to the MSM
> platform, we are thinking that putting them under:
just a question, is this code the one you have already in
codeaurora for 8974/8226/8626
> >just a question, is this code the one you have already in
> >codeaurora for 8974/8226/8626/8610 etc?
> Yes.
Finally, I would say! But you should have done this much earlier
so that you could have made the life of your customers easier and
maybe they could have helped you on upstreaming the cod
From: Onur Atilla
The rate table of the proximity sensor has included
one incorrect value that is not supported by the HW.
This value is now corrected from 25Hz to 20Hz. The
corresponding rate in the time table is corrected to
50ms accordingly.
Signed-off-by: Onur Atilla
Signed-off-by: Andi
prox_read_result() has been split in two functions:
- ps_get_result(): reads the proximity value from the register
- prox_read_result(): applies the logic above the proximity value
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c | 53 +-
1
the prox0_raw file in the sysfs interface reads the proximity
value directly from the register instead of reporting the last
read value; in this way userspace applications can have a real
time value
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c |5 +
1 file changed, 5
From: Onur Atilla
"lux0_raw" file gives the raw Ambient Light Sensor (ALS) value,
before adjusting it with the calibration coefficients, whereas
"lux0_input"returns the calibrated ALS value.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/mis
From: Onur Atilla
The Ambient Light Sensor (ALS) glass attenuation parameter should
be configurable and two new parameters are introduced:
als_scf_BH1770 and als_scf_SFH7770.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
include/linux/i2c/bh1770glc.h |2 ++
1 file changed, 2
From: Onur Atilla
Introduced lux0_glass_factor and lux0_comp_factor on sysfs
lux0_glass_factor and lux0_sensor_comp_factor are provided as
read-only files on the sysfs structure of the bh1770glc optical sensor.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc
top of any branch since they
don't affect any core code.
Thanks,
Andi
Andi Shyti (7):
bh1770glc: added input device interface
bh1770glc: removed proximity adjustement
bh1770glc: split read result function
bh1770glc: logic change in the proximity read
bh1770glc: use min_t instead o
From: Onur Atilla
Removed unused variables and definitions, adjusted some code
alignement and removed trailing spaces.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c | 55 +++--
include/linux/i2c/bh1770glc.h | 25
From: Onur Atilla
Changed the neutral glass attenuation value from 16384
to 8192. This is for adaptation to the new scaling factor.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
include/linux/i2c/bh1770glc.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
lux_raw_result_show() will run directly the lux_get_result()
instead of using another support function
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c
index
als_int_enable is set to 0, then the INT output signal of the
sensor will not be used by the ALS, but only by the proximity
sensor.
The interrupt setting can be changed during runtime by defining
new threshold values for the ambient light sensor.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
From: Onur Atilla
Sensor compensation factor input from the platform
is being checked now before use.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/misc
From: Onur Atilla
Some obsolete version-dependent coefficient and constant settings
were removed out of the sensor detection functions. These values
cause unwanted offset between different sensor types.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c |3
The driver generates an event in /dev/input/ under the name
'bh1770'. It's a switch event where is reported '0' or '1'
whenever the sensor detects something crossing the threshold.
Signed-off-by: Onur Atilla
Signed-off-by: Phil Carmody
Signed-off-by: Andi S
sensor
sysfs interface.
Signed-off-by: Andi Shyti
Signed-off-by: Onur Atilla
---
drivers/misc/bh1770glc.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c
index bd90eaf..b5fc2b9 100644
--- a/drivers/misc
actual status of the proximity interrupt, the threshold
is set dynamically using a newly introduced hysteresis value.
Hysteresis is a configurable parameter.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c | 96
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/bh1770glc.c b/drivers/misc/bh1770glc.c
index 031a9fa..bd90eaf 100644
--- a/drivers/misc/bh1770glc.c
+++ b/drivers/misc/bh1770glc.c
@@ -273,7 +273,7 @@ static
From: Onur Atilla
Instead of using a constant value, the LED current
of the proximity sensor is now made individually
configurable for each product.
bh1770glc reads the platform-defined data and sets
the most suitable current value accordingly.
Signed-off-by: Onur Atilla
Signed-off-by: Andi
proximity sensor doesn't need to be adjusted; removed all the
overcode used for the proximity coefficients
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c | 39 ++-
1 file changed, 2 insertions(+), 37 deletions(-)
diff --git a/drivers
From: Onur Atilla
Changed all exposed scalers to 8192 (Q13) in order to
achieve consistency in the sysfs interface.
Signed-off-by: Onur Atilla
Signed-off-by: Andi Shyti
---
drivers/misc/bh1770glc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc
,
Andi
Andi Shyti (2):
drivers/misc: etzkx driver for kxcnl/kxtnk accelerometer
Documentation: added etzkx driver documentation
Documentation/misc-devices/etzkx.txt | 325 +
drivers/misc/Kconfig | 12 +
drivers/misc/Makefile|1 +
drivers/misc/etzkx.c
The etzkx driver's documentation contains some basic information about
- accelerometer chip overview
- driver interfaces
- driver usage
Signed-off-by: Andi Shyti
Reviewed-by: Onur Atilla
---
Documentation/misc-devices/etzkx.txt | 325 ++
1 file changed
> > these two patches provide the etzkx device driver which supports
> > the following accelerometers:
> >
> > - Kionix kxcnl
> > - Kionix kxtnk
> > - ST lisn3dsh
> >
> > Support for ST lis3dsh accelerometer is still in progress.
> >
> > The etzkx accelerometers are a kind of devices that are
> > > > these two patches provide the etzkx device driver which supports
> > > > the following accelerometers:
> > > >
> > > > - Kionix kxcnl
> > > > - Kionix kxtnk
> > > > - ST lisn3dsh
> > > >
> > > > Support for ST lis3dsh accelerometer is still in progress.
> > > >
> > > > The etzkx accel
Hi Greg,
> > The driver generates an event in /dev/input/ under the name
> > 'bh1770'. It's a switch event where is reported '0' or '1'
> > whenever the sensor detects something crossing the threshold.
> >
> > Signed-off-by: Onur
> > Introduced lux0_glass_factor and lux0_comp_factor on sysfs
> >
> > lux0_glass_factor and lux0_sensor_comp_factor are provided as
> > read-only files on the sysfs structure of the bh1770glc optical sensor.
>
> You can't add/remove/modify sysfs files without the proper
> Documentation/ABI chang
> > This patchset contains a collection of new features and fixes for
> > the bh1770glc driver for the BH1770 and SFH7770 proximity
> > and ambient light sensor device.
>
> Remind me again why this isn't an drivers/iio/ driver, using that api?
Well, the driver is not written by me, I just found i
> > > > The driver generates an event in /dev/input/ under the name
> > > > 'bh1770'. It's a switch event where is reported '0' or '1'
> > > > whenever the sensor detects something crossing the threshold.
> > > >
> > > Doesn't this mean that this driver is now an "input" driver, so it
> > > should
Hi Joseph,
had a fast look...
[ ... ]
> +static int dm9620_set_eeprom(struct net_device *net,
> + struct ethtool_eeprom *eeprom, u8 *data)
> +{
> + struct usbnet *dev = netdev_priv(net);
> + int offset = eeprom->offset;
> + int len = eeprom->len;
> + int done;
> +
> +
if 'copy_from_user' fails, the 'rsxx_cram_write()' function
returns without freeing the allocated buffer 'buf'.
Free 'buf' before returning.
This issue has been reported by scan.coverity.com
Signed-off-by: Andi Shyti
---
drivers/block/rsxx/core.c | 4
Free 'buf' before returning.
the 'rsxx_cram_write()' function returns twice without freeing
the allocated buffer 'buf' causing a possible memory leak.
This issue has been reported by scan.coverity.com
Signed-off-by: Andi Shyti
---
drivers/block/rsxx/core.c
Hi,
this version is a bit better since it fixes two memleak situations.
Andi
Andi Shyti (1):
rsxx: core: fix memory leak
drivers/block/rsxx/core.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
--
1.8.4.rc2
--
To unsubscribe from this list: send the line "unsubscribe
in the sq_overhead() function, if qp_typ is equal to IB_QPT_RC,
size will be used uninitialized.
Signed-off-by: Andi Shyti
---
drivers/infiniband/hw/mlx5/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
Hi Steve,
> Your patch looks reasonable. Would you repost the patch to
> linux-cifs mailing list (and add any additional reviewers or testers
> if you would like if you got feedback)?
Thanks for your mail,
Actually linux-cifs is on CC and this is the output of
get_maintainer:
Steve French (s
e function jumps
to the label reopen_success and checks for oparms.reconnect
which is not initialized.
To avoid this the oparms structure initialization is anticipated
before the if statement.
This issue has been reported by scan.coverity.com
Signed-off-by: Andi Shyti
---
fs/cifs/file.c | 18
> > + oparms.tcon = tcon;
> > + oparms.cifs_sb = cifs_sb;
> > + oparms.desired_access = desired_access;
> > + oparms.create_options = create_options;
>
> This patch just moves the brokenness around. You're
> setting .desired_access here to an unintialized variable.
> create_options also lo
s
to the label reopen_success and checks for oparms.reconnect
which is not initialized.
This issue has been reported by scan.coverity.com
Signed-off-by: Andi Shyti
---
fs/cifs/file.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index 1e57f36..7e36ae3 100644
Hi Greg,
> > > > these two patches provide the etzkx device driver which supports
> > > > the following accelerometers:
> > >
> > > Why isn't this a drivers/iio/accel/ driver instead of a misc driver?
> > > Please make this an iio driver, then you will be using the correct
> > > user/kernel api t
This patch enables CONFIG_DETTMPFS and CONFIG_DEVTMPFS_MOUNT
flags for u8500 based devices.
In this way it's possible to create a tmpfs/ramfs already in the
early stages of the boot, allowing programs like udev/mdev to
populate the /dev directory.
Signed-off-by: Andi Shyti
---
arch/arm/co
: Andi Shyti
---
net/9p/trans_rdma.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 928f2bb..8f68df5 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -588,17 +588,6 @@ static int rdma_cancel(struct p9_client *client
From: Andi Shyti
This patch gets rid of the following warning:
drivers/video/vga16fb.c: In function ‘vga16fb_destroy’:
drivers/video/vga16fb.c:1268:26: warning: unused variable ‘dev’
[-Wunused-variable]
struct platform_device *dev = container_of(info->device, struct
platform_device,
e function jumps
to the label reopen_success and checks for oparms.reconnect
which is not initialized.
To avoid this the oparms structure initialization is anticipated
before the if statement.
Signed-off-by: Andi Shyti
---
fs/cifs/file.c | 18 +-
1 file changed, 9 insertions(+), 9 delet
This is patch 1/1, not 2/2... messed up with git.
Andi
On Mon, Jul 22, 2013 at 09:24:00PM +0200, Andi Shyti wrote:
> In the cifs_reopen_file function, if the following statement is
> asserted:
>
> (tcon->unix_ext && cap_unix(tcon->ses) &&
>
free bvec_integrity_pool if it's allocated, not bio_integrity_pool
Signed-off-by: Andi Shyti
---
fs/bio-integrity.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
index 8fb4291..45e944f 100644
--- a/fs/bio-integrity.c
+++ b/f
alloc_rbio frees already bbio and raid_map, therefore they don't
need to be freed in case it fails
Signed-off-by: Andi Shyti
---
fs/btrfs/raid56.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c
index 0525e13..35fe775 100644
if ext_debugging is enabled and path[depth].p_ext is NULL, len
and lblock are printed non initialized
Signed-off-by: Andi Shyti
---
fs/ext4/extents.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index a618738..acaf53c 100644
Hi,
> To be more precise, there's a single call to c->trans_mode->cancelled in
> net/9p/client.c, in p9_client_flush, which is called on subfunction returning
> -ERESTARTSYS... which never happens as far as I could see.
>
> This will be useful once/if we start working on client recovery, though
>
This patch reverts commit
80b45261a0b263536b043c5ccfc4ba4fc27c2acc
which was implementing a 'cancelled' functionality to notify that
a cancelled request will not be replied.
This implementation was not used anywhere and therefore removed.
Signed-off-by: Andi Shyti
---
incl
Hi David,
On Thu, Jul 25, 2013 at 10:54:24AM +0200, Andi Shyti wrote:
> This patch reverts commit
>
> 80b45261a0b263536b043c5ccfc4ba4fc27c2acc
>
> which was implementing a 'cancelled' functionality to notify that
> a cancelled request will not be replied.
>
>
Hi Tony,
> for your very helpful comments on all on the patches in this first submission
> attempt, I will digest and regurgitate a second attempt as soon as I can.
once you have digested and regurgitated :), you could also split
the patchset in smaller patches, I would say at least one patch
pe
> >> + char name[30];
> >> + char buf[50];
> >> +
> >> + if (size >= sizeof(buf))
> >> + size = sizeof(buf);
> >
> > what's the point of this?
>
> This is a way to limit copied from userspace data by available buffer size,
> widely used in current kernel sources. Are you im
Hi Sean,
> > The driver type can be assigned immediately when an RC device
> > requests to the framework to allocate the device.
> >
> > This is an 'enum rc_driver_type' data type and specifies whether
> > the device is a raw receiver or scancode receiver. The type will
> > be given as parameter
Hi Sean,
> > + if (dev->driver_type == RC_DRIVER_IR_RAW ||
> > + dev->driver_type == RC_DRIVER_IR_RAW_TX) {
>
> Here the if is wrong. It should be
> "if (dev->driver_type != RC_DRIVER_IR_RAW_TX)". Note that as result
> the decoder thread is not started, so patch 4 won
Hi Sean,
> > Raw transmitters receive the data which need to be sent to
> > receivers from userspace as stream of bits, they don't require
> > any handling from the lirc framework.
>
> No drivers of type RC_DRIVER_IR_RAW_TX should handle tx just like any
> other device, so data should be provided
Hi Sean,
> > + int ret;
> > + struct ir_spi_data *idata = (struct ir_spi_data *) dev->priv;
>
> No cast needed.
yes, thanks.
> > + ret = regulator_enable(idata->regulator);
> > + if (ret)
> > + return ret;
> > +
> > + mutex_lock(&idata->mutex);
> > + idata->xfer.len = n;
>
Hi Sean,
> > > > + ret = regulator_enable(idata->regulator);
> > > > + if (ret)
> > > > + return ret;
> > > > +
> > > > + mutex_lock(&idata->mutex);
> > > > + idata->xfer.len = n;
> > > > + idata->xfer.tx_buf = buffer;
> > > > + mutex_unlock(&idata
Hi Tomasz,
> >> > The SPI 3 bus uses two clocks, a bus clock and an input clock.
> >> > Do not disable the clocks when unused in order to allow access to
> >> > the SPI 3 device.
> >>
> >> If unused, why would access to SPI 3 device needed?
> >
> > because next I will submit a small driver which u
> Unfortunately I have to NAK this patch. Please add proper support for
> them to the SPI driver.
I agree, this is quite a lazy solution.
But your comment is giving me more work than what I was willing
to have, also because in this driver the SPI1 is aslo using
CLK_IGNORE_UNUSED :)
Thanks for yo
Transmitters do not need to wait until the data has been sent
(and of course received). Return before waiting.
Signed-off-by: Andi Shyti
---
drivers/media/rc/ir-lirc-codec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc
ice device.
Change accordingly all the drivers calling rc_allocate_device()
so that the device type is specified during the rc device
allocation. Whenever the device type is not specified, it will be
set as RC_DRIVER_SCANCODE which was the default '0' value.
Suggested-by: Sean Young
converts it to
a bit stream.
Thanks,
Andi
Andi Shyti (7):
[media] rc-main: assign driver type during allocation
[media] rc-main: split setup and unregister functions
[media] rc-core: add support for IR raw transmitters
[media] rc-ir-raw: do not generate any receiving
urn -1;
val = 60;
ret = ioctl(fd, LIRC_SET_SEND_DUTY_CYCLE, &val);
if (ret < 0)
return -1;
n = write(fd, buffer, BUF_LEN);
if (n < 0 || n != BUF_LEN)
ret = -1;
close(fd);
Signed-off-by: Andi Shyti
---
d
Document the ir-spi driver's binding which is a IR led driven
through the SPI line.
Signed-off-by: Andi Shyti
---
Documentation/devicetree/bindings/media/spi-ir.txt | 26 ++
1 file changed, 26 insertions(+)
create mode 100644 Documentation/devicetree/bindings/medi
Raw IR transmitters do not need any thread listening for
occurring events. Check the driver type before running the
thread.
Signed-off-by: Andi Shyti
---
drivers/media/rc/rc-ir-raw.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/media/rc/rc-ir
Move the input device allocation, map and protocol handling to
different functions.
Signed-off-by: Andi Shyti
---
drivers/media/rc/rc-main.c | 144 +
1 file changed, 81 insertions(+), 63 deletions(-)
diff --git a/drivers/media/rc/rc-main.c b/drivers
need to be
registered as raw devices.
Suggested-by: Sean Young
Signed-off-by: Andi Shyti
---
drivers/media/rc/rc-main.c | 39 +++
include/media/rc-core.h| 9 ++---
2 files changed, 29 insertions(+), 19 deletions(-)
diff --git a/drivers/media/rc/rc-m
Hi Sean,
> > ir = kzalloc(sizeof(*ir), GFP_KERNEL);
> > - dev = rc_allocate_device();
> > + dev = rc_allocate_device(RC_DRIVER_IR_RAW);
> > if (!ir || !dev)
> > goto err_out_free;
> >
>
> If ir->sampling = 0 then it should be RC_DRIVER_SCANCODE.
>
>
> > @@ -481,7 +481,
> Thanks Andi, this is looking great!
Thanks Sean! With your reviews the whole thing looks much better
now :)
I agree with all your points here, I will fix them. Can I add
your reviewd-by?
Thanks,
Andi
Hi Rob,
> > Document the ir-spi driver's binding which is a IR led driven
> > through the SPI line.
> >
> > Signed-off-by: Andi Shyti
> > ---
> > Documentation/devicetree/bindings/media/spi-ir.txt | 26
> > ++
> > 1 f
Hi Gustavo,
> desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
> dma->direction, DMA_PREP_INTERRUPT);
>
> + if (!desc) {
> + dev_err(&sdd->master->dev,
> + "%s:dmaengine_prep_slave_sg Failed\n", __func__)
Add the binding file for the Samsung capacitive multi-touch
touchscreen S6SY761.
Signed-off-by: Andi Shyti
Acked-by: Rob Herring
---
.../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++
1 file changed, 34 insertions(+)
create mode 100644
Documentation/devicetree
'
- use max_t instead of '? :'
- use managed 'devm_device_add_group()'
Andi Shyti (2):
dt-bindings: Input: add Samsung S6SY761 touchscreen binding file
Input: add support for the Samsung S6SY761 touchscreen
.../bindings/input/touchscreen/samsung,s6sy761.txt | 34 ++
dr
h, in the version
I currently have, doesn't provide all the possible
functionalities mentioned in the datasheet.
Signed-off-by: Andi Shyti
---
drivers/input/touchscreen/Kconfig | 11 +
drivers/input/touchscreen/Makefile | 1 +
drivers/input/touchscreen/s6sy7
ned-off-by: Andi Shyti
---
drivers/input/touchscreen/ad7877.c | 15 ++-
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/input/touchscreen/ad7877.c
b/drivers/input/touchscreen/ad7877.c
index 3a4230219b23..c8a143db8681 100644
--- a/drivers/input/touchscreen/ad78
Allocate the driver's structure by using devm_kzalloc instead of
simple kzalloc and remove all the related kfree calls.
CC: Michael Hennerich
Signed-off-by: Andi Shyti
---
drivers/input/touchscreen/ad7877.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/
Allocate the input device by using the devm_input_allocate_device
function and remove all the related cleanup function and adjust
the goto error handlings accordingly.
CC: Michael Hennerich
Signed-off-by: Andi Shyti
---
drivers/input/touchscreen/ad7877.c | 18 ++
1 file changed
Request the interrupt by using its related managed
devm_request_threaded_irq function, remove the cleanup function
calls and adjust the goto error handlings accordingly.
CC: Michael Hennerich
Signed-off-by: Andi Shyti
---
drivers/input/touchscreen/ad7877.c | 7 ++-
1 file changed, 2
to reject it.
Thanks,
Andi
[*] https://marc.info/?l=linux-input&m=150671805312148&w=2
Andi Shyti (5):
Input: ad7897 - use managed devm_kzalloc
Input: ad7897 - use managed devm_input_allocate_device
Input: ad7897 - use managed devm_request_threaded_irq
Input: ad7897 - use
Split the error between devm_kzalloc and
devm_input_allocate_device, there is no need to call the second
allocator if the first has failed. Besides this doesn't provide
practical advantages.
CC: Michael Hennerich
Signed-off-by: Andi Shyti
---
drivers/input/touchscreen/ad7877.c | 3 +++
1
ant you can add:
Reviewed-by: Andi Shyti
Andi
the relative sysfs_remove_group and goto label.
> >
> > CC: Michael Hennerich
> > Signed-off-by: Andi Shyti
> > ---
> > drivers/input/touchscreen/ad7877.c | 8 ++--
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drive
Hi Pavel,
> > AFAIR Fedin was talking about missing functionality, not about adding
> > the contribution by himself. So he might add it or he might not. I did
> > not receive any commitments from him.
>
> I am waiting for the driver to be integrated, because i see it's constantly
> redesigned.
On Tue, Oct 20, 2015 at 02:45:37PM +0530, Pankaj Dubey wrote:
> This patch adds Exynos SROM controller driver which will handle
> save restore of SROM registers during S2R.
>
> Signed-off-by: Pankaj Dubey
...
> +config EXYNOS_SROM
> + bool
> + depends on ARM && ARCH_EXYNOS && PM
Cool,
Hi Derek,
next time, could you please avoid using html mails when replying
to the mailing list? They are not clear.
On Fri, Aug 24, 2018 at 04:07:41PM -0700, dbasehore . wrote:
>
>
> On Fri, Aug 24, 2018 at 1:49 AM Andi Shyti wrote:
>
> Hi Derek,
>
> > > &
Hi Colin,
On Tue, Aug 28, 2018 at 03:56:48PM +0100, Colin King wrote:
> From: Colin Ian King
>
> Pointer 'nb' is being assigned but is never used hence it is
'np' here. Other than that,
Reviewed-by: Andi Shyti
Andi
> redundant and can be removed.
>
&
Hi Derek,
> > > On Thu, Aug 23, 2018 at 04:10:13PM -0700, Derek Basehore wrote:
> > > > We only need to wait 10ms instead of 30ms before starting fastboot or
> > > > sending IAP on the touchscreen. Also, instead of delaying everytime
> > > > sw_reset is called, this delays 10ms in the function tha
ore we disable
> interrupts/allocate memory for debug buffers.
>
> Fixes: fd335ab04b3f ("Input: edt-ft5x06 - add support for M09 firmware
> version")
> Signed-off-by: Dmitry Torokhov
makes sense!
Reviewed-by: Andi Shyti
Andi
> ---
> drivers/input/touchscreen/edt-ft5x
Hi Dmitry,
On Wed, Jan 24, 2018 at 11:38:01AM -0800, Dmitry Torokhov wrote:
> Rely on the platform (device tree, ACPI, etc) to properly configure
> interrupt trigger/polarity instead of hardcoding the falling edge.
>
> Signed-off-by: Dmitry Torokhov
Reviewed-by: Andi Shyti
Tes
d error handling for input_mt_init_slots().
>
> Signed-off-by: Dmitry Torokhov
Reviewed-by: Andi Shyti
Tested-by: Andi Shyti
Thanks,
Andi
mitry Torokhov
yes, looks better. I'm happy you dropped the
(mms114_parse_dt(data) < 0).
Reviewed-by: Andi Shyti
Tested-by: Andi Shyti
Thanks,
Andi
> ---
> .../bindings/input/touchscreen/mms114.txt | 29 ++--
> drivers/input/touchscreen/mms114.c
25841
> Signed-off-by: Dmitry Torokhov
also here
Reviewed-by: Andi Shyti
Tested-by: Andi Shyti
one small nitpick:
> @@ -239,14 +249,33 @@ static int mms114_get_version(struct mms114_data *data)
> {
> struct device *dev = &data->client->dev;
> u8 buf[6]
1 - 100 of 499 matches
Mail list logo
