Hi, > To be more precise, there's a single call to c->trans_mode->cancelled in > net/9p/client.c, in p9_client_flush, which is called on subfunction returning > -ERESTARTSYS... which never happens as far as I could see. > > This will be useful once/if we start working on client recovery, though > - so the function in itself definitely does interest me, and I guess > that thinking about I would have preferred to have the hook added rather > than the function removed. > But there definitely is no hurry to add this cancelled function till > then.
I would prefer to NACK my patch, it messes up things more than fixes. If we really want to get rid of this function we should completely revert this patch: 80b45261a0b263536b043c5ccfc4ba4fc27c2acc otherwise, spread in the code, there will be empty references to the 'cancelled' function (struct p9_trans_module in transport.h and the one you mentioned). I would rather prefer Paul's approach to mine, let's just get rid of the warning :) Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
