On Mon, Jul 07, 2014 at 03:42:04PM -0700, Paul E. McKenney wrote:
> From: "Paul E. McKenney"
>
> Drop Dipankar Sarma at his request (https://lkml.org/lkml/2014/6/2/628),
> add Josh Triplett based on long-term review, contributions, and
> agreement to take on this role (h
On Wed, Jul 16, 2014 at 09:01:52PM -0400, Pranith Kumar wrote:
> Sure, please find an updated patch with Josh Triplett's sign-off added:
It appears to have a reviewed-by from someone named "Joe Tripplett"
instead. ;)
> From: Pranith Kumar
> Date: Mon, 14 Jul 2014 16:01:05 -0400
> Subject: [PATCH
gt; make -j8 C=2 CLOG=
>
> Any feed back for this change? I want to clarify that this patch
> is for the Linux kernel kbuild system, not sparse.
Seems reasonable to me.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
th Kumar.
>
> 3.Add acquire/release barrier to memory-barrier pairing rules.
>
> 4.Add pointer to percpu-ref in rcuref.txt documentation.
For all four:
Reviewed-by: Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the
On Thu, Apr 17, 2014 at 05:18:35PM +0900, Masami Hiramatsu wrote:
> Use NOKPROBE_SYMBOL macro to protect functions from
> kprobes instead of __kprobes annotation in notifier.
>
> Signed-off-by: Masami Hiramatsu
> Reviewed-by: Steven Rostedt
> Cc: Josh Triplett
>
scheduler IPI that did nothing...)
I wonder if timer slack would make sense here: when you have at least
one RCU callback pending, set a timer with a huge amount of timer slack,
and cancel it if you end up handling the callback via a trip through the
scheduler.
- Josh Triplett
--
To unsubscribe
ning in isci/phy.c:
> > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for
> > ‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
>
> Acked-by: Lukasz Dorau
Since
; \
> sizeof(t) < (1 << _IOC_SIZEBITS)) ? \
> sizeof(t) : __invalid_size_argument_for_IOC)
>
> If it is defined as this (as is already done if __KERNEL__ is not defined):
>
> #define _IOC_TYPECHECK(t) (sizeof(t))
>
> then all is well with the world.
>
> This pa
On Thu, May 22, 2014 at 11:51:04AM -0700, Kees Cook wrote:
> Since the rcutorture thread creation interface does not include format
> string arguments, make sure the name can never be accidentally processed
> as a format string.
>
> Signed-off-by: Kees Cook
Reviewed-by
On Thu, May 22, 2014 at 09:58:02PM +0200, Rickard Strandqvist wrote:
> Removal of null pointer checks that could never happen
>
> Signed-off-by: Rickard Strandqvist
Reviewed-by: Josh Triplett
> drivers/staging/rtl8188eu/os_dep/usb_intf.c | 110
> +-
On Sat, May 24, 2014 at 03:06:08PM +0200, Fabian Frederick wrote:
> Convert all except KERN_DEBUG
Why not KERN_DEBUG?
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
Reviewed-by: Josh Triplett
> lib/debugobjects.c | 12 +---
> 1 file cha
On Sat, May 24, 2014 at 03:06:55PM +0200, Fabian Frederick wrote:
> Add ODEBUG: prefix to pr_fmt
>
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
Reviewed-by: Josh Triplett
> lib/debugobjects.c | 13 -
> 1 file changed, 8 inser
On Sat, May 24, 2014 at 03:07:19PM +0200, Fabian Frederick wrote:
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
No, don't make this change. A quick "git grep __initdata" shows that to
the extent it has a consistent placement, it'
On Sat, May 24, 2014 at 03:08:06PM +0200, Fabian Frederick wrote:
> Fix some checkpatch warnings.
>
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
Some of these make sense, one of them does not. Comments below.
Also, please explicitly note the chec
Adding Andy and Joe to CC.
On Sun, May 25, 2014 at 05:13:38AM +0200, Fabian Frederick wrote:
> On Sat, 24 May 2014 14:56:35 -0700
> Josh Triplett wrote:
>
> > On Sat, May 24, 2014 at 03:07:19PM +0200, Fabian Frederick wrote:
> > > Cc: Josh Triplett
> > > Cc: A
On Sun, May 25, 2014 at 05:18:36AM +0200, Fabian Frederick wrote:
> On Sat, 24 May 2014 14:53:22 -0700
> Josh Triplett wrote:
>
> > On Sat, May 24, 2014 at 03:06:08PM +0200, Fabian Frederick wrote:
> > > Convert all except KERN_DEBUG
> >
> > Why not KERN
On Tue, May 27, 2014 at 04:25:54PM +0200, Fabian Frederick wrote:
> On Sat, 24 May 2014 20:40:43 -0700
> Josh Triplett wrote:
>
> > On Sun, May 25, 2014 at 05:18:36AM +0200, Fabian Frederick wrote:
> > > On Sat, 24 May 2014 14:53:22 -0700
> > > Josh Triplett wro
This makes it more likely that patch submitters will CC API/ABI changes
to the linux-api list, and tools like get_maintainer.pl will do so
automatically.
Signed-off-by: Josh Triplett
Acked-by: Steven Rostedt
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS
>
> 44. Remove __init from torture_init_begin() and torture_init_end()
> to allow rcutorture to once again work as a loadable module.
>
> 45. Remove unused torture_parm() macro.
I responded with feedback on patches 1, 6, 7, 8, 10, 11, 12, 15, 18, 19,
20, 21, 24, 27, 32, 39, and 41.
For the remaining patches:
Reviewed-by: Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
;
> That said, I haven't thought that far down that path.
>
> So for the --defconfig argument, I was thinking more in terms of things
> like pseries_defconfig or versatile_defconfig.
Ah, I see. --defconfig specifies the base configuration, while
--configs specifies the constra
On Wed, May 07, 2014 at 07:43:24PM -0700, Paul E. McKenney wrote:
> On Wed, May 07, 2014 at 06:54:08PM -0700, Josh Triplett wrote:
> > On Wed, May 07, 2014 at 04:52:40PM -0700, Paul E. McKenney wrote:
> > > On Wed, May 07, 2014 at 02:22:19PM -0700, j...@joshtriplett.org wrote:
&
On Thu, May 29, 2014 at 09:24:08AM +0200, Fabian Frederick wrote:
> Add ODEBUG: prefix to pr_fmt
>
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
Reviewed-by: Josh Triplett
> lib/debugobjects.c | 13 -
> 1 file changed, 8 inser
On Thu, May 29, 2014 at 09:22:58AM +0200, Fabian Frederick wrote:
> Convert all printk to pr_foo() except KERN_DEBUG
> (see Documentation/CodingStyle Chapter 13)
>
> Cc: Josh Triplett
> Cc: Andrew Morton
> Signed-off-by: Fabian Frederick
Reviewed-by: Josh Triplett
> li
On Thu, May 29, 2014 at 09:25:32AM +0200, Fabian Frederick wrote:
> Direct conversion of one KERN_DEBUG message without DEBUG definition
> (suggested by Josh Triplett)
>
> That message will now be disabled by default.
> (see Documentation/CodingStyle Chapter 13)
>
> Cc
:35 -0700, Andrew Morton wrote:
> >>>> On Mon, 2 Jun 2014 10:00:20 -0700 "Paul E. McKenney"
> >>>> wrote:
> >>>>
> >>>>> --- a/MAINTAINERS
> >>>>> +++ b/MAINTAINERS
> >>>>> @@ -7321,6 +732
On Mon, Jun 02, 2014 at 08:11:36PM -0700, Joe Perches wrote:
> On Mon, 2014-06-02 at 18:51 -0700, Josh Triplett wrote:
> > git send-email can invoke 'scripts/get_maintainer.pl --no-rolestats'
> > directly via --to-cmd or -cc-cmd; that works fine as long as you don&
On Fri, Jun 13, 2014 at 01:48:22PM -0700, Paul E. McKenney wrote:
> On Fri, Jun 13, 2014 at 09:44:41AM -0700, Josh Triplett wrote:
> > On Fri, Jun 13, 2014 at 06:21:32PM +0200, Frederic Weisbecker wrote:
> > > On Fri, Jun 13, 2014 at 09:16:30AM -0700, Paul E. McKenney wrot
On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote:
> Very dumb patch to just skip --param allow-store-data-races=0 introduced in
> newest Linux kernel buildsystem.
>
> Actually the option is present in few GCC versions and probably should be
> handled properly.
>
> Signed-off-by: An
On Mon, Jun 16, 2014 at 04:48:51PM -0700, David Rientjes wrote:
> On Mon, 16 Jun 2014, Josh Triplett wrote:
>
> > On Mon, Jun 16, 2014 at 01:43:06PM +0300, Andy Shevchenko wrote:
> > > Very dumb patch to just skip --param allow-store-data-races=0 introduced
> > >
ething (functionally) like the attached patch? Instead
> of counting cond_resched() calls, we could just specify some future time
> by which we want have a quiescent state. We could even push the time to
> be something _just_ before we would have declared a stall.
Looks quite pr
tting patches that uglify code to quiet checkpatch's
line-width limit.
The on-by-default DEEP_INDENTATION warning for lines indented more than
6 levels deep makes more sense as a default, to encourage people to
refactor, since it cannot be "fixed" by simply reformatting code.
Signed-o
clock source is to associate user space
> events with kernel events on a given kernel. It is explicitly not
> supposed to be used as a generic time source and won't necessarily be
> consistent between kernels.
>
> Signed-off-by: Sonny Rao
Reviewed-by: Josh Triplett
--
To u
fter the LOCK
> - operation has completed.
> + operation has completed. An smp_mb__before_spinlock(), combined
> + with a following LOCK, acts as an smp_wmb(). Note the "w",
> + this is smp_wmb(), not smp_mb(). The smp_mb__before_spinlock()
> + pr
so.
More importantly: you document this earlier in the patch series than you
introduce it.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
s
> when the UNLOCK and LOCK are on different variables.
That would certainly be a good assumption to preserve, and it would
eliminate most of the need for smp_mb__after_unlock_lock().
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
ppc
Or, ppc could fix its lock primitives to preserve the unlock+lock
assumption, and avoid subtle breakage across half the kernel.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
the rcu_assign_pointer() invocations in the kernel. This commit
> courtesy of Josh Triplett.
>
> 4.Add an RCU_INITIALIZER() for compile-time initialization of
> global RCU-protected pointers.
For all the patches (other than the one I wrote, for obvious reasons):
Reviewed-by: Josh
complete_pio ceased to exist in commit
7972995b0c346de76fe260ce0fd6bcc8ffab724a ("KVM: x86 emulator: Move
string pio emulation into emulator.c"), but the prototype remained.
Remove its prototype.
Signed-off-by: Josh Triplett
---
arch/x86/include/asm/kvm_host.h | 1 -
1 file changed,
The prototype for kvm_check_iopl appeared in commit
f850e2e603bf5a05b0aee7901857cf85715aa694 ("KVM: x86 emulator: Check IOPL
level during io instruction emulation"), but the function never actually
existed. Remove the prototype.
Signed-off-by: Josh Triplett
---
arch/x86/include/asm/
many prospective driver authors learn
the give-and-take required to successfully participate in the community.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
/stable_api_nonsense.txt.
Document both of these in Documentation/ABI/README, in a new section for
notable bits of non-ABI.
Signed-off-by: Josh Triplett
---
Documentation/ABI/README | 13 +
1 file changed, 13 insertions(+)
diff --git a/Documentation/ABI/README b/Documentation/ABI/README
index 1006982
On Thu, Oct 24, 2013 at 10:57:11AM +0200, Richard Weinberger wrote:
> On Thu, Oct 24, 2013 at 10:41 AM, Josh Triplett wrote:
> > Discussion at Kernel Summit made it clear that the presence or absence
> > of specific Kconfig symbols are not considered ABI, and that no
> > use
itional on CONFIG_BUG, and map them all to the passthrough WARN_ON
when !CONFIG_BUG.
This saves 4.4k on a minimized configuration (smaller than
allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n.
Signed-off-by: Josh Triplett
---
include/asm-generic/
: Josh Triplett
---
include/linux/lglock.h | 16
kernel/Makefile| 4 ++--
2 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/include/linux/lglock.h b/include/linux/lglock.h
index 0d24e93..6561b1c 100644
--- a/include/linux/lglock.h
+++ b/include/linux/lglock.h
--no-edit -f $commit_containing_bug
Generalize append_signoff to support appending arbitrary extra lines to
a commit in the signoff block; this avoids duplicating the logic to find
or construct that block.
Signed-off-by: Josh Triplett
---
Documentation/git-commit.txt | 12 ++--
On Sun, Oct 27, 2013 at 06:42:44AM +0100, Michael Haggerty wrote:
> On 10/27/2013 02:34 AM, Josh Triplett wrote:
> > Linux Kernel Summit 2013 decided on a commit message convention to
> > identify commits containing bugs fixed by a commit: a "Fixes:" line,
> >
On Sun, Oct 27, 2013 at 03:33:19PM +0700, Duy Nguyen wrote:
> On Sun, Oct 27, 2013 at 8:34 AM, Josh Triplett wrote:
> > Add a command line option for git commit to automatically construct the
> > "Fixes:" line for a commit. This avoids the need to manually construct
>
On Sun, Oct 27, 2013 at 09:09:32AM +0100, Thomas Rast wrote:
> Josh Triplett writes:
>
> > On Sun, Oct 27, 2013 at 06:42:44AM +0100, Michael Haggerty wrote:
> >> But I don't think that this feature should be given the "-f" short
> >> option, as (a)
On Sun, Oct 27, 2013 at 01:03:47AM -0700, Michel Lespinasse wrote:
> On Sun, Oct 27, 2013 at 12:14 AM, Josh Triplett wrote:
> >> > +-f ::
> >> > +--fixes=::
> >> > + Add Fixes line for the specified commit at the end of the commit
> >> >
sing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/ssb/main.c | 19 ---
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
> index 32a811d..8138952 100644
> --- a/drivers/ssb/main.c
ng: no previous prototype for
> ‘sfi_map_table’ [-Wmissing-prototypes]
> drivers/sfi/sfi_core.c:192:6: warning: no previous prototype for
> ‘sfi_unmap_table’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/sfi/sfi_core.c
ecessary for including ide-cd.h.
>
> This eliminates the following warnings in ide-cd_verbose.c:
> drivers/ide/ide-cd_verbose.c:251:6: warning: no previous prototype for
> ‘ide_cd_log_error’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
&
declarations necessary for include/linux/sfi_acpi.h.
>
> This eliminates the following warning in sfi_acpi.c:
> drivers/sfi/sfi_acpi.c:154:5: warning: no previous prototype for
> ‘sfi_acpi_table_parse’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by:
owing warning in ide-pio-blacklist.c:
> drivers/ide/ide-pio-blacklist.c:85:5: warning: no previous prototype for
> ‘ide_scan_pio_blacklist’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/ide/ide-pio-blacklist.c |1 +
> 1
are extremely low risk, don't actually
change the compiled code in any way like some of those did, and fix real
compiler warnings.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
On Tue, Dec 17, 2013 at 05:35:46PM +, Moore, Robert wrote:
> I'm not sure what version of ACPICA you are looking at, but in the master git
> tree for ACPICA, the file accommon.h includes "acutils.h".
This is the version in the latest git tree for the Linux ker
magic_func.h:221:1: warning: no previous prototype for
> ‘drbd_genl_cmd_to_str’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/genl_magic_func.h | 16
> 1 file changed, 16 deletions(-)
>
> diff --git a/in
ng: no previous prototype for
> ‘arch_msi_mask_irq’ [-Wmissing-prototypes]
> drivers/pci/msi.c:232:12: warning: no previous prototype for
> ‘arch_msix_mask_irq’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/msi.h |2 +
s prototype for
> ‘memory_block_size_bytes’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/memory.h |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/memory.h b/include/linux/memory.h
> index
ese issues with 'sparse' or just a "normal"
> build, then that might be worth fixing up.
Code that generates warnings with gcc -Wmissing-prototypes will also
generate warnings with Sparse's (on by default) -Wdecl. (-Wdecl also
warns about data, which gcc doesn't.)
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
ing extra headers isn't ideal - it can considerably
> slow down the compilation time. There are many subsystems that don't
> really separate their internal headers from their external ones.
There's a benefit to doing so, though: it ensures that the prototypes in
the header stay
es the following warning in memory.c:
> > drivers/base/memory.c:87:1: warning: no previous prototype for
> > ‘memory_block_size_bytes’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
>
> Please ALWAYS run your
he mailing address. The match on "You should
have received a copy" should probably be reduced to CHK level or
dropped.
> Jesse had a question recently about the appropriateness of the
> removal given the license text.
>
> http://www.spinics.net/lists/netdev/msg262152.html
Chang
On Fri, Dec 20, 2013 at 12:37:10AM -0800, Joe Perches wrote:
> On Thu, 2013-12-19 at 23:56 -0800, Josh Triplett wrote:
> > On Thu, Dec 19, 2013 at 02:15:48PM -0800, Joe Perches wrote:
> > > On Thu, 2013-12-19 at 13:01 -0800, Ravi Patel wrote:
> > > > My name is R
Absolutely, but as far as I can tell Rashika is doing this
incrementally, organized more by header than by source file, so I'd
expect a few externs in a source file to disappear at a time rather than
all in one patch.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/pci/lx6464es/lx_core.c | 84
> --
> 1 file changed, 84 deletions(-)
>
> diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
> index 626ecad..df4044d 100644
s2_mixer.c:62:1: warning: no previous prototype for ‘mix_write’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/oss/pas2.h |3 +++
> sound/oss/pas2_card.c |2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>
On Fri, Feb 07, 2014 at 05:22:58PM +, David Laight wrote:
> From: Josh Triplett
> > On Fri, Feb 07, 2014 at 01:33:46PM +, David Laight wrote:
> > > From: Rashika Kheria
> > > > Move prototype declarations of function to header file
> > > > hardware
csp_input.c:110:5: warning: no previous prototype for
> ‘pcspkr_input_remove’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/drivers/pcsp/pcsp_input.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/drivers/
ter to just declare the __early_pfn_to_nid() in
> mm/page_alloc.c to be static?
Won't that break the ability to override that function in
architecture-specific code (as arch/ia64/mm/numa.c does)?
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
ine int __early_pfn_to_nid(unsigned long pfn)
> {
> return 0;
> }
> #else
> /* please see mm/page_alloc.c */
> extern int __meminit early_pfn_to_nid(unsigned long pfn);
> #ifdef CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID
> /* th
On Fri, Feb 07, 2014 at 05:02:02PM -0800, David Rientjes wrote:
> On Fri, 7 Feb 2014, Josh Triplett wrote:
>
> > > Why?? If CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID then, yes, we need it to be
> > > global. Otherwise it's perfectly fine just being static in file s
kdev_issue_zeroout’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> block/blk-lib.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 2da76c9..332e7a9 100644
> ---
s prototype for
> ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> block/blk-throttle.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 14
‘p9_fcall_alloc’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/9p/client.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index a5e4d2d..9186550 100644
> ---
v.c:
> net/caif/caif_dev.c:303:6: warning: no previous prototype for
> ‘caif_enroll_dev’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/caif/caif_dev.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/caif/caif_dev.
net/caif/cfsrvl.c:198:6: warning: no previous prototype for
> ‘caif_free_client’ [-Wmissing-prototypes]
> net/caif/cfsrvl.c:208:6: warning: no previous prototype for
> ‘caif_client_register_refcnt’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Tripl
_dev_queue_xmit’
> [-Wmissing-prototypes]
> net/core/dev.c:4640:5: warning: no previous prototype for
> ‘netdev_adjacent_sysfs_add’ [-Wmissing-prototypes]
> net/core/dev.c:4650:6: warning: no previous prototype for
> ‘netdev_adjacent_sysfs_del’ [-Wmissing-prototypes]
>
> Signed-off-by
On Sun, Feb 09, 2014 at 01:25:05AM +0530, Rashika Kheria wrote:
> Mark function as static in core/filter.c because it is not used outside
> this file.
>
> This eliminates the following warning in core/filter.c:
> net/core/filter.c:48:7: warning: no previous prototype for
> ‘bpf_internal_load_poin
> net/decnet/dn_route.c:629:5: warning: no previous prototype for
> ‘dn_route_rcv’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/dn_route.h |2 ++
> net/decnet/af_decnet.c |2 --
> 2 files changed, 2 insertions(+
m’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/ipx.h |3 +++
> net/ipx/ipx_route.c |4
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/include/net/ipx.h b/include/net/ipx.h
> index 9e9
> net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for
> ‘dn_register_sysctl’ [-Wmissing-prototypes]
> net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for
> ‘dn_unregister_sysctl’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheri
us prototype for ‘ipxrtr_ioctl’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/ipx.h |8
> net/ipx/af_ipx.c |9 -
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/include/
et/ipx/pe2.c:20:24: warning: no previous prototype for ‘make_EII_client’
> [-Wmissing-prototypes]
> net/ipx/pe2.c:32:6: warning: no previous prototype for ‘destroy_EII_client’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include
On Sun, Feb 09, 2014 at 01:37:20AM +0530, Rashika Kheria wrote:
> Move prototype declaration of function to header file
> include/net/net_namespace.h from net/ipx/af_ipx.c because they are used
> by more than one file.
>
> This eliminates the following warning in net/ipx/sysctl_net_ipx.c:
> net/ip
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/netfilter/nft_lookup.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/netfilter/nft_lookup.c b/net/netfilter/nft_lookup.c
> index 8a6116b..bb4ef4c 100644
> --- a/net/netfilter/nft_loo
s]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/sunrpc/svc_xprt.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index 80a6640..06c6ff0 100644
> --- a/net/sunrp
conflicting definitions when CONFIG_XEN_PVHVM is not defined.
>
> This eliminates the following warning in xen/events/events_base.c:
> drivers/xen/events/events_base.c:1640:6: warning: no previous prototype for
> ‘xen_callback_vector’ [-Wmissing-prototypes]
>
> Signed-off-by: Rash
s prototype for
> ‘bio_integrity_tag’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> fs/bio-integrity.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 0bad24d..51
callback_stop’
> [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’
> [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika K
s prototype for
> ‘bio_integrity_tag_size’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> Some of the API functions like bio_integrity_tag_size appears to be
> entirely unused. Such occurences should be pruned because they haven't
>
vious prototype for ‘sys32_quotactl’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/syscalls.h |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
>
t; 2.Add long atomic examples alongside the existing atomics.
>
> 3.Prohibit architectures supporting the Linux kernel from
> speculating stores.
>
> 4.Document what ACCESS_ONCE() does along with a number of situations
> requiring its use.
For all four
s in the process.
Thanks,
Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
en answer
> is "Inquiring programming-language memory-model designers want
> to know."
I find myself wondering about the original form of the question, since
I'd hope that programming-languge memory-model designers would
understand the need for synchronization ar
On Thu, Jan 02, 2014 at 09:14:17PM -0800, Paul E. McKenney wrote:
> On Thu, Jan 02, 2014 at 07:39:07PM -0800, Josh Triplett wrote:
> > On Thu, Jan 02, 2014 at 12:33:20PM -0800, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > From what I can see, the Linux-
On Thu, Jan 02, 2014 at 11:57:27PM -0800, Paul E. McKenney wrote:
> On Thu, Jan 02, 2014 at 09:47:00PM -0800, Josh Triplett wrote:
> > On Thu, Jan 02, 2014 at 09:14:17PM -0800, Paul E. McKenney wrote:
> > > On Thu, Jan 02, 2014 at 07:39:07PM -0800, Josh Triplett wrote:
> >
is also quite telling.
In any case, it's disappointing to have a pile of unused functions in
the kernel on the theory that they *might* be needed; it's not like it'd
be hard to retrieve them from git if they're ever needed.
However, if you're insistent on keeping them, it'
On Fri, Jan 03, 2014 at 05:40:52PM +0100, Michal Marek wrote:
> On 2013-12-23 22:56, Josh Triplett wrote:
> > GCC 4.9 and newer have a new warning -Wdate-time, which warns on any use
> > of __DATE__, __TIME__, or __TIMESTAMP__, which would make the build
> > non-deterministic.
On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> On 3.1.2014 21:29, Josh Triplett wrote:
> > Please feel free to take the entire series through your tree; I received
> > some maintainer acks, but no indications that the patches are going
> > through their trees.
801 - 900 of 1376 matches
Mail list logo
