On Thu, Dec 19, 2013 at 10:13:57AM -0800, Greg Kroah-Hartman wrote: > On Thu, Dec 19, 2013 at 04:54:57PM +0530, Rashika Kheria wrote: > > Add prototype declaration of function memory_block_size_bytes() to > > the header file include/linux/memory.h. > > > > This eliminates the following warning in memory.c: > > drivers/base/memory.c:87:1: warning: no previous prototype for > > ‘memory_block_size_bytes’ [-Wmissing-prototypes] > > > > Signed-off-by: Rashika Kheria <rashika.khe...@gmail.com> > > Reviewed-by: Josh Triplett <j...@joshtriplett.org> > > Please ALWAYS run your patches through checkpatch.pl so a maintainer > doesn't have to write you an email like this reminding you to do that... > > Josh, come on, you should have caught this as well, fix up your email > client to flag stuff like this easier...
If you're referring to the trailing whitespace on the line that was added, I did indeed miss that. Sorry about that. I don't see any option in mutt that would make trailing whitespace visible; if you know of one, I'd love to hear about it. I do have vim configured to highlight trailing whitespace, but I normally review patches in mutt and then hit reply and use vim to provide a Reviewed-by or line-by-line feedback if needed. I should get in the habit of reviewing patches in vim instead; if I had, I'd have caught this. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
