On Sun, Feb 09, 2014 at 01:37:20AM +0530, Rashika Kheria wrote: > Move prototype declaration of function to header file > include/net/net_namespace.h from net/ipx/af_ipx.c because they are used > by more than one file. > > This eliminates the following warning in net/ipx/sysctl_net_ipx.c: > net/ipx/sysctl_net_ipx.c:33:6: warning: no previous prototype for > ‘ipx_register_sysctl’ [-Wmissing-prototypes] > net/ipx/sysctl_net_ipx.c:38:6: warning: no previous prototype for > ‘ipx_unregister_sysctl’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <[email protected]>
You should move the entire ifdef/else block into the header file, so that the stubs are available as well. > include/net/net_namespace.h | 3 +++ > net/ipx/af_ipx.c | 6 ++---- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/include/net/net_namespace.h b/include/net/net_namespace.h > index da68c9a..a43435c 100644 > --- a/include/net/net_namespace.h > +++ b/include/net/net_namespace.h > @@ -162,6 +162,9 @@ extern struct list_head net_namespace_list; > struct net *get_net_ns_by_pid(pid_t pid); > struct net *get_net_ns_by_fd(int pid); > > +void ipx_register_sysctl(void); > +void ipx_unregister_sysctl(void); > + > #ifdef CONFIG_NET_NS > void __put_net(struct net *net); > > diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c > index 224d058..aa2abb8 100644 > --- a/net/ipx/af_ipx.c > +++ b/net/ipx/af_ipx.c > @@ -54,13 +54,11 @@ > #include <net/sock.h> > #include <net/datalink.h> > #include <net/tcp_states.h> > +#include <net/net_namespace.h> > > #include <asm/uaccess.h> > > -#ifdef CONFIG_SYSCTL > -extern void ipx_register_sysctl(void); > -extern void ipx_unregister_sysctl(void); > -#else > +#ifndef CONFIG_SYSCTL > #define ipx_register_sysctl() > #define ipx_unregister_sysctl() > #endif > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
